Replace technical terminology with creator-friendly language in Assets - PR_26163_084-assets-fun-factor-and-foundry-bot

Author: ToolboxAid

docs_build/dev/reports/PR_26163_084-assets-fun-factor-and-foundry-bot.md

@@ -0,0 +1,105 @@
+# PR_26163_084-assets-fun-factor-and-foundry-bot
+
+## Branch Validation
+
+- PASS: Current branch is `main`.
+- PASS: Expected branch is `main`.
+- PASS: Local branches found: `main`.
+- PASS: Worktree was clean before implementation.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before changes.
+- PASS: Continued `PR_26163_084-assets-fun-factor-and-foundry-bot`. No existing `PR_26163_084` report file was present before this run, so this report was created with the requested terminology cleanup evidence.
+- PASS: Added beginner-friendly creator language review to `toolbox/assets`.
+- PASS: Added Foundry Bot guidance for beginner creators in `toolbox/assets/index.html`.
+- PASS: Foundry Bot copy uses beginner creator language, not professional developer language.
+- PASS: Removed user-facing `GDD` and `manifest` terms from the rendered Assets page; none were present in the scoped Assets source before or after this PR.
+- PASS: Replaced visible technical wording where practical: `owner-scoped`, `catalog records`, `workspace tags`, `Repository Tables`, `Rows`, `metadata`, and `Reference-only`.
+- PASS: Used `Game Design` rather than `GDD`.
+- PASS: Avoided user-facing `tool state`.
+- PASS: Avoided user-facing `workspace` in the rendered Assets page.
+
+## Terminology Cleanup Evidence
+
+- PASS: `toolbox/assets/index.html` lede now says: `Add artwork, sounds, music, fonts, and other resources to your game.`
+- PASS: `toolbox/assets/index.html` center panel now uses `Asset Library` instead of `Asset Library Catalog`.
+- PASS: `toolbox/assets/index.html` now uses `Game Tags` and `No game tags added yet.` instead of workspace-tag wording.
+- PASS: `toolbox/assets/index.html` now uses `Status Details` with `Area` and `Count` instead of `Repository Tables`, `Table`, and `Rows`.
+- PASS: `toolbox/assets/assets.js` now renders `No game tags added yet.` after runtime refresh.
+- PASS: `toolbox/assets/assets.js` now renders `No selected asset details.` instead of metadata wording.
+- PASS: `toolbox/assets/assets.js` now renders `1 asset ready for your game.` / `<n> assets ready for your game.` instead of asset catalog record wording.
+- PASS: `toolbox/assets/assets.js` now renders `Viewing asset.` and `Editing asset.` instead of asset catalog record wording.
+- PASS: `toolbox/assets/assets.js` source help now says beginner-friendly phrases such as `Upload artwork for characters, enemies, worlds, icons, and menus.` and `Connect sprites to artwork you already added.`
+
+## Foundry Bot Evidence
+
+- PASS: Added Foundry Bot accordion to the Assets left setup column.
+- PASS: Foundry Bot copy:
+  - `Hi! I'm Foundry Bot.`
+  - `Upload artwork, sounds, and fonts for your game.`
+  - `You can connect assets to characters, enemies, worlds, and other game features.`
+  - `Need ideas? Start by describing your game in Game Design.`
+- PASS: Playwright asserts all four Foundry Bot guidance lines are present on the rendered Assets page.
+- PASS: Playwright asserts rendered Assets page text does not contain `GDD`, `manifest`, `tool state`, `workspace`, or `catalog record`.
+
+## Search Evidence
+
+- PASS: `rg -n "GDD|manifest|tool state|owner-scoped|catalog record|catalog records|workspace tags|No workspace tags|Reference-only|No valid reference source|No reference sources" toolbox/assets/index.html toolbox/assets/assets.js` returned no matches.
+- PASS: `rg -n "Hi! I'm Foundry Bot|Upload artwork, sounds, and fonts for your game|connect assets to characters, enemies, worlds|Game Design" toolbox/assets/index.html tests/playwright/tools/AssetToolMockRepository.spec.mjs` found the expected page copy and Playwright assertions.
+
+## Impacted Lanes
+
+- Toolbox Assets runtime/UI text lane.
+- Assets targeted Playwright recovery/UAT lane.
+- Project Workspace contract lane, because `npm run test:workspace-v2` was explicitly required. The script name is legacy; user-facing product language remains Project Workspace.
+
+## Skipped Lanes
+
+- Full samples smoke: SKIP. No sample JSON or sample runtime behavior changed.
+- Engine runtime: SKIP. No engine behavior changed.
+- Broad toolbox smoke: SKIP. This PR is scoped to Assets user-facing language and targeted Assets validation.
+
+## Validation Performed
+
+- PASS: `git branch --show-current` -> `main`.
+- PASS: `git branch --list` -> `* main`.
+- PASS: `git status --short` before changes -> no output.
+- PASS: `node --check toolbox/assets/assets.js`.
+- PASS: `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`.
+- PASS: `Select-String -Path toolbox/assets/index.html -Pattern '<style\\b'` -> no output.
+- PASS: `Select-String -Path toolbox/assets/index.html -Pattern '<script(?![^>]*\\bsrc=)'` -> no output.
+- PASS: `git diff --check -- toolbox/assets/index.html toolbox/assets/assets.js tests/playwright/tools/AssetToolMockRepository.spec.mjs docs_build/dev/reports/playwright_v8_coverage_report.txt docs_build/dev/reports/coverage_changed_js_guardrail.txt`.
+- PASS: `npx.cmd playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs --workers=1 --reporter=list` -> 15 passed.
+- PASS: `npm.cmd run test:workspace-v2` -> workspace-contract lane passed, 5 Playwright tests passed.
+
+## Playwright Result
+
+- PASS: Targeted Assets Playwright: 15/15 passed.
+- PASS: Required Project Workspace validation command: 5/5 passed.
+
+## V8 Coverage
+
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
+- PASS: `toolbox/assets/assets.js` collected browser V8 coverage at 93%.
+- PASS: `docs_build/dev/reports/coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+
+## Review Artifacts
+
+- `docs_build/dev/reports/PR_26163_084-assets-fun-factor-and-foundry-bot.md`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+
+## Manual Validation Notes
+
+1. Open `/toolbox/assets/index.html`.
+2. Confirm Foundry Bot appears in the left column with beginner creator guidance.
+3. Confirm the page uses `Game Design`, not `GDD`.
+4. Confirm the rendered Assets page does not show `manifest`, `tool state`, or `workspace`.
+5. Confirm the Asset Library still supports upload, tag, view, edit, and delete flows.
+
+## Samples Decision
+
+- SKIP: Full samples smoke was not run because this PR only changes Assets user-facing language and targeted Assets tests.

docs_build/dev/reports/codex_changed_files.txt

@@ -1,22 +1,18 @@
 # git status --short
-M docs_build/dev/reports/codex_changed_files.txt
- M docs_build/dev/reports/codex_review.diff
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
  M tests/playwright/tools/AssetToolMockRepository.spec.mjs
  M toolbox/assets/assets.js
  M toolbox/assets/index.html
-?? docs_build/dev/reports/PR_26163_083-assets-upload-cleanup-fixes.md
+?? docs_build/dev/reports/PR_26163_084-assets-fun-factor-and-foundry-bot.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/PR_26163_083-assets-upload-cleanup-fixes.md
+docs_build/dev/reports/PR_26163_084-assets-fun-factor-and-foundry-bot.md
 
 # git diff --stat
-docs_build/dev/reports/codex_changed_files.txt     |   65 +-
- docs_build/dev/reports/codex_review.diff           | 1786 ++++++--------------
- .../dev/reports/coverage_changed_js_guardrail.txt  |    2 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |    8 +-
- .../tools/AssetToolMockRepository.spec.mjs         |  127 +-
- toolbox/assets/assets.js                           |  134 +-
- toolbox/assets/index.html                          |   48 -
- 7 files changed, 669 insertions(+), 1501 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |  5 +--
+ .../dev/reports/playwright_v8_coverage_report.txt  |  8 ++--
+ .../tools/AssetToolMockRepository.spec.mjs         | 15 +++++++-
+ toolbox/assets/assets.js                           | 33 +++++++++--------
+ toolbox/assets/index.html                          | 43 +++++++++++++---------
+ 5 files changed, 61 insertions(+), 43 deletions(-)