Skip to content

Commit 7ea0ae6

Browse files
committed
Align active tool page panel colors to Toolbox groups - PR_26156_124-tool-page-group-color-alignment & Correct active tool page group colors from Toolbox source of truth - PR_26156_125-tool-group-color-correction-pass
1 parent 4c0d7f9 commit 7ea0ae6

46 files changed

Lines changed: 317 additions & 128 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs_build/dev/codex_commands.md

Lines changed: 61 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -727,3 +727,64 @@ Required reports:
727727
- `docs_build/dev/reports/testing_lane_execution_report.md`
728728
- `docs_build/dev/reports/codex_changed_files.txt`
729729
- `docs_build/dev/reports/codex_review.diff`
730+
731+
732+
## PR_26156_123
733+
734+
Changes:
735+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
736+
- Removed placeholder `image-missing.svg` center-panel preview images from active registry-owned tool pages.
737+
- Preserved center-panel headings and workspace content.
738+
- Updated shared Tool Display Mode badge styling in `assets/theme-v2/css/panels.css`.
739+
- Kept normal Tool Display Mode badge display at `64px` by `64px`.
740+
- Added fullscreen Tool Display Mode badge display at `32px` by `32px`.
741+
- Removed badge border, circular radius, panel background, and crop treatment so the square badge artwork displays fully.
742+
- Added active tool page UI coverage to confirm active tool center panels no longer render placeholder center images.
743+
- Added Tool Display Mode coverage for normal/fullscreen badge sizing and square/no-ring rendering.
744+
- Did not add inline styles, style blocks, script blocks, inline event handlers, page-local CSS, or tool-local CSS.
745+
- Did not modify archived V1/V2 pages.
746+
- Did not modify `start_of_day`.
747+
748+
Validation:
749+
- `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
750+
- `node --check tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs`
751+
- `node ./scripts/run-targeted-test-lanes.mjs --lane tool-runtime --lane tool-display-mode`
752+
- Registry-driven static check confirmed no active tool-center-panel placeholder images remain.
753+
- Scoped `git diff --check` for changed implementation/test/report files.
754+
- Targeted changed-file scan confirmed no inline styles, style blocks, inline scripts, inline event handlers, archived V1/V2 paths, or `start_of_day` file changes were introduced.
755+
- Full samples smoke: skipped by request.
756+
757+
Required reports:
758+
- `docs_build/dev/reports/tool-center-image-and-badge-cleanup-report.md`
759+
- `docs_build/dev/reports/testing_lane_execution_report.md`
760+
- `docs_build/dev/reports/codex_changed_files.txt`
761+
- `docs_build/dev/reports/codex_review.diff`
762+
763+
764+
## PR_26156_124
765+
766+
Changes:
767+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
768+
- Validated every active registry-owned tool page against the Toolbox registry group color class used by `toolbox/index.html` Group view.
769+
- Updated active tool page left and right `aside.tool-column` classes so each side column uses the page tool's registry `colorGroup`.
770+
- Preserved tool page layout, content, Theme V2 CSS wiring, and Toolbox Group view rendering.
771+
- Added targeted active tool page Playwright coverage for registry-aligned side column group classes and Toolbox Group view card classes.
772+
- Did not modify `toolbox/index.html`.
773+
- Did not add CSS, page-local CSS, tool-local CSS, inline styles, style blocks, script blocks, or inline event handlers.
774+
- Did not modify archived V1/V2 pages.
775+
- Did not modify `start_of_day`.
776+
777+
Validation:
778+
- `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
779+
- Targeted registry static check for active tool side column group classes.
780+
- `npm run test:lane:tool-runtime`
781+
- `git diff --check`
782+
- Changed-file static validation for forbidden archive/start_of_day paths and inline style/script/event-handler additions.
783+
- Confirmed `toolbox/index.html` has no diff.
784+
- Full samples smoke: skipped by request.
785+
786+
Required reports:
787+
- `docs_build/dev/reports/tool-page-group-color-alignment-report.md`
788+
- `docs_build/dev/reports/testing_lane_execution_report.md`
789+
- `docs_build/dev/reports/codex_changed_files.txt`
790+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Fix Tool Display Mode media and navigation layout - PR_26156_122-tool-display-mode-layout-fix
1+
Align active tool page side column group colors - PR_26156_124-tool-page-group-color-alignment

docs_build/dev/reports/testing_lane_execution_report.md

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
# Testing Lane Execution Report
22

3-
Generated: 2026-06-05T13:34:55.467Z
3+
Generated: 2026-06-05T13:48:12.557Z
44
Dry run: No
55

66
## Summary
77

8-
PASS: 2
8+
PASS: 1
99
WARN: 0
1010
FAIL: 0
11-
SKIP: 12
12-
Total lane elapsed time: 96.49s
13-
Actual browser launches: 2
11+
SKIP: 13
12+
Total lane elapsed time: 97.25s
13+
Actual browser launches: 1
1414

1515
## Full Samples Smoke
1616

@@ -21,7 +21,7 @@ Reason: Skipped because changed files do not modify sample JSON or shared sample
2121

2222
Status: PASS
2323
Reason: Runner preflight and Playwright structure audit passed before expensive lane execution.
24-
Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes tool-runtime,tool-display-mode --targets tests/playwright/tools/RootToolsFutureState.spec.mjs,tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
24+
Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes tool-runtime --targets tests/playwright/tools/RootToolsFutureState.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
2525
Details: none
2626

2727
## Dependency Gate
@@ -32,15 +32,15 @@ Reason: No deterministic dependency failures before runtime.
3232
## Runtime Scheduling
3333

3434
Status: PASS
35-
Scheduled lane order: tool-display-mode, tool-runtime
36-
Reused runtime sessions: 1
37-
Reused lane snapshots: 2
38-
Reused warm-start lanes: 2
39-
Reused dependency hydration: 2
40-
Prevented graph rebuilds: 2
41-
Prevented redundant initialization: 2
35+
Scheduled lane order: tool-runtime
36+
Reused runtime sessions: 0
37+
Reused lane snapshots: 0
38+
Reused warm-start lanes: 0
39+
Reused dependency hydration: 0
40+
Prevented graph rebuilds: 0
41+
Prevented redundant initialization: 0
4242
Prevented redundant browser launches: 0
43-
Prevented redundant lane execution: 12
43+
Prevented redundant lane execution: 13
4444

4545
## Validation Cache
4646

@@ -61,39 +61,39 @@ Prevented broad lane escalation: 0
6161
## Discovery Scope
6262

6363
Status: PASS
64-
Target files: tests/playwright/tools/RootToolsFutureState.spec.mjs, tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs
64+
Target files: tests/playwright/tools/RootToolsFutureState.spec.mjs
6565
Required shared helpers: tests/helpers/playwrightRepoServer.mjs, tests/helpers/playwrightStorageIsolation.mjs, tests/helpers/playwrightV8CoverageReporter.mjs, tests/helpers/workspaceV2CoverageReporter.mjs
6666
Required fixtures: none
67-
Targeted file/helper reads: 0
67+
Targeted file/helper reads: 5
6868
Cached discovery reuse: Yes
6969
Prevented fallback expansion: Yes; no ownership or scope blocker widened into broad discovery.
7070

7171
## Targeted File Manifests
7272

7373
Status: PASS
74-
Generated manifests: tool-runtime:PASS, tool-display-mode:PASS
74+
Generated manifests: tool-runtime:PASS
7575
Prevented discovery expansion: Yes
76-
Prevented redundant scans: 0
77-
Persistent manifest events: tool-runtime:REUSED, tool-display-mode:REUSED
76+
Prevented redundant scans: 4
77+
Persistent manifest events: tool-runtime:INVALIDATED
7878

7979
## Warm-Start Reuse
8080

8181
Status: PASS
82-
Warm-start events: tool-runtime:REUSED, tool-display-mode:REUSED
83-
Dependency hydration events: tool-runtime:REUSED, tool-display-mode:REUSED
84-
Prevented redundant initialization: 2
85-
Prevented helper resolution passes: 8
82+
Warm-start events: tool-runtime:INVALIDATED
83+
Dependency hydration events: tool-runtime:INVALIDATED
84+
Prevented redundant initialization: 0
85+
Prevented helper resolution passes: 0
8686
Prevented fixture ownership traversal: 0
8787

8888
## Lane Snapshots
8989

9090
Status: PASS
91-
Snapshot events: tool-runtime:REUSED, tool-display-mode:REUSED
92-
Reused snapshots: 2
93-
Invalidated snapshots: 0
94-
Prevented graph rebuilds: 2
95-
Prevented redundant dependency traversal: 2
96-
Prevented fixture/helper graph assembly: 8
91+
Snapshot events: tool-runtime:INVALIDATED
92+
Reused snapshots: 0
93+
Invalidated snapshots: 1
94+
Prevented graph rebuilds: 0
95+
Prevented redundant dependency traversal: 0
96+
Prevented fixture/helper graph assembly: 0
9797

9898
## Lane Deduplication
9999

@@ -112,9 +112,9 @@ Prevented Workspace lane reruns: 0
112112
| build-path | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | repo-served Toolbox page; repo-served Admin Tools Progress page; Project Workspace mock project context; Toolbox role simulation |
113113
| tools-progress | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | repo-served Admin Tools Progress page; repo-served Toolbox Group view; Toolbox registry build sequence; Project Build Path workflow table |
114114
| tool-navigation | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | repo-served Admin Tools Progress page; repo-served Project Workspace, Game Design, and Game Configuration tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata |
115-
| tool-display-mode | PASS | 17.55s | 1 | Tool Display Mode validates the two-row identity/navigation layout, anchors for previous/next targets, disabled text for missing targets, registry build-order labels, role preservation, and multi-path fallback without exercising unrelated toolbox routes. | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | repo-served Project Workspace, Game Design, Game Configuration, and AI Assistant tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata; shared Theme V2 Tool Display Mode script |
115+
| tool-display-mode | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | repo-served Project Workspace, Game Design, Game Configuration, and AI Assistant tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata; shared Theme V2 Tool Display Mode script |
116116
| tool-images | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | Toolbox registry badge/tool image contract; repo-served Toolbox page; repo-served representative Toolbox tool pages; shared registry image fallback |
117-
| tool-runtime | PASS | 78.94s | 1 | Tool runtime lane now validates the active public toolbox/template surface and excludes removed V2 tool routes. | Active public toolbox and Tool Template V2 contract | repo-served root toolbox page; Tool Template V2 public page; Theme V2 shared partials and assets |
117+
| tool-runtime | PASS | 97.25s | 1 | Tool runtime lane now validates the active public toolbox/template surface and excludes removed V2 tool routes. | Active public toolbox and Tool Template V2 contract | repo-served root toolbox page; Tool Template V2 public page; Theme V2 shared partials and assets |
118118
| game-runtime | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Deprecated archive/v1-v2/games reference coverage | |
119119
| integration | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Integration handoff behavior | No active integration Playwright specs after removal of stale V2 tool and removed game manifest routes. |
120120
| engine-src | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | src/ engine and shared runtime capability behavior | explicit node unit fixtures; fresh in-memory localStorage/sessionStorage mocks per file |
@@ -124,11 +124,11 @@ Prevented Workspace lane reruns: 0
124124

125125
| Lane | Duration | Test |
126126
| --- | --- | --- |
127-
| tool-runtime | 34.00s | tests\playwright\tools\RootToolsFutureState.spec.mjs:508:1 > active tool pages do not render placeholder center panel images |
128-
| tool-runtime | 12.20s | tests\playwright\tools\RootToolsFutureState.spec.mjs:69:1 > root tools surface links current tool pages without old_* routes |
129-
| tool-runtime | 10.80s | tests\playwright\tools\RootToolsFutureState.spec.mjs:408:1 > learn wireframe pages load with shared Theme V2 structure |
130-
| tool-runtime | 9.10s | tests\playwright\tools\RootToolsFutureState.spec.mjs:323:1 > common header renders primary navigation order across active pages |
131-
| tool-display-mode | 4.20s | tests\playwright\tools\ToolDisplayModeNavigation.spec.mjs:231:1 > multi-path fallback opens Toolbox Group view with only the target group expanded |
127+
| tool-runtime | 39.70s | tests\playwright\tools\RootToolsFutureState.spec.mjs:512:1 > active tool pages align center cleanup and registry group colors |
128+
| tool-runtime | 20.70s | tests\playwright\tools\RootToolsFutureState.spec.mjs:73:1 > root tools surface links current tool pages without old_* routes |
129+
| tool-runtime | 12.30s | tests\playwright\tools\RootToolsFutureState.spec.mjs:327:1 > common header renders primary navigation order across active pages |
130+
| tool-runtime | 9.30s | tests\playwright\tools\RootToolsFutureState.spec.mjs:412:1 > learn wireframe pages load with shared Theme V2 structure |
131+
| tool-runtime | 1.20s | tests\playwright\tools\RootToolsFutureState.spec.mjs:490:1 > tool template future-state page loads from root Theme V2 paths |
132132

133133
## Commands
134134

@@ -154,13 +154,13 @@ Prevented Workspace lane reruns: 0
154154
- SKIP
155155

156156
### tool-display-mode
157-
- PASS 17.55s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs --project=playwright --workers=1 --reporter=list
157+
- SKIP
158158

159159
### tool-images
160160
- SKIP
161161

162162
### tool-runtime
163-
- PASS 78.94s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/RootToolsFutureState.spec.mjs --project=playwright --workers=1 --reporter=list
163+
- PASS 97.25s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/RootToolsFutureState.spec.mjs --project=playwright --workers=1 --reporter=list
164164

165165
### game-runtime
166166
- SKIP
Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
# PR_26156_124 Tool Page Group Color Alignment Report
2+
3+
## Scope
4+
5+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
6+
- Validated active Toolbox tool pages against the Toolbox registry color assignment used by `toolbox/index.html` Group view.
7+
- Corrected each active tool page left and right `<aside class="tool-column ...">` so the only `tool-group-*` class matches that tool's `colorGroup` from `toolbox/toolRegistry.js`.
8+
- Did not modify `toolbox/index.html`.
9+
- Did not modify archived V1/V2 pages.
10+
- Did not modify `start_of_day`.
11+
- Did not add CSS, page-local CSS, tool-local CSS, inline styles, style blocks, script blocks, or inline event handlers.
12+
13+
## Source Of Truth
14+
15+
The source of truth is `toolbox/toolRegistry.js`:
16+
17+
- `getActiveToolRegistry()` identifies active tool pages.
18+
- `getToolRoute(tool)` identifies active tool page routes.
19+
- `tool.colorGroup` provides the group color class used by Toolbox Group view cards.
20+
21+
Theme V2 already owns the group color tokens and aliases under `assets/theme-v2/css/`; this PR only aligns page-side column classes to the registry-owned class name.
22+
23+
## Updated Active Tool Pages
24+
25+
Each route below had two side columns updated: left column and right column.
26+
27+
| Tool | Route | Registry group class |
28+
| --- | --- | --- |
29+
| AI Assistant | `toolbox/ai-assistant/index.html` | `tool-group-ai` |
30+
| Project Workspace | `toolbox/project-workspace/index.html` | `tool-group-build-create` |
31+
| Game Design | `toolbox/game-design/index.html` | `tool-group-design` |
32+
| Game Configuration | `toolbox/game-configuration/index.html` | `tool-group-build-create` |
33+
| Assets | `toolbox/assets/index.html` | `tool-group-design` |
34+
| Colors | `toolbox/colors/index.html` | `tool-group-design` |
35+
| Fonts | `toolbox/fonts/index.html` | `tool-group-design` |
36+
| Sprites | `toolbox/sprites/index.html` | `tool-group-design` |
37+
| Characters | `toolbox/characters/index.html` | `tool-group-design` |
38+
| Objects | `toolbox/objects/index.html` | `tool-group-design` |
39+
| Worlds | `toolbox/worlds/index.html` | `tool-group-design` |
40+
| Animations | `toolbox/animations/index.html` | `tool-group-design` |
41+
| Audio | `toolbox/audio/index.html` | `tool-group-audio` |
42+
| Music | `toolbox/music/index.html` | `tool-group-audio` |
43+
| Voices | `toolbox/voices/index.html` | `tool-group-audio` |
44+
| Videos | `toolbox/videos/index.html` | `tool-group-audio` |
45+
| Build Game | `toolbox/build-game/index.html` | `tool-group-build-create` |
46+
| Game Testing | `toolbox/game-testing/index.html` | `tool-group-play` |
47+
| Controls | `toolbox/controls/index.html` | `tool-group-platform` |
48+
| Hitboxes | `toolbox/hitboxes/index.html` | `tool-group-platform` |
49+
| Saved Data | `toolbox/saved-data/index.html` | `tool-group-platform` |
50+
| Debug | `toolbox/debug/index.html` | `tool-group-platform` |
51+
| Performance | `toolbox/performance/index.html` | `tool-group-platform` |
52+
| Events | `toolbox/events/index.html` | `tool-group-platform` |
53+
| Publish | `toolbox/publish/index.html` | `tool-group-marketplace` |
54+
| Marketplace | `toolbox/marketplace/index.html` | `tool-group-marketplace` |
55+
| Community | `toolbox/community/index.html` | `tool-group-marketplace` |
56+
| Languages | `toolbox/languages/index.html` | `tool-group-platform` |
57+
| Achievements | `toolbox/achievements/index.html` | `tool-group-play` |
58+
| Ratings | `toolbox/ratings/index.html` | `tool-group-play` |
59+
| Cloud | `toolbox/cloud/index.html` | `tool-group-platform` |
60+
| Custom Extensions | `toolbox/code/index.html` | `tool-group-build-create` |
61+
| MIDI | `toolbox/midi/index.html` | `tool-group-audio` |
62+
| Particles | `toolbox/particles/index.html` | `tool-group-audio` |
63+
| Audio Effects | `toolbox/audio-effects/index.html` | `tool-group-audio` |
64+
| Voice Capture | `toolbox/speech-to-text/index.html` | `tool-group-audio` |
65+
| Voice Output | `toolbox/text-to-speech/index.html` | `tool-group-audio` |
66+
| Users | `toolbox/users/index.html` | `tool-group-platform` |
67+
| Environments | `toolbox/environments/index.html` | `tool-group-platform` |
68+
| Game Migration | `toolbox/game-migration/index.html` | `tool-group-platform` |
69+
| Platform Settings | `toolbox/platform-settings/index.html` | `tool-group-platform` |
70+
71+
## Test Coverage
72+
73+
Updated `tests/playwright/tools/RootToolsFutureState.spec.mjs` so the active tool page walk now verifies:
74+
75+
- every active tool page has exactly two `aside.tool-column` side columns
76+
- both side columns carry exactly one `tool-group-*` class
77+
- the class equals the active tool's registry `colorGroup`
78+
- Toolbox Group view cards remain aligned to the same registry `colorGroup`
79+
80+
## Validation
81+
82+
Impacted lane:
83+
84+
- `tool-runtime` - active Toolbox tool page UI/color alignment.
85+
86+
Commands run:
87+
88+
- `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
89+
- targeted registry static check for active tool side column group classes
90+
- `npm run test:lane:tool-runtime`
91+
- `git diff --check`
92+
- changed-file static validation for forbidden archive/start_of_day paths and inline style/script/event-handler additions
93+
94+
Results:
95+
96+
- Active tool page group-color validation: passed.
97+
- `npm run test:lane:tool-runtime`: passed, 5 Playwright tests.
98+
- `git diff --check`: passed.
99+
- `toolbox/index.html` diff check: no changes.
100+
- Changed-file static validation: passed.
101+
102+
Skipped lanes:
103+
104+
- Full samples smoke: skipped by request.
105+
- Broad workspace/full suite validation: skipped because the change is active tool page markup plus targeted Playwright coverage only; shared runtime, shared parser, shared DB, and cross-tool integration behavior were not changed.

0 commit comments

Comments
 (0)