Remove Objects status column and improve action button spacing - PR_26161_013-objects-action-spacing-cleanup

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -4,15 +4,15 @@ M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M tests/playwright/tools/ObjectsTool.spec.mjs
  M toolbox/objects/index.html
  M toolbox/objects/objects.js
-?? docs_build/dev/reports/objects-table-status-actions-report.md
+?? docs_build/dev/reports/objects-action-spacing-cleanup-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/objects-table-status-actions-report.md
+docs_build/dev/reports/objects-action-spacing-cleanup-report.md
 
 # git diff --stat
-.../dev/reports/coverage_changed_js_guardrail.txt  |   2 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   4 +-
- tests/playwright/tools/ObjectsTool.spec.mjs        | 123 +++++++++++---------
- toolbox/objects/index.html                         |  21 +---
- toolbox/objects/objects.js                         | 128 ++++++++-------------
- 5 files changed, 120 insertions(+), 158 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  | 10 +---
+ .../dev/reports/playwright_v8_coverage_report.txt  | 16 +-----
+ tests/playwright/tools/ObjectsTool.spec.mjs        | 64 +++++++++++++++-------
+ toolbox/objects/index.html                         |  1 -
+ toolbox/objects/objects.js                         | 50 ++++++-----------
+ 5 files changed, 66 insertions(+), 75 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -6,13 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(94%) toolbox/objects/objects.js - executed lines 1123/1123; executed functions 101/107
-(100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
+(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
 
 Guardrail warnings:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,76 @@
+# PR_26161_013 Objects Action Spacing Cleanup Report
+
+## Branch Validation
+
+PASS
+
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches observed: `* main`
+
+## Scope
+
+- Impacted lane: Objects tool runtime/UI lane.
+- Playwright impacted: Yes.
+- Runtime engine behavior changed: No.
+- Samples validation: Skipped as requested. No sample JSON, game sample, engine runtime, auth, or production DB behavior changed.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Verified current git branch was `main` before edits.
+- PASS: Removed the `Status` column from the Objects Table.
+- PASS: Removed row-level Object Status cells and badges from the Objects Table.
+- PASS: Kept action button styling as the row visual status indicator.
+- PASS: Preserved Missing/incomplete visual highlighting through `btn btn--compact primary` on `Open Hitboxes` and `Open Events`.
+- PASS: Preserved Complete/ready visual highlighting through `btn btn--compact cyan` on `Edit Sprite`.
+- PASS: Increased row action spacing with existing Theme V2 `action-group action-group--tight` classes.
+- PASS: Kept `Edit`, `Edit Sprite`, `Open Hitboxes`, `Open Events`, and `Trash` visually distinct and individually clickable.
+- PASS: Did not introduce page-local CSS, inline styles, or tool-specific styling.
+- PASS: Preserved DB/mock-adapter persistence, table editing, sprite asset linking, and current object behavior.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+
+## Testing Performed
+
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: `rg --pcre2 -n '<script(?![^>]*\bsrc=)|<style\b|\son[a-z]+\s*=' toolbox/objects/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `rg -n 'Not connected yet|session-only|setup readiness|MVP|publishes|coverage|technical object family|runtime type|handoff|\binternal\b' toolbox/objects/index.html toolbox/objects/objects.js`
+  - Expected no matches; command exited with no matches.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line`
+  - Result: 6 passed.
+- PASS: `git diff --check`
+  - Result: PASS. Git reported line-ending normalization warnings only.
+
+## Playwright Behavior Covered
+
+- PASS: Objects Table headers no longer include `Status`.
+- PASS: Row status data attributes and badges are absent.
+- PASS: Row action group uses Theme V2 spacing classes.
+- PASS: `Edit`, `Open Hitboxes`, `Open Events`, and `Trash` remain visible and clickable for non-sprite rows.
+- PASS: `Edit`, `Edit Sprite`, `Open Hitboxes`, `Open Events`, and `Trash` remain visible and clickable for sprite rows.
+- PASS: Missing action buttons retain `primary` styling.
+- PASS: Ready sprite action retains `cyan` styling.
+- PASS: Add, cancel, save, edit, trash, reset, DB persistence after reload, and sprite asset linking remain covered.
+
+## Playwright V8 Coverage
+
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Changed runtime JavaScript covered:
+  - `(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105`
+
+## Manual Validation Steps
+
+1. Open `/toolbox/objects/index.html`.
+2. Confirm the Objects Table header is `Name | Type | State | Render | Capabilities | Render Asset | Actions`.
+3. Seed starter objects and confirm each row shows spaced action buttons without a Status column.
+4. Confirm `Open Hitboxes` and `Open Events` use the missing/incomplete button state.
+5. Add a Sprite object and save it, then confirm `Edit Sprite` appears with the ready/complete button state.
+6. Reload the page and confirm saved rows and sprite asset links persist.
+
+## Skipped Lanes
+
+- Full samples validation: SKIP, explicitly requested and no samples changed.
+- Broad workspace/project suite: SKIP, no shared Workspace contract, engine runtime behavior, public navigation behavior, auth behavior, production DB behavior, or sample behavior changed.
+

docs_build/dev/reports/objects-action-spacing-cleanup-report.md

@@ -17,11 +17,7 @@ Exercised tool entry points detected:
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(94%) toolbox/objects/objects.js - executed lines 1123/1123; executed functions 101/107
-(100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
+(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
 
 Files with executed line/function counts where available:
 (33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
@@ -35,20 +31,14 @@ Files with executed line/function counts where available:
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
 (86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(94%) toolbox/objects/objects.js - executed lines 1123/1123; executed functions 101/107
+(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/objects-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
 (94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
-(100%) toolbox/objects/objects-api-client.js - changed JS file with browser V8 coverage