Skip to content

Commit 7f36b7d

Browse files
committed
Strengthen Product Owner testable governance
1 parent 5729a23 commit 7f36b7d

11 files changed

Lines changed: 72 additions & 22 deletions

docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Codex responses must include:
3737
## Tool MVP PR Report Requirements
3838

3939
Every tool MVP PR report must include:
40-
- Creator-testable outcome
40+
- Product Owner testable outcome
4141
- What Playwright tests
4242
- What Mr. Q should manually test
4343
- Whether the PR is part of a stacked MVP sequence
@@ -50,7 +50,7 @@ The report must answer:
5050
What can Mr. Q test after applying this ZIP?
5151
```
5252

53-
If a tool MVP PR has no Playwright lane, the report must state why and list the manual Creator validation instead.
53+
If a tool MVP PR has no Playwright lane, the report must state why and list the manual Product Owner validation instead.
5454

5555
## Code Change Reporting
5656

docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Browser -> API -> Database
2020
## Rules
2121

2222
- Mock repositories are 100% technical debt.
23-
- "Mock repository ready" is not a valid Creator-testable completion state.
23+
- "Mock repository ready" is not a valid Product Owner testable completion state.
2424
- Page arrays are not product-data sources of truth.
2525
- JSON source files are not product-data sources of truth.
2626
- `/tmp` files are not product-data sources of truth.
@@ -38,7 +38,7 @@ If a temporary mock repository exists for transition, it must be documented as t
3838
- affected files
3939
- removal PR
4040
- replacement API/DB path
41-
- Creator-testable limitation
41+
- Product Owner testable limitation
4242

4343
Temporary mock repositories do not make a feature complete. They may only document a transition state.
4444

@@ -52,4 +52,4 @@ Completion requires Game Configuration data to load through:
5252
Browser → API → Database
5353
```
5454

55-
The Creator-testable completion state must prove that browser-visible Game Configuration data was read back through the API/service contract backed by the database.
55+
The Product Owner testable completion state must prove that browser-visible Game Configuration data was read back through the API/service contract backed by the database.

docs_build/dev/ProjectInstructions/addendums/pr_workflow.md

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,14 @@ Tool MVP work must follow:
143143

144144
`docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md`
145145

146-
For tool MVPs, use one large Codex command, multiple focused stacked PRs, and one testable Creator outcome per PR.
146+
For tool MVPs, use one large Codex command, multiple focused stacked PRs, and one Product Owner testable outcome per PR.
147147

148148
Do not create one giant PR.
149149

150150
Do not stop after every small PR unless blocked by branch state, failed validation, missing source files, Project Instructions conflict, or an unresolved dependency from a prior PR.
151151

152152
Each tool MVP PR plan or template must include:
153-
- Creator-testable outcome
153+
- Product Owner testable outcome
154154
- What Playwright tests
155155
- What Mr. Q should manually test
156156
- Whether the PR is part of a stacked MVP sequence
@@ -161,15 +161,29 @@ Visible acceptance must be Creator-facing first. Architecture can be handled und
161161

162162
## Product Owner Testable Definition
163163

164-
A request to complete a page, tool, or testable MVP means Product Owner testable.
164+
A request to complete a page, tool, MVP, or testable experience means Product Owner testable by default. Codex must deliver a working Product Owner testable feature, not a shell or foundation page, unless the Product Owner explicitly requests a shell/foundation PR.
165+
166+
A Product Owner testable outcome means the Product Owner can:
167+
168+
- open the page/tool
169+
- perform the primary workflow
170+
- save/load data where applicable
171+
- observe expected results
172+
- validate success and failure states
173+
- follow manual validation steps from the PR report
165174

166175
Not acceptable as a completed/testable page or tool:
167176

168177
- shell-only page
178+
- route-only page
179+
- navigation-only PR
180+
- template-only page
181+
- placeholder controls
182+
- static table with no workflow
169183
- `Not implemented yet`
184+
- `coming soon`
170185
- placeholder-only workspace, inspector, or output sections
171186
- planned-only tile
172-
- template-only page
173187
- route that loads but cannot be used
174188

175189
Required for Product Owner testable completion:
@@ -182,6 +196,10 @@ Required for Product Owner testable completion:
182196
- manual validation steps for Product Owner
183197
- targeted Playwright coverage where impacted.
184198

199+
## No-Shell Completion Rule
200+
201+
A PR requested to complete a page, tool, MVP, or testable experience must not stop after route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless the Product Owner explicitly requested a shell/foundation PR.
202+
185203
## OWNER Shortcut: PRs
186204

187205
Keyword:

docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Regression tests:
3434
- Tool tests validate tool functionality.
3535
- Regression tests validate platform behavior.
3636
- New tests follow the canonical structure.
37-
- Every user-accessible page must have at least one page-level Playwright test.
37+
- Every user-accessible page must have at least one matching page-level Playwright test before it can be considered complete.
3838
- Runtime page path determines the page-level Playwright test path.
3939
- Primary page-level Playwright test file should be `index.spec.mjs`.
4040
- Do not organize new page-level Playwright tests only by feature nickname or technology bucket when a page path exists.
@@ -56,6 +56,8 @@ Minimum page-level test:
5656
- page renders
5757
- navigation works
5858
- no visible placeholder-only state for completed/testable pages
59+
- primary workflow is covered where the PR claims Product Owner testable completion
60+
- save/load and validation are covered where applicable
5961
- no runtime console errors when feasible
6062

6163
Additional scenario files may use:

docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ Define how Codex plans and executes Creator-facing tool MVP work without creatin
1212
For tool MVPs, use:
1313

1414
```text
15-
One large Codex command -> multiple focused stacked PRs -> each PR has a testable Creator outcome.
15+
One large Codex command -> multiple focused stacked PRs -> each PR has a Product Owner testable outcome.
1616
```
1717

1818
## Rules
1919

2020
- Do not create one giant PR.
2121
- Do not stop after every small PR unless blocked.
2222
- Each PR must be independently scoped.
23-
- Each PR must produce a Creator-testable outcome.
23+
- Each PR must produce a Product Owner testable outcome.
2424
- Each PR must answer:
2525

2626
```text
@@ -40,15 +40,29 @@ For tool MVP PR planning, visible acceptance must be Creator-facing first.
4040

4141
Architecture can be handled under the covers, but PR purpose must be user-testable.
4242

43-
A request to complete a page, tool, or testable MVP means Product Owner testable.
43+
A request to complete a page, tool, MVP, or testable experience means Product Owner testable by default. Codex must deliver a working Product Owner testable feature, not a shell or foundation page, unless the Product Owner explicitly requests a shell/foundation PR.
44+
45+
A Product Owner testable outcome means the Product Owner can:
46+
47+
- open the page/tool
48+
- perform the primary workflow
49+
- save/load data where applicable
50+
- observe expected results
51+
- validate success and failure states
52+
- follow manual validation steps from the PR report
4453

4554
Not acceptable as complete/testable:
4655

4756
- shell-only page
57+
- route-only page
58+
- navigation-only PR
59+
- template-only page
60+
- placeholder controls
61+
- static table with no workflow
4862
- `Not implemented yet`
63+
- `coming soon`
4964
- placeholder-only workspace, inspector, or output sections
5065
- planned-only tile
51-
- template-only page
5266
- route that loads but cannot be used
5367

5468
Required for Product Owner testable completion:
@@ -62,7 +76,7 @@ Required for Product Owner testable completion:
6276
- targeted Playwright coverage where impacted.
6377

6478
Each tool MVP PR must state:
65-
- Creator-testable outcome
79+
- Product Owner testable outcome
6680
- What Playwright tests
6781
- What Mr. Q should manually test
6882
- Whether the PR is part of a stacked MVP sequence
@@ -71,6 +85,8 @@ Each tool MVP PR must state:
7185

7286
## Runtime Data Completion Boundary
7387

88+
A PR requested to complete a page, tool, MVP, or testable experience must not stop after route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless the Product Owner explicitly requested a shell/foundation PR.
89+
7490
A PR outcome must not be described as complete if the visible data is coming from:
7591

7692
- mock repositories

docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ No runtime code, UI code, API code, database code, start_of_day files, history s
2424
- The rule applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team.
2525
- `main` is only the SOD baseline and EOD return target unless OWNER approves a merge checkpoint.
2626
- Added Product Owner testable completion definition.
27+
- Replaced validation/completion-gate `Creator-testable` wording with Product Owner testable wording while preserving product-facing Creator language where appropriate.
28+
- Added the no-shell completion rule for page/tool/MVP requests.
29+
- Strengthened page-level Playwright completion gates for primary workflows, save/load, and validation coverage where applicable.
2730
- Confirmed `Browser -> API -> Database`, one API/service contract across environments, and `Local API` as the shared API running locally.
2831
- Added page-path Playwright organization rules and examples.
2932
- Fixed active team registry mismatch in `TEAM_ASSIGNMENTS.md`.
@@ -42,7 +45,8 @@ No runtime code, UI code, API code, database code, start_of_day files, history s
4245
- PASS: no active instruction permits direct PR commits to `main`.
4346
- PASS: EOD/main-return wording is clarified as closeout or OWNER-approved merge checkpoint, not between stacked/sequential PRs.
4447
- PASS: Product Owner testable definition exists.
45-
- PASS: page-level Playwright organization exists.
48+
- PASS: shell/template/navigation-only completion is explicitly disallowed unless requested by Product Owner.
49+
- PASS: page-level Playwright completion gate exists.
4650
- PASS: API/environment wording is consistent.
4751
- PASS: active registry and assignment table agree for current Delta active assignment.
4852

docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,10 @@ Date: 2026-06-26
99
- Confirm stacked/sequential PR branches/commits stay on the active team branch/workstream during the day.
1010
- Confirm this branch workflow applies to all teams: OWNER, Team Alfa, Team Bravo, Team Charlie, Team Delta, and any future team.
1111
- Confirm Product Owner testable excludes shell-only, placeholder-only, planned-only, or route-only completion.
12+
- Confirm Product Owner testable means the Product Owner can open the page/tool, perform the primary workflow, save/load where applicable, observe expected results, validate success/failure states, and follow PR-report manual steps.
13+
- Confirm page/tool/MVP completion PRs cannot stop at route creation, shell creation, placeholder UI, static mock layout, or navigation activation unless Product Owner requested a shell/foundation PR.
1214
- Confirm page-level Playwright tests follow runtime page paths.
15+
- Confirm page-level Playwright completion gates cover primary workflows and save/load/validation where applicable.
1316
- Confirm `Local API` means the shared API running locally.
1417
- Confirm Team Charlie owns Sprites canvas editor MVP.
1518
- Confirm Sprites planning requires canvas/grid editor, width/height controls, Palette/Colors-only reusable colors, pixel painting, API/database save/load, and Product Owner manual validation.

docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ Date: 2026-06-26
88
| Daily branch workflow documented | PASS | Added SOD/day-work/EOD wording. |
99
| Branch workflow is team-neutral | PASS | Active wording says work commits and sequential PR branches/commits stay on the active team branch/workstream and applies to all teams. |
1010
| Product Owner testable definition documented | PASS | Added in PR workflow and Tool MVP standard. |
11+
| Ambiguous Creator-testable completion wording replaced | PASS | Completion/validation gates now use Product Owner testable wording; product-facing Creator language is preserved. |
12+
| No-shell PR rule added | PASS | Completion requests may not stop at routes, shells, placeholder UI, static mock layouts, or navigation activation unless explicitly requested. |
13+
| Product Owner testable outcome definition expanded | PASS | Defines opening the page/tool, primary workflow, save/load where applicable, expected results, success/failure states, and PR-report manual steps. |
14+
| Page-level Playwright completion gate strengthened | PASS | Requires matching page-level tests before completion, including primary workflow and save/load/validation where applicable. |
1115
| API/environment rule confirmed | PASS | Added `Browser -> API -> Database`, shared API contract, and Local API definition. |
1216
| Page-level Playwright organization added | PASS | Added runtime path to test path rules and examples. |
1317
| Active team registry consistency fixed | PASS | `TEAM_ASSIGNMENTS.md` now matches the active registry for Delta assignment. |

docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ Date: 2026-06-26
99
git diff --check
1010
git diff --name-only
1111
rg -n "Always return to main before starting the next PR|Sprite Studio V2" docs_build/dev/ProjectInstructions
12-
rg -n "Product Owner testable|page-level Playwright|Browser -> API -> Database|Local API" docs_build/dev/ProjectInstructions
12+
rg -n "Creator-testable|testable Creator outcome|manual Creator validation" docs_build/dev/ProjectInstructions
13+
rg -n "Product Owner testable|no-shell|route-only page|static table with no workflow|page-level Playwright|primary workflow is covered|Browser -> API -> Database|Local API" docs_build/dev/ProjectInstructions
1314
```
1415

1516
## Results
@@ -20,8 +21,11 @@ rg -n "Product Owner testable|page-level Playwright|Browser -> API -> Database|L
2021
- PASS: no `Sprite Studio V2` active backlog owner remains.
2122
- PASS: no OWNER-only branch workflow wording remains.
2223
- PASS: active branch workflow says commits and sequential PR branches/commits stay on the active team branch/workstream.
24+
- PASS: no `Creator-testable`, `testable Creator outcome`, or `manual Creator validation` completion-gate wording remains.
25+
- PASS: Product Owner testable outcome definition includes primary workflow, save/load where applicable, expected results, success/failure states, and PR-report manual steps.
26+
- PASS: no-shell completion rule exists.
2327
- PASS: Product Owner testable text exists.
24-
- PASS: page-level Playwright organization text exists.
28+
- PASS: page-level Playwright completion gate includes primary workflow and save/load/validation coverage where applicable.
2529
- PASS: API/environment contract text exists.
2630

2731
## Playwright

docs_build/dev/reports/codex_changed_files.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md
2-
docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md
1+
docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md
2+
docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md
33
docs_build/dev/ProjectInstructions/addendums/pr_workflow.md
4-
docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md
4+
docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md
55
docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md
66
docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment.md
7-
docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_branch-validation.md
87
docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_manual-validation-notes.md
98
docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_requirements-checklist.md
109
docs_build/dev/reports/PR_26177_OWNER_009-project-instructions-workflow-testable-tests-alignment_validation-lane.md

0 commit comments

Comments
 (0)