Skip to content

Commit 87cae57

Browse files
committed
Finalize Toolbox naming and planned shells before first rebuild - PR_26155_016-018-toolbox-ready-for-rebuild
1 parent 7aab924 commit 87cae57

27 files changed

Lines changed: 1120 additions & 87 deletions

assets/theme-v2/js/gamefoundry-partials.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,25 @@
1010
"game-design": "toolbox/game-design/index.html",
1111
"input": "toolbox/input/index.html",
1212
"localization": "toolbox/localization/index.html",
13+
"music-library": "toolbox/music-library/index.html",
1314
"midi": "toolbox/midi/index.html",
1415
"object-vector": "toolbox/object-vector/index.html",
15-
"palette-manager": "toolbox/palette/index.html",
16+
"palette": "toolbox/palette/index.html",
1617
"particles": "toolbox/particles/index.html",
1718
publisher: "toolbox/publish/index.html",
19+
"sound-effects": "toolbox/sound-effects/index.html",
1820
"sound": "toolbox/sound/index.html",
19-
"storage-inspector": "toolbox/storage/index.html",
21+
"speech-to-text": "toolbox/speech-to-text/index.html",
22+
"storage": "toolbox/storage/index.html",
23+
"text-to-speech": "toolbox/text-to-speech/index.html",
24+
voice: "toolbox/voice/index.html",
2025
"world-vector": "toolbox/world-vector/index.html",
2126
cloud: "toolbox/cloud/index.html",
27+
fonts: "toolbox/fonts/index.html",
2228
"project-workspace": "toolbox/project-workspace/index.html",
29+
"tool-learn": "toolbox/learn/index.html",
30+
"tool-marketplace": "toolbox/marketplace/index.html",
31+
"tool-settings": "toolbox/settings/index.html",
2332
games: "games/index.html",
2433
arcade: "games/arcade/index.html",
2534
"game-action": "games/action/index.html",

assets/theme-v2/partials/header-nav.html

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,32 @@
2323
<a data-nav-link data-toolbox-menu-item data-route="cloud" href="toolbox/cloud/index.html">Cloud</a>
2424
<a data-nav-link data-toolbox-menu-item data-route="localization" href="toolbox/localization/index.html">Localization</a>
2525
<a data-nav-link data-toolbox-menu-item data-route="publisher" href="toolbox/publish/index.html">Publish</a>
26-
<a data-nav-link data-toolbox-menu-item data-route="storage-inspector" href="toolbox/storage/index.html">Storage Inspector</a>
26+
<a data-nav-link data-toolbox-menu-item data-route="storage" href="toolbox/storage/index.html">Storage</a>
2727
</div>
2828
</div>
2929
<div class="nav-item nav-popout-item" data-toolbox-menu-group>
30-
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Audio &#9656;</a>
31-
<div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="Audio tools">
30+
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Media &amp; Audio &#9656;</a>
31+
<div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="Media and audio tools">
3232
<a data-nav-link data-toolbox-menu-item data-route="midi" href="toolbox/midi/index.html">MIDI</a>
33-
<a data-nav-link data-toolbox-menu-item data-route="sound" href="toolbox/sound/index.html">Sound</a>
33+
<a data-nav-link data-toolbox-menu-item data-route="music-library" href="toolbox/music-library/index.html">Music Library</a>
34+
<a data-nav-link data-toolbox-menu-item data-route="sound" href="toolbox/sound/index.html">Audio</a>
35+
<a data-nav-link data-toolbox-menu-item data-route="sound-effects" href="toolbox/sound-effects/index.html">Sound Effects</a>
36+
<a data-nav-link data-toolbox-menu-item data-route="speech-to-text" href="toolbox/speech-to-text/index.html">Speech to Text</a>
37+
<a data-nav-link data-toolbox-menu-item data-route="text-to-speech" href="toolbox/text-to-speech/index.html">Text to Speech</a>
38+
<a data-nav-link data-toolbox-menu-item data-route="voice" href="toolbox/voice/index.html">Voice</a>
3439
</div>
3540
</div>
36-
<a data-nav-link data-toolbox-menu-item data-route="palette-manager" href="toolbox/palette/index.html">Palette Manager</a>
37-
<a data-nav-link data-toolbox-menu-item data-route="input" href="toolbox/input/index.html">Input</a>
41+
<div class="nav-item nav-popout-item" data-toolbox-menu-group>
42+
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Support &#9656;</a>
43+
<div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="Support tools">
44+
<a data-nav-link data-toolbox-menu-item data-route="fonts" href="toolbox/fonts/index.html">Fonts</a>
45+
<a data-nav-link data-toolbox-menu-item data-route="tool-learn" href="toolbox/learn/index.html">Learn</a>
46+
<a data-nav-link data-toolbox-menu-item data-route="tool-marketplace" href="toolbox/marketplace/index.html">Marketplace</a>
47+
<a data-nav-link data-toolbox-menu-item data-route="tool-settings" href="toolbox/settings/index.html">Settings</a>
48+
</div>
49+
</div>
50+
<a data-nav-link data-toolbox-menu-item data-route="palette" href="toolbox/palette/index.html">Palette / Colors</a>
51+
<a data-nav-link data-toolbox-menu-item data-route="input" href="toolbox/input/index.html">Input Mapping</a>
3852
<div class="nav-item nav-popout-item" data-toolbox-menu-group>
3953
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Objects &#9656;</a>
4054
<div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="Objects tools">

docs_build/dev/codex_commands.md

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,3 +342,36 @@ Required reports:
342342
- `docs_build/dev/reports/toolbox-build-path-model.md`
343343
- `docs_build/dev/reports/codex_changed_files.txt`
344344
- `docs_build/dev/reports/codex_review.diff`
345+
346+
## PR_26155_016-018
347+
348+
Changes:
349+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
350+
- Created stacked Toolbox closeout bundle:
351+
- `PR_26155_016-toolbox-final-name-cleanup`
352+
- `PR_26155_017-planned-tool-shells`
353+
- `PR_26155_018-ready-for-first-tool-rebuild`
354+
- Applied final active Toolbox labels: Palette / Colors, Storage, Audio, and Input Mapping.
355+
- Updated safe active ids/routes for Palette / Colors and Storage.
356+
- Added planned Toolbox shell folders and `index.html` pages from `toolbox/_tool_template-v2`.
357+
- Added planned Media & Audio shells and planned Support shells to the active registry, header navigation, route map, and Toolbox index renderer.
358+
- Kept `toolbox/tools-page-accordions.js` as the current transitional renderer.
359+
- Did not add CSS, database behavior, persistence, save/load behavior, real tool behavior, or Arcade.
360+
361+
Validation:
362+
- `node --check assets/theme-v2/js/gamefoundry-partials.js`.
363+
- `node --check toolbox/tools-page-accordions.js`.
364+
- `node --check toolbox/toolRegistry.js`.
365+
- `node --check scripts/validate-active-tools-surface.mjs`.
366+
- `node scripts/validate-active-tools-surface.mjs`.
367+
- `node scripts/validate-tool-registry.mjs`.
368+
- Targeted browser page sweep for `toolbox/index.html` plus each new and renamed tool shell.
369+
- `npm run test:workspace-v2` (legacy command name for the Project Workspace test lane).
370+
- `git diff --check`.
371+
372+
Required reports:
373+
- `docs_build/dev/reports/toolbox-final-name-cleanup.md`
374+
- `docs_build/dev/reports/planned-tool-shells.md`
375+
- `docs_build/dev/reports/ready-for-first-tool-rebuild.md`
376+
- `docs_build/dev/reports/codex_changed_files.txt`
377+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Normalize active Toolbox identities and add static progress/build path models - PR_26155_013-015-toolbox-models
1+
Finalize Toolbox names and add planned shells - PR_26155_016-018-toolbox-shells
Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
# PR_26155_017 Planned Tool Shells
2+
3+
## Scope
4+
5+
- Added planned Toolbox shell pages from `toolbox/_tool_template-v2/index.html`.
6+
- Preserved the copied template structure:
7+
- shared header partial
8+
- shared footer partial
9+
- ToolDisplayMode host
10+
- `tool-workspace` shell
11+
- left column
12+
- center panel
13+
- right column
14+
- Theme V2 CSS entry point
15+
- Added no page-local CSS, tool-local CSS, inline styles, inline scripts, or real implementation logic.
16+
17+
## Planned Media & Audio Shells
18+
19+
- `toolbox/text-to-speech/index.html`
20+
- `toolbox/speech-to-text/index.html`
21+
- `toolbox/voice/index.html`
22+
- `toolbox/sound-effects/index.html`
23+
- `toolbox/music-library/index.html`
24+
25+
## Planned Support Shells
26+
27+
- `toolbox/fonts/index.html`
28+
- `toolbox/settings/index.html`
29+
- `toolbox/learn/index.html`
30+
- `toolbox/marketplace/index.html`
31+
32+
## Wiring
33+
34+
- Added planned shells to the active Toolbox registry.
35+
- Added planned shells to the shared Toolbox header navigation.
36+
- Added planned shells to the shared partial route map.
37+
- Added planned shells to the Toolbox index renderer.
38+
- Kept Arcade out of Toolbox.
39+
40+
## Validation Notes
41+
42+
- PASS: `node --check assets/theme-v2/js/gamefoundry-partials.js`.
43+
- PASS: `node --check toolbox/tools-page-accordions.js`.
44+
- PASS: `node --check toolbox/toolRegistry.js`.
45+
- PASS: `node --check scripts/validate-active-tools-surface.mjs`.
46+
- PASS: `node scripts/validate-active-tools-surface.mjs`.
47+
- PASS: `node scripts/validate-tool-registry.mjs`.
48+
- PASS: targeted browser page sweep for every new shell.
49+
- PASS: targeted scan found no inline script/style/event-handler usage in new shell pages.
50+
- PASS: `npm run test:workspace-v2` using the legacy command name for the Project Workspace test lane.
51+
- PASS: `git diff --check`.
52+
53+
## Manual Notes
54+
55+
- Each planned shell loads with header, footer, ToolDisplayMode, left column, center panel, and right column.
56+
- Each planned shell is reachable from Toolbox navigation and the Toolbox index.
57+
- No console errors or failed requests were observed in the targeted page sweep.
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_26155_018 Ready For First Tool Rebuild
2+
3+
## Status
4+
5+
The next PR should start the first real rebuild: Project Workspace.
6+
7+
## Current State
8+
9+
- Toolbox is still transitional.
10+
- `toolbox/tools-page-accordions.js` still owns current Toolbox index rendering.
11+
- Tool pages are wireframe shells, not production implementations.
12+
- The registry and Toolbox index now expose the planned shells needed before the first real rebuild starts.
13+
14+
## Explicit Non-Goals Preserved
15+
16+
- No database implementation.
17+
- No persistence implementation.
18+
- No real save/load behavior.
19+
- No real tool runtime behavior.
20+
- No new CSS.
21+
22+
## Validation Notes
23+
24+
- PASS: Project Workspace naming remains user-facing in current reports.
25+
- PASS: `npm run test:workspace-v2` ran as the legacy test command name for the Project Workspace test lane.
26+
- PASS: targeted browser page sweep confirmed Toolbox and planned shells load.
27+
- PASS: Arcade is absent from the Toolbox surface.
28+
- PASS: `git diff --check`.
29+
30+
## Manual Notes
31+
32+
- Project Workspace is ready to be the first real rebuild target.
33+
- Planned shells are placeholders only and should not be treated as completed tools.

docs_build/dev/reports/studio-vocabulary-cleanup.md

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# PR_26155_013 Studio Vocabulary Cleanup
1+
# PR_26155_013 Legacy Tool Identity Cleanup
22

33
## Scope
44

5-
- Removed old `*-studio` tool identities from active Toolbox labels, route keys, registry ids, tool display slugs, and the active Toolbox Playwright assertion.
5+
- Removed old tool identity wording from active Toolbox labels, route keys, registry ids, tool display slugs, and the active Toolbox Playwright assertion.
66
- Kept the product/site id as `GameFoundryStudio`.
77
- Updated active shared navigation and route wiring in:
88
- `assets/theme-v2/partials/header-nav.html`
@@ -13,21 +13,21 @@
1313

1414
## Identity Mapping
1515

16-
- `animation-studio` -> `animation`
17-
- `asset-studio` -> `assets` for the registry id and `tool-assets` for the header route key to avoid collision with the community assets route.
18-
- `cloud-studio` -> `cloud`
19-
- `code-studio` -> `code`
20-
- `game-design-studio` -> `game-design`
21-
- `input-studio` -> `input`
22-
- `localization-studio` -> `localization`
23-
- `midi-studio-v2` -> `midi`
24-
- `object-vector-studio-v2` -> `object-vector`
25-
- `palette-manager-v2` -> `palette-manager`
26-
- `particle-studio` -> `particles`
27-
- `publish-studio` -> `publish`
28-
- `sound-studio` -> `sound`
29-
- `storage-inspector-v2` -> `storage-inspector`
30-
- `world-vector-studio-v2` -> `world-vector`
16+
- Animation uses `animation`.
17+
- Assets uses `assets` for the registry id and `tool-assets` for the header route key to avoid collision with the community assets route.
18+
- Cloud uses `cloud`.
19+
- Custom Extensions uses `code`.
20+
- Game Design uses `game-design`.
21+
- Input Mapping uses `input`.
22+
- Localization uses `localization`.
23+
- MIDI uses `midi`.
24+
- Object Vector uses `object-vector`.
25+
- Palette / Colors uses `palette`.
26+
- Particles uses `particles`.
27+
- Publish uses `publish`.
28+
- Audio uses `sound`.
29+
- Storage uses `storage`.
30+
- World Vector uses `world-vector`.
3131

3232
## Validation Notes
3333

docs_build/dev/reports/toolbox-build-path-model.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ The current static path is:
2525
These remain side/capability tools and are not blockers unless a future registry rule explicitly requires them:
2626

2727
- AI Assistant
28-
- Storage Inspector
28+
- Storage
2929
- Settings
3030
- Learn
3131
- Cloud
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# PR_26155_016 Toolbox Final Name Cleanup
2+
3+
## Scope
4+
5+
- Applied final active Toolbox labels:
6+
- Palette / Colors
7+
- Storage
8+
- Audio
9+
- Input Mapping
10+
- Updated active registry ids/routes where safe:
11+
- `palette`
12+
- `storage`
13+
- Updated shared header navigation, route map, tool display slugs, Toolbox index cards, progress model keys, and Build Path references.
14+
- Kept `GameFoundryStudio` as the only allowed product token containing the protected naming word.
15+
16+
## Validation Notes
17+
18+
- PASS: `node scripts/validate-active-tools-surface.mjs`.
19+
- PASS: `node scripts/validate-tool-registry.mjs`.
20+
- PASS: focused active Toolbox scan for final labels and ids.
21+
- PASS: `npm run test:workspace-v2` using the legacy command name for the Project Workspace test lane.
22+
- PASS: targeted browser page sweep for the Toolbox index and renamed pages.
23+
- PASS: no CSS files appear in `git diff --name-only -- '*.css'`.
24+
- PASS: `git diff --check`.
25+
26+
## Manual Notes
27+
28+
- Toolbox cards show the final labels.
29+
- Header Toolbox navigation shows the final labels.
30+
- No Arcade tile appears in the Toolbox surface.
31+
- No database, persistence, save/load, or real tool behavior was added.

scripts/validate-active-tools-surface.mjs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@ async function main() {
109109
}
110110
}
111111

112-
if (/title:\s*["']Marketplace["']|href:\s*["'][^"']*marketplace\/index\.html|>\s*Marketplace\s*</i.test(toolboxIndex + "\n" + toolsAccordions)) {
113-
issues.push("Marketplace must not appear as an active toolbox tile or toolbox index link.");
114-
}
115-
116112
if (/>\s*Arcade\s*</i.test(toolboxIndex) || /title:\s*["']Arcade["']/i.test(toolsAccordions)) {
117113
issues.push("Arcade must not appear as an active toolbox tile or toolbox index label.");
118114
}

0 commit comments

Comments
 (0)