Skip to content

Commit 87dfb21

Browse files
committed
Fix toolbox workflow render order and move project team into Create - PR_26170_007-toolbox-workflow-render-order-project-team
1 parent b599edc commit 87dfb21

16 files changed

Lines changed: 3607 additions & 360 deletions
Binary file not shown.
Binary file not shown.
438 KB
Binary file not shown.
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
# PR_26170_007-toolbox-workflow-render-order-project-team
2+
3+
## Branch Validation
4+
5+
PASS - Current branch verified as `main`.
6+
7+
## Requirement Checklist
8+
9+
- PASS - Toolbox grouped rendering no longer alphabetizes cards inside groups. `toolbox/tools-page-accordions.js` uses `compareByWorkflowOrder` for grouped card ordering.
10+
- PASS - Toolbox groups render by declared Game Journey order from source order. The targeted Playwright grouped-view check asserted `GAME_JOURNEY_GROUP_ORDER`.
11+
- PASS - Create group renders in required workflow order: `Game Workspace`, `Game Configuration`, `Project Team`, `Tags`. Covered by source validation and Playwright.
12+
- PASS - Existing `users` tool was moved into Create as `Project Team` without changing its route (`toolbox/users/index.html`) or planned status.
13+
- PASS - `Users` is no longer exposed as a Toolbox tile under Share, Account, Platform, or any non-Create group. API snapshot validation confirms `id: users` displays as `Project Team` with `group/category/toolboxGroup: Create`.
14+
- PASS - User-facing Toolbox copy uses `Project Team` for project-specific team assignment. `Studio Team` remains documented as the account-level roster distinction.
15+
- PASS - No database source contract was replaced. A one-tool source-controlled metadata sync keeps the configured DB-backed Toolbox metadata aligned for the governed `users` -> `Project Team` move while leaving other tool metadata rows owner-editable.
16+
17+
## Validation Lane Report
18+
19+
- PASS - `node --check toolbox/tools-page-accordions.js`
20+
- PASS - `node --check src/shared/toolbox/tool-metadata-inventory.js`
21+
- PASS - `node --check src/dev-runtime/server/local-api-router.mjs`
22+
- PASS - `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
23+
- PASS - `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
24+
- PASS - `node --check tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs`
25+
- PASS - HTML inline guard: `rg -n "<style|\\sstyle=|\\son[a-z]+=" toolbox/users/index.html` returned no matches.
26+
- PASS - Targeted source/API validation confirmed shared inventory, API registry snapshot, grouped renderer mapping, Create workflow order, and Project Team page copy.
27+
- PASS - `git diff --check` completed with no whitespace errors; only existing Windows line-ending warnings were reported.
28+
29+
## Playwright Result
30+
31+
- PASS - `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --grep "toolbox grouped view renders Game Journey order" --workers=1 --reporter=list`
32+
- PASS - `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --project=playwright --grep "toolbox index shows wireframe and beta tools" --workers=1 --reporter=list`
33+
34+
## Coverage Notes
35+
36+
- Generated advisory Playwright V8 reports:
37+
- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
38+
- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
39+
- Browser coverage exercised `toolbox/tools-page-accordions.js`.
40+
- Server-side `src/dev-runtime/server/local-api-router.mjs` and shared metadata inventory are not browser-collected by V8 coverage; targeted Node/API validation covered those paths.
41+
42+
## Skipped Lanes
43+
44+
- SKIP - Full samples smoke was not run per request.
45+
- SKIP - Broad workspace suite was not run because targeted Toolbox Playwright validation covered the impacted UI/rendering behavior.
46+
- SKIP - Database behavior, runtime behavior, Workspace behavior, routes, and status-value lanes were not broadened beyond the directly required Toolbox metadata/API validation.
47+
48+
## Manual Validation Notes
49+
50+
- Confirmed `/toolbox/index.html?view=group` renders all Game Journey groups in declared order.
51+
- Confirmed Create group tile order is `Game Workspace`, `Game Configuration`, `Project Team`, `Tags`.
52+
- Confirmed `Project Team` uses the existing `toolbox/users/index.html` route and remains planned.
53+
- Confirmed `Users` does not remain as a visible Toolbox tile label in the API-backed active registry.
Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,20 @@
1-
# git status --short
2-
M docs_build/dev/PROJECT_INSTRUCTIONS.md
3-
M docs_build/dev/admin-notes/tools/index.txt
4-
M owner/grouping-colors.html
5-
?? docs_build/dev/reports/PR_26170_006-toolbox-workflow-order-and-project-team.md
6-
?? docs_build/pr/BUILD_PR_26170_006-toolbox-workflow-order-and-project-team.md
1+
# PR_26170_007 changed files
72

8-
# git ls-files --others --exclude-standard
9-
docs_build/dev/reports/PR_26170_006-toolbox-workflow-order-and-project-team.md
10-
docs_build/pr/BUILD_PR_26170_006-toolbox-workflow-order-and-project-team.md
3+
docs_build/dev/reports/PR_26170_007-toolbox-workflow-render-order-project-team.md
4+
docs_build/dev/reports/codex_changed_files.txt
5+
docs_build/dev/reports/codex_review.diff
6+
docs_build/dev/reports/coverage_changed_js_guardrail.txt
7+
docs_build/dev/reports/playwright_v8_coverage_report.txt
8+
docs_build/pr/BUILD_PR_26170_007-toolbox-workflow-render-order-project-team.md
9+
src/dev-runtime/server/local-api-router.mjs
10+
src/shared/toolbox/tool-metadata-inventory.js
11+
tests/playwright/tools/RootToolsFutureState.spec.mjs
12+
tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs
13+
tests/playwright/tools/ToolboxRoutePages.spec.mjs
14+
toolbox/tools-page-accordions.js
15+
toolbox/users/index.html
1116

12-
# git diff --stat
13-
docs_build/dev/PROJECT_INSTRUCTIONS.md | 26 ++++++++
14-
docs_build/dev/admin-notes/tools/index.txt | 97 ++++++++++++++++++------------
15-
owner/grouping-colors.html | 19 ++++--
16-
3 files changed, 97 insertions(+), 45 deletions(-)
17+
# Unrelated untracked files intentionally excluded from this PR artifact
18+
19+
docs_build/dev/admin-notes/GFS-Connected-Play-Second-Screen-Turn-Based-Design-26170-001.pdf
20+
docs_build/dev/admin-notes/GFS_Game_Identity_Strategy.pdf.pdf

0 commit comments

Comments
 (0)