Continue migration cleanup, clarify Share, and remove deprecated-only scripts and tests - PR_26154_021-migration-cleanup-share-tools-scripts

Author: ToolboxAid

assets/theme/v2/js/tools-page-accordions.js

@@ -141,9 +141,9 @@ The product guidance phrase is:
 `Build · Play · Share`
 
 Use that phrase as a compact IA and copywriting anchor:
-- Build: creator tools, asset creation, prototypes, systems, and publishing preparation.
-- Play: playable games, arcade browsing, testing, saves, and discovery.
-- Share: marketplace assets, tutorials, community visibility, publishing, and creator identity.
+- Build: tools and creation flow, including asset creation, prototypes, systems, and publishing preparation.
+- Play: games and discovery, including playable games, arcade browsing, testing, and saves.
+- Share: public game pages, share links, creator profiles, marketplace assets, tutorials/community, ratings, and future publish/export flows.
 
 ## GAMEFOUNDRYSTUDIO THEME V2 GOVERNANCE
 

docs_build/dev/PROJECT_INSTRUCTIONS.md

@@ -2,79 +2,50 @@
 
 Task:
 
-- `PR_26154_018-theme-v2-wiring-and-fontawesome-audit`
-- `PR_26154_019-tools-legacy-and-capture-runtime-audit`
-- `PR_26154_020-theme-v2-css-structure-normalization`
+- `PR_26154_021-migration-cleanup-share-tools-scripts`
 
 Commands run:
 
 - `Get-Content .codex/skills/repo-build/SKILL.md`
 - `Get-Content docs_build/dev/PROJECT_INSTRUCTIONS.md`
 - `git status --short --untracked-files=all`
-- Targeted file inspection for:
-  - `assets/theme/v2/`
+- Targeted inspection for:
+  - `index.html`
   - `tools/index.html`
   - `tools/tools-page-accordions.js`
   - `assets/theme/v2/js/tools-page-accordions.js`
-  - `assets/theme/v2/js/gamefoundry-partials.js`
-  - `assets/theme/v2/js/tool-display-mode.js`
-  - `src/engine/ui/toolboxaid-header.html`
+  - `tools/`
   - `tools/shared/tooling/CapturePreviewRuntime.js`
-  - `tools/dev/checkStyleSystemGuard.mjs`
-  - `package.json`
   - `scripts/`
-- Targeted reference checks for:
-  - `assets/theme/v2`
-  - Font Awesome and `fa-*` usage
-  - `tools/index.html` active data
-  - `src/engine/ui/toolboxaid-header.html`
-  - `tools/shared/tooling/CapturePreviewRuntime.js`
-  - `assets/theme/v2/css/theme/v2`
-  - deprecated game/sample test shims
-- Removed Arcade from active `tools/tools-page-accordions.js`.
-- Deleted unreferenced `src/engine/ui/toolboxaid-header.html`.
-- Deleted obsolete `tools/shared/tooling/CapturePreviewRuntime.js`.
-- Moved Theme V2 core CSS files from `assets/theme/v2/css/theme/v2/` to `assets/theme/v2/css/`.
-- Preserved existing `styles.css` bundle support modules as `site-colors.css` and `site-controls.css`.
-- Moved deprecated game/sample test shims from `scripts/` to `tests/validation/`.
-- Updated package scripts to the moved deprecated test shims.
-- Updated Theme V2 stylesheet references to `assets/theme/v2/css/theme.css`.
-- Updated `docs_build/dev/PROJECT_INSTRUCTIONS.md` to the normalized Theme V2 CSS root.
-- Updated `assets/theme/v2/css/gamefoundrystudio.css` so pages on the `styles.css` path use direct-child Toolbox submenu expansion and nested Objects/Worlds popouts.
+  - `scripts/PS/`
+  - `package.json`
+  - `tests/run-tests.mjs`
+- Removed deprecated-only old game/sample package scripts.
+- Removed deprecated-only old game/sample scripts and deprecated validation wrappers.
+- Removed old game template contract test wiring from `tests/run-tests.mjs`.
+- Removed unreferenced duplicate `assets/theme/v2/js/tools-page-accordions.js`.
+- Added display-only Staff Picks content under Trending Games on `index.html`.
+- Expanded `Build · Play · Share` guidance in `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
 - Created:
-  - `docs_build/dev/reports/theme_v2_wiring_fontawesome_audit_report.md`
-  - `docs_build/dev/reports/tools_legacy_capture_runtime_audit_report.md`
-  - `docs_build/dev/reports/theme_v2_css_structure_normalization_report.md`
-- Ran targeted validation for active references, CSS import resolution, tools ordering, moved/deleted files, and Font Awesome status.
-- Ran targeted Playwright hover validation for `marketplace/index.html` Toolbox nested menu behavior.
-- Ran static validation for changed HTML, JS, CSS, JSON, and Markdown files.
-- Ran `npm run check:style-system-guard`.
+  - `docs_build/dev/reports/migration_cleanup_share_tools_scripts_report.md`
+- Ran targeted reference checks for removed deprecated scripts/tests, active Tools index Arcade state, capture runtime references, package scripts, and Build/Play/Share documentation.
+- Ran static validation for changed HTML, JS, JSON, and Markdown files.
 - Ran `git diff --check`.
-- Ran `git status --short -- start_of_day old-tools old_games old_samples`.
 - Ran `npm run codex:review-artifacts`.
-- Expanded `docs_build/dev/reports/codex_review.diff` with new-file patches for untracked text additions.
 - Packaged repo-structured ZIP:
-  - `tmp/PR_26154_018-020-theme-tools-css-stack_delta.zip`
+  - `tmp/PR_26154_021-migration-cleanup-share-tools-scripts_delta.zip`
 
 Validation summary:
 
-- PASS initial PR017 closeout state was clean enough to continue.
-- PASS active Tools index excludes Arcade and remains alphabetically sorted.
-- PASS no active references remain to `src/engine/ui/toolboxaid-header.html`.
-- PASS no active references remain to `tools/shared/tooling/CapturePreviewRuntime.js` or `bootCapturePreview`.
-- PASS package scripts point to `tests/validation/skip-deprecated-*.mjs`.
-- PASS no active references remain to `assets/theme/v2/css/theme/v2`.
-- PASS `assets/theme/v2/css/theme/v2/` is removed.
-- PASS Theme V2 core CSS imports resolve from `assets/theme/v2/css/`.
-- PASS Font Awesome remains under `assets/theme/v2/fonts/fontawesome/` and is classified as unused/stale.
-- PASS `marketplace/index.html` Toolbox hover opens only the first-level Toolbox menu, then opens Objects and Worlds separately.
-- PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files.
-- PASS `npm run check:style-system-guard`.
+- PASS `package.json` parses and remains at repo root.
+- PASS `tests/run-tests.mjs` parses after removing the deprecated game-template test import.
+- PASS `tools/tools-page-accordions.js` parses and active tools links resolve.
+- PASS active `tools/index.html`/`tools/tools-page-accordions.js` has no Arcade tile.
+- PASS no active references remain to removed deprecated script/test names.
+- PASS no active references remain to `CapturePreviewRuntime` or `bootCapturePreview` outside docs/reports/deprecated folders.
+- PASS `index.html` Staff Picks markup uses existing classes, has no inline script/style/event handlers, and image assets resolve.
+- PASS `Build · Play · Share` guidance includes Build, Play, and Share definitions requested by the PR.
 - PASS `git diff --check`.
-- PASS no `start_of_day/`, `old-tools/`, `old_games/`, or `old_samples/` changes.
-- PASS review artifact generation.
-- PASS review diff includes untracked text additions.
-- PASS repo-structured delta ZIP packaging.
 - SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
 - SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples` per request.
 - SKIPPED full samples smoke test per request.

docs_build/dev/codex_commands.md

@@ -1,10 +1,8 @@
-Normalize Theme V2 CSS wiring and retire obsolete tool legacy references - PR_26154_018-020-theme-tools-css-stack
+Clean up migration scripts, deprecated test wiring, and Share guidance - PR_26154_021-migration-cleanup-share-tools-scripts
 
-- Remove Arcade from the active Tools index data.
-- Delete unreferenced `src/engine/ui/toolboxaid-header.html`.
-- Delete obsolete `tools/shared/tooling/CapturePreviewRuntime.js` after active reference audit.
-- Move Theme V2 core CSS from `assets/theme/v2/css/theme/v2/` to `assets/theme/v2/css/`.
-- Preserve `styles.css` bundle behavior through `site-colors.css` and `site-controls.css`.
-- Move deprecated old game/sample test skip shims to `tests/validation/` and update package scripts.
-- Fix Marketplace Toolbox nested submenu behavior on the `styles.css` path.
-- Report Theme V2 asset wiring, Font Awesome unused/stale status, legacy tools review, and CSS structure normalization.
+- Add a display-only Staff Picks section under Trending Games on the root home page.
+- Remove deprecated-only old game/sample script commands, generators, audits, and skip wrappers.
+- Remove old game template contract test wiring retained only for deprecated coverage.
+- Remove the unreferenced duplicate Theme V2 tools accordion script that still listed Arcade.
+- Confirm active Tools index excludes Arcade and CapturePreviewRuntime has no active dependency.
+- Expand Build · Play · Share documentation for tools, games, and Share surfaces.

docs_build/dev/commit_comment.txt

@@ -0,0 +1,143 @@
+# PR_26154_021 Migration Cleanup, Share, Tools, Scripts Report
+
+## Scope
+
+This PR continues the root migration cleanup without modifying `start_of_day/`, `old-tools/`, `old_games/`, or `old_samples/`.
+
+Changed:
+
+- Added a display-only Staff Picks section under Trending Games in `index.html`.
+- Expanded `Build · Play · Share` guidance in `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Removed deprecated-only old game/sample script commands from root `package.json`.
+- Removed deprecated-only old game/sample generator, audit, presentation, and skip-wrapper scripts.
+- Removed old game template contract test wiring retained only for deprecated `old_games/` coverage.
+- Removed unreferenced duplicate `assets/theme/v2/js/tools-page-accordions.js`.
+
+## Games Index
+
+`index.html` now includes a Staff Picks display-only block under Trending Games.
+
+- Uses existing Theme V2 classes: `section-head`, `trending-grid`, `game-tile`, `game-art`, and `game-meta`.
+- Adds no CSS.
+- Adds no JavaScript.
+- Adds no dynamic behavior.
+- Reuses existing game image assets from `games/assets/images/`.
+
+Note: `index.html` already had an uncommitted dual-entry card order change before this PR started. It was preserved and not reverted.
+
+## Tools Cleanup
+
+Active tools surface:
+
+- `tools/index.html` loads `tools/tools-page-accordions.js`.
+- Active `tools/tools-page-accordions.js` does not contain an Arcade tile.
+- Active tools links in `tools/tools-page-accordions.js` resolve.
+
+Removed:
+
+- `assets/theme/v2/js/tools-page-accordions.js`
+
+Reason:
+
+- It was an unreferenced duplicate tools accordion script.
+- It still contained an Arcade entry.
+- No active page referenced it.
+
+Ambiguous or active items retained:
+
+- `tools/_templates-v2/`: retained because project instructions define it as the required first-class tool template source.
+- `tools/shared/`: retained because active tests, scripts, and Workspace V2 paths still import it; moving it would be a separate shared-dependency cleanup.
+- `tools/dev/`: retained because package guard scripts actively reference it.
+- `tools/schemas/`: retained because active tool/schema validation still references tool schemas.
+- `tools/toolRegistry.js` and `tools/renderToolsIndex.js`: retained because active tests and tool launch support import them.
+
+## Capture Runtime
+
+`tools/shared/tooling/CapturePreviewRuntime.js` no longer exists in the current checkout.
+
+Checks:
+
+- No active references to `CapturePreviewRuntime` remain outside docs/reports/deprecated folders.
+- No active references to `bootCapturePreview` remain outside docs/reports/deprecated folders.
+
+Result:
+
+- No delete or move was needed in this PR because the file had already been removed.
+
+## Scripts Cleanup
+
+Removed deprecated-only files:
+
+- `scripts/audit-sample-json-ownership.mjs`
+- `scripts/generate-curriculum-validation-artifact.mjs`
+- `scripts/generate-runtime-sample-previews.mjs`
+- `scripts/generate-sample-manifest.mjs`
+- `scripts/generate-samples-index.mjs`
+- `scripts/normalize-games-presentation.mjs`
+- `scripts/normalize-samples-presentation.mjs`
+- `scripts/sync-tool-hints-from-workspace-manager.mjs`
+- `scripts/validate-games-template-contract.mjs`
+- `scripts/PS/audit-sample-json-js-references.ps1`
+- `scripts/PS/audit-sample-json-lockdown.ps1`
+- `scripts/PS/audit-samples-only-palette-json.ps1`
+- `scripts/PS/validate-sample-json.ps1`
+- `tests/tools/GamesTemplateContractEnforcement.test.mjs`
+- `tests/validation/skip-deprecated-game-tests.mjs`
+- `tests/validation/skip-deprecated-sample-tests.mjs`
+
+Package script cleanup:
+
+- Removed `build:manifest`.
+- Removed `build:curriculum-validation-artifact`.
+- Removed `sync:tool-hints`.
+- Removed `normalize:games-presentation`.
+- Removed `check:games-template-contract`.
+- Removed deprecated old game/sample test wrapper scripts.
+
+Root `package.json` was kept at repo root.
+
+Retained with reason:
+
+- `scripts/run-targeted-test-lanes.mjs`: active validation router; its old game/sample lane metadata excludes deprecated lanes from active automated validation.
+- `scripts/validate-json-contracts.mjs`: general JSON validator with multiple modes; not solely a deprecated old game/sample script.
+- `scripts/validate-asset-ownership-strategy.mjs`: retained because it is still imported by active test wiring and validates mixed asset ownership strategy, not just deprecated paths.
+
+## Share Guidance
+
+`docs_build/dev/PROJECT_INSTRUCTIONS.md` now describes:
+
+- Build: tools and creation flow, including asset creation, prototypes, systems, and publishing preparation.
+- Play: games and discovery, including playable games, arcade browsing, testing, and saves.
+- Share: public game pages, share links, creator profiles, marketplace assets, tutorials/community, ratings, and future publish/export flows.
+
+## Validation
+
+Executed:
+
+- `node --check tests/run-tests.mjs`
+- `node --check tools/tools-page-accordions.js`
+- `node -e "JSON.parse(require('fs').readFileSync('package.json','utf8')); console.log('PASS package.json parse')"`
+- `git diff --check`
+- Static `index.html` Staff Picks and image-path validation.
+- Targeted reference checks for removed deprecated script/test names.
+- Targeted reference checks for active Tools index Arcade state.
+- Targeted reference checks for `CapturePreviewRuntime` and `bootCapturePreview`.
+- Active tools accordion link resolution.
+
+Results:
+
+- PASS: `package.json` parses.
+- PASS: `tests/run-tests.mjs` parses.
+- PASS: `tools/tools-page-accordions.js` parses.
+- PASS: active tools accordion links resolve.
+- PASS: active Tools index has no Arcade tile.
+- PASS: removed deprecated script/test names have no active references in `package.json`, `scripts/`, or `tests/`.
+- PASS: `CapturePreviewRuntime` and `bootCapturePreview` have no active references outside docs/reports/deprecated folders.
+- PASS: `index.html` Staff Picks markup is static and uses existing assets/classes.
+- PASS: `git diff --check`.
+
+Skipped:
+
+- `npm run test:workspace-v2`: skipped because active Workspace V2 launch/navigation behavior was not changed.
+- Full samples smoke test: skipped per request.
+- Tests against `old-tools/`, `old_games/`, and `old_samples`: skipped per request.

docs_build/dev/reports/migration_cleanup_share_tools_scripts_report.md

@@ -23,10 +23,10 @@ <h1>Build. Play. Share.</h1>
           <div class="hero-cta"><a class="btn primary" href="tools/index.html">Start Building</a><a class="btn"
               href="games/index.html">Explore Games</a></div>
           <div class="dual-entry" aria-label="Primary entry points">
-            <a class="entry-card" href="games/index.html"><span>Play</span><strong>Play Games</strong><small>Browse the
-                Arcade</small></a>
             <a class="entry-card" href="tools/index.html"><span>Build</span><strong>Create Games</strong><small>Open the
                 Studio</small></a>
+            <a class="entry-card" href="games/index.html"><span>Play</span><strong>Play Games</strong><small>Browse the
+                Arcade</small></a>
           </div>
         </div>
         <aside class="hero-art" aria-label="Game Foundry Studio logo artwork">
@@ -67,6 +67,27 @@ <h2>Trending Games</h2>
                 4.6</em></div>
           </article>
         </div>
+        <div class="section-head">
+          <div>
+            <div class="kicker">Staff Choice</div>
+            <h3>Staff Picks</h3>
+          </div>
+          <p>Display-only highlights for editor-selected games, creator showcases, and community-ready releases.</p>
+        </div>
+        <div class="trending-grid" aria-label="Staff Picks">
+          <article class="game-tile">
+            <div class="game-art"><img src="/games/assets/images/game-forgequest.svg" alt="Forge Quest staff pick art"></div>
+            <div class="game-meta"><strong>Forge Quest</strong><span>Creator challenge</span><em>Staff pick</em></div>
+          </article>
+          <article class="game-tile">
+            <div class="game-art"><img src="/games/assets/images/game-nebula.svg" alt="Nebula Runner staff pick art"></div>
+            <div class="game-meta"><strong>Nebula Runner</strong><span>Arcade survival</span><em>Staff pick</em></div>
+          </article>
+          <article class="game-tile">
+            <div class="game-art"><img src="/games/assets/images/game-retrobot.svg" alt="RetroBot Rescue staff pick art"></div>
+            <div class="game-meta"><strong>RetroBot Rescue</strong><span>Pixel platformer</span><em>Staff pick</em></div>
+          </article>
+        </div>
       </div>
     </section>
     <section class="section" id="what">

index.html

@@ -15,23 +15,14 @@
     "test:lane:integration": "node ./scripts/run-targeted-test-lanes.mjs --lane integration",
     "test:lane:engine-src": "node ./scripts/run-targeted-test-lanes.mjs --lane engine-src",
     "test:lane:samples": "node ./scripts/run-targeted-test-lanes.mjs --lane samples --include-samples",
-    "build:manifest": "node ./scripts/generate-sample-manifest.mjs",
-    "build:curriculum-validation-artifact": "node ./scripts/generate-curriculum-validation-artifact.mjs",
-    "sync:tool-hints": "node ./scripts/sync-tool-hints-from-workspace-manager.mjs",
-    "normalize:games-presentation": "node ./scripts/normalize-games-presentation.mjs",
     "check:shared-extraction-guard": "node tools/dev/checkSharedExtractionGuard.mjs",
     "check:phase24-closeout-guard": "node tools/dev/checkPhase24CloseoutExecutionGuard.mjs",
     "check:style-system-guard": "node tools/dev/checkStyleSystemGuard.mjs",
     "check:intentional-alias-ledger": "node tools/dev/checkIntentionalAliasLedgerGuard.mjs",
     "check:internal-barrel-guard": "node tools/dev/checkInternalBarrelGuard.mjs",
-    "check:games-template-contract": "node ./tests/validation/skip-deprecated-game-tests.mjs",
     "codex:review-artifacts": "node ./scripts/write-codex-review-artifacts.mjs",
     "test:workspace-v2": "node ./scripts/run-targeted-test-lanes.mjs --lane workspace-contract",
-    "test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs",
-    "test:launch-smoke:games": "node ./tests/validation/skip-deprecated-game-tests.mjs",
-    "test:workspace-manager:games": "node ./tests/validation/skip-deprecated-game-tests.mjs",
-    "test:manifest-payload:games": "node ./tests/validation/skip-deprecated-game-tests.mjs",
-    "test:sample-standalone:data-flow": "node ./tests/validation/skip-deprecated-sample-tests.mjs"
+    "test:launch-smoke": "node ./tests/runtime/LaunchSmokeAllEntries.test.mjs"
   },
   "dependencies": {
     "ws": "^8.20.0"