Polish Project Journey key SSoT search and user item creation - PR_26157_008-project-journey-key-search-additem-polish

Author: ToolboxAid

admin/db-viewer.js

@@ -35,12 +35,16 @@ class AdminDbViewer {
   }
 
   recordId(record) {
-    return record.itemId || record.templateId || record.id || record.name || "record";
+    return record.key || record.name || "record";
   }
 
-  shortKey(record) {
-    const key = String(this.recordId(record));
-    return key.length > 8 ? key.slice(-8) : key;
+  isUlidKey(value) {
+    return /^[0-9A-HJKMNP-TV-Z]{26}$/.test(String(value || ""));
+  }
+
+  formatKeyValue(value) {
+    const key = String(value);
+    return key.slice(0, 10);
   }
 
   formatValue(value) {
@@ -92,7 +96,6 @@ class AdminDbViewer {
     const fields = this.tableFields(records);
     const head = this.createElement("thead");
     const headerRow = this.createElement("tr");
-    headerRow.append(this.createElement("th", { text: "Key" }));
     fields.forEach((field) => {
       headerRow.append(this.createElement("th", { text: field }));
     });
@@ -102,11 +105,15 @@ class AdminDbViewer {
     records.forEach((record) => {
       const row = this.createElement("tr");
       row.dataset.adminDbRecord = this.recordId(record);
-      const keyCell = this.createElement("td", { text: this.shortKey(record) });
-      keyCell.title = this.recordId(record);
-      row.append(keyCell);
       fields.forEach((field) => {
-        row.append(this.createElement("td", { text: this.formatValue(record[field]) }));
+        const value = record[field];
+        const cell = this.createElement("td", {
+          text: this.isUlidKey(value) ? this.formatKeyValue(value) : this.formatValue(value),
+        });
+        if (this.isUlidKey(value)) {
+          cell.title = String(value);
+        }
+        row.append(cell);
       });
       tableBody.append(row);
     });
@@ -142,52 +149,52 @@ class AdminDbViewer {
   }
 
   relationshipsForTables(tables) {
-    const noteTypeIds = new Set(tables.project_journey_note_types.map((type) => type.id));
-    const noteIds = new Set(tables.project_journey_notes.map((note) => note.id));
-    const activeTemplateIds = new Set(
+    const noteTypeKeys = new Set(tables.project_journey_note_types.map((type) => type.key));
+    const noteKeys = new Set(tables.project_journey_notes.map((note) => note.key));
+    const activeTemplateKeys = new Set(
       tables.project_journey_templates
         .filter((template) => template.isActive)
-        .map((template) => template.templateId),
+        .map((template) => template.key),
     );
     return [
       {
-        name: "project_journey_notes.typeId -> project_journey_note_types.id",
+        name: "project_journey_notes.typeKey -> project_journey_note_types.key",
         checked: tables.project_journey_notes.length,
-        missing: tables.project_journey_notes.filter((note) => !noteTypeIds.has(note.typeId)),
+        missing: tables.project_journey_notes.filter((note) => !noteTypeKeys.has(note.typeKey)),
       },
       {
-        name: "project_journey_items.noteId -> project_journey_notes.id",
+        name: "project_journey_items.noteKey -> project_journey_notes.key",
         checked: tables.project_journey_items.length,
-        missing: tables.project_journey_items.filter((item) => !noteIds.has(item.noteId)),
+        missing: tables.project_journey_items.filter((item) => !noteKeys.has(item.noteKey)),
       },
       {
-        name: "system project_journey_items.templateId -> active project_journey_templates.templateId",
+        name: "system project_journey_items.templateKey -> active project_journey_templates.key",
         checked: tables.project_journey_items.filter((item) => item.createdByType === "system").length,
         missing: tables.project_journey_items.filter(
-          (item) => item.createdByType === "system" && !activeTemplateIds.has(item.templateId),
+          (item) => item.createdByType === "system" && !activeTemplateKeys.has(item.templateKey),
         ),
       },
       {
-        name: "project_journey_activity.noteId -> project_journey_notes.id",
+        name: "project_journey_activity.noteKey -> project_journey_notes.key",
         checked: tables.project_journey_activity.length,
-        missing: tables.project_journey_activity.filter((activity) => !noteIds.has(activity.noteId)),
+        missing: tables.project_journey_activity.filter((activity) => !noteKeys.has(activity.noteKey)),
       },
     ];
   }
 
   tableBleedFindings(tables) {
-    const notesById = new Map(tables.project_journey_notes.map((note) => [note.id, note]));
+    const notesByKey = new Map(tables.project_journey_notes.map((note) => [note.key, note]));
     const findings = [];
     tables.project_journey_items.forEach((item) => {
-      const note = notesById.get(item.noteId);
-      if (note && note.projectId !== item.projectId) {
-        findings.push(`${item.itemId} projectId ${item.projectId} does not match note ${note.id} projectId ${note.projectId}.`);
+      const note = notesByKey.get(item.noteKey);
+      if (note && note.projectKey !== item.projectKey) {
+        findings.push(`${item.key} projectKey ${item.projectKey} does not match note ${note.key} projectKey ${note.projectKey}.`);
       }
     });
     tables.project_journey_activity.forEach((activity) => {
-      const note = notesById.get(activity.noteId);
-      if (note && note.projectId !== activity.projectId) {
-        findings.push(`${activity.id} projectId ${activity.projectId} does not match note ${note.id} projectId ${note.projectId}.`);
+      const note = notesByKey.get(activity.noteKey);
+      if (note && note.projectKey !== activity.projectKey) {
+        findings.push(`${activity.key} projectKey ${activity.projectKey} does not match note ${note.key} projectKey ${note.projectKey}.`);
       }
     });
     return findings;

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -17,8 +17,8 @@ Exercised tool entry points detected:
 (74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(95%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 960/960; executed functions 76/80
-(96%) toolbox/project-journey/project-journey.js - executed lines 805/805; executed functions 79/82
+(95%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 961/961; executed functions 76/80
+(96%) toolbox/project-journey/project-journey.js - executed lines 950/950; executed functions 100/104
 
 Files with executed line/function counts where available:
 (67%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 10/15
@@ -27,17 +27,15 @@ Files with executed line/function counts where available:
 (76%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 26/34
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 207/207; executed functions 16/20
 (86%) toolbox/toolRegistry.js - executed lines 1788/1788; executed functions 32/37
-(95%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 960/960; executed functions 76/80
-(96%) toolbox/project-journey/project-journey.js - executed lines 805/805; executed functions 79/82
-(98%) admin/db-viewer.js - executed lines 221/221; executed functions 40/41
+(95%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 961/961; executed functions 76/80
+(96%) toolbox/project-journey/project-journey.js - executed lines 950/950; executed functions 100/104
+(98%) admin/db-viewer.js - executed lines 227/227; executed functions 41/42
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
-(0%) admin/notes.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AdminNotesViewer.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ProjectJourneyTool.spec.mjs - changed JS file not collected as browser runtime coverage
 (95%) toolbox/project-journey/project-journey-mock-repository.js - changed JS file with browser V8 coverage
 (96%) toolbox/project-journey/project-journey.js - changed JS file with browser V8 coverage

docs_build/dev/reports/project-journey-key-search-additem-polish-report.md

@@ -0,0 +1,23 @@
+# Project Journey Key Search Add Item Polish Report
+
+PR: PR_26157_008-project-journey-key-search-additem-polish
+
+## Summary
+- Migrated Project Journey mock DB records to use `key` as the only ULID primary key SSoT.
+- Updated note, item, template, type, activity, and repository relationships to use `projectKey`, `ownerKey`, `noteKey`, `typeKey`, and `templateKey`.
+- Updated the Admin DB Viewer to display actual table field names, shorten ULID values to their first 10 characters, and expose the full key through hover/title text.
+- Added Project Journey search across note names, note types, item titles, item details, system guidance, status labels/icons, linked tool contexts, and suggested tool text.
+- Polished Add Item so user-created items can be titled before creation, default to Not Started unless a different status is selected, become selected immediately, and never create disabled system-owned blank rows.
+
+## Validation Notes
+- DB Viewer relationship checks now report key-based relationships and continue to show no missing-link or table-bleed diagnostics for valid seed data.
+- Search filters the Summary Table and the selected Note Tree where applicable, and visible Statistics counts are recomputed from the filtered item set.
+- Search clear restores the prior navigation/filter state, including a navigation-click state where no Summary Table row was selected.
+- System-created titles and template guidance remain protected; system-created items remain non-deletable.
+- User-created titles and Item Details remain editable, and user-created delete confirmation behavior is preserved.
+
+## Constraints Checked
+- No page-local CSS, tool-local CSS, inline styles, style blocks, inline script blocks, or inline event handlers were added.
+- No archived V1/V2 files were modified.
+- No `start_of_day` folders were modified.
+- Full samples smoke was not run.

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,6 +1,6 @@
 # Testing Lane Execution Report
 
-PR: PR_26157_007-project-journey-ulid-db-table-polish
+PR: PR_26157_008-project-journey-key-search-additem-polish
 
 ## Lanes Run
 - Project Journey runtime/UI lane.
@@ -15,21 +15,26 @@ PR: PR_26157_007-project-journey-ulid-db-table-polish
 - `node --check tests/playwright/tools/ProjectJourneyTool.spec.mjs`
 - `node --check tests/playwright/tools/AdminDbViewer.spec.mjs`
 - `npx playwright test tests/playwright/tools/ProjectJourneyTool.spec.mjs tests/playwright/tools/AdminDbViewer.spec.mjs --reporter=list --workers=1`
-- `npm run test:playwright:static -- --static-report docs_build/dev/reports/static_validation_report.md`
+- `npm run test:playwright:static`
+- `git diff --check`
+- `rg -n "<style|style=|on(click|change|input|submit)=" admin/db-viewer.js toolbox/project-journey/index.html toolbox/project-journey/project-journey.js toolbox/project-journey/project-journey-mock-repository.js tests/playwright/tools/AdminDbViewer.spec.mjs tests/playwright/tools/ProjectJourneyTool.spec.mjs`
+- `rg -n "<script" toolbox/project-journey/index.html admin/db-viewer.js`
+- `git diff --name-only | rg -n "(^|/)(start_of_day|archived|archive)(/|$)"`
 
 ## Results
 - Syntax checks: PASS.
-- Targeted Playwright: PASS, 12 passed.
+- Targeted Playwright: PASS, 13 passed.
 - Static validation: PASS.
+- Changed-file scans: PASS. No forbidden inline styles, style blocks, inline event handlers, inline script blocks, archived paths, or `start_of_day` paths were introduced. Existing external script tags remain unchanged.
+- `git diff --check`: PASS with line-ending warnings only.
 - V8 coverage report: generated at `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
 
 ## Behavior Covered
-- Project Journey Statistics mini-stat value/label inline layout.
-- Project Journey Status Legend removal.
-- Summary Table sorting, Skipped status, Open/Total formulas, System Generated filter, system template SSoT, and ownership fields.
-- User-created generated note/type/item IDs remain ULID-style and editable/deletable as scoped.
-- System-created items remain template-backed and non-deletable.
-- DB Viewer field casing, Key column, full-key hover titles, read-only behavior, relationship summaries, and no table bleed diagnostics.
+- Project Journey `key`-based mock DB SSoT and key-based relationships across notes, note types, items, templates, and activity.
+- DB Viewer actual field casing, 10-character ULID display, full-key hover titles, read-only behavior, relationship summaries, and no table bleed diagnostics.
+- Project Journey Search filters Summary Table and Note Tree content, recomputes visible counts, and restores the prior navigation/filter state on clear.
+- Add Item creates immediately editable user-created items with pre-entered titles, default Not Started status, and no disabled blank system-created rows.
+- System-created title/guidance protections, no-delete behavior, user-created edit/delete behavior, Summary Table sorting, Skipped status, Open/Total formulas, System Generated filter, and template SSoT behavior remain covered.
 
 ## Skipped Lanes
 - Full samples smoke: SKIP. Samples are not in scope and the PR does not modify sample manifests or game runtime.

tests/playwright/tools/AdminDbViewer.spec.mjs

@@ -1,5 +1,5 @@
 import { expect, test } from "@playwright/test";
-import { PROJECT_JOURNEY_IDS } from "../../../toolbox/project-journey/project-journey-mock-repository.js";
+import { PROJECT_JOURNEY_KEYS } from "../../../toolbox/project-journey/project-journey-mock-repository.js";
 import { startRepoServer } from "../../helpers/playwrightRepoServer.mjs";
 import { clearPlaywrightStorage, installPlaywrightStorageIsolation } from "../../helpers/playwrightStorageIsolation.mjs";
 import { workspaceV2CoverageReporter } from "../../helpers/workspaceV2CoverageReporter.mjs";
@@ -82,35 +82,37 @@ test("Admin DB Viewer shows read-only mock DB tables and diagnostics", async ({
       "project_journey_notes",
       "project_journey_templates",
     ]) {
-      await expect(page.locator(`[data-admin-db-table="${tableName}"] thead th`).first()).toHaveText("Key");
+      await expect(page.locator(`[data-admin-db-table="${tableName}"] thead th`).first()).toHaveText("key");
       const keyCell = page.locator(`[data-admin-db-table="${tableName}"] tbody tr`).first().locator("td").first();
-      await expect(keyCell).toHaveText(/^[0-9A-HJKMNP-TV-Z]{6,8}$/);
+      await expect(keyCell).toHaveText(/^[0-9A-HJKMNP-TV-Z]{10}$/);
       await expect(keyCell).toHaveAttribute("title", ULID_PATTERN);
     }
 
     const itemHeaders = await page.locator("[data-admin-db-table='project_journey_items'] thead th").allTextContents();
-    expect(itemHeaders[0]).toBe("Key");
+    expect(itemHeaders[0]).toBe("key");
     expect(itemHeaders).toEqual(expect.arrayContaining([
-      "itemId",
-      "projectId",
-      "noteId",
+      "key",
+      "projectKey",
+      "noteKey",
       "status",
       "title",
       "userDetails",
       "createdAt",
       "updatedAt",
       "createdByType",
       "updatedByType",
-      "templateId",
+      "templateKey",
     ]));
+    expect(itemHeaders).not.toEqual(expect.arrayContaining(["id", "itemId", "projectId", "noteId", "templateId"]));
     expect(itemHeaders).not.toEqual(expect.arrayContaining(["CREATEDAT", "UPDATEDAT", "CREATEDBYTYPE", "UPDATEDBYTYPE"]));
     const createdAtHeader = page.locator("[data-admin-db-table='project_journey_items'] thead th", { hasText: "createdAt" });
     await expect(createdAtHeader).toHaveCSS("text-transform", "none");
-    const designItemRow = page.locator(`[data-admin-db-record="${PROJECT_JOURNEY_IDS.items.designAffordance}"]`);
-    await expect(designItemRow.locator("td").first()).toHaveText(PROJECT_JOURNEY_IDS.items.designAffordance.slice(-8));
-    await expect(designItemRow.locator("td").first()).toHaveAttribute("title", PROJECT_JOURNEY_IDS.items.designAffordance);
-    await expect(page.locator("[data-admin-db-table='project_journey_items']")).toContainText(PROJECT_JOURNEY_IDS.items.designAffordance);
-    await expect(page.locator("[data-admin-db-table='project_journey_templates']")).toContainText(PROJECT_JOURNEY_IDS.templates.paletteAffordance);
+    const designItemRow = page.locator(`[data-admin-db-record="${PROJECT_JOURNEY_KEYS.items.designAffordance}"]`);
+    await expect(designItemRow.locator("td").first()).toHaveText(PROJECT_JOURNEY_KEYS.items.designAffordance.slice(0, 10));
+    await expect(designItemRow.locator("td").first()).toHaveAttribute("title", PROJECT_JOURNEY_KEYS.items.designAffordance);
+    await expect(page.locator("[data-admin-db-table='project_journey_items']")).toContainText(PROJECT_JOURNEY_KEYS.items.designAffordance.slice(0, 10));
+    await expect(page.locator("[data-admin-db-table='project_journey_items']")).not.toContainText(PROJECT_JOURNEY_KEYS.items.designAffordance);
+    await expect(page.locator("[data-admin-db-table='project_journey_templates']")).toContainText(PROJECT_JOURNEY_KEYS.templates.paletteAffordance.slice(0, 10));
     await expect(page.locator("[data-admin-db-table='project_journey_note_types']")).toContainText("Design");
     await expect(page.locator("[data-admin-db-table='project_journey_activity']")).toContainText("Palette and Input Density updated by Designer");
 
@@ -119,10 +121,10 @@ test("Admin DB Viewer shows read-only mock DB tables and diagnostics", async ({
     );
     await expect(page.locator("[data-admin-db-bleed-findings]")).toContainText("No table bleed detected.");
     await expect(page.locator("[data-admin-db-relationship-summary]")).toContainText(
-      "project_journey_items.noteId -> project_journey_notes.id: 9/9 records linked."
+      "project_journey_items.noteKey -> project_journey_notes.key: 9/9 records linked."
     );
     await expect(page.locator("[data-admin-db-relationship-summary]")).toContainText(
-      "system project_journey_items.templateId -> active project_journey_templates.templateId: 9/9 records linked."
+      "system project_journey_items.templateKey -> active project_journey_templates.key: 9/9 records linked."
     );
     await expect(page.locator("[data-admin-db-missing-links]")).toContainText("No missing links detected.");
     await expect(page.locator("[data-admin-db-viewer] input, [data-admin-db-viewer] textarea, [data-admin-db-viewer] select, [data-admin-db-viewer] button")).toHaveCount(0);