Deprecate legacy palette source swatches runtime paths - PR_26160_076-palette-source-swatches-deprecation

Author: ToolboxAid

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,7 +6,11 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(86%) toolbox/colors/colors.js - executed lines 2289/2289; executed functions 193/224
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(66%) toolbox/colors/colors.js - executed lines 2162/2162; executed functions 138/209
+(97%) src/engine/api/mock-db-viewer-ui.js - executed lines 484/484; executed functions 88/91
 
 Guardrail warnings:
-(100%) none - no changed runtime JS coverage warnings
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/palette-source-swatches-deprecation-report.md

@@ -0,0 +1,61 @@
+# PR_26160_076 Palette Source Swatches Deprecation Report
+
+Generated: 2026-06-09
+
+## Branch Validation
+
+| Check | Status | Evidence |
+| --- | --- | --- |
+| Current branch is `main` | PASS | `git branch --show-current` returned `main`. |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Implement PR_26160_075 recommendation: DEPRECATE `palette_source_swatches` | PASS | `src/engine/api/mock-db-viewer-ui.js` labels `palette_source_swatches` as deprecated and shows a visible deprecation note. |
+| Remove/replace dead source-browser code paths reading `palette_source_swatches` | PASS | `toolbox/colors/colors.js` no longer creates source-mode repositories or binds source select/search/pin/sort/size handlers; `src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js` removed source row normalization, source options, source list, source pin-all, and source table output. |
+| Remove/replace dead source-harmony code paths implying source table affects current harmony output | PASS | Harmony labels changed to Current/All Picker closest match, and `harmonyForSwatch()` now matches only supplied picker swatches when not calculated. No source table palette fallback remains. |
+| Ensure Colors grid rendering does not depend on `palette_source_swatches` | PASS | Targeted Colors Playwright passed; runtime trace rendered 24 picker swatches with no source controls or source table count. |
+| Ensure Colors editing does not depend on `palette_source_swatches` | PASS | Targeted Colors Playwright passed Add/Update/Remove/Pin flows; runtime trace added `Trace Blue`. |
+| Ensure Colors save/load does not depend on `palette_source_swatches` | PASS | Targeted Colors Playwright covers reload behavior; runtime trace reloaded and found `Trace Blue` persisted. |
+| Ensure Colors import/export does not depend on `palette_source_swatches` | PASS | Runtime trace verified import/export UI text is absent from the current Colors page; no active import/export source-table path remains. |
+| Remove active Colors runtime reads if safe | PASS | Repository `getSnapshot()` no longer exposes `sourcePaletteOptions`/`sourcePaletteRecordCount`; `getTables()` no longer returns `palette_source_swatches`; Colors Repository Tables now show Project Swatches, Swatch Usage, and Project Swatch Settings only. |
+| Keep table only for migration/history if needed | PASS | Server DB snapshot still includes seeded `palette_source_swatches` rows for DB Viewer history/reference via `paletteTables()` in `src/dev-runtime/server/mock-api-router.mjs`. |
+| Mark deprecated table in DB Viewer/reporting | PASS | DB Viewer summary displays `palette_source_swatches (deprecated)` and a visible note: current Colors grid rendering, editing, save/load, and import/export do not read this table. |
+| Do not migrate unrelated Toolbox/Admin data | PASS | Changes are scoped to Colors repository/runtime, DB Viewer labeling, targeted tests, and reports. |
+| Do not use inline script/style/event handlers | PASS | No HTML inline script/style/event handlers were added; `git diff` shows external JS/HTML option text/test/report edits only. |
+
+## Deprecation Evidence
+
+- Active Colors repository tables now exclude `palette_source_swatches`.
+- Active Colors runtime no longer has source select/search/pin-all controls.
+- Active Colors runtime no longer accepts `?source=empty` / `?source=invalid` source-browser test modes.
+- Harmony source wording now refers to picker swatches, not source palettes.
+- DB Viewer still shows 838 deprecated source history rows under Palette, with an explicit visible deprecation note.
+
+## Validation Evidence
+
+| Lane | Status | Evidence |
+| --- | --- | --- |
+| Syntax checks | PASS | `node --check` on all changed JS/test files exited 0. |
+| Colors Playwright | PASS | `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --reporter=line` -> 9 passed. |
+| DB Viewer Playwright | PASS | `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs --reporter=line` -> 7 passed. |
+| Runtime trace | PASS | Inline Playwright trace: source controls 0; source table absent from Colors table counts; picker swatches 24; reload retained added swatch; DB Viewer deprecated source table visible with 838 rows. |
+| Static validation | PASS | `git diff --check` passed with line-ending warnings only. |
+
+## Impacted Lanes
+
+- Colors runtime/UI lane.
+- Admin DB Viewer lane.
+- Changed-file syntax/static lane.
+
+## Skipped Lanes
+
+| Lane | Reason |
+| --- | --- |
+| Full samples validation | Samples and sample loaders are not touched. |
+| Unrelated Toolbox/Admin metadata migration | Explicitly out of scope for PR_26160_076. |
+
+## Manual Test Notes
+
+No additional manual browser walkthrough was required. The targeted Playwright lanes and runtime trace directly covered the requested Colors and DB Viewer behavior.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,24 +12,39 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(85%) Toolbox Index - exercised 3 runtime JS files
+(73%) Toolbox Index - exercised 7 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
-(77%) Theme V2 Shared JS - exercised 3 runtime JS files
+(74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(86%) toolbox/colors/colors.js - executed lines 2289/2289; executed functions 193/224
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(66%) toolbox/colors/colors.js - executed lines 2162/2162; executed functions 138/209
+(97%) src/engine/api/mock-db-viewer-ui.js - executed lines 484/484; executed functions 88/91
 
 Files with executed line/function counts where available:
-(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
+(63%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 12/19
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
+(66%) toolbox/colors/colors.js - executed lines 2162/2162; executed functions 138/209
+(67%) admin/db-viewer.js - executed lines 53/53; executed functions 4/6
+(75%) toolbox/project-journey/project-journey.js - executed lines 1003/1003; executed functions 74/99
 (77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 548/548; executed functions 37/48
-(86%) toolbox/colors/colors.js - executed lines 2289/2289; executed functions 193/224
-(92%) assets/theme-v2/js/account-controls.js - executed lines 47/47; executed functions 12/13
+(79%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 22/28
+(88%) toolbox/assets/assets.js - executed lines 519/519; executed functions 53/60
+(97%) src/engine/api/mock-db-viewer-ui.js - executed lines 484/484; executed functions 88/91
+(100%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 5/5
+(100%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 3/3
 (100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
+(100%) toolbox/project-journey/project-journey-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(100%) none - no low-coverage changed runtime JS files
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
-(86%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
+(66%) toolbox/colors/colors.js - changed JS file with browser V8 coverage
+(97%) src/engine/api/mock-db-viewer-ui.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,33 +1,37 @@
 # Testing Lane Execution Report
 
-PR: PR_26160_075-palette-runtime-usage-verification
+PR: PR_26160_076-palette-source-swatches-deprecation
 Generated: 2026-06-09
 Full samples validation: SKIPPED
 
 ## Summary
 
-PASS: 4
-WARN: 0
+PASS: 7
+WARN: 2
 FAIL: 0
-SKIP: 3
+SKIP: 2
 
 ## Executed Lanes
 
 | Lane | Status | Command | Evidence |
 | --- | --- | --- | --- |
 | Branch guard | PASS | `git branch --show-current` | Returned `main`. |
-| Colors runtime trace | PASS | Inline Playwright/Chromium trace against `/toolbox/colors/index.html` and `/toolbox/colors/index.html?source=empty` | Captured palette API calls, source snapshot values, source control count, grid count/hexes, add behavior, reload behavior, and harmony output. |
-| Colors runtime Playwright | PASS | `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --reporter=line` | 9 passed. Covers Colors page load, grid rendering, palette editing, save/load behavior, and symbol-free validation. |
-| Static whitespace validation | PASS | `git diff --check` | No whitespace errors after final artifact generation. |
+| Changed-file syntax checks | PASS | `node --check toolbox/colors/colors.js`; `node --check src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js`; `node --check src/dev-runtime/server/mock-api-router.mjs`; `node --check src/engine/api/mock-db-viewer-ui.js`; `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`; `node --check tests/playwright/tools/AdminDbViewer.spec.mjs` | All commands exited 0. |
+| Colors runtime/UI Playwright | PASS | `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --reporter=line` | 9 passed. Covers Colors grid rendering, editing, selection/pinning, reload/save behavior, tag behavior, symbol-free validation, and no source-browser controls. |
+| DB Viewer Playwright | PASS | `npx playwright test tests/playwright/tools/AdminDbViewer.spec.mjs --reporter=line` | 7 passed. Covers Palette DB grouping, deprecated `palette_source_swatches` display, Local Mem/Local DB table visibility, schema headers, diagnostics, and read-only behavior. |
+| Colors + DB Viewer runtime trace | PASS | Inline Playwright/Chromium trace | `sourceControlCount=0`; Colors Repository Tables omit source rows; picker grid rendered 24 swatches; edit/reload kept `Trace Blue`; import/export UI text absent; DB Viewer showed `palette_source_swatches (deprecated) (838 records)` with the deprecation note. |
+| Static source audit | PASS | `rg -n "sourcePalette\|listSourceSwatches\|sourceSwatchRows\|selectedSourceSwatch\|data-palette-source\|sourcePin\|sourceSort\|sourceSize\|sourceMode\|Current Source\|All Sources" ...` | Only test assertions that source controls are absent remain; no active Colors/server source-browser path remains. |
+| Whitespace/static diff validation | PASS | `git diff --check` | No whitespace errors. Line-ending warnings only. |
+| V8 coverage report | WARN | Generated by targeted Playwright runs | `toolbox/colors/colors.js` and `src/engine/api/mock-db-viewer-ui.js` were collected. Server-side changed JS is listed as advisory WARN because browser V8 coverage does not collect Node server modules. |
+| Changed JS coverage guardrail | WARN | Generated by targeted Playwright runs | Advisory-only warnings for server-side changed JS not collected by browser V8 coverage. |
 
 ## Skipped Lanes
 
 | Lane | Status | Reason |
 | --- | --- | --- |
-| Full samples validation | SKIP | The PR is evidence-only for Colors runtime usage and does not touch samples, sample loaders, or game runtime. |
-| Admin DB Viewer Playwright | SKIP | The request explicitly said not to rely on DB Viewer visibility and requested targeted Colors runtime validation only. |
-| Toolbox/Admin migration validation | SKIP | The PR does not migrate Toolbox/Admin data or change shared metadata contracts. |
+| Full samples validation | SKIP | The PR touches Colors repository/runtime and DB Viewer reporting only; samples and sample loaders are unchanged. |
+| Unrelated Toolbox/Admin metadata migration | SKIP | The PR explicitly excludes unrelated Toolbox/Admin data migration. |
 
 ## Manual Test Notes
 
-No separate manual walkthrough was needed. Runtime trace evidence showed `palette_source_swatches` is requested through palette snapshots and rendered as a Repository Tables count, but does not affect grid rendering, palette editing, import/export, or save/load behavior. The report recommends **DEPRECATE**.
+No separate manual walkthrough was needed beyond targeted Playwright and the inline runtime trace. The trace confirmed the deprecated source table is inspectable in DB Viewer but no longer participates in Colors runtime table counts, source controls, grid rendering, editing, save/load, or import/export UI.