|
| 1 | +# PR_26151_003-accordion-header-layout-correction Validation |
| 2 | + |
| 3 | +## Scope |
| 4 | + |
| 5 | +- Scope was limited to affected accordion header layout CSS and required reports. |
| 6 | +- No HTML was changed. |
| 7 | +- No JavaScript behavior was changed. |
| 8 | +- No inline CSS, inline JavaScript, or inline event handlers were added. |
| 9 | + |
| 10 | +## Changes |
| 11 | + |
| 12 | +- Updated open side-panel header layout: |
| 13 | + - `<info>` on the left |
| 14 | + - `[accordion button]` on the right |
| 15 | +- Updated closed side-panel header layout: |
| 16 | + - first row: `[accordion button]` |
| 17 | + - second row: `<info>` |
| 18 | +- Applied through shared side-panel selectors so left and right panels use the same layout rules. |
| 19 | + |
| 20 | +## Validation Performed |
| 21 | + |
| 22 | +Passed: |
| 23 | + |
| 24 | +- `node --check GameFoundryStudio/assets/js/tool-display-mode.js` |
| 25 | +- `rg -n "tool-column-header|horizontal-accordion-toggle|flex-direction|order:|writing-mode|align-items|justify-content" GameFoundryStudio/assets/css/gamefoundrystudio.css GameFoundryStudio/assets/js/tool-display-mode.js` |
| 26 | + |
| 27 | +Confirmed layout rules: |
| 28 | + |
| 29 | +- Open state: |
| 30 | + - `.tool-column-header` uses `flex-direction: row` |
| 31 | + - `.tool-column-header h2, h3` uses `order: 1` |
| 32 | + - `.tool-column-header .horizontal-accordion-toggle` uses `order: 2` |
| 33 | +- Closed state: |
| 34 | + - `.tool-column.is-collapsed .tool-column-header` uses `flex-direction: column` |
| 35 | + - `.tool-column.is-collapsed .horizontal-accordion-toggle` uses `order: 1` |
| 36 | + - `.tool-column.is-collapsed .tool-column-header h2, h3` uses `order: 2` |
| 37 | + - collapsed headers use `writing-mode: horizontal-tb` |
| 38 | + |
| 39 | +Blocked: |
| 40 | + |
| 41 | +- `npm run test:workspace-v2` |
| 42 | + - Blocked by `windows sandbox: spawn setup refresh`. |
| 43 | +- `git diff` |
| 44 | + - Blocked by `windows sandbox: spawn setup refresh`. |
| 45 | + |
| 46 | +## Manual UI Validation |
| 47 | + |
| 48 | +- Open a tool page with left and right side columns. |
| 49 | +- Confirm both open side-panel headers render title/info on the left and the accordion button on the right. |
| 50 | +- Collapse the left panel. |
| 51 | +- Confirm the left header renders the accordion button on the first row and title/info on the second row. |
| 52 | +- Reopen the left panel and confirm the single-row layout returns. |
| 53 | +- Repeat for the right panel and confirm identical behavior. |
| 54 | + |
| 55 | +## Playwright |
| 56 | + |
| 57 | +Playwright impacted: Yes. This PR changes shared side-panel header UI layout. |
| 58 | + |
| 59 | +- `npm run test:workspace-v2` was attempted because the affected behavior is tool UI behavior. |
| 60 | +- The command was blocked by `windows sandbox: spawn setup refresh`. |
0 commit comments