Skip to content

Commit 9b5fcc7

Browse files
committed
Correct accordion header layout for open and closed states - PR_26151_003-accordion-header-layout-correction
1 parent 0dfc039 commit 9b5fcc7

2 files changed

Lines changed: 79 additions & 2 deletions

File tree

GameFoundryStudio/assets/css/gamefoundrystudio.css

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@ details.vertical-accordion[open] summary:after {
525525
background: rgba(255, 122, 0, .08);
526526
display: flex;
527527
align-items: center;
528+
flex-direction: row;
528529
gap: 12px
529530
}
530531

@@ -534,23 +535,39 @@ details.vertical-accordion[open] summary:after {
534535
color: var(--gold);
535536
font-size: 16px;
536537
letter-spacing: .08em;
537-
text-transform: uppercase
538+
text-transform: uppercase;
539+
order: 1
540+
}
541+
542+
.tool-column-header .horizontal-accordion-toggle {
543+
order: 2
538544
}
539545

540546
.tool-column.is-collapsed .tool-column-header {
541547
height: 100%;
542548
min-height: 180px;
543549
padding: 12px 8px;
544-
writing-mode: vertical-rl;
550+
writing-mode: horizontal-tb;
545551
text-orientation: mixed;
552+
flex-direction: column;
553+
align-items: center;
546554
justify-content: flex-start
547555
}
548556

549557
.tool-column.is-collapsed .horizontal-accordion-toggle {
550558
margin: 0;
559+
order: 1;
551560
writing-mode: horizontal-tb
552561
}
553562

563+
.tool-column.is-collapsed .tool-column-header h2,
564+
.tool-column.is-collapsed .tool-column-header h3 {
565+
order: 2;
566+
writing-mode: vertical-rl;
567+
text-orientation: mixed;
568+
text-align: center
569+
}
570+
554571
.tool-center-panel {
555572
grid-column: 2;
556573
grid-row: 2;
Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,60 @@
1+
# PR_26151_003-accordion-header-layout-correction Validation
2+
3+
## Scope
4+
5+
- Scope was limited to affected accordion header layout CSS and required reports.
6+
- No HTML was changed.
7+
- No JavaScript behavior was changed.
8+
- No inline CSS, inline JavaScript, or inline event handlers were added.
9+
10+
## Changes
11+
12+
- Updated open side-panel header layout:
13+
- `<info>` on the left
14+
- `[accordion button]` on the right
15+
- Updated closed side-panel header layout:
16+
- first row: `[accordion button]`
17+
- second row: `<info>`
18+
- Applied through shared side-panel selectors so left and right panels use the same layout rules.
19+
20+
## Validation Performed
21+
22+
Passed:
23+
24+
- `node --check GameFoundryStudio/assets/js/tool-display-mode.js`
25+
- `rg -n "tool-column-header|horizontal-accordion-toggle|flex-direction|order:|writing-mode|align-items|justify-content" GameFoundryStudio/assets/css/gamefoundrystudio.css GameFoundryStudio/assets/js/tool-display-mode.js`
26+
27+
Confirmed layout rules:
28+
29+
- Open state:
30+
- `.tool-column-header` uses `flex-direction: row`
31+
- `.tool-column-header h2, h3` uses `order: 1`
32+
- `.tool-column-header .horizontal-accordion-toggle` uses `order: 2`
33+
- Closed state:
34+
- `.tool-column.is-collapsed .tool-column-header` uses `flex-direction: column`
35+
- `.tool-column.is-collapsed .horizontal-accordion-toggle` uses `order: 1`
36+
- `.tool-column.is-collapsed .tool-column-header h2, h3` uses `order: 2`
37+
- collapsed headers use `writing-mode: horizontal-tb`
38+
39+
Blocked:
40+
41+
- `npm run test:workspace-v2`
42+
- Blocked by `windows sandbox: spawn setup refresh`.
43+
- `git diff`
44+
- Blocked by `windows sandbox: spawn setup refresh`.
45+
46+
## Manual UI Validation
47+
48+
- Open a tool page with left and right side columns.
49+
- Confirm both open side-panel headers render title/info on the left and the accordion button on the right.
50+
- Collapse the left panel.
51+
- Confirm the left header renders the accordion button on the first row and title/info on the second row.
52+
- Reopen the left panel and confirm the single-row layout returns.
53+
- Repeat for the right panel and confirm identical behavior.
54+
55+
## Playwright
56+
57+
Playwright impacted: Yes. This PR changes shared side-panel header UI layout.
58+
59+
- `npm run test:workspace-v2` was attempted because the affected behavior is tool UI behavior.
60+
- The command was blocked by `windows sandbox: spawn setup refresh`.

0 commit comments

Comments
 (0)