Skip to content

Commit 9d1e930

Browse files
committed
PR_26174_ALFA_013-align-game-hub-with-table-first-ui
1 parent 9f53b91 commit 9d1e930

11 files changed

Lines changed: 348 additions & 149 deletions

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@ Branch Validation: PASS
22

33
PASS - Current branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
44
PASS - Expected branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
5-
PASS - Branch stacks on the current Team Alfa PR_012 branch.
5+
PASS - Branch remains stacked on PR_26174_ALFA_012.
6+
PASS - Owner-updated docs_build/dev/ProjectInstructions/addendums/table_first_ui.md was reviewed as instruction content and left unstaged.
67
PASS - Work stayed scoped to Game Hub row rendering, targeted Playwright expectations, and required reports.
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
Manual Validation Notes: PASS
22

3-
- Confirmed the Game Hub table uses game rows as the parent rows.
4-
- Confirmed the previous Open Games table identity and caption are absent.
5-
- Confirmed expanding a game creates exactly two child rows.
6-
- Confirmed Source Idea appears before Readiness Output.
7-
- Confirmed the old Game Summary child table is absent.
3+
- Reviewed docs_build/dev/ProjectInstructions/addendums/table_first_ui.md as the owner-updated table-first reference.
4+
- Compared Game Hub against the Idea Board parent row plus expanded child row pattern.
5+
- Confirmed Game Hub no longer renders standalone Source Idea, Game Foundation, or Readiness Output panel/card sections.
6+
- Confirmed expanding a game creates exactly two child rows: Source Idea, then Readiness Output.
7+
- Confirmed Source Idea remains read-only and the readiness rows use existing service-contract output.
88
- Confirmed safe empty and unavailable state checks still pass.
9-
- Confirmed Idea Board-created Source Idea context still appears in Game Hub.
9+
- Confirmed Idea Board-created Source Idea context still appears in Game Hub through the child table after reload.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
Requirement Checklist: PASS
22

3-
PASS - Open Games is no longer used as the wrapper/accordion table identity.
4-
PASS - Parent rows are games.
5-
PASS - Each game row expands/collapses.
6-
PASS - Expanded game rows show Source Idea child table first.
7-
PASS - Expanded game rows show Readiness Output child table second.
8-
PASS - Source Idea and Readiness Output render as child rows under the game parent row.
3+
PASS - table_first_ui.md was used as the parent/child table reference.
4+
PASS - Game row is the parent row.
5+
PASS - Source Idea is a child row/table under the game row.
6+
PASS - Readiness Output is a child row/table under the game row.
7+
PASS - Source Idea and Readiness Output are no longer separate card/panel sections.
8+
PASS - Open Games wrapper/table identity is not used.
9+
PASS - Game rows expand/collapse.
10+
PASS - Expanded game rows show Source Idea first and Readiness Output second.
911
PASS - No new readiness math was added.
1012
PASS - Existing API/service contract was preserved.
1113
PASS - Safe empty/unavailable states were preserved by targeted validation.
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
Validation Lane: PASS
22

33
Commands:
4-
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state"
5-
Result: 4 passed.
4+
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state|Game Hub readiness child rows update from mock game state"
5+
Result: 5 passed.
66

77
2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
88
Result: 1 passed.
99

10-
3. git diff --check
10+
3. git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
1111
Result: PASS.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,18 @@
22

33
## Purpose
44

5-
Correct Game Hub so each game is the parent row and Source Idea plus Readiness Output render as child rows/child tables.
5+
Correct Game Hub so each game is the parent row and Source Idea plus Readiness Output render only as child rows/child tables under that game row.
66

77
## Summary
88

9+
- Applied the updated table_first_ui.md guidance and matched the Idea Board parent-row/expanded-child-row pattern.
910
- Removed the Open Games wrapper/table identity from the Game Hub list table.
10-
- Removed the Game Summary child table from expanded game rows.
11-
- Rendered each expanded game as two child rows in this order: Source Idea, Readiness Output.
11+
- Removed standalone Source Idea, Game Foundation, and Readiness Output panel/card sections.
12+
- Kept Source Idea and Readiness Output as the two expanded child rows under each game parent row.
1213
- Preserved the existing Game Hub API/service contract and safe empty/unavailable states.
1314

1415
## Validation
1516

16-
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state"`
17+
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state|Game Hub readiness child rows update from mock game state"`
1718
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
18-
PASS - `git diff --check`
19+
PASS - `git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`

docs_build/dev/reports/codex_changed_files.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
toolbox/game-hub/index.html
12
toolbox/game-hub/game-hub.js
23
tests/playwright/tools/GameHubMockRepository.spec.mjs
4+
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
35
docs_build/dev/reports/codex_review.diff
46
docs_build/dev/reports/codex_changed_files.txt
57
docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md

0 commit comments

Comments
 (0)