Restore Asset import dropdown values and fix import form layout - PR_26156_148-150-asset-import-dropdown-layout-fix

Author: ToolboxAid

assets/theme-v2/css/tables.css

@@ -48,9 +48,14 @@ td {
 }
 
 .tool-form-table td {
+  min-width: 12rem;
   width: auto
 }
 
+.tool-form-table td[colspan] {
+  min-width: 0
+}
+
 .tool-form-table input:not([type="checkbox"]):not([type="radio"]):not([type="range"]):not([type="color"]),
 .tool-form-table textarea,
 .tool-form-table select {

docs_build/dev/codex_commands.md

@@ -1035,3 +1035,38 @@ Required reports:
 - `docs_build/dev/reports/testing_lane_execution_report.md`
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
+
+
+## PR_26156_148-150
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Read `archive/v1-v2/tools/old_asset-manager-v2/js/assetManagerMetadata.js` as behavior reference only.
+- Restored Asset Role to Usage dropdown relationships for Audio, Color, Data, Font, Image, Localization, Shader, and Video.
+- Removed the generic mixed usage dropdown source from the active Asset Tool repository.
+- Updated Asset runtime wiring so changing Asset Role refreshes Usage options.
+- Updated import validation so Usage must belong to the selected Asset Role.
+- Fixed Import Asset form layout:
+  - `Asset Role` and `Storage Path` labels render on two lines.
+  - File picker remains in the File row.
+  - Upload help text moved into a separate `colspan="2"` row.
+- Added a reusable Theme V2 `tool-form-table` value-cell minimum width in `assets/theme-v2/css/tables.css` after Playwright proved the existing shared pattern still allowed squashed selects.
+- Updated targeted Asset Tool Playwright coverage for dropdown options and layout usability.
+- Did not add page-local CSS, tool-local CSS, inline styles, style blocks, script blocks, or inline event handlers.
+- Did not modify archived V1/V2 files.
+- Did not modify `start_of_day`.
+
+Validation:
+- `node --check toolbox/assets/assets-mock-repository.js`
+- `node --check toolbox/assets/assets.js`
+- `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `node ./scripts/run-targeted-test-lanes.mjs --lane asset-tool`
+- `git diff --check`
+- Supplemental static checks for generic usage values and inline styling/handlers.
+- Full samples smoke: skipped by request and because samples were not changed.
+
+Required reports:
+- `docs_build/dev/reports/asset-import-dropdown-layout-fix-report.md`
+- `docs_build/dev/reports/testing_lane_execution_report.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Add project-owned Asset roles and upload workflow - PR_26156_142-147
+Fix Asset import role dropdown and form layout - PR_26156_148-150

docs_build/dev/reports/asset-import-dropdown-layout-fix-report.md

@@ -0,0 +1,92 @@
+# PR_26156_148-150 Asset Import Dropdown and Layout Fix Report
+
+Generated: 2026-06-05
+
+## Scope
+
+Stacked PRs:
+- `PR_26156_148-asset-import-dropdown-layout-fix`
+- `PR_26156_149-asset-import-help-row-fix`
+- `PR_26156_150-asset-import-validation-coverage`
+
+Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first.
+
+Reference use:
+- Read `archive/v1-v2/tools/old_asset-manager-v2/js/assetManagerMetadata.js`.
+- Used it only to confirm the role-to-usage relationship.
+- Did not copy archive/reference code.
+- Did not modify archived V1/V2 files.
+
+## PR_26156_148 Dropdown Values
+
+Restored the Asset Role to Usage relationship in `toolbox/assets/assets-mock-repository.js`:
+
+| Asset Role | Usage options |
+| --- | --- |
+| Audio | sound, music |
+| Color | hud, text, background, border, accent, warning, success, danger, shadow, highlight |
+| Data | config, table |
+| Font | ui, display |
+| Image | sprite, background, bezel, preview, ui |
+| Localization | strings, dialogue |
+| Shader | fragment, vertex, compute |
+| Video | cutscene, loop |
+
+Implementation notes:
+- Added `usageRoles` to each active Asset role definition.
+- Added `ASSET_USAGE_BY_ROLE` as the active role-to-usage source.
+- Removed the generic mixed `ASSET_USAGE_ROLES` dropdown source.
+- Updated `toolbox/assets/assets.js` so changing Asset Role refreshes Usage options immediately.
+- Validation now checks Usage against the selected Asset Role instead of a mixed global list.
+
+## PR_26156_149 Import Form Layout
+
+Updated `toolbox/assets/index.html`:
+- `Asset Role` label renders as two lines.
+- `Storage Path` label renders as two lines.
+- File label and file picker remain in the same row.
+- Upload explanatory text moved below the file row.
+- Upload help row spans both columns.
+- File input keeps `aria-describedby="assetToolFileHelp"`.
+
+Theme V2 gap:
+- Existing `.tool-form-table` made controls `width: 100%`, but browser validation showed the left-panel table could still shrink select controls to about 74px.
+- Added a reusable Theme V2 rule in `assets/theme-v2/css/tables.css`:
+  - normal form value cells get a reusable `12rem` minimum width
+  - `colspan` helper rows opt out so help text can span naturally
+- No page-local CSS, tool-local CSS, inline styles, or style blocks were added.
+
+## PR_26156_150 Validation Coverage
+
+Updated `tests/playwright/tools/AssetToolMockRepository.spec.mjs`:
+- Validates each Asset Role exposes its exact Usage options.
+- Validates changing Asset Role changes Usage options.
+- Validates two-line labels are present for Asset Role and Storage Path.
+- Validates upload help text uses a `colspan="2"` table row.
+- Validates file picker remains in the File row.
+- Validates import form controls stay usable at narrow left-panel width.
+- Existing upload/preview/failure coverage was updated to use role-specific usage values.
+
+## Validation
+
+Impacted lane:
+- `asset-tool`
+
+Executed:
+- `node --check toolbox/assets/assets-mock-repository.js`
+- `node --check toolbox/assets/assets.js`
+- `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `node ./scripts/run-targeted-test-lanes.mjs --lane asset-tool`
+- `git diff --check`
+- `rg -n 'ASSET_USAGE_ROLES|usage:\s*"(Sprite|Music|UI|Sound Effect|Background|Character|World|Font|Data|Tile)"' toolbox/assets tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `rg -n '<style|style=|onclick=|onchange=|oninput=|<script' toolbox/assets/index.html toolbox/assets/assets.js`
+
+Results:
+- Asset Tool lane: PASS, 5 tests.
+- `git diff --check`: PASS. Git reported line-ending warnings only for edited files.
+- Generic usage source check: PASS, no matches.
+- Inline style/event-handler check: PASS; only expected external `src` script tags were found.
+
+Skipped lanes:
+- Full samples smoke skipped by request and because no sample JSON, sample loader, or sample runtime framework behavior changed.
+- Project Workspace, Game Design, Game Configuration, Build Path, Tools Progress, tool navigation, tool images, tool runtime, engine, integration, games, and samples lanes were skipped because this stack only changed Asset Tool dropdown/layout behavior plus a reusable Theme V2 form-table rule validated by the Asset Tool lane.

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,16 +1,16 @@
 # Testing Lane Execution Report
 
-Generated: 2026-06-05T17:56:30.265Z
+Generated: 2026-06-05T18:27:22.138Z
 Dry run: No
 
 ## Summary
 
-PASS: 2
+PASS: 1
 WARN: 0
 FAIL: 0
-SKIP: 13
-Total lane elapsed time: 53.48s
-Actual browser launches: 2
+SKIP: 14
+Total lane elapsed time: 14.98s
+Actual browser launches: 1
 
 ## Full Samples Smoke
 
@@ -21,7 +21,7 @@ Reason: Skipped because changed files do not modify sample JSON or shared sample
 
 Status: PASS
 Reason: Runner preflight and Playwright structure audit passed before expensive lane execution.
-Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes asset-tool,project-workspace --targets tests/playwright/tools/AssetToolMockRepository.spec.mjs,tests/playwright/tools/ProjectWorkspaceMockRepository.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
+Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes asset-tool --targets tests/playwright/tools/AssetToolMockRepository.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
 Details: none
 
 ## Dependency Gate
@@ -32,15 +32,15 @@ Reason: No deterministic dependency failures before runtime.
 ## Runtime Scheduling
 
 Status: PASS
-Scheduled lane order: project-workspace, asset-tool
-Reused runtime sessions: 1
+Scheduled lane order: asset-tool
+Reused runtime sessions: 0
 Reused lane snapshots: 1
 Reused warm-start lanes: 1
 Reused dependency hydration: 1
 Prevented graph rebuilds: 1
 Prevented redundant initialization: 1
 Prevented redundant browser launches: 0
-Prevented redundant lane execution: 13
+Prevented redundant lane execution: 14
 
 ## Validation Cache
 
@@ -61,39 +61,39 @@ Prevented broad lane escalation: 0
 ## Discovery Scope
 
 Status: PASS
-Target files: tests/playwright/tools/AssetToolMockRepository.spec.mjs, tests/playwright/tools/ProjectWorkspaceMockRepository.spec.mjs
+Target files: tests/playwright/tools/AssetToolMockRepository.spec.mjs
 Required shared helpers: tests/helpers/playwrightRepoServer.mjs, tests/helpers/playwrightStorageIsolation.mjs, tests/helpers/playwrightV8CoverageReporter.mjs, tests/helpers/workspaceV2CoverageReporter.mjs
 Required fixtures: none
-Targeted file/helper reads: 5
+Targeted file/helper reads: 0
 Cached discovery reuse: Yes
 Prevented fallback expansion: Yes; no ownership or scope blocker widened into broad discovery.
 
 ## Targeted File Manifests
 
 Status: PASS
-Generated manifests: asset-tool:PASS, project-workspace:PASS
+Generated manifests: asset-tool:PASS
 Prevented discovery expansion: Yes
-Prevented redundant scans: 3
-Persistent manifest events: asset-tool:INVALIDATED, project-workspace:REUSED
+Prevented redundant scans: 0
+Persistent manifest events: asset-tool:REUSED
 
 ## Warm-Start Reuse
 
 Status: PASS
-Warm-start events: asset-tool:INVALIDATED, project-workspace:REUSED
-Dependency hydration events: asset-tool:INVALIDATED, project-workspace:REUSED
+Warm-start events: asset-tool:REUSED
+Dependency hydration events: asset-tool:REUSED
 Prevented redundant initialization: 1
-Prevented helper resolution passes: 2
+Prevented helper resolution passes: 4
 Prevented fixture ownership traversal: 0
 
 ## Lane Snapshots
 
 Status: PASS
-Snapshot events: asset-tool:INVALIDATED, project-workspace:REUSED
+Snapshot events: asset-tool:REUSED
 Reused snapshots: 1
-Invalidated snapshots: 1
+Invalidated snapshots: 0
 Prevented graph rebuilds: 1
 Prevented redundant dependency traversal: 1
-Prevented fixture/helper graph assembly: 2
+Prevented fixture/helper graph assembly: 4
 
 ## Lane Deduplication
 
@@ -106,10 +106,10 @@ Prevented Workspace lane reruns: 0
 | Lane | Status | Elapsed | Browser Launches | Executed/Skipped Reason | Affected Surface | Fixtures / Inputs |
 | --- | --- | --- | --- | --- | --- | --- |
 | workspace-contract | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Root tools future-state navigation and Tool Template V2 contract | repo-served root tools page; Tool Template V2 future-state page; Theme V2 shared partials and assets |
-| project-workspace | PASS | 38.66s | 1 | Project Workspace rebuild slice validates mock users/projects/project_members data actions, project lifecycle controls, and project-driven Progress/Build Path copy without exercising unrelated toolbox routes. | Project Workspace mock repository, Project Workspace UI, and Toolbox Progress/Build Path project-state bridge | repo-served Project Workspace page; repo-served Toolbox page with role simulation; in-memory SQL-shaped mock project repository |
+| project-workspace | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Project Workspace mock repository, Project Workspace UI, and Toolbox Progress/Build Path project-state bridge | repo-served Project Workspace page; repo-served Toolbox page with role simulation; in-memory SQL-shaped mock project repository |
 | game-design | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Design mock repository, project purpose flow, validation overlay, capability demo authoring, and Toolbox progress handoff | repo-served Game Design page; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Design mock repository; Project Workspace mock project context |
 | game-configuration | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | repo-served Game Configuration page; repo-served Game Design page for handoff checks; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Configuration mock repository; Game Design mock repository handoff |
-| asset-tool | PASS | 14.82s | 1 | Asset Tool rebuild slice validates SQL-shaped asset tables, ready Game Configuration handoff, import/preview workflow, and visible validation errors without exercising unrelated toolbox routes. | Asset Tool mock repository, Game Configuration readiness handoff, library records, import preview, and visible failure handling | repo-served Assets page; in-memory SQL-shaped Asset Tool mock repository; Game Configuration mock repository handoff; file-name/path-based import preview |
+| asset-tool | PASS | 14.98s | 1 | Asset Tool rebuild slice validates SQL-shaped asset tables, ready Game Configuration handoff, import/preview workflow, and visible validation errors without exercising unrelated toolbox routes. | Asset Tool mock repository, Game Configuration readiness handoff, library records, import preview, and visible failure handling | repo-served Assets page; in-memory SQL-shaped Asset Tool mock repository; Game Configuration mock repository handoff; file-name/path-based import preview |
 | build-path | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | repo-served Toolbox page; repo-served Admin Tools Progress page; Project Workspace mock project context; Toolbox role simulation |
 | tools-progress | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | repo-served Admin Tools Progress page; repo-served Toolbox Group view; Toolbox registry build sequence; Project Build Path workflow table |
 | tool-navigation | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | repo-served Admin Tools Progress page; repo-served Project Workspace, Game Design, and Game Configuration tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata |
@@ -125,19 +125,19 @@ Prevented Workspace lane reruns: 0
 
 | Lane | Duration | Test |
 | --- | --- | --- |
-| project-workspace | 7.60s | tests\playwright\tools\ProjectWorkspaceMockRepository.spec.mjs:259:1 > representative Toolbox tool pages use the wide Theme V2 layout |
-| project-workspace | 5.50s | tests\playwright\tools\ProjectWorkspaceMockRepository.spec.mjs:376:1 > Toolbox member-role filters focus tools without exposing admin-only controls |
-| project-workspace | 4.60s | tests\playwright\tools\ProjectWorkspaceMockRepository.spec.mjs:326:1 > Toolbox Project Data controls are admin-only and drive mock Build Path state |
-| asset-tool | 3.00s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:214:1 > Asset upload failures are visible and project context is required |
-| project-workspace | 2.70s | tests\playwright\tools\ProjectWorkspaceMockRepository.spec.mjs:96:1 > Project Workspace displays and edits project purpose and member role |
+| asset-tool | 2.80s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:250:1 > Asset upload failures are visible and project context is required |
+| asset-tool | 2.30s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:196:1 > Image, video, and audio uploads create project-owned metadata and previews |
+| asset-tool | 1.90s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:161:1 > Asset Role changes update Usage options and import form layout stays usable |
+| asset-tool | 1.70s | tests\playwright\tools\AssetToolMockRepository.spec.mjs:119:1 > Assets page lists all asset roles and starts from active project context |
+| asset-tool | 485ms | tests\playwright\tools\AssetToolMockRepository.spec.mjs:75:1 > Asset Tool repository exposes SQL-shaped role, storage, and metadata ownership |
 
 ## Commands
 
 ### workspace-contract
 - SKIP
 
 ### project-workspace
-- PASS 38.66s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ProjectWorkspaceMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
+- SKIP
 
 ### game-design
 - SKIP
@@ -146,7 +146,7 @@ Prevented Workspace lane reruns: 0
 - SKIP
 
 ### asset-tool
-- PASS 14.82s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
+- PASS 14.97s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/AssetToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
 
 ### build-path
 - SKIP