Skip to content

Commit a9696a0

Browse files
ToolboxAidToolboxAid
committed
MISSED
1 parent f14a3ab commit a9696a0

4 files changed

Lines changed: 165 additions & 26 deletions

File tree

‎docs_build/dev/codex_commands.md‎

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,50 +2,52 @@
22

33
Task:
44

5-
- `PR_26154_029-theme-v2-root-rename`
5+
- `PR_26154_030-toolbox-nav-character-closeout`
66

77
Changes:
88

99
- Read `.codex/skills/repo-build/SKILL.md`.
1010
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
11-
- Confirmed PR_26154_026-028 convergence baseline was clean enough to proceed.
12-
- Renamed the public Theme V2 asset root to `assets/theme-v2/`.
13-
- Updated active public/root page references to `assets/theme-v2`.
14-
- Updated active toolbox page references to `assets/theme-v2`.
15-
- Updated `_page_template_v2.html` and `toolbox/_tool_template-v2/index.html`.
16-
- Updated Theme V2 JS, partial, and toolbox index helper references.
17-
- Updated Theme V2 docs/governance references.
18-
- Adjusted moved Theme V2 CSS image URLs so checked `url(...)` targets resolve.
11+
- Used `PR_26154_029-theme-v2-root-rename` as the current baseline.
12+
- Updated shared Theme V2/toolbox character styling in `assets/theme-v2/css/panels.css`.
13+
- Kept the character image on the left by preserving the existing ToolDisplayMode DOM order.
14+
- Confirmed 15px character-to-content spacing through the existing `--space-15` token.
15+
- Updated the stale aggregate Theme V2 selector in `assets/theme-v2/css/gamefoundrystudio.css`.
16+
- Updated `assets/theme-v2/partials/header-nav.html` so all active toolbox tool pages appear in the Toolbox navigation.
17+
- Added Toolbox nav submenus for multi-tool groups, including Audio with MIDI and Sound.
18+
- Added route-map entries for Tool Builder and Tool Creator in `assets/theme-v2/js/gamefoundry-partials.js`.
19+
- Removed Marketplace from the active toolbox index data in `toolbox/tools-page-accordions.js`.
20+
- Kept Marketplace in the header and footer as a product/capability destination outside Toolbox.
1921
- Did not modify `old-tools/`, `old_games/`, `old_samples/`, or `start_of_day/`.
2022

2123
Validation:
2224

23-
- Ran targeted reference checks for the retired Theme V2 root path and `assets/theme-v2`.
24-
- Ran Theme V2 CSS import and `url(...)` target validation.
25-
- Ran template consistency audit after the rename.
25+
- Ran targeted reference checks for `toolbox/index.html`, `toolbox/tools-page-accordions.js`, shared header nav, Marketplace entries, `.tool-display-mode__character`, and `assets/theme-v2` paths.
26+
- Ran template consistency audit after the Toolbox nav update.
2627
- Ran static validation for changed HTML, JS, CSS, JSON, and Markdown files.
28+
- Ran changed JavaScript syntax checks.
2729
- Ran `npm run test:workspace-v2`.
2830
- Ran `git diff --check`.
2931
- Ran `npm run codex:review-artifacts`.
3032
- Packaged repo-structured ZIP:
31-
- `tmp/PR_26154_029-theme-v2-root-rename_delta.zip`
33+
- `tmp/PR_26154_030-toolbox-nav-character-closeout_delta.zip`
3234

3335
Required reports:
3436

3537
- `docs_build/dev/reports/codex_changed_files.txt`
3638
- `docs_build/dev/reports/codex_review.diff`
37-
- `docs_build/dev/reports/theme_v2_root_rename_report.md`
38-
- `docs_build/dev/reports/template_consistency_after_theme_rename_report.md`
39+
- `docs_build/dev/reports/toolbox_nav_character_closeout_report.md`
40+
- `docs_build/dev/reports/template_consistency_after_toolbox_nav_report.md`
3941

4042
Validation summary:
4143

42-
- PASS baseline convergence audit before rename: public/root pages `43/43`, active toolbox pages `20/20`.
43-
- PASS post-rename template audit: public/root pages `43/43`, active toolbox pages `20/20`.
44-
- PASS `assets/theme-v2/` exists.
45-
- PASS the retired Theme V2 root path does not exist.
44+
- PASS active toolbox header coverage: `20/20`.
45+
- PASS Marketplace removed from `toolbox/index.html` rendered data.
46+
- PASS Marketplace remains in footer Product column.
47+
- PASS `.tool-display-mode__character` is 150px by 150px in shared Theme V2 styling.
48+
- PASS 15px character spacing is present through `--space-15`.
4649
- PASS zero active references remain to the retired Theme V2 root path.
47-
- PASS active references resolve to `assets/theme-v2`.
48-
- PASS Theme V2 CSS import and image URL targets resolve.
50+
- PASS post-change template audit: public/root pages `43/43`, active toolbox pages `20/20`.
4951
- PASS `npm run test:workspace-v2`.
5052
- PASS `git diff --check`.
5153
- SKIPPED tests against `old-tools/`, `old_games/`, and `old_samples/` per request.

‎docs_build/dev/commit_comment.txt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Rename public Theme V2 asset root to assets/theme-v2 - PR_26154_029-theme-v2-root-rename
1+
Close out toolbox nav coverage and ToolDisplayMode character sizing - PR_26154_030-toolbox-nav-character-closeout
22

3-
- Move the public Theme V2 asset root to `assets/theme-v2/`.
4-
- Update active pages, toolbox pages, templates, JS helpers, partials, tests, and Theme V2 governance docs to the new root.
5-
- Keep deprecated old-tools and historical reports isolated without rewriting them.
6-
- Validate active references, template consistency, static changed files, Workspace V2, diff hygiene, and review artifacts.
3+
- Set shared Theme V2 `.tool-display-mode__character` rendering to 150px by 150px with 15px adjacent spacing.
4+
- Add all active toolbox tools to the shared header Toolbox navigation, including grouped Audio, Assets, Objects, Tooling, and Worlds submenus.
5+
- Remove Marketplace from the active toolbox index data while preserving Marketplace as a product/footer destination.
6+
- Validate active toolbox nav coverage, template consistency, Workspace V2, static changed files, diff hygiene, and review artifacts.

‎docs_build/dev/reports/template_consistency_after_toolbox_nav_report.md‎

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# PR_26154_030 Template Consistency After Toolbox Nav
2+
3+
Baseline used: `PR_26154_029-theme-v2-root-rename`.
4+
5+
## Audit Criteria
6+
7+
Public/root pages were checked for:
8+
9+
- `assets/theme-v2/css/theme.css`
10+
- no active retired Theme V2 root path references
11+
- no active `assets/theme-v2/css/styles.css` references
12+
- `page-title` marker on non-home public/root pages
13+
14+
Active toolbox pages were checked for:
15+
16+
- `assets/theme-v2/css/theme.css`
17+
- no active retired Theme V2 root path references
18+
- no active `assets/theme-v2/css/styles.css` references
19+
- `data-tool-display-mode`
20+
- `data-tool-slug`
21+
- `tool-display-mode.js`
22+
- `tool-workspace`
23+
- at least two `tool-column` markers
24+
- `tool-center-panel`
25+
26+
The audit excludes:
27+
28+
- `old-tools/`
29+
- `old_games/`
30+
- `old_samples/`
31+
- `start_of_day/`
32+
- generated reports
33+
- template source files when counting active pages
34+
35+
## Results
36+
37+
| Surface | Total | Matching | Mismatches |
38+
| --- | ---: | ---: | ---: |
39+
| Public/root pages | 43 | 43 | 0 |
40+
| Active toolbox pages | 20 | 20 | 0 |
41+
42+
## Header Nav Coverage
43+
44+
The shared header Toolbox navigation was also checked against active toolbox pages:
45+
46+
| Surface | Total | In Header Nav | Missing |
47+
| --- | ---: | ---: | ---: |
48+
| Active toolbox pages | 20 | 20 | 0 |
49+
50+
## Result
51+
52+
No active template-critical mismatches remain after the Toolbox nav and character sizing closeout.

‎docs_build/dev/reports/toolbox_nav_character_closeout_report.md‎

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
# PR_26154_030 Toolbox Nav Character Closeout
2+
3+
Baseline used: `PR_26154_029-theme-v2-root-rename`.
4+
5+
## Scope
6+
7+
This PR updates only shared active Theme V2/toolbox surfaces:
8+
9+
- `assets/theme-v2/css/panels.css`
10+
- `assets/theme-v2/css/gamefoundrystudio.css`
11+
- `assets/theme-v2/partials/header-nav.html`
12+
- `assets/theme-v2/js/gamefoundry-partials.js`
13+
- `toolbox/tools-page-accordions.js`
14+
15+
No `old-tools/`, `old_games/`, `old_samples/`, or `start_of_day/` files were modified.
16+
17+
## Tool Display Character Sizing
18+
19+
Updated shared Theme V2 toolbox styling so `.tool-display-mode__character` uses:
20+
21+
- `width: 150px`
22+
- `height: 150px`
23+
- `margin-right: var(--space-15)` in the active `theme.css` import path
24+
25+
The body gap was set to zero so the requested 15px character-to-content spacing is not doubled by flex gap. The character remains the first item in the existing ToolDisplayMode body, so it stays on the left of the adjacent content.
26+
27+
`assets/theme-v2/css/gamefoundrystudio.css` was updated in parallel to avoid retaining a conflicting stale Theme V2 selector in the aggregate stylesheet path.
28+
29+
## Toolbox Header Navigation
30+
31+
Updated the shared header partial so every active toolbox tool page appears in the Toolbox navigation.
32+
33+
Active toolbox pages checked: `20`
34+
35+
Header coverage result: `20/20`
36+
37+
Grouped submenu changes:
38+
39+
- `Assets`: Cloud, Localization, Publish, Storage Inspector
40+
- `Audio`: MIDI, Sound
41+
- `Objects`: Animation, Assets, Custom Extensions, Object Vector
42+
- `Tooling`: Tool Builder, Tool Creator
43+
- `Worlds`: Game Builder, Game Design, Particles, World Vector
44+
45+
Single active tool links remain direct:
46+
47+
- AI Assistant
48+
- Configuration Admin
49+
- Input
50+
- Palette Manager
51+
52+
Added route-map entries for:
53+
54+
- `tool-builder`
55+
- `tool-creator`
56+
57+
## Marketplace Cleanup
58+
59+
Removed Marketplace from the active toolbox index data in `toolbox/tools-page-accordions.js`.
60+
61+
Marketplace remains available as a product/capability destination:
62+
63+
- top-level shared header link
64+
- footer Product column link
65+
66+
## Targeted Checks
67+
68+
- PASS: all active `toolbox/[toolname]/index.html` pages are represented in `assets/theme-v2/partials/header-nav.html`.
69+
- PASS: no deprecated `old-tools/`, `old_games/`, or `old_samples/` paths are present in the shared header.
70+
- PASS: `toolbox/index.html` and `toolbox/tools-page-accordions.js` contain no Marketplace tile/link entry.
71+
- PASS: `assets/theme-v2/partials/footer.html` still contains the Marketplace Product-column link.
72+
- PASS: zero active references remain to the retired `assets/theme/v2` path.
73+
- PASS: `.tool-display-mode__character` resolves to 150px by 150px in shared Theme V2 styling.
74+
- PASS: 15px adjacent spacing is provided through `var(--space-15)`.
75+
76+
## Validation
77+
78+
- `npm run test:workspace-v2`: PASS, 2 tests passed.
79+
- Targeted header/toolbox/Marketplace/reference checks: PASS.
80+
- Template consistency audit after Toolbox nav update: PASS.
81+
- Static validation for changed HTML, JS, CSS, JSON, and Markdown files: PASS.
82+
- Changed JavaScript syntax validation: PASS.
83+
- `git diff --check`: PASS with line-ending warnings only.
84+
85+
Full samples smoke test was skipped by request. Tests against `old-tools/`, `old_games/`, and `old_samples/` were skipped by request.

0 commit comments

Comments
 (0)