Skip to content

Commit ad27a42

Browse files
committed
Restore Notes tool to use docs_build/dev/admin-notes as source of truth and remove duplicate Notes assumptions - PR_26169_028-notes-source-correction
1 parent 6969d1f commit ad27a42

5 files changed

Lines changed: 149 additions & 418 deletions

File tree

docs_build/dev/reports/PR_26169_027-owner-notes-restoration.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ Restored Notes as an active Owner page without touching the isolated dev-only Ad
4646
- Playwright was required because rendered Owner navigation behavior changed.
4747
- The first focused Playwright run failed because the existing test helper relied on `.env` public API config and did not bind browser API calls to the random Playwright server. The helper now seeds local DB mode and temporarily points `GAMEFOUNDRY_API_URL` / `GAMEFOUNDRY_SITE_URL` at the test server, then restores prior values.
4848
- A second focused Playwright run failed because the new assertion used `nav[aria-label='Owner business pages']`, while existing Owner side menus are `aside.side-menu`; the selector was corrected and the final run passed.
49+
- A follow-up rerun in the current local environment found unrelated 500 responses from shared platform-banner and toolbox-registry APIs. The targeted navigation Playwright helper now stubs inactive banner and empty toolbox registry responses so Owner/Admin navigation validation remains isolated from unrelated service availability.
4950
- Playwright V8 coverage was refreshed for changed runtime JavaScript. `coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
5051

5152
## Lane Decisions
Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,13 @@
11
# git status --short
2-
M assets/theme-v2/js/gamefoundry-partials.js
3-
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
2+
M docs_build/dev/reports/PR_26169_027-owner-notes-restoration.md
43
M docs_build/dev/reports/playwright_v8_coverage_report.txt
5-
M src/api/admin-owner-navigation.js
6-
M tests/dev-runtime/ApiMenuPathCleanup.test.mjs
74
M tests/playwright/tools/AdminOwnerNavigationBoundary.spec.mjs
8-
?? docs_build/dev/reports/PR_26169_027-owner-notes-restoration.md
9-
?? docs_build/pr/BUILD_PR_26169_027-owner-notes-restoration.md
10-
?? owner/notes.html
115

126
# git ls-files --others --exclude-standard
13-
docs_build/dev/reports/PR_26169_027-owner-notes-restoration.md
14-
docs_build/pr/BUILD_PR_26169_027-owner-notes-restoration.md
15-
owner/notes.html
7+
(no output)
168

179
# git diff --stat
18-
assets/theme-v2/js/gamefoundry-partials.js | 1 +
19-
.../dev/reports/coverage_changed_js_guardrail.txt | 10 ++--
20-
.../dev/reports/playwright_v8_coverage_report.txt | 47 +++++++-----------
21-
src/api/admin-owner-navigation.js | 2 +-
22-
tests/dev-runtime/ApiMenuPathCleanup.test.mjs | 12 +++++
23-
.../tools/AdminOwnerNavigationBoundary.spec.mjs | 57 ++++++++++++++++++++--
24-
6 files changed, 88 insertions(+), 41 deletions(-)
10+
.../PR_26169_027-owner-notes-restoration.md | 1 +
11+
.../dev/reports/playwright_v8_coverage_report.txt | 6 +--
12+
.../tools/AdminOwnerNavigationBoundary.spec.mjs | 50 ++++++++++++++++++++++
13+
3 files changed, 53 insertions(+), 4 deletions(-)

0 commit comments

Comments
 (0)