Skip to content

Commit af88cd2

Browse files
committed
Merge PR_26171_010-message-speech-preview
2 parents 1054001 + d2cf555 commit af88cd2

11 files changed

Lines changed: 726 additions & 828 deletions

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Add Messages TTS profile foundation - PR_26171_008
1+
Add browser-local Messages speech preview - PR_26171_010
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR_26171_010 Manual Validation Notes
2+
3+
- Confirmed the Messages inspector includes a Speech Preview section.
4+
- Confirmed selected message preview uses the active TTS profile voice/language and the message emotion profile delivery values.
5+
- Confirmed active segment preview speaks active segments in display order.
6+
- Confirmed segment preview applies each segment emotion profile's delivery values.
7+
- Confirmed Stop Preview calls cancel and reports stopped status.
8+
- Confirmed missing browser speech synthesis reports an actionable diagnostic.
9+
- Confirmed no server TTS, audio generation, audio persistence, runtime playback API, or preview history storage was introduced.
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
PR_26171_010-message-speech-preview validation
2+
3+
Branch:
4+
PASS pr/PR_26171_010-message-speech-preview
5+
6+
Syntax:
7+
PASS node --check toolbox/messages/messages.js
8+
PASS node --check tests/playwright/tools/MessagesTool.spec.mjs
9+
10+
Targeted Playwright:
11+
PASS npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list
12+
Result: 2 passed.
13+
14+
Preview behavior:
15+
PASS selected full-message preview produced a stubbed utterance.
16+
PASS active ordered segment preview produced ordered stubbed utterances.
17+
PASS segment preview used emotion profile volume, pitch, and rate.
18+
PASS Stop Preview called cancel.
19+
PASS missing speech synthesis displayed an actionable diagnostic.
20+
21+
Workspace lane:
22+
FAIL npm run test:workspace-v2
23+
Failure file: tests/playwright/tools/RootToolsFutureState.spec.mjs
24+
Failures:
25+
- Toolbox accordion control-card count was 0.
26+
- Header alphabetical expectation failed around Game Hub/Game Journey ordering.
27+
- Non-Messages pages reported failed requests to session, platform banner, registry, and toolbox constants APIs.
28+
29+
Whitespace:
30+
PASS git diff --check on touched files. CRLF warnings only.
31+
32+
Disposition:
33+
MERGE WITH RECORDED WORKSPACE FAILURE. PR_010 targeted validation passed. The required workspace-v2 lane failed outside the Messages speech preview scope and is documented for follow-up.
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# PR_26171_010-message-speech-preview
2+
3+
## Branch Validation
4+
5+
- Branch: `pr/PR_26171_010-message-speech-preview`
6+
- Source: clean `main` after PR_26171_008 merge and push.
7+
- Status: PASS for branch setup and scoped implementation.
8+
9+
## Requirement Checklist
10+
11+
- PASS: Added a Theme V2 Speech Preview section to the Messages tool.
12+
- PASS: Added selected full-message preview.
13+
- PASS: Added selected ordered active-segment preview.
14+
- PASS: Preview uses selected/default active TTS Profile settings for language and voice.
15+
- PASS: Segment preview uses each segment's Emotion Profile settings for volume, pitch, and rate.
16+
- PASS: Browser-local preview uses `speechSynthesis` and `SpeechSynthesisUtterance` when available.
17+
- PASS: Missing browser speech support shows a visible actionable diagnostic.
18+
- PASS: Stop Preview calls `speechSynthesis.cancel()` and updates status.
19+
- PASS: Preview logic lives in external `toolbox/messages/messages.js`.
20+
- PASS: Playwright stubs browser speech synthesis and validates preview payloads without real audio output.
21+
- PASS: No server-side TTS generation, audio file generation, audio persistence, AI voices, voice adapters, runtime playback API, dialog trees, localization, translation, game runtime integration, or preview history storage was added.
22+
- PASS: No new API/DB persistence was added.
23+
- PASS: No inline styles, style blocks, inline scripts, or inline event handlers were introduced.
24+
- FAIL: Required `npm run test:workspace-v2` lane failed in existing `RootToolsFutureState.spec.mjs` coverage outside the Messages speech preview scope.
25+
26+
## Validation Lane Report
27+
28+
- PASS: `node --check toolbox/messages/messages.js`
29+
- PASS: `node --check tests/playwright/tools/MessagesTool.spec.mjs`
30+
- PASS: `npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --project=playwright --workers=1 --reporter=list`
31+
- PASS: Validated preview selected message payload with stubbed speech synthesis.
32+
- PASS: Validated preview active ordered segment payloads with emotion profile settings.
33+
- PASS: Validated Stop Preview cancel behavior.
34+
- PASS: Validated unavailable speech synthesis diagnostic.
35+
- PASS: `git diff --check` on touched files.
36+
- FAIL: `npm run test:workspace-v2`
37+
38+
## Workspace-V2 Failure Summary
39+
40+
`npm run test:workspace-v2` failed in `tests/playwright/tools/RootToolsFutureState.spec.mjs`:
41+
42+
- Toolbox accordion `.control-card` count was `0`.
43+
- Header alphabetical expectation failed around `Game Hub` and `Game Journey`.
44+
- Non-Messages pages reported failed requests to session, platform banner, registry, and toolbox constants APIs.
45+
46+
These failures were already present for the batch and are outside PR_010's browser-local Messages speech preview scope.
47+
48+
## Manual Validation Notes
49+
50+
- Selected message preview reports a preview request and produces one stubbed utterance.
51+
- Active ordered segment preview reports a preview request and produces ordered stubbed utterances.
52+
- Segment utterances use the segment emotion profile's volume, pitch, and rate.
53+
- Stop Preview reports stopped status and calls cancel.
54+
- Missing browser speech synthesis shows an actionable diagnostic.
55+
- No audio is generated or persisted.
56+
57+
## Samples Decision
58+
59+
- Full samples smoke was not run because samples are out of scope for browser-local Messages speech preview.
Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
1-
docs_build/database/ddl/messages.sql
2-
docs_build/database/dml/messages.sql
3-
docs_build/database/seed/messages.json
41
docs_build/dev/commit_comment.txt
5-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation-manual-validation.md
6-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation-validation.txt
7-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation.md
2+
docs_build/dev/reports/PR_26171_010-message-speech-preview-manual-validation.md
3+
docs_build/dev/reports/PR_26171_010-message-speech-preview-validation.txt
4+
docs_build/dev/reports/PR_26171_010-message-speech-preview.md
85
docs_build/dev/reports/codex_changed_files.txt
96
docs_build/dev/reports/codex_review.diff
107
docs_build/dev/reports/coverage_changed_js_guardrail.txt
118
docs_build/dev/reports/playwright_v8_coverage_report.txt
12-
src/dev-runtime/messages/messages-sqlite-service.mjs
139
tests/playwright/tools/MessagesTool.spec.mjs
1410
toolbox/messages/index.html
15-
toolbox/messages/messages-api-client.js
1611
toolbox/messages/messages.js

0 commit comments

Comments
 (0)