Skip to content

Commit b0efd21

Browse files
committed
Document Toolbox recovery alignment and next architecture step - PR_26155_005-toolbox-recovery-alignment
1 parent 0e5563a commit b0efd21

3 files changed

Lines changed: 85 additions & 1 deletion

File tree

docs_build/dev/codex_commands.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,3 +222,28 @@ Required reports:
222222
- `docs_build/dev/reports/toolbox-runtime-ownership.md`
223223
- `docs_build/dev/reports/codex_changed_files.txt`
224224
- `docs_build/dev/reports/codex_review.diff`
225+
226+
## PR_26155_005
227+
228+
Changes:
229+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
230+
- Created `docs_build/dev/reports/toolbox-recovery-alignment.md`.
231+
- Summarized the executed Toolbox recovery sequence:
232+
- `PR_26154_053` initially added the wireframe incorrectly as extra sections.
233+
- The follow-up view-mode correction made Progress and Build Path page mode controls.
234+
- `PR_26155_004` kept `toolbox/tools-page-accordions.js` because it still owns current Toolbox rendering.
235+
- Documented that `toolbox/index.html` is transitional and still depends on `toolbox/tools-page-accordions.js`.
236+
- Documented the next required architecture step: create a registry-driven Toolbox runtime for Order, Group, Progress, and Build Path before removing `tools-page-accordions.js`.
237+
- Added Project Workspace naming guidance in the report.
238+
- Added targeted validation guidance in the report.
239+
- Did not modify runtime behavior, `toolbox/index.html`, CSS, tools, or `toolbox/tools-page-accordions.js`.
240+
241+
Validation:
242+
- `git diff --check`.
243+
- Verified the report names the current state and next architecture step clearly.
244+
- Playwright skipped because impacted is No and this PR is docs/report alignment only.
245+
246+
Required reports:
247+
- `docs_build/dev/reports/toolbox-recovery-alignment.md`
248+
- `docs_build/dev/reports/codex_changed_files.txt`
249+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Document Toolbox runtime ownership decision - PR_26155_004-toolbox-runtime-ownership
1+
Add Toolbox recovery alignment report - PR_26155_005-toolbox-recovery-alignment
Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# Toolbox Recovery Alignment
2+
3+
PR: `PR_26155_005-toolbox-recovery-alignment`
4+
5+
## Scope
6+
- This PR is docs/report alignment only.
7+
- No runtime behavior was modified.
8+
- `toolbox/index.html` was not modified.
9+
- No CSS was added.
10+
- No tools were added.
11+
- `toolbox/tools-page-accordions.js` was not deleted.
12+
13+
## Executed Toolbox PR Sequence
14+
- `PR_26154_053` added the initial Toolbox wireframe incorrectly as extra Progress and Build Path sections.
15+
- The view-mode correction changed Progress and Build Path into page mode controls on the same Toolbox surface.
16+
- The corrected Toolbox surface uses `Order | Group | Progress | Build Path` as view modes, not standalone tool cards, accordions, or extra sections.
17+
- `PR_26155_004` audited `toolbox/index.html` and `toolbox/tools-page-accordions.js`.
18+
- `PR_26155_004` decided KEEP for `toolbox/tools-page-accordions.js` because it still owns current Toolbox rendering.
19+
20+
## Current State
21+
- `toolbox/index.html` is transitional.
22+
- `toolbox/index.html` contains the Toolbox title, four view controls, and an empty `[data-tools-accordion-list]` render host.
23+
- Current Toolbox card rendering still depends on `toolbox/tools-page-accordions.js`.
24+
- Current Order, Group, Progress, and Build Path views still depend on `toolbox/tools-page-accordions.js`.
25+
- Current Progress readiness labels still depend on `toolbox/tools-page-accordions.js`.
26+
- Current Build Path grouped rendering still depends on `toolbox/tools-page-accordions.js`.
27+
28+
## Runtime Ownership Decision
29+
- KEEP `toolbox/tools-page-accordions.js` for now.
30+
- Deletion is not safe while the active Toolbox page still relies on it for rendering.
31+
- Do not remove `toolbox/tools-page-accordions.js` until the Toolbox runtime has a replacement active source of truth.
32+
33+
## Next Required Architecture Step
34+
Create a registry-driven Toolbox runtime for:
35+
- Order
36+
- Group
37+
- Progress
38+
- Build Path
39+
40+
The registry-driven runtime should own tool metadata, grouping, routes, status/readiness, requirements, progress checklist data, and deferred flags through a declared registry/data source.
41+
42+
Only after that runtime exists and `toolbox/index.html` no longer depends on `toolbox/tools-page-accordions.js` should `toolbox/tools-page-accordions.js` be removed.
43+
44+
## Project Workspace Naming Guidance
45+
- User-facing text must say `Project Workspace`.
46+
- New test/report prose should use `Project Workspace` for the current product experience.
47+
- `Workspace V2` may appear only when referencing actual legacy script names, command names, lane identifiers, or historical suite names that still exist.
48+
- Example: `npm run test:workspace-v2` may be named as a legacy command, but reports should explain that user-facing language is `Project Workspace`.
49+
50+
## Targeted Validation Reminder
51+
- Tool, page, and `src/` changes must use the narrowest affected validation lane that proves the changed behavior.
52+
- Do not run broad validation for small scoped changes unless shared runtime behavior changes.
53+
- Docs/report-only alignment changes should use static validation such as `git diff --check` unless the BUILD explicitly requests more.
54+
55+
## Validation
56+
- PASS: `git diff --check`.
57+
- PASS: report names the current transitional Toolbox state clearly.
58+
- PASS: report names the next required registry-driven runtime step clearly.
59+
- SKIPPED: Playwright, because this PR is docs/report alignment only and Playwright impacted is No.

0 commit comments

Comments
 (0)