Consolidate storage prefix, document GFSP packages, validate R2, and wire Assets storage - PR_26168_222-through-225-r2-assets-stack

Author: ToolboxAid

.env.example

@@ -26,4 +26,3 @@ GAMEFOUNDRY_STORAGE_ACCESS_KEY_ID=
 GAMEFOUNDRY_STORAGE_SECRET_ACCESS_KEY=
 GAMEFOUNDRY_STORAGE_BUCKET=
 GAMEFOUNDRY_STORAGE_PROJECTS_PREFIX=
-GAMEFOUNDRY_ASSET_STORAGE_PATH=

admin/infrastructure.html

@@ -44,7 +44,7 @@ <h2>Admin</h2>
                                     <p>/dev/projects/</p>
                                     <p>/ist/projects/</p>
                                     <p>/uat/projects/</p>
-                                    <p>/prod/projects/</p>
+                                    <p>/prd/projects/</p>
                                 </div>
                             </details>
                         </div>
@@ -72,7 +72,7 @@ <h3 id="admin-infrastructure-image-zoom-title">Game Foundry Infrastructure</h3>
                         </dialog>
                         <div class="table-wrapper">
                             <table class="data-table" aria-label="Project storage path reference">
-                                <caption>Project Asset Storage Paths use <code>GAMEFOUNDRY_ASSET_STORAGE_PATH</code></caption>
+                                <caption>Project Asset Storage Paths use <code>GAMEFOUNDRY_STORAGE_PROJECTS_PREFIX</code></caption>
                                 <thead>
                                     <tr>
                                         <th scope="col">Lane</th>
@@ -84,7 +84,23 @@ <h3 id="admin-infrastructure-image-zoom-title">Game Foundry Infrastructure</h3>
                                     <tr><td>DEV</td><td>/dev/projects/</td><td>Loading</td></tr>
                                     <tr><td>IST</td><td>/ist/projects/</td><td>Loading</td></tr>
                                     <tr><td>UAT</td><td>/uat/projects/</td><td>Loading</td></tr>
-                                    <tr><td>PROD</td><td>/prod/projects/</td><td>Loading</td></tr>
+                                    <tr><td>PRD</td><td>/prd/projects/</td><td>Loading</td></tr>
+                                </tbody>
+                            </table>
+                        </div>
+                        <div class="table-wrapper">
+                            <table class="data-table" aria-label="Admin storage connectivity results">
+                                <caption>Storage Connectivity Results</caption>
+                                <thead>
+                                    <tr>
+                                        <th scope="col">Action</th>
+                                        <th scope="col">Status</th>
+                                        <th scope="col">Executed</th>
+                                        <th scope="col">Message</th>
+                                    </tr>
+                                </thead>
+                                <tbody data-admin-storage-connectivity-result-rows>
+                                    <tr><td>startup</td><td>SKIP</td><td>no</td><td>No storage connectivity action has been run.</td></tr>
                                 </tbody>
                             </table>
                         </div>
@@ -107,7 +123,17 @@ <h2>Inspector</h2>
                                 <summary>Guardrails</summary>
                                 <div class="accordion-body content-stack">
                                     <p>Infrastructure status remains a read-only Admin reference.</p>
-                                    <p>Operational actions and connection validation stay on Owner Operations.</p>
+                                    <p>Storage connectivity tests run through the Local API and never expose secrets.</p>
+                                </div>
+                            </details>
+                            <details class="vertical-accordion" open>
+                                <summary>Storage Connectivity</summary>
+                                <div class="accordion-body content-stack">
+                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-list">List</button>
+                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-write-test-object">Write Test Object</button>
+                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-read-test-object">Read Test Object</button>
+                                    <button class="btn btn--compact" type="button" data-admin-storage-connectivity-action="storage-delete-test-object">Delete Test Object</button>
+                                    <p class="status" role="status" data-admin-storage-connectivity-status>Storage connectivity not run.</p>
                                 </div>
                             </details>
                         </div>

assets/theme-v2/js/admin-infrastructure.js

@@ -1,27 +1,58 @@
 import {
-    readAdminInfrastructureStoragePathStatus
+    readAdminInfrastructureStoragePathStatus,
+    runAdminInfrastructureStorageConnectivityAction
 } from "../../../src/engine/api/admin-infrastructure-api-client.js";
 
 const STORAGE_PATH_LANES = Object.freeze([
     Object.freeze({ lane: "DEV", path: "/dev/projects/" }),
     Object.freeze({ lane: "IST", path: "/ist/projects/" }),
     Object.freeze({ lane: "UAT", path: "/uat/projects/" }),
-    Object.freeze({ lane: "PROD", path: "/prod/projects/" }),
+    Object.freeze({ lane: "PRD", path: "/prd/projects/" }),
 ]);
 
 class AdminInfrastructureStoragePathStatus {
     constructor(root) {
         this.root = root;
+        this.connectivityActionButtons = Array.from(root.querySelectorAll("[data-admin-storage-connectivity-action]"));
+        this.connectivityRows = root.querySelector("[data-admin-storage-connectivity-result-rows]");
+        this.connectivityStatus = root.querySelector("[data-admin-storage-connectivity-status]");
         this.rows = root.querySelector("[data-admin-storage-path-status-rows]");
     }
 
     init() {
         if (!this.rows) {
             return;
         }
+        this.connectivityActionButtons.forEach((button) => {
+            button.addEventListener("click", () => this.runStorageConnectivityAction(button.dataset.adminStorageConnectivityAction));
+        });
         this.load();
     }
 
+    setConnectivityStatus(status, message) {
+        if (this.connectivityStatus) {
+            this.connectivityStatus.textContent = `${status}: ${message}`;
+        }
+    }
+
+    appendConnectivityResult(result = {}) {
+        if (!this.connectivityRows) {
+            return;
+        }
+        const row = document.createElement("tr");
+        [
+            result.actionId || "storage-connectivity",
+            result.status || "WARN",
+            result.executed === true ? "yes" : "no",
+            result.message || "No storage connectivity message returned.",
+        ].forEach((value) => {
+            const cell = document.createElement("td");
+            cell.textContent = value;
+            row.append(cell);
+        });
+        this.connectivityRows.prepend(row);
+    }
+
     renderRows(rows) {
         this.rows.replaceChildren();
         rows.forEach((row) => {
@@ -58,6 +89,16 @@ class AdminInfrastructureStoragePathStatus {
             this.renderFailure(error instanceof Error ? error.message : "Storage path status unavailable.");
         }
     }
+
+    runStorageConnectivityAction(actionId) {
+        try {
+            const result = runAdminInfrastructureStorageConnectivityAction(actionId);
+            this.appendConnectivityResult(result);
+            this.setConnectivityStatus(result.status || "WARN", result.message || "Storage connectivity action returned no message.");
+        } catch (error) {
+            this.setConnectivityStatus("FAIL", error instanceof Error ? error.message : "Storage connectivity action failed.");
+        }
+    }
 }
 
 document.addEventListener("DOMContentLoaded", () => {

docs_build/codex/decisions/project-packages.md

@@ -0,0 +1,38 @@
+# Project Packages
+
+## Decision
+
+`.gfsp` is the Game Foundry Studio Project package extension.
+
+Game Foundry Studio project packages use an internal ZIP-based package format. The `.gfsp` extension identifies the package as a Game Foundry Studio Project while preserving the operational advantages of a ZIP container for export, import, validation, and inspection.
+
+## Filename Format
+
+Project package filenames use:
+
+`<ProjectNameWithoutSpaces>-<YYJJJ>-<sequence>.gfsp`
+
+Example:
+
+`KingOfTheIceberg-26168-001.gfsp`
+
+Rules:
+
+- `ProjectNameWithoutSpaces` removes spaces from the project display name.
+- `YYJJJ` uses the two-digit year plus Julian day.
+- `sequence` is a three-digit package sequence for that project/day.
+- The filename is metadata for operators and review; package contents remain authoritative for project identity.
+
+## Promotion Terms
+
+Project promotion language uses package operations:
+
+- Export Project Package
+- Import Project Package
+- Validate Project Package
+
+Promotion planning should describe which project package is exported, imported, or validated and which environment lane is involved. Browser surfaces must not perform destructive promotion behavior without an explicit reviewed runtime contract.
+
+## Notes
+
+These notes are Codex decision notes only. They are intentionally kept under `docs_build/codex/decisions/` and must not be promoted into root, `src/`, `assets/`, `toolbox/`, `games/`, or runtime paths.

docs_build/dev/codex_commands.md

@@ -2180,3 +2180,125 @@ Required reports:
 
 Packaging:
 - `tmp/PR_26168_221-storage-path-error-rule-and-r2-env-ready_delta.zip`
+
+
+## PR_26168_222-storage-env-prefix-consolidation
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main`.
+- Consolidated Admin Infrastructure storage path status on `GAMEFOUNDRY_STORAGE_PROJECTS_PREFIX`.
+- Removed active Admin/runtime/page dependence on `GAMEFOUNDRY_ASSET_STORAGE_PATH`.
+- Updated Admin Infrastructure lane copy from `/prod/projects/` to `/prd/projects/`.
+- Updated tracked `.env.example` to remove the old asset storage path placeholder.
+- Updated ignored local `.env.<target>` copy-source files with non-secret storage prefix placeholders only.
+
+Validation:
+- `node --check src/dev-runtime/server/local-api-router.mjs`
+- `node --check assets/theme-v2/js/admin-infrastructure.js`
+- `node --check tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs`
+- Admin Infrastructure static contract check for storage prefix consolidation and no inline HTML script/style/event handlers.
+- `npx playwright test tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs -g "Infrastructure Admin wireframe preserves template structure|Infrastructure storage path status reports missing env path as ERROR|Infrastructure storage path status reports invalid env path as ERROR|Infrastructure storage path status reports DEV match only|Infrastructure storage path status reports IST match only"`
+- Full samples smoke skipped because sample JSON and sample runtime behavior were not touched.
+
+Required reports:
+- `docs_build/dev/reports/PR_26168_222-storage-env-prefix-consolidation.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+
+Packaging:
+- `tmp/PR_26168_222-storage-env-prefix-consolidation_delta.zip`
+
+
+## PR_26168_223-codex-decisions-notes
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main`.
+- Added `docs_build/codex/decisions/project-packages.md`.
+- Documented `.gfsp` as Game Foundry Studio Project.
+- Documented the internal ZIP-based package format, package filename format, example filename, and package-based promotion terms.
+- Kept Codex decision notes under `docs_build/codex/decisions/` only.
+
+Validation:
+- `Get-Content -Path docs_build/codex/decisions/project-packages.md`
+- Static Node validation for `.gfsp`, ZIP package format, filename format, example, promotion terminology, and allowed notes path.
+- `git diff --check`
+- Full samples smoke skipped because sample JSON and sample runtime behavior were not touched.
+
+Required reports:
+- `docs_build/dev/reports/PR_26168_223-codex-decisions-notes.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`
+
+Packaging:
+- `tmp/PR_26168_223-codex-decisions-notes_delta.zip`
+
+
+## PR_26168_224-r2-storage-connectivity-test
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main`.
+- Added Owner Operations storage connectivity actions for List, Write test object, Read test object, and Delete test object.
+- Added Admin Infrastructure storage connectivity actions for List, Write test object, Read test object, and Delete test object.
+- Routed connectivity actions through Local API and the configured project asset storage provider.
+- Added storage provider delete support for the test object cleanup path.
+- Preserved hidden credential handling and visible failure diagnostics.
+
+Validation:
+- `node --check src/dev-runtime/server/local-api-router.mjs`
+- `node --check src/dev-runtime/storage/r2-project-asset-storage.mjs`
+- `node --check src/engine/api/admin-infrastructure-api-client.js`
+- `node --check assets/theme-v2/js/admin-infrastructure.js`
+- `node --check tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs`
+- Static Node storage connectivity contract validation for no inline HTML script/style/event handlers, server-owned storage actions, prefix diagnostics, and DELETE support.
+- `npx playwright test tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs -g "Infrastructure Admin wireframe preserves template structure|Infrastructure storage connectivity actions call Local API and hide secrets|Owner Operations exposes owner-only connection validation and manual operation actions"`
+- `git diff --check`
+- Full samples smoke skipped because sample JSON and sample runtime behavior were not touched.
+
+Required reports:
+- `docs_build/dev/reports/PR_26168_224-r2-storage-connectivity-test.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+
+Packaging:
+- `tmp/PR_26168_224-r2-storage-connectivity-test_delta.zip`
+
+
+## PR_26168_225-assets-r2-storage-integration
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main`.
+- Updated Assets storage-backed delete so the Local API repository deletes the configured storage object before removing DB metadata.
+- Preserved upload/list/read through the Local API and configured project asset storage provider.
+- Preserved browser API repository ownership and guest upload blocking.
+- Added fake R2 DELETE validation to the targeted Assets storage Playwright test.
+
+Validation:
+- `node --check src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js`
+- `node --check tests/playwright/tools/AssetToolMockRepository.spec.mjs`
+- `node --check toolbox/assets/assets.js`
+- `node --check toolbox/assets/assets-api-client.js`
+- Static Node Assets storage/API contract validation for API repository ownership, no browser storage SSoT, storage-provider write/read/delete, DB metadata keys, no sample JSON changes, and no `start_of_day` changes.
+- `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs -g "Assets DEV storage upload list read and delete use configured projects prefix"`
+- `npx playwright test tests/playwright/tools/AssetToolMockRepository.spec.mjs -g "Assets guest upload action shows account prompt and creates no record"`
+- `npm run test:workspace-v2`
+- `git diff --check`
+- Full samples smoke skipped because sample JSON and sample runtime behavior were not touched.
+- `npm run test:workspace-v2` is a legacy command name; user-facing language is Project Workspace.
+
+Required reports:
+- `docs_build/dev/reports/PR_26168_225-assets-r2-storage-integration.md`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+
+Packaging:
+- `tmp/PR_26168_225-assets-r2-storage-integration_delta.zip`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Storage path error rule and R2 env readiness - PR_26168_221-storage-path-error-rule-and-r2-env-ready
+Assets R2 storage integration - PR_26168_225-assets-r2-storage-integration