Back Toolbox status and votes with DB state - PR_26160_057-toolbox-db-status-vote-restore

Author: ToolboxAid

admin/tool-votes.html

@@ -42,15 +42,22 @@ <h1>Tool Votes</h1>
                             <div class="kicker">Shared Toolbox Data</div>
                             <h2>Vote Review</h2>
                         </div>
-                        <p>Vote totals are read from the server API data source used by Toolbox tiles.</p>
+                        <p>Vote totals and order values are read from the server API data source used by Toolbox tiles.</p>
                         <p class="status" role="status" data-toolbox-votes-status>Loading Toolbox vote totals.</p>
+                        <div class="content-cluster" aria-label="Selected Toolbox vote item">
+                            <span class="pill">Selected Order: <span data-toolbox-votes-selected-order>None</span></span>
+                            <span class="pill">Selected Group: <span data-toolbox-votes-selected-group>None</span></span>
+                            <span class="pill">Selected Path: <span data-toolbox-votes-selected-path>None</span></span>
+                        </div>
                         <div class="table-wrapper">
                             <table class="data-table" aria-label="Toolbox vote totals">
                                 <caption>Toolbox Vote Totals</caption>
                                 <thead>
                                     <tr>
                                         <th scope="col">Tool</th>
+                                        <th scope="col">Order</th>
                                         <th scope="col">Group</th>
+                                        <th scope="col">Path</th>
                                         <th scope="col">State</th>
                                         <th scope="col">Up</th>
                                         <th scope="col">Down</th>

admin/tool-votes.js

@@ -1,7 +1,16 @@
-import { readToolboxVoteSnapshot } from "../src/engine/api/toolbox-votes-api-client.js";
+import {
+  readToolboxVoteSnapshot,
+  updateToolboxVoteOrder,
+} from "../src/engine/api/toolbox-votes-api-client.js";
 
 const status = document.querySelector("[data-toolbox-votes-status]");
 const body = document.querySelector("[data-toolbox-votes-body]");
+const selectedOrder = document.querySelector("[data-toolbox-votes-selected-order]");
+const selectedGroup = document.querySelector("[data-toolbox-votes-selected-group]");
+const selectedPath = document.querySelector("[data-toolbox-votes-selected-path]");
+
+let selectedToolId = "";
+let snapshotRows = [];
 
 function setStatus(message) {
   if (status) {
@@ -11,47 +20,110 @@ function setStatus(message) {
 
 function tableCell(value) {
   const cell = document.createElement("td");
-  cell.textContent = String(value || "");
+  cell.textContent = value === null || value === undefined ? "" : String(value);
+  return cell;
+}
+
+function setSelectedDetails(voteRow) {
+  if (selectedOrder) {
+    selectedOrder.textContent = voteRow ? String(voteRow.order) : "None";
+  }
+  if (selectedGroup) {
+    selectedGroup.textContent = voteRow?.group || "None";
+  }
+  if (selectedPath) {
+    selectedPath.textContent = voteRow?.path || "None";
+  }
+}
+
+function selectRow(toolId) {
+  selectedToolId = String(toolId || "");
+  const selectedRow = snapshotRows.find((row) => row.toolId === selectedToolId);
+  setSelectedDetails(selectedRow);
+  body?.querySelectorAll("tr[data-toolbox-votes-tool-id]").forEach((row) => {
+    row.setAttribute("aria-selected", String(row.dataset.toolboxVotesToolId === selectedToolId));
+  });
+}
+
+function orderCell(voteRow) {
+  const cell = document.createElement("td");
+  const input = document.createElement("input");
+  input.type = "number";
+  input.min = "0";
+  input.step = "1";
+  input.value = String(voteRow.order);
+  input.dataset.toolboxVotesOrderInput = voteRow.toolId;
+  input.setAttribute("aria-label", `Order for ${voteRow.toolName}`);
+  input.addEventListener("change", () => {
+    updateOrder(voteRow, input.value);
+  });
+  input.addEventListener("focus", () => {
+    selectRow(voteRow.toolId);
+  });
+  cell.append(input);
   return cell;
 }
 
 function renderRows(rows) {
   if (!body) {
     return;
   }
+  snapshotRows = rows;
   if (!rows.length) {
     const row = document.createElement("tr");
     const cell = document.createElement("td");
-    cell.colSpan = 6;
+    cell.colSpan = 8;
     cell.textContent = "No Toolbox vote rows are available.";
     row.append(cell);
     body.replaceChildren(row);
+    setSelectedDetails(null);
     return;
   }
 
   body.replaceChildren(...rows.map((voteRow) => {
     const row = document.createElement("tr");
     row.dataset.toolboxVotesToolId = voteRow.toolId;
+    row.addEventListener("click", () => {
+      selectRow(voteRow.toolId);
+    });
     row.append(
       tableCell(voteRow.toolName),
+      orderCell(voteRow),
       tableCell(voteRow.group),
+      tableCell(voteRow.path),
       tableCell(voteRow.releaseChannelLabel),
       tableCell(voteRow.up),
       tableCell(voteRow.down),
       tableCell(voteRow.currentUserVote || "None"),
     );
     return row;
   }));
+
+  selectRow(selectedToolId || rows[0].toolId);
+}
+
+function renderSnapshot(snapshot, message) {
+  renderRows(snapshot.rows || []);
+  setStatus(message || `Showing Toolbox vote totals for ${snapshot.currentUserName || "current session"}.`);
+}
+
+function updateOrder(voteRow, value) {
+  try {
+    const snapshot = updateToolboxVoteOrder(voteRow.toolId, Number(value));
+    renderSnapshot(snapshot, `${voteRow.toolName} order updated to ${Number(value)}.`);
+    selectRow(voteRow.toolId);
+  } catch (error) {
+    const message = error instanceof Error ? error.message : String(error || "Toolbox vote order unavailable.");
+    setStatus(`Toolbox vote order could not be updated. ${message}`);
+  }
 }
 
 function renderToolboxVotes() {
   if (window.GameFoundrySessionGuard?.blocked) {
     return;
   }
   try {
-    const snapshot = readToolboxVoteSnapshot();
-    renderRows(snapshot.rows || []);
-    setStatus(`Showing Toolbox vote totals for ${snapshot.currentUserName || "current session"}.`);
+    renderSnapshot(readToolboxVoteSnapshot());
   } catch (error) {
     const message = error instanceof Error ? error.message : String(error || "Toolbox votes unavailable.");
     renderRows([]);
@@ -60,4 +132,3 @@ function renderToolboxVotes() {
 }
 
 renderToolboxVotes();
-

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,13 +6,17 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(65%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 30/46
-(67%) src/engine/api/toolbox-votes-api-client.js - executed lines 19/19; executed functions 2/3
-(75%) toolbox/tools-page-accordions.js - executed lines 1067/1067; executed functions 78/104
-(93%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 13/14
+(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
+(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
+(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
+(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
 
 Guardrail warnings:
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,43 +12,51 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(80%) Toolbox Index - exercised 8 runtime JS files
+(68%) Toolbox Index - exercised 9 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
-(72%) Theme V2 Shared JS - exercised 2 runtime JS files
+(74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(65%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 30/46
-(67%) src/engine/api/toolbox-votes-api-client.js - executed lines 19/19; executed functions 2/3
-(75%) toolbox/tools-page-accordions.js - executed lines 1067/1067; executed functions 78/104
-(93%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 13/14
+(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
+(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
+(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
+(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
 
 Files with executed line/function counts where available:
 (38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
-(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
-(65%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 30/46
-(67%) src/engine/api/toolbox-votes-api-client.js - executed lines 19/19; executed functions 2/3
-(71%) toolbox/project-workspace/project-workspace.js - executed lines 264/264; executed functions 17/24
-(75%) toolbox/tools-page-accordions.js - executed lines 1067/1067; executed functions 78/104
-(78%) toolbox/game-configuration/game-configuration.js - executed lines 169/169; executed functions 14/18
-(91%) toolbox/game-design/game-design.js - executed lines 242/242; executed functions 20/22
-(93%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 13/14
-(96%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 26/27
-(100%) toolbox/game-configuration/game-configuration-api-client.js - executed lines 10/10; executed functions 2/2
-(100%) toolbox/game-design/game-design-api-client.js - executed lines 12/12; executed functions 2/2
+(55%) toolbox/colors/colors.js - executed lines 2147/2147; executed functions 114/206
+(55%) toolbox/project-journey/project-journey.js - executed lines 1003/1003; executed functions 54/99
+(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
+(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
+(71%) toolbox/assets/assets.js - executed lines 519/519; executed functions 42/59
+(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 547/547; executed functions 37/48
+(85%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 23/27
+(96%) toolbox/tools-page-accordions.js - executed lines 1033/1033; executed functions 108/113
+(100%) admin/tool-votes.js - executed lines 120/120; executed functions 16/16
+(100%) src/engine/api/toolbox-votes-api-client.js - executed lines 28/28; executed functions 4/4
+(100%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 3/3
+(100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
+(100%) toolbox/project-journey/project-journey-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
-(0%) admin/tool-votes.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/helpers/playwrightV8CoverageReporter.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ToolboxRoutePages.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) toolbox/toolRegistry.js - changed JS file not collected as browser runtime coverage
-(65%) assets/theme-v2/js/gamefoundry-partials.js - changed JS file with browser V8 coverage
-(67%) src/engine/api/toolbox-votes-api-client.js - changed JS file with browser V8 coverage
-(75%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
-(93%) assets/theme-v2/js/tool-display-mode.js - changed JS file with browser V8 coverage
+(77%) assets/theme-v2/js/gamefoundry-partials.js - changed JS file with browser V8 coverage
+(96%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
+(100%) admin/tool-votes.js - changed JS file with browser V8 coverage
+(100%) src/engine/api/toolbox-votes-api-client.js - changed JS file with browser V8 coverage

docs_build/dev/reports/toolbox-db-status-vote-restore-report.md

@@ -0,0 +1,67 @@
+# PR_26160_057 Toolbox DB Status Vote Restore Report
+
+## Branch Validation
+
+| Check | Result | Evidence |
+| --- | --- | --- |
+| Current branch is `main` | PASS | `git branch --show-current` returned `main`. |
+| Local branches reported | PASS | `git branch --list` returned only `* main`. |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Build Path reads tool Status from shared DB/tool registry data source | PASS | `toolbox/tools-page-accordions.js` now renders Build Path status from each tool release channel populated by the server-backed registry API client. |
+| Remove Build Path Complete column | PASS | `createBuildPathTable()` now renders `Order`, `Tool`, and `Status` only; Playwright asserts these headers. |
+| Build Path supports planned/wireframe/beta/complete filters | PASS | Shared release-channel filter controls are active in Build Path mode and filter Build Path rows. |
+| Default Build Path filter state shows only Complete active | PASS | `applyReleaseFilterDefaults("build-path")` sets only `complete`; Playwright asserts planned/wireframe/beta false and complete true after opening Build Path. |
+| Filter counts show Planned includes remaining planned tools | PASS | Counts now use all visible registry tools rather than role-filtered tiles; Playwright asserts `Planned (28)`, `Wireframe (4)`, `Beta (5)`, `Complete (1)`. |
+| Persist each user vote in shared DB-backed state | PASS | Added `toolbox_votes` shared table schema/seed plus server writes through `/api/toolbox/votes/cast`; Playwright verifies `/api/mock-db/snapshot` contains vote rows. |
+| Vote Up/Down counts show all users' votes | PASS | Server snapshot aggregates all rows in `toolbox_votes`; Playwright verifies two users voting Up produces `Up 2`, `Down 0`. |
+| Current user's selected vote is visually identified and can switch direction | PASS | Vote buttons retain `aria-pressed`; Playwright verifies restore and switching from Down to Up updates counts and pressed state. |
+| Add admin ability to change order number for each tool | PASS | Added `/api/toolbox/votes/order`, `updateToolboxVoteOrder()`, and editable order inputs on `admin/tool-votes.html`; Playwright edits Build Game order to `7`. |
+| Make selected Order, Group, and Path visible in admin vote viewer | PASS | `admin/tool-votes.html` shows selected detail pills; Playwright selects Build Game and verifies Order, Group, and Path. |
+| Preserve one-vote-per-user-per-tool behavior | PASS | Server stores one `toolbox_votes` row per `toolId` + `userKey`; changing direction mutates the existing row. |
+| No inline script/style/event handlers | PASS | Static `rg --pcre2` scan returned no matches for inline scripts, styles, or inline event handlers in touched HTML pages. |
+
+## Validation Performed
+
+| Lane | Command | Result |
+| --- | --- | --- |
+| Branch guard | `git branch --show-current`; `git branch --list` | PASS |
+| Changed-file syntax | `node --check` on changed JS/MJS files | PASS |
+| Static diff check | `git diff --check` | PASS |
+| Inline HTML guard | `rg --pcre2 -n "<script(?![^>]+src=)|<style[\\s>]|\\son(?:click|change|input|submit|keydown|keyup|load)=" toolbox/index.html admin/tool-votes.html` | PASS, no matches |
+| Targeted Toolbox/page Playwright | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --reporter=line` | PASS, 5 passed |
+| Playwright V8 coverage | Generated by `ToolboxRoutePages.spec.mjs` via `workspaceV2CoverageReporter` | PASS, report written to `docs_build/dev/reports/playwright_v8_coverage_report.txt` |
+
+## Impacted Lane
+
+Targeted Toolbox/page lane only: Toolbox index Build Path filters, Toolbox tile voting, admin Tool Votes viewer, and supporting server/API vote endpoints.
+
+## Artifacts
+
+- Codex review diff: `docs_build/dev/reports/codex_review.diff`
+- Changed files: `docs_build/dev/reports/codex_changed_files.txt`
+- V8 coverage: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Repo-structured ZIP: `tmp/PR_26160_057-toolbox-db-status-vote-restore_20260609_001_delta.zip`
+
+## Skipped Lanes
+
+| Lane | Decision | Reason |
+| --- | --- | --- |
+| Full samples validation | SKIPPED | Samples were not changed and no shared sample loader/framework was touched. |
+| Broad Project Workspace lane | SKIPPED | Project Workspace runtime files were not changed; Toolbox only reads existing registry/project summary context. |
+| Full app Playwright suite | SKIPPED | PR scope is targeted Toolbox/page behavior and the affected file was validated directly. |
+
+## Manual Test Notes
+
+1. Open `http://127.0.0.1:5501/toolbox/index.html`.
+2. Select `Build Path`; verify only Complete is active and the table has `Order`, `Tool`, `Status`.
+3. Vote on a planned or wireframe tile as User 1, navigate away/back, and verify the selected vote is restored.
+4. Switch to another user, vote the other direction, and verify aggregate counts include both users.
+5. Log in as DavidQ/Admin, open `admin/tool-votes.html`, select a row, and edit its Order value.
+
+## Coverage Notes
+
+V8 coverage reports browser-collected files. Server-side dev-runtime changes are listed as advisory warnings because they execute in Node behind the API boundary rather than Chromium coverage.