Skip to content

Commit b5d4e58

Browse files
committed
Clean up Toolbox cards status visibility and Game Configuration form layout - PR_26156_127-toolbox-card-and-status-cleanup
1 parent 9ebbf72 commit b5d4e58

15 files changed

Lines changed: 471 additions & 325 deletions
1.81 MB
Loading
2.19 MB
Loading
2.11 MB
Loading
2.27 MB
Loading
1.72 MB
Loading

docs_build/dev/codex_commands.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -859,3 +859,40 @@ Required reports:
859859
- `docs_build/dev/reports/testing_lane_execution_report.md`
860860
- `docs_build/dev/reports/codex_changed_files.txt`
861861
- `docs_build/dev/reports/codex_review.diff`
862+
863+
864+
## PR_26156_127
865+
866+
Changes:
867+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
868+
- Updated `toolbox/game-configuration/index.html` Playable Setup fields to use the reusable Theme V2 `table-wrapper`, `data-table`, and `tool-form-table` form table pattern.
869+
- Preserved Game Configuration field IDs, data hooks, form behavior, and submit behavior.
870+
- Set Game Configuration Playable Setup textareas to 4 rows.
871+
- Updated Toolbox card rendering in `toolbox/tools-page-accordions.js`.
872+
- Removed duplicate local Toolbox status ownership and enriched Toolbox cards from the active registry data used by Admin Tools Progress.
873+
- Updated normal role visibility so only Ready tools are visible outside Admin role.
874+
- Kept non-Ready tools visible in Admin role for planning/status review.
875+
- Converted Toolbox card bullet/list content to comma-separated bottom values.
876+
- Updated Toolbox tile action rows to one line with badge, Open Tool/Open Page link, brand color swatch, and status tag.
877+
- Updated targeted Playwright expectations for the changed Toolbox status/card rendering and Game Configuration table layout.
878+
- Did not add CSS.
879+
- Did not modify archived V1/V2 pages.
880+
- Did not modify `start_of_day`.
881+
882+
Validation:
883+
- `node --check toolbox/tools-page-accordions.js`
884+
- `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
885+
- `node --check tests/playwright/tools/ToolsProgressHydration.spec.mjs`
886+
- `node --check tests/playwright/tools/ToolNavigationPrevNext.spec.mjs`
887+
- `node --check tests/playwright/tools/GameConfigurationMockRepository.spec.mjs`
888+
- `node --check tests/playwright/tools/ProjectWorkspaceMockRepository.spec.mjs`
889+
- `node ./scripts/run-targeted-test-lanes.mjs --lane tool-runtime --lane tools-progress --lane game-configuration --lane tool-navigation`
890+
- `git diff --check`
891+
- Changed-file static validation for forbidden archive/start_of_day paths and inline style/script/event-handler additions.
892+
- Full samples smoke: skipped by request.
893+
894+
Required reports:
895+
- `docs_build/dev/reports/toolbox-card-and-status-cleanup-report.md`
896+
- `docs_build/dev/reports/testing_lane_execution_report.md`
897+
- `docs_build/dev/reports/codex_changed_files.txt`
898+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Consolidate Toolbox group color SSoT - PR_26156_126-tool-group-color-ssot-consolidation
1+
Clean up Toolbox cards and status visibility - PR_26156_127-toolbox-card-and-status-cleanup

docs_build/dev/reports/testing_lane_execution_report.md

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
# Testing Lane Execution Report
22

3-
Generated: 2026-06-05T14:21:16.547Z
3+
Generated: 2026-06-05T14:53:22.656Z
44
Dry run: No
55

66
## Summary
77

8-
PASS: 1
8+
PASS: 4
99
WARN: 0
1010
FAIL: 0
11-
SKIP: 13
12-
Total lane elapsed time: 81.90s
13-
Actual browser launches: 1
11+
SKIP: 10
12+
Total lane elapsed time: 136.67s
13+
Actual browser launches: 4
1414

1515
## Full Samples Smoke
1616

@@ -21,7 +21,7 @@ Reason: Skipped because changed files do not modify sample JSON or shared sample
2121

2222
Status: PASS
2323
Reason: Runner preflight and Playwright structure audit passed before expensive lane execution.
24-
Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes tool-runtime --targets tests/playwright/tools/RootToolsFutureState.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
24+
Command: C:\nvm4w\nodejs\node.exe scripts/audit-playwright-test-locations.mjs --discovery-report docs_build/dev/reports/playwright_discovery_ownership_report.md --scope-report docs_build/dev/reports/playwright_discovery_scope_report.md --scan-report docs_build/dev/reports/filesystem_scan_reduction_report.md --lanes tool-runtime,tools-progress,game-configuration,tool-navigation --targets tests/playwright/tools/GameConfigurationMockRepository.spec.mjs,tests/playwright/tools/RootToolsFutureState.spec.mjs,tests/playwright/tools/ToolNavigationPrevNext.spec.mjs,tests/playwright/tools/ToolsProgressHydration.spec.mjs --helpers tests/helpers/playwrightRepoServer.mjs,tests/helpers/playwrightStorageIsolation.mjs,tests/helpers/playwrightV8CoverageReporter.mjs,tests/helpers/workspaceV2CoverageReporter.mjs
2525
Details: none
2626

2727
## Dependency Gate
@@ -32,15 +32,15 @@ Reason: No deterministic dependency failures before runtime.
3232
## Runtime Scheduling
3333

3434
Status: PASS
35-
Scheduled lane order: tool-runtime
36-
Reused runtime sessions: 0
37-
Reused lane snapshots: 0
38-
Reused warm-start lanes: 0
39-
Reused dependency hydration: 0
40-
Prevented graph rebuilds: 0
41-
Prevented redundant initialization: 0
35+
Scheduled lane order: game-configuration, tools-progress, tool-navigation, tool-runtime
36+
Reused runtime sessions: 1
37+
Reused lane snapshots: 3
38+
Reused warm-start lanes: 3
39+
Reused dependency hydration: 3
40+
Prevented graph rebuilds: 3
41+
Prevented redundant initialization: 3
4242
Prevented redundant browser launches: 0
43-
Prevented redundant lane execution: 13
43+
Prevented redundant lane execution: 10
4444

4545
## Validation Cache
4646

@@ -61,7 +61,7 @@ Prevented broad lane escalation: 0
6161
## Discovery Scope
6262

6363
Status: PASS
64-
Target files: tests/playwright/tools/RootToolsFutureState.spec.mjs
64+
Target files: tests/playwright/tools/GameConfigurationMockRepository.spec.mjs, tests/playwright/tools/RootToolsFutureState.spec.mjs, tests/playwright/tools/ToolNavigationPrevNext.spec.mjs, tests/playwright/tools/ToolsProgressHydration.spec.mjs
6565
Required shared helpers: tests/helpers/playwrightRepoServer.mjs, tests/helpers/playwrightStorageIsolation.mjs, tests/helpers/playwrightV8CoverageReporter.mjs, tests/helpers/workspaceV2CoverageReporter.mjs
6666
Required fixtures: none
6767
Targeted file/helper reads: 5
@@ -71,29 +71,29 @@ Prevented fallback expansion: Yes; no ownership or scope blocker widened into br
7171
## Targeted File Manifests
7272

7373
Status: PASS
74-
Generated manifests: tool-runtime:PASS
74+
Generated manifests: tool-runtime:PASS, tools-progress:PASS, game-configuration:PASS, tool-navigation:PASS
7575
Prevented discovery expansion: Yes
76-
Prevented redundant scans: 4
77-
Persistent manifest events: tool-runtime:INVALIDATED
76+
Prevented redundant scans: 1
77+
Persistent manifest events: tool-runtime:REUSED, tools-progress:REUSED, game-configuration:REUSED, tool-navigation:INVALIDATED
7878

7979
## Warm-Start Reuse
8080

8181
Status: PASS
82-
Warm-start events: tool-runtime:INVALIDATED
83-
Dependency hydration events: tool-runtime:INVALIDATED
84-
Prevented redundant initialization: 0
85-
Prevented helper resolution passes: 0
82+
Warm-start events: tool-runtime:REUSED, tools-progress:REUSED, game-configuration:REUSED, tool-navigation:INVALIDATED
83+
Dependency hydration events: tool-runtime:REUSED, tools-progress:REUSED, game-configuration:REUSED, tool-navigation:INVALIDATED
84+
Prevented redundant initialization: 3
85+
Prevented helper resolution passes: 12
8686
Prevented fixture ownership traversal: 0
8787

8888
## Lane Snapshots
8989

9090
Status: PASS
91-
Snapshot events: tool-runtime:INVALIDATED
92-
Reused snapshots: 0
91+
Snapshot events: tool-runtime:REUSED, tools-progress:REUSED, game-configuration:REUSED, tool-navigation:INVALIDATED
92+
Reused snapshots: 3
9393
Invalidated snapshots: 1
94-
Prevented graph rebuilds: 0
95-
Prevented redundant dependency traversal: 0
96-
Prevented fixture/helper graph assembly: 0
94+
Prevented graph rebuilds: 3
95+
Prevented redundant dependency traversal: 3
96+
Prevented fixture/helper graph assembly: 12
9797

9898
## Lane Deduplication
9999

@@ -108,13 +108,13 @@ Prevented Workspace lane reruns: 0
108108
| workspace-contract | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Root tools future-state navigation and Tool Template V2 contract | repo-served root tools page; Tool Template V2 future-state page; Theme V2 shared partials and assets |
109109
| project-workspace | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Project Workspace mock repository, Project Workspace UI, and Toolbox Progress/Build Path project-state bridge | repo-served Project Workspace page; repo-served Toolbox page with role simulation; in-memory SQL-shaped mock project repository |
110110
| game-design | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Design mock repository, project purpose flow, validation overlay, capability demo authoring, and Toolbox progress handoff | repo-served Game Design page; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Design mock repository; Project Workspace mock project context |
111-
| game-configuration | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | repo-served Game Configuration page; repo-served Game Design page for handoff checks; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Configuration mock repository; Game Design mock repository handoff |
111+
| game-configuration | PASS | 41.82s | 1 | Game Configuration rebuild slice validates the valid Game Design handoff, blocked invalid handoffs, configuration save/update, actionable validation, user-facing output, and Toolbox progress handoff without exercising unrelated toolbox routes. | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | repo-served Game Configuration page; repo-served Game Design page for handoff checks; repo-served Toolbox Progress and Build Path views; in-memory SQL-shaped Game Configuration mock repository; Game Design mock repository handoff |
112112
| build-path | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | repo-served Toolbox page; repo-served Admin Tools Progress page; Project Workspace mock project context; Toolbox role simulation |
113-
| tools-progress | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | repo-served Admin Tools Progress page; repo-served Toolbox Group view; Toolbox registry build sequence; Project Build Path workflow table |
114-
| tool-navigation | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | repo-served Admin Tools Progress page; repo-served Project Workspace, Game Design, and Game Configuration tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata |
113+
| tools-progress | PASS | 18.23s | 1 | Tools Progress validates that Admin platform progress hydrates every planned/active Toolbox registry entry in build order, the restored semantic group colors render in Toolbox Group view, and Project Build Path stays workflow-order and project-specific. | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | repo-served Admin Tools Progress page; repo-served Toolbox Group view; Toolbox registry build sequence; Project Build Path workflow table |
114+
| tool-navigation | PASS | 28.57s | 1 | Tool navigation validates registry-owned tool routes, disabled rendering for route-less tools, build-order previous/next controls, multi-path fallback to Toolbox Group view, and role query preservation without exercising unrelated toolbox routes. | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | repo-served Admin Tools Progress page; repo-served Project Workspace, Game Design, and Game Configuration tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata |
115115
| tool-display-mode | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | repo-served Project Workspace, Game Design, Game Configuration, and AI Assistant tool pages; repo-served Toolbox Group view with URL-selected accordion; Toolbox registry build sequence and route metadata; shared Theme V2 Tool Display Mode script |
116116
| tool-images | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | Toolbox registry badge/tool image contract; repo-served Toolbox page; repo-served representative Toolbox tool pages; shared registry image fallback |
117-
| tool-runtime | PASS | 81.90s | 1 | Tool runtime lane now validates the active public toolbox/template surface and excludes removed V2 tool routes. | Active public toolbox and Tool Template V2 contract | repo-served root toolbox page; Tool Template V2 public page; Theme V2 shared partials and assets |
117+
| tool-runtime | PASS | 48.06s | 1 | Tool runtime lane now validates the active public toolbox/template surface and excludes removed V2 tool routes. | Active public toolbox and Tool Template V2 contract | repo-served root toolbox page; Tool Template V2 public page; Theme V2 shared partials and assets |
118118
| game-runtime | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Deprecated archive/v1-v2/games reference coverage | |
119119
| integration | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | Integration handoff behavior | No active integration Playwright specs after removal of stale V2 tool and removed game manifest routes. |
120120
| engine-src | SKIP | 0ms | 0 | Lane was not selected for this targeted run. | src/ engine and shared runtime capability behavior | explicit node unit fixtures; fresh in-memory localStorage/sessionStorage mocks per file |
@@ -124,11 +124,11 @@ Prevented Workspace lane reruns: 0
124124

125125
| Lane | Duration | Test |
126126
| --- | --- | --- |
127-
| tool-runtime | 38.50s | tests\playwright\tools\RootToolsFutureState.spec.mjs:508:1 > active tool pages align center cleanup and registry group colors |
128-
| tool-runtime | 14.00s | tests\playwright\tools\RootToolsFutureState.spec.mjs:69:1 > root tools surface links current tool pages without old_* routes |
129-
| tool-runtime | 9.20s | tests\playwright\tools\RootToolsFutureState.spec.mjs:408:1 > learn wireframe pages load with shared Theme V2 structure |
130-
| tool-runtime | 8.00s | tests\playwright\tools\RootToolsFutureState.spec.mjs:323:1 > common header renders primary navigation order across active pages |
131-
| tool-runtime | 1.20s | tests\playwright\tools\RootToolsFutureState.spec.mjs:486:1 > tool template future-state page loads from root Theme V2 paths |
127+
| tool-runtime | 10.10s | tests\playwright\tools\RootToolsFutureState.spec.mjs:517:1 > representative active tool pages align center cleanup and registry group colors |
128+
| tool-runtime | 9.50s | tests\playwright\tools\RootToolsFutureState.spec.mjs:69:1 > root tools surface links current tool pages without old_* routes |
129+
| tool-runtime | 9.20s | tests\playwright\tools\RootToolsFutureState.spec.mjs:417:1 > learn wireframe pages load with shared Theme V2 structure |
130+
| tool-runtime | 7.70s | tests\playwright\tools\RootToolsFutureState.spec.mjs:332:1 > common header renders primary navigation order across active pages |
131+
| tool-navigation | 7.50s | tests\playwright\tools\ToolNavigationPrevNext.spec.mjs:101:1 > Toolbox card names link to registered tool routes without duplicating launch actions |
132132

133133
## Commands
134134

@@ -142,16 +142,16 @@ Prevented Workspace lane reruns: 0
142142
- SKIP
143143

144144
### game-configuration
145-
- SKIP
145+
- PASS 41.82s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/GameConfigurationMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list
146146

147147
### build-path
148148
- SKIP
149149

150150
### tools-progress
151-
- SKIP
151+
- PASS 18.23s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolsProgressHydration.spec.mjs --project=playwright --workers=1 --reporter=list
152152

153153
### tool-navigation
154-
- SKIP
154+
- PASS 28.57s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs --project=playwright --workers=1 --reporter=list
155155

156156
### tool-display-mode
157157
- SKIP
@@ -160,7 +160,7 @@ Prevented Workspace lane reruns: 0
160160
- SKIP
161161

162162
### tool-runtime
163-
- PASS 81.89s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/RootToolsFutureState.spec.mjs --project=playwright --workers=1 --reporter=list
163+
- PASS 48.06s C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/RootToolsFutureState.spec.mjs --project=playwright --workers=1 --reporter=list
164164

165165
### game-runtime
166166
- SKIP

0 commit comments

Comments
 (0)