Keep MIDI Studio V2 Tempo Key Style in Song Details and make Song Sheet structure-only - PR_26146_062-midi-studio-v2-song-sheet-structure-only

Author: ToolboxAid

docs/dev/reports/PR_26146_062-midi-studio-v2-song-sheet-ssot-map.md

@@ -0,0 +1,37 @@
+# PR_26146_062 MIDI Studio V2 Song Sheet SSoT Map
+
+## Editable Owners
+
+| Value | Owning tab/bucket | Editable control | Canonical path |
+| --- | --- | --- | --- |
+| Tempo/BPM | Song Setup > Song Details | `#songSheetTempoInput` | `studioArrangement.tempo` |
+| Key | Song Setup > Song Details | `#songSheetKeyInput` | `studioArrangement.key` |
+| Style | Song Setup > Song Details | `#songSheetStyleInput` | `studioArrangement.style` |
+| Song Sheet sections | Song Setup > Song Sheet | `#songSheetSectionsInput` | `studioArrangement.songSheet.sections` |
+| Song Sheet loop sections | Song Setup > Song Sheet | `#songSheetLoopSectionsInput` | `studioArrangement.songSheet.loopSections` |
+
+## Derived Read-Only Values
+
+| Value | Display location | Source |
+| --- | --- | --- |
+| Bars | Song Setup > Song Sheet summary | Parsed Song Sheet sections |
+| Chord count | Song Setup > Song Sheet summary | Parsed Song Sheet sections |
+| Estimated duration | Song Setup > Song Sheet summary | Parsed bars and Song Details tempo |
+| Warnings | Song Setup > Song Sheet summary | Song Sheet parser diagnostics |
+| Grid sections | Auto-Create Parts read-only mirror | `studioArrangement.sections`, refreshed from Song Sheet parse |
+| JSON Details | Diagnostics read-only display | Selected canonical song model |
+
+## Refresh Flow
+
+1. Editing Sections or Loop sections writes to `studioArrangement.songSheet`.
+2. The Song Sheet parser composes source text from Song Details metadata plus Song Sheet structure fields.
+3. Parsed sections refresh computed Bars, Chord count, Estimated duration, Loop sections, and Warnings.
+4. Parsed playable sections rebuild the Octave Timeline arrangement and generated lane data.
+5. The selected song JSON Details and diagnostics are refreshed from the canonical song model.
+
+## Non-Owners
+
+- Song Sheet does not own editable Tempo, Key, or Style.
+- Song Details does not own editable Song Sheet structure.
+- Auto-Create Parts does not own editable Song Sheet sections; its grid sections field is read-only.
+- Instruments, MIDI Import, Diagnostics, and Export do not own editable Song Sheet structure values.

docs/dev/reports/PR_26146_062-midi-studio-v2-song-sheet-structure-only_validation.md

@@ -0,0 +1,48 @@
+# PR_26146_062 MIDI Studio V2 Song Sheet Structure Only Validation
+
+Status: PASS
+
+## Scope Validated
+
+- Removed editable Tempo, Key, and Style from Song Setup > Song Sheet.
+- Preserved Song Details as the editable owner for Tempo/BPM, Key, and Style.
+- Changed Song Sheet to own only structure fields: Sections and Loop sections.
+- Kept Bars, Chord count, Estimated duration, and Warnings as computed/read-only or diagnostic summary rows.
+- Made the Auto-Create Parts grid sections field a read-only mirror of the canonical Song Sheet arrangement sections.
+- Edits to Sections and Loop sections update the selected song canonical model, refresh the Octave Timeline arrangement, refresh derived summary rows, update diagnostics, and update JSON Details.
+- Preserved Instruments tab SSoT, selected instrument sync, canvas note editing, Play/Stop, manifest import, multiple songs, Export ownership, and red unwired controls.
+
+## Validation Commands
+
+```powershell
+node --check tools/midi-studio-v2/js/controls/SongSheetControl.js
+node --check tools/midi-studio-v2/js/controls/SongDetailsControl.js
+node --check tools/midi-studio-v2/js/MidiStudioV2App.js
+node --check tools/midi-studio-v2/js/bootstrap.js
+node --check tools/midi-studio-v2/js/services/MidiStudioStateSerializer.js
+node --check tests/playwright/tools/MidiStudioV2.spec.mjs
+rg --pcre2 -n '<style\b|<script\b(?![^>]*\bsrc=)|\son[a-z]+\s=|style\s=' tools/midi-studio-v2/index.html; if ($LASTEXITCODE -eq 1) { exit 0 } else { exit $LASTEXITCODE }
+npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs --project=playwright -g 'keeps PR062'
+npx playwright test tests/playwright/tools/MidiStudioV2.spec.mjs --project=playwright -g 'keeps PR062|parses guided Song Sheet|shows guided Song Sheet warnings|rejects invalid guided Song Sheet|consolidates existing tab buckets|canvas note editing flow|syncs PR060|builds PR061|keeps Export tab usable'
+git diff --check
+```
+
+## Results
+
+- JS syntax checks: PASS.
+- Inline script/style/event handler guard: PASS, no matches.
+- PR062 focused Playwright test: PASS, 1 passed.
+- Targeted MIDI Studio V2 Playwright set: PASS, 9 passed.
+- `git diff --check`: PASS. Git reported line-ending normalization warnings only.
+- Full samples smoke test: not run, per PR instruction.
+
+## Playwright Proof Points
+
+- Tempo, Key, and Style remain editable in Song Details.
+- Tempo, Key, and Style are absent as editable Song Sheet fields.
+- Song Sheet exposes Sections and Loop sections as editable structured text fields.
+- Bars, Chord count, and Estimated duration are marked computed/read-only.
+- Warnings are marked read-only diagnostics.
+- Section edits update `studioArrangement.songSheet`, `studioArrangement.sections`, generated chord lane data, JSON Details, and the Octave Timeline section model.
+- Duplicate editable Song Sheet structure controls are absent from other tabs; the Auto-Create grid sections field is read-only.
+- Play and Stop still work after Song Sheet structure edits.