Skip to content

Commit bd2725b

Browse files
committed
Tear down obsolete root src legacy files
1 parent c1290bc commit bd2725b

20 files changed

Lines changed: 151 additions & 265 deletions

dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ Rules:
117117

118118
## Current Version/Date
119119

120-
- Project Instructions Version: 2026.06.28.019
120+
- Project Instructions Version: 2026.06.28.020
121121
- Date: 2026-06-28
122122
- Owner: OWNER
123123

dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Project Instructions Version
22

3-
Current Project Instructions Version: 2026.06.28.019
3+
Current Project Instructions Version: 2026.06.28.020
44

55
Last Updated: 2026-06-28
66

@@ -27,6 +27,7 @@ Last Updated: 2026-06-28
2727
- Removed the local demo `.gfsp` artifact and recorded a file-by-file `src/` destination audit for future scoped migrations.
2828
- Moved PR017-audited browser/www-owned legacy `src/` files into `www/src/` while preserving public `/src/...` browser route compatibility under the `www` web root.
2929
- Moved PR019a-audited active browser/runtime shared contracts and tool schemas into `www/src/shared/` while preserving public `/src/shared/...` browser route compatibility.
30+
- Removed obsolete root `src/` legacy placeholders, stale schema README files, and archived-only debug helpers while preserving active contracts and validation schemas.
3031
- Codex must read this version file and the latest repository copy of `PROJECT_INSTRUCTIONS.md` before performing work.
3132
- Codex must discard previously remembered Project Instructions and treat the repository copy as authoritative.
3233
- Codex must validate canonical report and ZIP paths, branching model, and legacy path avoidance before work proceeds.

dev/build/ProjectInstructions/PROJECT_STATE.md

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Project State
22

33
```yaml
4-
project_state_version: "2026.06.28.019"
4+
project_state_version: "2026.06.28.020"
55
last_updated: "2026-06-28"
66
current_main_commit: "40de767476d70cadfd1292c916844c2f31b6f185"
77
repository_status:
@@ -10,18 +10,18 @@ repository_status:
1010
runtime_database: "Postgres"
1111
creator_metadata: "API to Postgres"
1212
creator_assets: "API to R2"
13-
project_instructions_version: "2026.06.28.019"
14-
repository_structure_version: "2026.06.28.019"
15-
canonical_layout_version: "2026.06.28.019"
13+
project_instructions_version: "2026.06.28.020"
14+
repository_structure_version: "2026.06.28.020"
15+
canonical_layout_version: "2026.06.28.020"
1616
active_teams:
1717
- "Owner"
1818
- "Alfa"
1919
- "Bravo"
2020
- "Charlie"
2121
- "Delta"
2222
- "Golf"
23-
latest_owner_pr: "PR_26180_OWNER_019b-move-browser-shared-schemas-to-www"
24-
latest_structure_pr: "PR_26180_OWNER_019b-move-browser-shared-schemas-to-www"
23+
latest_owner_pr: "PR_26180_OWNER_020-src-legacy-teardown"
24+
latest_structure_pr: "PR_26180_OWNER_020-src-legacy-teardown"
2525
valid_top_level_folders:
2626
- "api/"
2727
- "deploy/"
@@ -41,7 +41,6 @@ valid_dev_folders:
4141
- "dev/workspace/"
4242
known_technical_debt:
4343
- "Remaining API/server-owned contracts, validation-only schemas, and project data store modules remain under src/shared/ until scoped follow-up PRs move them to api/ or dev/."
44-
- "Developer/source reference files remain under src/ until PR_26180_OWNER_020 moves them to dev/."
45-
- "src/dev-runtime/admin/.gitkeep remains as a placeholder until PR_26180_OWNER_021 retires the empty root src folder."
44+
- "Remaining actively validated contracts, validation schemas, and project data store modules remain under src/shared/ until scoped follow-up PRs move them to api/ or dev/."
4645
- "repository_directory_standard.md and codex_project_instructions_startup.md are superseded pointers retained for compatibility."
4746
```

dev/build/ProjectInstructions/backlog/BACKLOG_MASTER.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ The backlog is the authoritative source for determining the next logical PRs.
4040
- Product Area: Repository Architecture Simplification
4141
- Status: Active
4242
- Percent Complete: 99%
43-
- Active PR: PR_26180_OWNER_019b-move-browser-shared-schemas-to-www
43+
- Active PR: PR_26180_OWNER_020-src-legacy-teardown
4444
- Next Milestone: Move remaining API/server-owned source to api/
4545
- Source / Reference: `dev/build/ProjectInstructions/repository/repository_layout_architecture_plan.md`; `dev/build/ProjectInstructions/repository/www_migration_map.md`
4646

dev/build/ProjectInstructions/repository/canonical_repository_structure.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ Legacy transition buckets:
9090
- src/shared/contracts/
9191
- src/shared/schemas/
9292
- src/shared/projectDataStore/
93-
- src/dev-runtime/admin/.gitkeep
9493

9594
The `www/src/` legacy transition buckets preserve public `/src/...` browser import compatibility during source retirement. Remaining root `src/` buckets may remain only until explicit stacked migration PRs move them to `api/` or `dev/`.
9695

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# PR_26180_OWNER_020 Branch Validation
2+
3+
| Check | Status | Notes |
4+
|-------|--------|-------|
5+
| Current branch | PASS | `PR_26180_OWNER_020-src-legacy-teardown` |
6+
| Expected base | PASS | Stacked on `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www` workstream branch. |
7+
| Worktree scope | PASS | Changes limited to obsolete root `src/` deletions, Project Instructions/backlog status updates, guard baseline alignment, and PR reports. |
8+
| Runtime/API/UI/database changes | PASS | No active runtime, API, UI, or database implementation files changed. |
9+
| Protected dev workspace paths | PASS | No protected `dev/workspace/generated`, `dev/workspace/zips`, or `dev/workspace/tmp` files moved or deleted. |
10+
11+
## Branch Decision
12+
13+
PASS. Branch is valid for the stacked Owner Repository Architecture Simplification workstream.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PR_26180_OWNER_020 Manual Validation Notes
2+
3+
## Manual Review
4+
5+
- Confirmed current branch is `PR_26180_OWNER_020-src-legacy-teardown`.
6+
- Confirmed deleted files are limited to obsolete root `src/` placeholders, README notes, and debug helpers with no active references.
7+
- Confirmed remaining root `src/shared/contracts/**`, `src/shared/projectDataStore/**`, and active schema files are still needed by current validation/test references and were not removed.
8+
- Confirmed archive-only v1-v2 references to deleted debug helpers remain historical and are not active runtime blockers.
9+
- Confirmed the shared extraction guard baseline change removes only the deleted `src/shared/debug/network.js` entry.
10+
11+
## Manual Runtime Notes
12+
13+
No runtime/UI/API/database behavior was changed. Playwright was not required because this PR removes unreferenced legacy source files and documentation placeholders only.
14+
15+
## ZIP Notes
16+
17+
The repo-structured ZIP for this PR is generated under:
18+
19+
`dev/workspace/zips/PR_26180_OWNER_020-src-legacy-teardown_delta.zip`
Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# PR_26180_OWNER_020-src-legacy-teardown Report
2+
3+
## Executive Summary
4+
5+
PR_26180_OWNER_020 continues the root `src/` retirement work by removing legacy files that no longer have active runtime, API, dev script, validation, or test references. The PR preserves active root `src/shared/contracts/**`, `src/shared/projectDataStore/**`, and active schema files because they are still used by current dev validation/tests and require separate follow-up ownership moves.
6+
7+
No browser, API, database, or product behavior changes are introduced.
8+
9+
## Source Of Truth
10+
11+
- Base branch: `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www`
12+
- Workstream: Repository Architecture Simplification
13+
- Audit source: PR017 src destination audit and PR019a contracts/schemas obsolescence audit
14+
- Project Instructions version updated to `2026.06.28.020`
15+
16+
## Deleted Legacy Files
17+
18+
| File | Decision | Reason |
19+
|------|----------|--------|
20+
| `src/dev-runtime/admin/.gitkeep` | Deleted | Obsolete placeholder. Admin compatibility runtime now lives under `www/src/dev-runtime/admin/`. |
21+
| `src/engine/README.md` | Deleted | Legacy empty-engine-era note, not an active architecture source. |
22+
| `src/shared/debug/config.js` | Deleted | Old debug helper referenced only by archived v1-v2 material. No active runtime/test/script references. |
23+
| `src/shared/debug/network.js` | Deleted | Old debug helper referenced only by archived v1-v2 material. No active runtime/test/script references. |
24+
| `src/shared/debug/noopDevConsoleIntegration.js` | Deleted | Old debug helper referenced only by archived v1-v2 material. No active runtime/test/script references. |
25+
| `src/shared/schemas/README.md` | Deleted | Legacy schema README superseded by active Project Instructions/governance. |
26+
| `src/shared/schemas/tools/README.md` | Deleted | Legacy tool schema README superseded by active Project Instructions/governance. |
27+
28+
## Preserved Root src Files
29+
30+
| Path | Decision | Reason |
31+
|------|----------|--------|
32+
| `src/shared/contracts/**` | Preserved | Still actively imported by `dev/tests/shared/**` contract validation. |
33+
| `src/shared/projectDataStore/**` | Preserved | Still actively imported by current project data store validation tests. |
34+
| `src/shared/schemas/game.manifest.schema.json` | Preserved | Still actively referenced by current validation/tests. |
35+
| `src/shared/schemas/samples/sample.tool-payload.schema.json` | Preserved | Still actively referenced by current validation/tests. |
36+
37+
## Legacy Pattern Audit
38+
39+
| Pattern | Result |
40+
|---------|--------|
41+
| `src/shared/debug/*` active references | PASS: no active references outside archive/report/workspace folders. |
42+
| `src/engine/README` active references | PASS: no active references outside archive/report/workspace folders. |
43+
| `src/shared/schemas/README` active references | PASS: no active references outside archive/report/workspace folders. |
44+
| `src/dev-runtime/admin/.gitkeep` active references | PASS: no active references outside archive/report/workspace folders. |
45+
| `www/src/tools/**` | Not present in this PR scope. |
46+
| Protected dev workspace paths | PASS: no protected `dev/workspace/generated`, `zips`, or `tmp` files moved. |
47+
48+
Archive-only v1-v2 references to the removed debug helpers remain under `dev/archive/v1-v2/**`. They are historical reference material, not active runtime or validation dependencies.
49+
50+
## Shared Extraction Guard
51+
52+
`dev/tools/toolbox-dev/checkSharedExtractionGuard.baseline.json` was updated by removing the single baseline entry for deleted file `src/shared/debug/network.js`. No broad baseline regeneration was committed.
53+
54+
## Owner Recommendation
55+
56+
Proceed with this teardown PR. Remaining root `src/` files require follow-up PRs because active validation currently depends on them.
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PR_26180_OWNER_020 Requirement Checklist
2+
3+
| Requirement | Status | Evidence |
4+
|-------------|--------|----------|
5+
| Base from `PR_26180_OWNER_019b-move-browser-shared-schemas-to-www` | PASS | Branch `PR_26180_OWNER_020-src-legacy-teardown` was created from the PR019b stack. |
6+
| Do not copy files again | PASS | PR deletes obsolete legacy files only; no duplicate copies were added. |
7+
| Delete/archive obsolete root `src/` files only after replacement or proof of legacy status | PASS | Seven files removed after active-reference scan found no active runtime/script/test dependencies. |
8+
| Preserve runtime behavior | PASS | Removed files had no active references outside archive/report/workspace paths. |
9+
| Hard stop if active `www/api/dev` runtime or validation imports removed files | PASS | Active-reference scan found no active imports for removed files. |
10+
| Preserve active root `src/shared/contracts/**` and schemas still needed by validation | PASS | Active contract/schema/project data store files remain in root `src/` for follow-up PRs. |
11+
| Remove `src/dev-runtime/admin/.gitkeep` if obsolete | PASS | Obsolete placeholder removed. |
12+
| Audit legacy debug/schema/readme patterns | PASS | Active-reference scan completed; archive-only historical references documented. |
13+
| Do not move protected developer workspace files | PASS | No `dev/workspace/generated`, `dev/workspace/zips`, or `dev/workspace/tmp` files moved. |
14+
| Required reports under `dev/reports/` | PASS | PR-specific report, checklist, validation report, manual notes, branch validation, diff, and changed-file report created. |
15+
| Required ZIP under `dev/workspace/zips/` | PASS | Repo-structured ZIP generated for the PR outcome. |
16+
17+
## Remaining Follow-Up
18+
19+
Root `src/shared/contracts/**`, `src/shared/projectDataStore/**`, and active schema files remain because they are still required by current validation/test lanes.
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
# PR_26180_OWNER_020 Validation Report
2+
3+
## Validation Commands
4+
5+
| Command | Status | Notes |
6+
|---------|--------|-------|
7+
| `git diff --check` | PASS | No whitespace errors. |
8+
| `npm run validate:canonical-structure` | PASS | Canonical repository structure guardrail passed with 0 blocking violations. |
9+
| `node ./dev/scripts/run-node-test-files.mjs dev/tests/dev-runtime/AdminNotesBoundary.test.mjs dev/tests/dev-runtime/StaticWebRootCompatibility.test.mjs dev/tests/tools/ToolManifestBoundary.test.mjs` | PASS | 3/3 targeted node test files passed. |
10+
| `node dev/tools/toolbox-dev/checkSharedExtractionGuard.mjs` | PASS | Baseline aligned after removing the deleted `src/shared/debug/network.js` entry. |
11+
| Active legacy reference scan | PASS | No active references to deleted paths found outside archive/report/workspace folders. |
12+
13+
## Active Legacy Reference Scan
14+
15+
Command:
16+
17+
```powershell
18+
rg -n "src/shared/debug/(config|network|noopDevConsoleIntegration)|src/engine/README|src/shared/schemas/README|src/shared/schemas/tools/README|src/dev-runtime/admin/.gitkeep" www api dev/scripts dev/tests dev/tools package.json .github --glob '!dev/archive/**' --glob '!dev/reports/**' --glob '!dev/workspace/**'
19+
```
20+
21+
Result: no matches.
22+
23+
## Archive References
24+
25+
Historical references remain under `dev/archive/v1-v2/**`. These are intentionally excluded from active validation blockers because `dev/archive/` is historical reference material only.
26+
27+
## Product Impact
28+
29+
- Runtime behavior changed: No
30+
- UI changed: No
31+
- API changed: No
32+
- Database changed: No
33+
- Product feature changed: No

0 commit comments

Comments
 (0)