Skip to content

Commit c15c5b2

Browse files
committed
Add creator-friendly Game Journey descriptions with placeholder progress values - PR_26170_013-game-journey-friendly-descriptions
1 parent 4f94692 commit c15c5b2

8 files changed

Lines changed: 31762 additions & 30895 deletions
Lines changed: 131 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,131 @@
1+
# PR_26170_013-game-journey-friendly-descriptions Report
2+
3+
## Branch Validation
4+
5+
PASS
6+
7+
- Current branch: `main`
8+
- Expected branch: `main`
9+
- Command: `git branch --show-current`
10+
11+
## Requirement Checklist
12+
13+
PASS - Update Game Journey accordion labels to creator-friendly descriptions.
14+
15+
- `toolbox/tools-page-accordions.js` now renders the grouped Toolbox accordion summaries with:
16+
- `xxx% - Idea: Dream, brainstorm, and explore`
17+
- `xxx% - Create: Set up your game and crew`
18+
- `xxx% - Design: Shape the player experience`
19+
- `xxx% - Graphics: Create the look of your game`
20+
- `xxx% - Audio: Bring your world to life with sound`
21+
- `xxx% - Objects: Build things players can interact with`
22+
- `xxx% - Worlds: Design places to explore`
23+
- `xxx% - Interface: Create what players see and use`
24+
- `xxx% - Controls: Define how players play`
25+
- `xxx% - Rules: Make your game come alive`
26+
- `xxx% - Progression: Reward players and keep them engaged`
27+
- `xxx% - Play Test: See how your game feels`
28+
- `xxx% - Publish: Prepare your game for launch`
29+
- `xxx% - Share: Grow your community`
30+
31+
PASS - Use literal `xxx%` for now.
32+
33+
- Playwright asserts every accordion label starts with `xxx% - `.
34+
- No completion percentage calculation was introduced.
35+
36+
PASS - Do not calculate completion or introduce progress logic.
37+
38+
- The change is a static label map only.
39+
- No progress math, progress state, storage, API, or runtime logic was added.
40+
41+
PASS - Do not introduce status text such as `Complete`, `In Progress`, or `Not Started`.
42+
43+
- Static source check found no matches for those status strings in `toolbox/tools-page-accordions.js`.
44+
- Playwright asserts the rendered accordion labels do not contain those status strings.
45+
46+
PASS - Single-line accordion entries only.
47+
48+
- All configured labels are single-line string literals.
49+
- Playwright asserts rendered accordion labels contain no newline characters.
50+
51+
PASS - Preserve current workflow ordering.
52+
53+
- Existing `gameJourneyGroupOrder` remains unchanged.
54+
- Playwright asserts the rendered accordion order matches `GAME_JOURNEY_GROUP_ORDER`.
55+
56+
PASS - Preserve current accordion behavior.
57+
58+
- Existing `<details>` accordion rendering and open-target behavior were not changed.
59+
- Canonical `data-toolbox-group-label` values remain group names for color/order assertions; only the visible summary text changed.
60+
61+
## Validation Lane Report
62+
63+
Impacted lane: targeted Toolbox grouped Game Journey accordion rendering.
64+
65+
Commands run:
66+
67+
```powershell
68+
node --check toolbox/tools-page-accordions.js
69+
node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs
70+
rg -n "xxx% - (Idea: Dream, brainstorm, and explore|Create: Set up your game and crew|Design: Shape the player experience|Graphics: Create the look of your game|Audio: Bring your world to life with sound|Objects: Build things players can interact with|Worlds: Design places to explore|Interface: Create what players see and use|Controls: Define how players play|Rules: Make your game come alive|Progression: Reward players and keep them engaged|Play Test: See how your game feels|Publish: Prepare your game for launch|Share: Grow your community)" toolbox/tools-page-accordions.js tests/playwright/tools/ToolboxRoutePages.spec.mjs
71+
rg -n "Complete|In Progress|Not Started" toolbox/tools-page-accordions.js
72+
git diff --check -- toolbox/tools-page-accordions.js tests/playwright/tools/ToolboxRoutePages.spec.mjs docs_build/pr/BUILD_PR_26170_013-game-journey-friendly-descriptions.md
73+
```
74+
75+
Results:
76+
77+
- PASS - JavaScript syntax checks completed successfully.
78+
- PASS - exact friendly label source sweep found all expected labels.
79+
- PASS - status-text sweep returned no matches.
80+
- PASS - `git diff --check` completed successfully.
81+
82+
## Playwright Result
83+
84+
PASS
85+
86+
Command:
87+
88+
```powershell
89+
npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --grep "toolbox grouped view renders Game Journey order" --workers=1 --reporter=list
90+
```
91+
92+
Result:
93+
94+
- `1 passed`
95+
96+
Behavior validated:
97+
98+
- All 14 grouped accordion entries render in the expected order.
99+
- All 14 entries render the exact requested friendly label text.
100+
- Labels use literal `xxx%`.
101+
- Labels do not contain `Complete`, `In Progress`, or `Not Started`.
102+
- Labels are single-line strings.
103+
- Existing group color/order assertions still pass.
104+
105+
Coverage note:
106+
107+
- `toolbox/tools-page-accordions.js` was collected in Playwright V8 coverage at `85%`.
108+
- Coverage is advisory per project instructions.
109+
110+
## Manual Validation Notes
111+
112+
- Verified the label change is limited to accordion summaries; individual tool card group labels remain canonical group names such as `Idea`, `Create`, and `Graphics`.
113+
- Verified no database, runtime, route, or samples behavior changed.
114+
- Observed unrelated untracked local files `docs_build/dev/admin-notes/GFS_Create_Bucket_Workbook.pdf` and `docs_build/dev/admin-notes/GFS_Idea_Bucket_Workbook.pdf`; they were not touched and are excluded from the PR013 ZIP.
115+
116+
## Skipped Lanes
117+
118+
- Full samples: SKIP - samples are not in scope.
119+
- Broad Toolbox suite: SKIP - this PR changes only grouped accordion summary copy and is covered by the targeted grouped Toolbox test.
120+
- Admin/Owner navigation: SKIP - no Admin/Owner navigation files changed.
121+
- Runtime/database lanes: SKIP - no runtime or database behavior changed.
122+
123+
## Samples Decision
124+
125+
SKIP - no sample files or sample runtime behavior changed.
126+
127+
## Artifacts
128+
129+
- Review diff: `docs_build/dev/reports/codex_review.diff`
130+
- Changed files: `docs_build/dev/reports/codex_changed_files.txt`
131+
- Delta ZIP: `tmp/PR_26170_013-game-journey-friendly-descriptions_delta.zip`
Lines changed: 16 additions & 136 deletions
Original file line numberDiff line numberDiff line change
@@ -1,146 +1,26 @@
11
# git status --short
2-
M account/achievements.html
3-
M admin/invitations.html
4-
M admin/roles.html
5-
M admin/site-setup.html
6-
M admin/system-health.html
7-
M admin/users.html
8-
M assets/theme-v2/js/account-achievements.js
9-
M assets/theme-v2/js/admin-invitations.js
10-
M assets/theme-v2/js/admin-service-page-data.js
11-
M assets/theme-v2/js/admin-system-health.js
12-
M assets/theme-v2/partials/header-nav.html
13-
M docs_build/dev/PROJECT_INSTRUCTIONS.md
14-
M docs_build/dev/admin-notes/BusinessPlan.txt
15-
M docs_build/dev/admin-notes/deployment-uat-prod/index.txt
16-
M docs_build/dev/admin-notes/index.txt
17-
M docs_build/dev/admin-notes/tools/index.txt
18-
M docs_build/dev/reports/codex_changed_files.txt
2+
M docs_build/dev/reports/codex_changed_files.txt
193
M docs_build/dev/reports/codex_review.diff
204
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
215
M docs_build/dev/reports/playwright_v8_coverage_report.txt
22-
M owner/grouping-colors.html
23-
M src/api/admin-invitations-api-client.js
24-
M src/api/admin-owner-navigation.js
25-
M src/dev-runtime/admin/header-nav.local.html
26-
M src/dev-runtime/memberships/membership-assignment-service.mjs
27-
M src/dev-runtime/persistence/mock-db-store.js
28-
M src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js
29-
M src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
30-
M src/dev-runtime/persistence/tool-repositories/game-workspace-mock-repository.js
31-
M src/dev-runtime/server/local-api-router.mjs
32-
M src/shared/toolbox/tool-metadata-inventory.js
33-
M tests/playwright/tools/AdminDbViewer.spec.mjs
34-
M tests/playwright/tools/AdminInvitationsNavPage.spec.mjs
35-
M tests/playwright/tools/AdminOwnerNavigationBoundary.spec.mjs
36-
M tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs
37-
M tests/playwright/tools/BuildPathProgressSimplification.spec.mjs
38-
M tests/playwright/tools/GameDesignMockRepository.spec.mjs
39-
M tests/playwright/tools/GameJourneyTool.spec.mjs
40-
M tests/playwright/tools/GameWorkspaceMockRepository.spec.mjs
41-
M tests/playwright/tools/LoginSessionMode.spec.mjs
42-
M tests/playwright/tools/RootToolsFutureState.spec.mjs
43-
M tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs
44-
M tests/playwright/tools/ToolNavigationPrevNext.spec.mjs
45-
M tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs
466
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
47-
M toolbox/colors/index.html
48-
M toolbox/controls/index.html
49-
M toolbox/game-configuration/index.html
50-
M toolbox/game-design/game-design.js
51-
M toolbox/game-design/index.html
52-
M toolbox/game-journey/game-journey.js
53-
M toolbox/game-workspace/game-workspace-api-client.js
54-
M toolbox/game-workspace/game-workspace.js
55-
M toolbox/game-workspace/index.html
56-
M toolbox/project-workspace/index.html
57-
M toolbox/saved-data/index.html
58-
M toolbox/tags/index.html
597
M toolbox/tools-page-accordions.js
60-
M toolbox/users/index.html
61-
?? docs_build/dev/admin-notes/GFS-AI-Credits-Reseller-Strategy.pdf
62-
?? docs_build/dev/admin-notes/engine/GameLoop.txt
63-
?? docs_build/dev/reports/PR_26170_009-friendly-naming-audit.md
64-
?? docs_build/dev/reports/PR_26170_010-friendly-visible-copy.md
65-
?? docs_build/dev/reports/PR_26170_011-friendly-metadata-vars.md
66-
?? docs_build/dev/reports/PR_26170_012-friendly-routes-folders.md
67-
?? docs_build/pr/BUILD_PR_26170_009-friendly-naming-audit.md
68-
?? docs_build/pr/BUILD_PR_26170_010-friendly-visible-copy.md
69-
?? docs_build/pr/BUILD_PR_26170_011-friendly-metadata-vars.md
70-
?? docs_build/pr/BUILD_PR_26170_012-friendly-routes-folders.md
71-
?? toolbox/game-crew/
8+
?? docs_build/dev/admin-notes/GFS_Create_Bucket_Workbook.pdf
9+
?? docs_build/dev/admin-notes/GFS_Idea_Bucket_Workbook.pdf
10+
?? docs_build/dev/reports/PR_26170_013-game-journey-friendly-descriptions.md
11+
?? docs_build/pr/BUILD_PR_26170_013-game-journey-friendly-descriptions.md
7212

7313
# git ls-files --others --exclude-standard
74-
docs_build/dev/admin-notes/GFS-AI-Credits-Reseller-Strategy.pdf
75-
docs_build/dev/admin-notes/engine/GameLoop.txt
76-
docs_build/dev/reports/PR_26170_009-friendly-naming-audit.md
77-
docs_build/dev/reports/PR_26170_010-friendly-visible-copy.md
78-
docs_build/dev/reports/PR_26170_011-friendly-metadata-vars.md
79-
docs_build/dev/reports/PR_26170_012-friendly-routes-folders.md
80-
docs_build/pr/BUILD_PR_26170_009-friendly-naming-audit.md
81-
docs_build/pr/BUILD_PR_26170_010-friendly-visible-copy.md
82-
docs_build/pr/BUILD_PR_26170_011-friendly-metadata-vars.md
83-
docs_build/pr/BUILD_PR_26170_012-friendly-routes-folders.md
84-
toolbox/game-crew/index.html
14+
docs_build/dev/admin-notes/GFS_Create_Bucket_Workbook.pdf
15+
docs_build/dev/admin-notes/GFS_Idea_Bucket_Workbook.pdf
16+
docs_build/dev/reports/PR_26170_013-game-journey-friendly-descriptions.md
17+
docs_build/pr/BUILD_PR_26170_013-game-journey-friendly-descriptions.md
8518

8619
# git diff --stat
87-
account/achievements.html | 4 +-
88-
admin/invitations.html | 26 +-
89-
admin/roles.html | 8 +-
90-
admin/site-setup.html | 6 +-
91-
admin/system-health.html | 12 +-
92-
admin/users.html | 22 +-
93-
assets/theme-v2/js/account-achievements.js | 14 +-
94-
assets/theme-v2/js/admin-invitations.js | 76 +-
95-
assets/theme-v2/js/admin-service-page-data.js | 36 +-
96-
assets/theme-v2/js/admin-system-health.js | 2 +-
97-
assets/theme-v2/partials/header-nav.html | 2 +-
98-
docs_build/dev/PROJECT_INSTRUCTIONS.md | 36 +-
99-
docs_build/dev/admin-notes/BusinessPlan.txt | 10 +-
100-
.../dev/admin-notes/deployment-uat-prod/index.txt | 6 +-
101-
docs_build/dev/admin-notes/index.txt | 3 +-
102-
docs_build/dev/admin-notes/tools/index.txt | 16 +-
103-
docs_build/dev/reports/codex_changed_files.txt | 156 +-
104-
docs_build/dev/reports/codex_review.diff | 26780 ++++++++++++++++---
105-
.../dev/reports/coverage_changed_js_guardrail.txt | 29 +
106-
.../dev/reports/playwright_v8_coverage_report.txt | 62 +-
107-
owner/grouping-colors.html | 16 +-
108-
src/api/admin-invitations-api-client.js | 26 +-
109-
src/api/admin-owner-navigation.js | 6 +-
110-
src/dev-runtime/admin/header-nav.local.html | 2 +-
111-
.../memberships/membership-assignment-service.mjs | 2 +-
112-
src/dev-runtime/persistence/mock-db-store.js | 2 +-
113-
.../game-design-mock-repository.js | 10 +-
114-
.../game-journey-mock-repository.js | 28 +-
115-
.../game-workspace-mock-repository.js | 2 +-
116-
src/dev-runtime/server/local-api-router.mjs | 83 +-
117-
src/shared/toolbox/tool-metadata-inventory.js | 32 +-
118-
tests/playwright/tools/AdminDbViewer.spec.mjs | 36 +-
119-
.../tools/AdminInvitationsNavPage.spec.mjs | 58 +-
120-
.../tools/AdminOwnerNavigationBoundary.spec.mjs | 10 +-
121-
.../tools/AdminPlatformToolsWireframes.spec.mjs | 18 +-
122-
.../tools/BuildPathProgressSimplification.spec.mjs | 2 +-
123-
.../tools/GameDesignMockRepository.spec.mjs | 10 +-
124-
tests/playwright/tools/GameJourneyTool.spec.mjs | 4 +-
125-
.../tools/GameWorkspaceMockRepository.spec.mjs | 30 +-
126-
tests/playwright/tools/LoginSessionMode.spec.mjs | 8 +-
127-
.../playwright/tools/RootToolsFutureState.spec.mjs | 15 +-
128-
.../tools/ToolDisplayModeNavigation.spec.mjs | 4 +-
129-
.../tools/ToolNavigationPrevNext.spec.mjs | 2 +-
130-
.../tools/ToolboxAdminMetadataSsot.spec.mjs | 10 +-
131-
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 84 +-
132-
toolbox/colors/index.html | 8 +-
133-
toolbox/controls/index.html | 2 +-
134-
toolbox/game-configuration/index.html | 2 +-
135-
toolbox/game-design/game-design.js | 6 +-
136-
toolbox/game-design/index.html | 20 +-
137-
toolbox/game-journey/game-journey.js | 2 +-
138-
.../game-workspace/game-workspace-api-client.js | 2 +-
139-
toolbox/game-workspace/game-workspace.js | 22 +-
140-
toolbox/game-workspace/index.html | 28 +-
141-
toolbox/project-workspace/index.html | 12 +-
142-
toolbox/saved-data/index.html | 2 +-
143-
toolbox/tags/index.html | 12 +-
144-
toolbox/tools-page-accordions.js | 2 +-
145-
toolbox/users/index.html | 45 +-
146-
59 files changed, 23538 insertions(+), 4433 deletions(-)
20+
docs_build/dev/reports/codex_changed_files.txt | 152 +-
21+
docs_build/dev/reports/codex_review.diff | 31133 +------------------
22+
.../dev/reports/coverage_changed_js_guardrail.txt | 2 +-
23+
.../dev/reports/playwright_v8_coverage_report.txt | 11 +-
24+
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 25 +
25+
toolbox/tools-page-accordions.js | 22 +-
26+
6 files changed, 297 insertions(+), 31048 deletions(-)

0 commit comments

Comments
 (0)