Restore dev-only Admin Notes directory viewer and remove header hardcode - PR_26158_043-admin-notes-local-viewer-restore

Author: ToolboxAid

assets/theme-v2/js/gamefoundry-partials.js

@@ -80,7 +80,6 @@
         "admin-roles": "admin/roles.html",
         "admin-moderation": "admin/moderation.html",
         "admin-analytics": "admin/analytics.html",
-        "admin-notes-dev": "docs_build/dev/admin-notes/index.txt",
         "admin-tools-progress": "admin/tools-progress.html",
         "cookie-policy": "legal/cookie-policy.html",
         disclaimer: "legal/disclaimer.html",

assets/theme-v2/partials/header-nav.html

@@ -119,7 +119,6 @@
           <a data-nav-link data-route="game-migration" href="toolbox/game-migration/index.html">Game Migration</a>
           <a data-nav-link data-route="admin-grouping-colors" href="admin/grouping-colors.html">Grouping Colors</a>
           <a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
-          <a data-nav-link data-route="admin-notes-dev" href="docs_build/dev/admin-notes/index.txt">Notes (Dev/Admin Only)</a>
           <a data-nav-link data-route="platform-settings" href="toolbox/platform-settings/index.html">Platform Settings</a>
           <a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
           <a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>

docs_build/dev/admin-notes/README.md

@@ -11,6 +11,6 @@ Owned paths:
 
 Runtime boundary:
 - Admin Notes viewer implementation, when needed for local/dev inspection, belongs under `src/dev-runtime/admin/`.
-- Only the admin/dev menu may link directly to `docs_build/dev/admin-notes/` content.
-- Public user navigation, toolbox pages, root pages, and production runtime bundles must not link to or fetch Admin Notes content.
+- Local/dev viewer access belongs under `src/dev-runtime/admin/`.
+- Public user navigation, Admin/public route pages, toolbox pages, root pages, and production runtime bundles must not link to or fetch Admin Notes content.
 - UAT/PROD bundles must not import `src/dev-runtime/admin/`.

docs_build/dev/reports/admin-notes-local-viewer-restore-report.md

@@ -0,0 +1,73 @@
+# PR_26158_043 Admin Notes Local Viewer Restore Report
+
+## Summary
+
+Restored a dev-runtime-only Admin Notes viewer at `src/dev-runtime/admin/admin-notes.html`. The viewer loads `docs_build/dev/admin-notes/index.txt` by default, lists live folders/files from `docs_build/dev/admin-notes/`, and opens selected `.txt` notes without exposing Admin Notes from public or production navigation.
+
+## Requirement Checklist
+
+| Requirement | Evidence | Status |
+| --- | --- | --- |
+| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first. | Read before implementation. | PASS |
+| Restore prior Admin Notes local viewer behavior with default `index.txt`. | `src/dev-runtime/admin/admin-notes.html`; `src/dev-runtime/admin/admin-notes-viewer.js`; Playwright default-load assertion. | PASS |
+| Show folders and file names from `docs_build/dev/admin-notes/`. | `src/dev-runtime/admin/admin-notes-directory.mjs` safely lists live root folder entries; Playwright validates folder/file links. | PASS |
+| Read and display selected `.txt` note content. | Playwright opens `quick-reference.txt` and `other/index.txt`. | PASS |
+| Keep implementation dev-only under `src/dev-runtime/admin/`. | Viewer page, viewer JS, and directory handler live under `src/dev-runtime/admin/`. | PASS |
+| Remove Admin Notes hardcoded link from `assets/theme-v2/partials/header-nav.html`. | Header link removed; static audit returns no Admin Notes matches in public/header paths. | PASS |
+| Do not expose Admin Notes from production/public navigation. | Boundary test and static audit over `account admin assets toolbox src/engine src/shared`. | PASS |
+| Add local/dev-only access through the dev/admin local entrypoint only. | Local entrypoint is `/src/dev-runtime/admin/admin-notes.html`; no public nav or Admin menu link was added. | PASS |
+| Do not add fallbacks. | Viewer uses explicit fetches and shows existing visible diagnostics when files/listing are unavailable; no alternate source or hidden default was added. | PASS |
+| Do not modify `start_of_day` folders. | `git diff --name-only \| rg "(^|/)start_of_day(/|$)"` returned no matches. | PASS |
+| Run changed-file syntax checks. | `node --check` lane passed for changed JS/MJS files. | PASS |
+| Run targeted Admin Notes local viewer validation. | `npx playwright test tests/playwright/tools/AdminNotesLocalViewer.spec.mjs` passed. | PASS |
+| Verify `docs_build/dev/admin-notes/index.txt` displays by default. | Playwright title/status/content assertions. | PASS |
+| Verify folder/file selection displays selected note content. | Playwright clicks `quick-reference.txt` and `other/`. | PASS |
+| Verify header nav no longer links directly to `docs_build/dev/admin-notes/`. | Boundary test and `rg` exposure audit. | PASS |
+| Verify UAT/PROD paths do not import `src/dev-runtime/admin/`. | Static import audit returned no matches. | PASS |
+| Do not run full samples smoke unless directly impacted. | Skipped; no sample loader/framework or sample data changed. | PASS |
+
+## Changed Files
+
+| File | Purpose |
+| --- | --- |
+| `src/dev-runtime/admin/admin-notes.html` | Dev-runtime local viewer entrypoint. |
+| `src/dev-runtime/admin/admin-notes-viewer.js` | Points note/file links at the dev-runtime viewer and fetches repo-root note files. |
+| `src/dev-runtime/admin/admin-notes-directory.mjs` | Safely lists live Admin Notes folders/files under `docs_build/dev/admin-notes/`. |
+| `src/dev-runtime/server/local-api-server.mjs` | Wires the local server to the Admin Notes directory handler. |
+| `tests/helpers/playwrightRepoServer.mjs` | Wires the Playwright local server to the same dev-only directory handler. |
+| `assets/theme-v2/partials/header-nav.html` | Removes the direct Admin Notes menu link. |
+| `assets/theme-v2/js/gamefoundry-partials.js` | Removes the direct Admin Notes route map entry. |
+| `docs_build/dev/admin-notes/README.md` | Documents the restored dev-runtime-only viewer boundary. |
+| `tests/dev-runtime/AdminNotesBoundary.test.mjs` | Enforces no public/prod exposure and dev-runtime placement. |
+| `tests/playwright/tools/AdminNotesLocalViewer.spec.mjs` | Validates default load, live directory links, and selected note rendering. |
+| `tests/playwright/tools/LoginSessionMode.spec.mjs` | Removes the PR042 expectation that Admin navigation exposes Admin Notes. |
+
+## Validation Evidence
+
+| Validation | Result |
+| --- | --- |
+| Changed-file `node --check` lane | PASS |
+| `node --test tests/dev-runtime/AdminNotesBoundary.test.mjs` | PASS, 3/3 |
+| `npx playwright test tests/playwright/tools/AdminNotesLocalViewer.spec.mjs` | PASS |
+| `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs --grep "Local users unlock their allowed Account and Admin pages"` | PASS |
+| `npx playwright test tests/playwright/tools/RootToolsFutureState.spec.mjs --grep "common header renders primary navigation order across active pages"` | PASS |
+| Public navigation exposure audit | PASS, no matches |
+| UAT/PROD dev-runtime admin import audit | PASS, no matches |
+| `git diff --check` | PASS, line-ending warnings only |
+
+## Playwright Impact
+
+Playwright impacted: Yes. This PR restores a local viewer page, file selection behavior, and live directory-listing behavior. Expected pass behavior is that the viewer loads `index.txt`, lists current folder entries, and opens selected note content. Expected fail behavior is missing default content, missing folder/file links, or selected note clicks failing to update the content/status.
+
+## Manual Test Notes
+
+1. Start the API-backed local server.
+2. Open `/src/dev-runtime/admin/admin-notes.html`.
+3. Confirm `index.txt` content loads by default.
+4. Click `quick-reference.txt` and `other/`; each should display that selected note content.
+5. Confirm the public/Admin header menus do not contain an Admin Notes link.
+
+## Skipped Lanes
+
+- Full samples smoke: skipped because samples and game runtime were not touched.
+- Full Playwright suite: skipped because targeted Admin Notes, header, and auth/menu lanes cover the changed behavior.

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,24 +6,10 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(60%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 3/5
+(0%) src/dev-runtime/admin/admin-notes-directory.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/local-api-server.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(96%) src/dev-runtime/admin/admin-notes-viewer.js - executed lines 501/501; executed functions 47/49
 
 Guardrail warnings:
-(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/admin/admin-notes-directory.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/dev-runtime/server/local-api-server.mjs - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,63 +12,28 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(86%) Toolbox Index - exercised 6 runtime JS files
+(0%) Toolbox Index - not exercised by this Playwright run
 (0%) Tool Template V2 - not exercised by this Playwright run
-(72%) Theme V2 Shared JS - exercised 2 runtime JS files
+(0%) Theme V2 Shared JS - not exercised by this Playwright run
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(60%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 3/5
+(0%) src/dev-runtime/admin/admin-notes-directory.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/dev-runtime/server/local-api-server.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(96%) src/dev-runtime/admin/admin-notes-viewer.js - executed lines 501/501; executed functions 47/49
 
 Files with executed line/function counts where available:
-(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
-(60%) src/engine/api/mock-db-api-client.js - executed lines 19/19; executed functions 3/5
-(64%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 9/14
-(67%) admin/db-viewer.js - executed lines 53/53; executed functions 4/6
-(71%) toolbox/project-workspace/project-workspace.js - executed lines 264/264; executed functions 17/24
-(74%) toolbox/tools-page-accordions.js - executed lines 774/774; executed functions 53/72
-(75%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 442/442; executed functions 30/40
-(88%) src/engine/api/mock-db-viewer-ui.js - executed lines 517/517; executed functions 86/98
-(89%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 24/27
-(97%) toolbox/project-journey/project-journey.js - executed lines 1003/1003; executed functions 104/107
-(100%) toolbox/project-journey/project-journey-api-client.js - executed lines 12/12; executed functions 2/2
-(100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
+(96%) src/dev-runtime/admin/admin-notes-viewer.js - executed lines 501/501; executed functions 47/49
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/admin/admin-notes-directory.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/dev-runtime/server/local-api-server.mjs - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
-(0%) assets/theme-v2/js/login-session.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/guest-seeds/palette-source-mock-db.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/guest-seeds/tool-state-samples.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/game-configuration-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/game-design-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/palette-workspace-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/project-journey-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/project-workspace-mock-repository.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/dev-runtime/DbSeedIntegrity.test.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/dev-runtime/DevRuntimeBoundary.test.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AdminDbViewer.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AssetToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) assets/theme-v2/js/gamefoundry-partials.js - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/admin/admin-notes-directory.mjs - changed JS file not collected as browser runtime coverage
+(0%) src/dev-runtime/server/local-api-server.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/dev-runtime/AdminNotesBoundary.test.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/helpers/playwrightRepoServer.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/AdminNotesLocalViewer.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/LoginSessionMode.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ProjectJourneyTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(60%) src/engine/api/mock-db-api-client.js - changed JS file with browser V8 coverage
+(96%) src/dev-runtime/admin/admin-notes-viewer.js - changed JS file with browser V8 coverage