Skip to content

Commit c3af7aa

Browse files
committed
Reduce active toolbox ownership, finalize archive v1-v2, and establish toolbox end-state inventory - PR_26154_045-047-cleanup-stack
1 parent c5bcd43 commit c3af7aa

53 files changed

Lines changed: 561 additions & 971 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

toolbox/configuration-admin/index.html renamed to archive/v1-v2/tools/toolbox-reduction-reference/configuration-admin/index.html

File renamed without changes.

toolbox/creator/index.html renamed to archive/v1-v2/tools/toolbox-reduction-reference/tool-creator/index.html

File renamed without changes.
1.68 MB
Loading

assets/theme-v2/js/gamefoundry-partials.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
"sound-studio": "toolbox/sound/index.html",
1818
"storage-inspector": "toolbox/storage/index.html",
1919
"world-vector-studio": "toolbox/world-vector/index.html",
20-
"configuration-admin": "toolbox/configuration-admin/index.html",
21-
"tool-creator": "toolbox/creator/index.html",
2220
cloud: "toolbox/cloud/index.html",
2321
games: "games/index.html",
2422
arcade: "games/arcade/index.html",

assets/theme-v2/partials/header-nav.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
</div>
2727
</div>
2828
<a data-nav-link data-toolbox-menu-item data-route="palette-manager" href="toolbox/palette/index.html">Palette Manager</a>
29-
<a data-nav-link data-toolbox-menu-item data-route="configuration-admin" href="toolbox/configuration-admin/index.html">Configuration Admin</a>
3029
<a data-nav-link data-toolbox-menu-item data-route="input-studio" href="toolbox/input/index.html">Input</a>
3130
<div class="nav-item nav-popout-item" data-toolbox-menu-group>
3231
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Objects &#9656;</a>
@@ -37,7 +36,6 @@
3736
<a data-nav-link data-toolbox-menu-item data-route="object-vector-studio" href="toolbox/object-vector/index.html">Object Vector</a>
3837
</div>
3938
</div>
40-
<a data-nav-link data-toolbox-menu-item data-route="tool-creator" href="toolbox/creator/index.html">Tool Creator</a>
4139
<div class="nav-item nav-popout-item" data-toolbox-menu-group>
4240
<a data-toolbox-menu-group-label data-route="toolbox" href="toolbox/index.html" aria-haspopup="true">Worlds &#9656;</a>
4341
<div class="sub-menu sub-menu--nested" data-toolbox-submenu aria-label="World tools">
@@ -73,7 +71,6 @@
7371
<a data-nav-link data-route="admin-moderation" href="admin/moderation.html">Moderation</a>
7472
<a data-nav-link data-route="admin-ratings" href="admin/ratings.html">Ratings</a>
7573
<a data-nav-link data-route="admin-roles" href="admin/roles.html">Roles</a>
76-
<a data-nav-link data-route="configuration-admin" href="toolbox/configuration-admin/index.html">Settings and Admin</a>
7774
<a data-nav-link data-route="admin-site-settings" href="admin/site-settings.html">Site Settings</a>
7875
<a data-nav-link data-route="admin-themes" href="admin/themes.html">Themes</a>
7976
<a data-nav-link data-route="admin-users" href="admin/users.html">Users</a>

docs_build/dev/codex_commands.md

Lines changed: 32 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,52 +2,59 @@
22

33
Task:
44

5-
- `PR_26154_042-toolbox-route-reference-hygiene`
6-
- `PR_26154_043-docs-build-archive-consolidation`
7-
- `PR_26154_044-final-active-toolbox-template-gate`
5+
- `PR_26154_045-active-toolbox-reduction`
6+
- `PR_26154_046-archive-v1-v2-finalization`
7+
- `PR_26154_047-toolbox-endstate-inventory`
88

99
Changes:
1010

1111
- Read `.codex/skills/repo-build/SKILL.md`.
1212
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
13-
- Used `PR_26154_039-041-builder-shared-active-closeout` as baseline.
14-
- Audited active route references for removed builder surfaces.
15-
- Confirmed `toolbox/game-design/` is the only active game design/build planning surface.
16-
- Moved 46 historical builder/route reports from `docs_build/dev/reports/` to `archive/v1-v2/docs_build/dev/reports/toolbox-builder-route-history/`.
17-
- Moved existing `docs_build/dev/archive/object-vector-studio-v2/starter-project-template/` material to `archive/v1-v2/docs_build/dev/archive/object-vector-studio-v2/starter-project-template/`.
18-
- Updated docs_build references to moved archive material.
19-
- Ran the final active Toolbox template gate across all active tool pages.
13+
- Used `PR_26154_042-044-toolbox-route-archive-template-gate` as baseline.
14+
- Audited active Toolbox folders and classified requested candidates.
15+
- Moved `toolbox/configuration-admin/` to `archive/v1-v2/tools/toolbox-reduction-reference/configuration-admin/`.
16+
- Moved `toolbox/creator/` to `archive/v1-v2/tools/toolbox-reduction-reference/tool-creator/`.
17+
- Removed Configuration Admin and Tool Creator from active header navigation, route aliases, and Toolbox index grouping.
18+
- Updated active surface validation to reject the retired Toolbox folders if they return.
19+
- Rewired hidden legacy registry/sample references from removed `old-tools` and `old_samples` roots to `archive/v1-v2`.
20+
- Updated docs_build guard scripts and selected validation utilities for archive path ownership.
21+
- Produced active Toolbox and archive end-state reports.
2022
- Did not modify `start_of_day/`.
2123
- Did not run tests against `archive/v1-v2/`.
2224
- Did not run the full samples smoke test.
2325

2426
Validation:
2527

26-
- Ran targeted active route scans for retired builder paths.
27-
- Ran targeted docs_build archive reference checks.
28-
- Ran final active Toolbox template consistency audit with counts.
28+
- Ran targeted active route scans for retired Configuration Admin and Tool Creator paths.
29+
- Ran targeted archive path checks for `archive/v1-v2/tools`, `archive/v1-v2/games`, and `archive/v1-v2/samples`.
30+
- Ran active Toolbox template consistency audit: 16 active pages, 10 markers, 0 mismatches.
2931
- Ran `node scripts/validate-active-tools-surface.mjs`.
30-
- Ran changed-file static validation for HTML, JS, CSS, JSON, and Markdown files.
32+
- Ran `node docs_build/dev/toolbox/checkSharedExtractionGuard.mjs`.
33+
- Ran changed-file JavaScript syntax checks with `node --check`.
34+
- Ran changed JSON parse checks.
35+
- Ran `python -m py_compile scripts/engine_usage_audit.py`.
36+
- Ran `npm run test:workspace-v2`.
3137
- Ran `git diff --check`.
32-
- Skipped `npm run test:workspace-v2` because active Toolbox navigation and template wiring were not changed.
3338
- Regenerated required Codex review artifacts.
3439
- Packaged repo-structured ZIP:
35-
- `tmp/PR_26154_042-044-toolbox-route-archive-template-gate_delta.zip`
40+
- `tmp/PR_26154_045-047-toolbox-reduction-archive-endstate_delta.zip`
3641

3742
Required reports:
3843

3944
- `docs_build/dev/reports/codex_changed_files.txt`
4045
- `docs_build/dev/reports/codex_review.diff`
41-
- `docs_build/dev/reports/toolbox_route_reference_hygiene_report.md`
42-
- `docs_build/dev/reports/docs_build_archive_consolidation_report.md`
43-
- `docs_build/dev/reports/final_active_toolbox_template_gate_report.md`
46+
- `docs_build/dev/reports/active_toolbox_reduction_report.md`
47+
- `docs_build/dev/reports/archive_v1_v2_finalization_report.md`
48+
- `docs_build/dev/reports/toolbox_endstate_inventory_report.md`
4449

4550
Validation summary:
4651

47-
- PASS: active builder route hygiene.
48-
- PASS: docs_build archive consolidation.
49-
- PASS: active Toolbox template gate, 18 of 18 pages passing.
50-
- PASS: static validation.
52+
- PASS: active Toolbox surface reduced to 16 active pages.
53+
- PASS: retired tool routes removed from active nav/index/route aliases.
54+
- PASS: active Toolbox template audit.
55+
- PASS: Workspace V2 lane, 2 Playwright tests passed.
56+
- PASS: static syntax/JSON validation for changed files.
5157
- PASS: `git diff --check`.
52-
- SKIPPED: Workspace V2 Playwright because no active nav/template behavior changed.
53-
- SKIPPED: archive tests and full samples smoke test.
58+
- INFO: optional Phase 24 guard now resolves archive paths from repo root, but its existing roadmap hash lock is stale and was not used as this PR's gate.
59+
- SKIPPED: tests against `archive/v1-v2/`.
60+
- SKIPPED: full samples smoke test.

docs_build/dev/commit_comment.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
Close toolbox route hygiene and archive stale builder reports - PR_26154_042-044
1+
Reduce active Toolbox surface and finalize V1/V2 archive references - PR_26154_045-047
22

3-
- Confirm active surfaces no longer reference retired Tool Builder or Game Builder routes.
4-
- Keep Game Design as the only active game design/build planning surface.
5-
- Move stale builder-route and legacy GameFoundryStudio report history under archive/v1-v2.
6-
- Move existing docs_build/dev/archive material under archive/v1-v2.
7-
- Verify all 18 active Toolbox pages satisfy template-critical markers, Theme V2 wiring, header/index coverage, and no local css/js folders.
8-
- Validate targeted route checks, active Toolbox surface, changed-file static checks, diff hygiene, review artifacts, and repo-structured delta packaging.
3+
- Archive Configuration Admin and Tool Creator under archive/v1-v2/tools/toolbox-reduction-reference.
4+
- Remove those retired pages from active Toolbox navigation, route aliases, and Toolbox index grouping.
5+
- Keep 16 active end-user Toolbox tools plus toolbox/_tool_template-v2 as the active template.
6+
- Rewire hidden legacy registry/sample references and docs_build guards from removed old roots to archive/v1-v2 paths.
7+
- Confirm archive/v1-v2/tools, archive/v1-v2/games, and archive/v1-v2/samples are the deprecated reference roots.
8+
- Validate active Toolbox surface, template markers, changed-file syntax/JSON, Workspace V2, diff hygiene, review artifacts, and repo-structured delta packaging.
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
# Active Toolbox Reduction Report
2+
3+
Task: `PR_26154_045-active-toolbox-reduction`
4+
5+
## Summary
6+
7+
Reduced the active Toolbox surface to real end-user tools by archiving two clear non-user-facing pages:
8+
9+
- `toolbox/configuration-admin/index.html` -> `archive/v1-v2/tools/toolbox-reduction-reference/configuration-admin/index.html`
10+
- `toolbox/creator/index.html` -> `archive/v1-v2/tools/toolbox-reduction-reference/tool-creator/index.html`
11+
12+
The active Toolbox now contains 16 tool pages plus the active template source `toolbox/_tool_template-v2/`.
13+
14+
## Requested Folder Classification
15+
16+
| Folder | Classification | Action |
17+
| --- | --- | --- |
18+
| `toolbox/dev` | DOCS_BUILD | Already absent from active Toolbox; ownership remains under docs/build governance from prior cleanup. |
19+
| `toolbox/shared` | ENGINE/SRC | Already absent from active Toolbox; active shared behavior remains under `src/shared/toolbox/`. |
20+
| `toolbox/schemas` | ENGINE/SRC | Already absent from active Toolbox; active schemas remain under `src/shared/schemas/`. |
21+
| `toolbox/assets` | ACTIVE TOOL | Kept as an end-user asset creation surface. |
22+
| `toolbox/code` | ACTIVE TOOL / AMBIGUOUS | Kept because active contracts and shared creator-extension behavior still reference this surface. |
23+
| `toolbox/creator` | ARCHIVE | Moved to archive as template/tool-authoring reference material, not an end-user tool. |
24+
| `toolbox/configuration-admin` | ARCHIVE | Moved to archive as admin/settings reference material, not an end-user Toolbox tool. |
25+
26+
## Active Reference Updates
27+
28+
- Removed Configuration Admin and Tool Creator from `assets/theme-v2/partials/header-nav.html`.
29+
- Removed Configuration Admin and Tool Creator route aliases from `assets/theme-v2/js/gamefoundry-partials.js`.
30+
- Removed the `Tooling` group from `toolbox/tools-page-accordions.js`.
31+
- Extended `scripts/validate-active-tools-surface.mjs` so retired `toolbox/configuration-admin` and `toolbox/creator` routes fail active-surface validation if reintroduced.
32+
33+
## Validation
34+
35+
- PASS: `node scripts/validate-active-tools-surface.mjs`
36+
- PASS: targeted scans found no active references to the retired `toolbox/configuration-admin` or `toolbox/creator` routes.
37+
- PASS: active Toolbox template audit reports 16 active pages, 10 markers, 0 mismatches.
38+
- PASS: `npm run test:workspace-v2`
39+
40+
## Notes
41+
42+
- Marketplace remains outside Toolbox and is not listed in `toolbox/index.html`.
43+
- `toolbox/code` remains active for now because it is tied to active creator-extension contracts; moving it would require a dedicated registry/runtime reconciliation PR.
Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# Archive V1/V2 Finalization Report
2+
3+
Task: `PR_26154_046-archive-v1-v2-finalization`
4+
5+
## Summary
6+
7+
Confirmed the legacy reference material root is consolidated under `archive/v1-v2/`:
8+
9+
- `archive/v1-v2/tools/`
10+
- `archive/v1-v2/games/`
11+
- `archive/v1-v2/samples/`
12+
13+
The former root folders `old-tools/`, `old_games/`, and `old_samples/` are absent.
14+
15+
## Changes
16+
17+
- Added the newly retired Toolbox reference pages under `archive/v1-v2/tools/toolbox-reduction-reference/`.
18+
- Rewired hidden legacy Toolbox registry entries from `../old-tools/` and `../old_samples/` to `../archive/v1-v2/tools/` and `../archive/v1-v2/samples/`.
19+
- Rewired `toolbox/renderToolsIndex.js` sample metadata paths from `/old_samples/` to `/archive/v1-v2/samples/`.
20+
- Updated docs_build guard scripts and baselines that still encoded root `old_samples` / `old_games` paths to use `archive/v1-v2/samples` and `archive/v1-v2/games`.
21+
- Updated selected validation utilities so archive game/sample paths are recognized as deprecated reference ownership.
22+
23+
## Archive State
24+
25+
| Path | State |
26+
| --- | --- |
27+
| `archive/v1-v2/tools/` | Present; contains deprecated tool/reference material. |
28+
| `archive/v1-v2/games/` | Present; contains deprecated playable reference games. |
29+
| `archive/v1-v2/samples/` | Present; contains deprecated sample references. |
30+
| `old-tools/` | Absent. |
31+
| `old_games/` | Absent. |
32+
| `old_samples/` | Absent. |
33+
| `docs_build/archive/` | Absent. |
34+
| `docs_build/dev/archive/` | Absent. |
35+
36+
## Remaining Archive Policy Items
37+
38+
- `archive/v1-v2/docs_build/archive/tools/SpriteEditor_old_keep/` remains in its existing policy location. It is reported as an archive-placement policy candidate rather than moved in this PR.
39+
- Some compatibility code still accepts historical `old_games` / `old_samples` strings as legacy input. Those are retained as compatibility aliases and should be addressed in a dedicated runtime/path-convention PR.
40+
41+
## Validation
42+
43+
- PASS: archive root existence checks for `archive/v1-v2/tools`, `archive/v1-v2/games`, and `archive/v1-v2/samples`.
44+
- PASS: root absence checks for `old-tools`, `old_games`, and `old_samples`.
45+
- PASS: `node docs_build/dev/toolbox/checkSharedExtractionGuard.mjs`
46+
- PASS: changed JS syntax checks for touched archive-routing scripts.
47+
- INFO: `docs_build/dev/toolbox/checkPhase24CloseoutExecutionGuard.mjs` now resolves archive paths from repo root; its roadmap hash lock is stale independently of this PR and was not used as a required gate.
48+
49+
No tests were run against `archive/v1-v2/`.

0 commit comments

Comments
 (0)