Skip to content

Commit d4db33a

Browse files
committed
Add Toolbox build path wireframe and Theme V2 CSS guard - PR_26155_001-toolbox-build-path-wireframe & Correct Toolbox view modes instead of adding wireframe tools - PR_26155_002-toolbox-view-mode-correction
1 parent 8108f36 commit d4db33a

39 files changed

Lines changed: 446 additions & 285 deletions

docs_build/dev/PROJECT_INSTRUCTIONS.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1465,3 +1465,15 @@ Use the V2 naming consistently:
14651465
- First-Class Tool Starter V2
14661466
- First-Class Tools Surface V2
14671467
- First-Class Tool V2
1468+
1469+
## Targeted Toolbox Rebuild Rule
1470+
1471+
Targeted Toolbox rebuilds must use existing Theme V2 structure and styling first.
1472+
1473+
Rules:
1474+
- Do not add new CSS unless it is absolutely required for a documented Theme V2 gap.
1475+
- Do not create page-local CSS, tool-local CSS, inline styles, or script-generated styling for Toolbox rebuilds.
1476+
- Use existing Theme V2 layout, panel, accordion, button, card, status, and typography classes before requesting new styling.
1477+
- If existing Theme V2 cannot support a required Toolbox pattern, document the gap before adding an approved reusable Theme V2 pattern.
1478+
- Reusable Theme V2 patterns must live under `assets/theme-v2/css/` and must not reintroduce legacy/V1 styling.
1479+
- Wireframe-only Toolbox rebuilds must not add implementation logic.

docs_build/dev/codex_commands.md

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,3 +79,34 @@ Validation:
7979
Required reports:
8080
- `docs_build/dev/reports/theme_css_entrypoint_closeout_report.md`
8181
- `docs_build/dev/reports/migration_final_status_report.md`
82+
83+
## PR_26154_053
84+
85+
Changes:
86+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
87+
- Added a targeted Toolbox rebuild rule to `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
88+
- Corrected `toolbox/index.html` so Order, Group, Progress, and Build Path are view controls for the same Toolbox surface.
89+
- Removed the extra Progress Wireframe and Build Path Wireframe accordion/card content.
90+
- Preserved existing active tool tile data and `tools-page-accordions.js` page wiring.
91+
- Added Progress view rendering with static `locked`, `ready`, `in-progress`, and `complete` readiness labels on existing tool tiles.
92+
- Added Build Path view rendering as visual path groups using existing tool tiles.
93+
- Kept Arcade out of Toolbox content.
94+
- Kept forbidden `Studio` wording out of Toolbox dynamic tool labels except brand usage.
95+
- Updated active validation scripts and Workspace V2 Playwright assertions for the corrected view-mode contract.
96+
- Added validation and manual test notes.
97+
- Generated local review artifacts.
98+
- Created the repo-structured delta ZIP at `tmp/PR_26154_053-toolbox-wireframe-rebuild-rule_view-mode-correction_delta.zip`.
99+
100+
Validation:
101+
- `node scripts/validate-active-tools-surface.mjs`
102+
- `node scripts/validate-tool-registry.mjs`
103+
- Toolbox source checks for view controls, Progress readiness labels, Build Path path groups, absence of extra Progress/Build Path wireframe sections, Arcade absence, forbidden `Studio` label absence, and no inline CSS/JS/event handlers.
104+
- `npm run test:workspace-v2`
105+
- `git diff --check`
106+
- `node --check` for changed JS/MJS files.
107+
- No new CSS added.
108+
109+
Required reports:
110+
- `docs_build/dev/reports/codex_changed_files.txt`
111+
- `docs_build/dev/reports/codex_review.diff`
112+
- `docs_build/dev/reports/toolbox_wireframe_rebuild_rule_report.md`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Remove inactive Theme V2 styles aggregate and confirm final migration paths - PR_26154_052-theme-css-entrypoint-closeout
1+
Correct Toolbox wireframe view modes on shared tool surface - PR_26154_053-toolbox-wireframe-rebuild-rule

docs_build/dev/reports/coverage_changed_js_guardrail.txt

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,32 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
66
Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
77

88
Changed runtime JS files considered:
9-
(0%) src/engine/release/DistributionPackager.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
10-
(0%) src/engine/runtime/gameImageConvention.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
11-
(0%) src/shared/state/getStateVariantClassification.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
12-
(0%) src/shared/toolbox/pipeline/assetManifestLoader.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
13-
(0%) src/shared/toolbox/pipeline/assetPipelineTooling.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
14-
(0%) src/shared/toolbox/pipeline/gameAssetManifestCoordinator.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
15-
(0%) src/shared/toolbox/pipeline/runtimeAssetLookup.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
16-
(0%) src/shared/toolbox/platformShell.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
17-
(0%) src/shared/toolbox/toolLaunchSSoT.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
18-
(0%) src/shared/toolbox/toolSampleCatalog.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
19-
(0%) src/shared/toolbox/vectorNativeTemplate.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
20-
(0%) src/shared/toolbox/vectorTemplateSampleGame.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
21-
(0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
22-
(75%) toolbox/tools-page-accordions.js - executed lines 373/373; executed functions 15/20
9+
(88%) toolbox/tools-page-accordions.js - executed lines 466/466; executed functions 30/34
2310

2411
Guardrail warnings:
25-
(0%) src/engine/release/DistributionPackager.js - WARNING: changed runtime JS file missing from coverage; advisory only
26-
(0%) src/engine/runtime/gameImageConvention.js - WARNING: changed runtime JS file missing from coverage; advisory only
27-
(0%) src/shared/state/getStateVariantClassification.js - WARNING: changed runtime JS file missing from coverage; advisory only
28-
(0%) src/shared/toolbox/pipeline/assetManifestLoader.js - WARNING: changed runtime JS file missing from coverage; advisory only
29-
(0%) src/shared/toolbox/pipeline/assetPipelineTooling.js - WARNING: changed runtime JS file missing from coverage; advisory only
30-
(0%) src/shared/toolbox/pipeline/gameAssetManifestCoordinator.js - WARNING: changed runtime JS file missing from coverage; advisory only
31-
(0%) src/shared/toolbox/pipeline/runtimeAssetLookup.js - WARNING: changed runtime JS file missing from coverage; advisory only
32-
(0%) src/shared/toolbox/platformShell.js - WARNING: changed runtime JS file missing from coverage; advisory only
33-
(0%) src/shared/toolbox/toolLaunchSSoT.js - WARNING: changed runtime JS file missing from coverage; advisory only
34-
(0%) src/shared/toolbox/toolSampleCatalog.js - WARNING: changed runtime JS file missing from coverage; advisory only
35-
(0%) src/shared/toolbox/vectorNativeTemplate.js - WARNING: changed runtime JS file missing from coverage; advisory only
36-
(0%) src/shared/toolbox/vectorTemplateSampleGame.js - WARNING: changed runtime JS file missing from coverage; advisory only
37-
(0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file missing from coverage; advisory only
12+
(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/dependency_gating_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-06-04T02:37:31.280Z
3+
Generated: 2026-06-04T03:43:28.722Z
44
Status: PASS
55

66
## Gate Order

docs_build/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-06-04T02:37:31.281Z
3+
Generated: 2026-06-04T03:43:28.722Z
44
Status: PASS
55

66
## Summary
77

8-
Reused dependency hydration: 1
9-
Invalidated dependency hydration: 0
8+
Reused dependency hydration: 0
9+
Invalidated dependency hydration: 1
1010
Generated dependency hydration: 0
11-
Prevented dependency graph hydration: 1
12-
Prevented helper resolution passes: 4
11+
Prevented dependency graph hydration: 0
12+
Prevented helper resolution passes: 0
1313
Prevented fixture ownership traversal: 0
1414

1515
## Hydration Decisions
1616

1717
| Lane | Status | Helpers | Fixtures | Imports | Dependency Hydration Hash | Reason |
1818
| --- | --- | --- | --- | --- | --- | --- |
19-
| workspace-contract | REUSED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | 0ff8fc92c789456d | Dependency hydration reused from validated warm-start state. |
19+
| workspace-contract | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | 0ff8fc92c789456d | Dependency hydration was refreshed after warm-start invalidation. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/execution_graph_reuse_report.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-06-04T02:37:31.281Z
3+
Generated: 2026-06-04T03:43:28.723Z
44
Status: PASS
55

66
## Summary
77

8-
Reused execution graphs: 1
9-
Prevented graph rebuilds: 1
10-
Prevented redundant dependency traversal: 1
11-
Prevented fixture/helper graph assembly: 4
12-
Prevented manifest traversal: 1
13-
Prevented targeted scheduling work: 1
8+
Reused execution graphs: 0
9+
Prevented graph rebuilds: 0
10+
Prevented redundant dependency traversal: 0
11+
Prevented fixture/helper graph assembly: 0
12+
Prevented manifest traversal: 0
13+
Prevented targeted scheduling work: 0
1414

1515
## Execution Graph Decisions
1616

1717
| Lane | Status | Snapshot Status | Execution Graph Hash | Reason |
1818
| --- | --- | --- | --- | --- |
19-
| workspace-contract | REUSED | REUSED | 99a754ff31ffa25d | Lane snapshot is part of the selected targeted execution graph. |
19+
| workspace-contract | INVALIDATED | INVALIDATED | d71814dbea6e33fd | Lane snapshot is part of the selected targeted execution graph. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/failure_fingerprint_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-06-04T02:37:41.129Z
3+
Generated: 2026-06-04T03:43:38.895Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/filesystem_scan_reduction_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Filesystem Scan Reduction Report
22

3-
Generated: 2026-06-04T02:37:31.259Z
3+
Generated: 2026-06-04T03:43:28.704Z
44
Status: PASS
55

66
## Scan Enforcement

docs_build/dev/reports/incremental_validation_report.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,24 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-06-04T02:37:31.282Z
3+
Generated: 2026-06-04T03:43:28.723Z
44
Status: PASS
55

66
## Reuse Summary
77

8-
Reused manifests: 1
9-
Invalidated manifests: 0
8+
Reused manifests: 0
9+
Invalidated manifests: 1
1010
Generated manifests: 0
1111
Skipped manifests: 0
12-
Prevented lane regeneration: 1
13-
Prevented discovery scans: 1
14-
Prevented helper resolution passes: 4
12+
Prevented lane regeneration: 0
13+
Prevented discovery scans: 0
14+
Prevented helper resolution passes: 0
1515
Prevented fixture resolution passes: 0
1616

1717
## Incremental Decisions
1818

1919
| Lane | Decision | Invalidated By | Runtime Savings Observation |
2020
| --- | --- | --- | --- |
21-
| workspace-contract | REUSED | unchanged inputs | Reused 1 test input(s), 4 helper(s), and 0 fixture(s). |
21+
| workspace-contract | INVALIDATED | Persistent manifest input hash changed for workspace-contract.; Persistent manifest hash changed for workspace-contract. | Manifest was regenerated or skipped; no reuse savings for this lane. |
2222

2323
## Invalidation Rules
2424

0 commit comments

Comments
 (0)