Move Project Journey system guidance to reusable template SSoT - PR_26157_003-project-journey-template-ssot

ToolboxAid · ToolboxAid · commit d85f01fa2593 · 2026-06-06T16:06:24.000-04:00
diff --git a/assets/theme-v2/css/panels.css b/assets/theme-v2/css/panels.css
@@ -439,6 +439,57 @@ body.tool-focus-mode .tool-display-mode__badge {
   width: var(--icon-size-sm)
 }
 
+.tool-tree--compact,
+.tool-tree--compact ul {
+  margin-top: var(--space-8)
+}
+
+.tool-tree--compact ul {
+  padding-left: var(--space-14)
+}
+
+.tool-tree--compact li {
+  line-height: var(--line-height-md);
+  margin-top: var(--space-6)
+}
+
+.tool-tree-row {
+  align-items: center;
+  display: flex;
+  gap: var(--space-8);
+  width: 100%
+}
+
+.tool-tree-row__content {
+  flex: 1 1 auto;
+  justify-content: flex-start;
+  min-width: var(--space-0)
+}
+
+.tool-tree-row__action {
+  flex: 0 0 32px;
+  margin-left: auto
+}
+
+.tool-icon-32 {
+  height: 32px;
+  object-fit: contain;
+  width: 32px
+}
+
+.tool-icon-32.tool-tree-row__action {
+  height: 32px;
+  margin: var(--space-0) var(--space-0) var(--space-0) auto;
+  width: 32px
+}
+
+.tool-icon-button {
+  height: 32px;
+  min-width: 32px;
+  padding: var(--space-0);
+  width: 32px
+}
+
 .mascot-role {
   color: var(--text);
   font-size: var(--font-size-xl);
diff --git a/docs_build/dev/reports/coverage_changed_js_guardrail.txt b/docs_build/dev/reports/coverage_changed_js_guardrail.txt
@@ -7,8 +7,8 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
 (84%) toolbox/toolRegistry.js - executed lines 1788/1788; executed functions 31/37
-(92%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 524/524; executed functions 58/63
-(97%) toolbox/project-journey/project-journey.js - executed lines 554/554; executed functions 57/59
+(93%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 805/805; executed functions 68/73
+(97%) toolbox/project-journey/project-journey.js - executed lines 631/631; executed functions 64/66
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings
diff --git a/docs_build/dev/reports/dependency_gating_report.md b/docs_build/dev/reports/dependency_gating_report.md
@@ -1,6 +1,6 @@
 # Dependency Gating Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.241Z
 Status: PASS
 
 ## Gate Order
diff --git a/docs_build/dev/reports/dependency_hydration_reuse_report.md b/docs_build/dev/reports/dependency_hydration_reuse_report.md
@@ -1,6 +1,6 @@
 # Dependency Hydration Reuse Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/execution_graph_reuse_report.md b/docs_build/dev/reports/execution_graph_reuse_report.md
@@ -1,6 +1,6 @@
 # Execution Graph Reuse Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/failure_fingerprint_report.md b/docs_build/dev/reports/failure_fingerprint_report.md
@@ -1,6 +1,6 @@
 # Failure Fingerprint Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/incremental_validation_report.md b/docs_build/dev/reports/incremental_validation_report.md
@@ -1,6 +1,6 @@
 # Incremental Validation Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Reuse Summary
diff --git a/docs_build/dev/reports/lane_compilation_report.md b/docs_build/dev/reports/lane_compilation_report.md
@@ -1,6 +1,6 @@
 # Lane Compilation Report
 
-Generated: 2026-06-06T19:12:11.134Z
+Generated: 2026-06-06T19:55:52.241Z
 Status: PASS
 
 ## Lane Graph
diff --git a/docs_build/dev/reports/lane_deduplication_report.md b/docs_build/dev/reports/lane_deduplication_report.md
@@ -1,6 +1,6 @@
 # Lane Deduplication Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.241Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/lane_input_validation_report.md b/docs_build/dev/reports/lane_input_validation_report.md
@@ -1,6 +1,6 @@
 # Lane Input Validation Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.243Z
 Status: PASS
 
 ## Input Files
diff --git a/docs_build/dev/reports/lane_runtime_optimization_report.md b/docs_build/dev/reports/lane_runtime_optimization_report.md
@@ -1,6 +1,6 @@
 # Lane Runtime Optimization Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.241Z
 Status: PASS
 
 ## Runtime Cost Summary
diff --git a/docs_build/dev/reports/lane_snapshot_report.md b/docs_build/dev/reports/lane_snapshot_report.md
@@ -1,6 +1,6 @@
 # Lane Snapshot Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 Snapshot directory: docs_build/dev/reports/lane_snapshots
 
diff --git a/docs_build/dev/reports/lane_warm_start_report.md b/docs_build/dev/reports/lane_warm_start_report.md
@@ -1,6 +1,6 @@
 # Lane Warm-Start Report
 
-Generated: 2026-06-06T19:12:11.135Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 Warm-start directory: docs_build/dev/reports/lane_warm_starts
 
diff --git a/docs_build/dev/reports/monolith_trigger_removal_report.md b/docs_build/dev/reports/monolith_trigger_removal_report.md
@@ -1,6 +1,6 @@
 # Monolith Trigger Removal Report
 
-Generated: 2026-06-06T19:12:11.138Z
+Generated: 2026-06-06T19:55:52.245Z
 Status: PASS
 
 ## Removed Broad Execution Triggers
diff --git a/docs_build/dev/reports/persistent_lane_manifest_report.md b/docs_build/dev/reports/persistent_lane_manifest_report.md
@@ -1,6 +1,6 @@
 # Persistent Lane Manifest Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 Manifest directory: docs_build/dev/reports/lane_manifests
 
diff --git a/docs_build/dev/reports/playwright_v8_coverage_report.txt b/docs_build/dev/reports/playwright_v8_coverage_report.txt
@@ -18,8 +18,8 @@ Exercised tool entry points detected:
 
 Changed runtime JS files covered:
 (84%) toolbox/toolRegistry.js - executed lines 1788/1788; executed functions 31/37
-(92%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 524/524; executed functions 58/63
-(97%) toolbox/project-journey/project-journey.js - executed lines 554/554; executed functions 57/59
+(93%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 805/805; executed functions 68/73
+(97%) toolbox/project-journey/project-journey.js - executed lines 631/631; executed functions 64/66
 
 Files with executed line/function counts where available:
 (67%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 10/15
@@ -28,14 +28,14 @@ Files with executed line/function counts where available:
 (76%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 26/34
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 206/206; executed functions 16/20
 (84%) toolbox/toolRegistry.js - executed lines 1788/1788; executed functions 31/37
-(92%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 524/524; executed functions 58/63
-(97%) toolbox/project-journey/project-journey.js - executed lines 554/554; executed functions 57/59
+(93%) toolbox/project-journey/project-journey-mock-repository.js - executed lines 805/805; executed functions 68/73
+(97%) toolbox/project-journey/project-journey.js - executed lines 631/631; executed functions 64/66
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/ProjectJourneyTool.spec.mjs - changed JS file not collected as browser runtime coverage
 (84%) toolbox/toolRegistry.js - changed JS file with browser V8 coverage
-(92%) toolbox/project-journey/project-journey-mock-repository.js - changed JS file with browser V8 coverage
+(93%) toolbox/project-journey/project-journey-mock-repository.js - changed JS file with browser V8 coverage
 (97%) toolbox/project-journey/project-journey.js - changed JS file with browser V8 coverage
diff --git a/docs_build/dev/reports/project-journey-template-ssot-report.md b/docs_build/dev/reports/project-journey-template-ssot-report.md
@@ -0,0 +1,55 @@
+# Project Journey Template SSoT Report
+
+Generated: 2026-06-06
+
+## Scope
+
+- Migrated Project Journey mock data from entry-owned system meaning to item/template SSoT ownership.
+- Added `project_journey_items` for project/user instance data.
+- Added `project_journey_templates` for reusable system guidance, original meaning, linked tool contexts, versioning, and active state.
+- Removed `originalMeaning`, `systemGuidance`, and `linkedToolContexts` from stored item records; resolved views attach those values from templates by `templateId`.
+- Preserved system-created edit/no-delete behavior and user-created edit/delete behavior.
+
+## Item And Template Rules
+
+- System-created items resolve guidance from active templates.
+- User-created items may have an empty `templateId`.
+- System-created items can update status and Item Details only through user editing.
+- System-created title and System Guidance stay template-owned.
+- User-created items can update title, status, and Item Details.
+- User edits set `updatedByType=user`.
+- Mock system updates set `updatedByType=system`.
+- Visible diagnostics report missing, inactive, or invalid template IDs for system-created items.
+
+## UI Changes
+
+- Selected Note Tree now renders compact tree rows with reusable Theme V2 `tool-tree-*` classes.
+- Forge-bot and trash actions are 32x32 and aligned at the end of tree rows.
+- Item Details renders directly below the selected item.
+- System Guidance renders separately from editable Item Details for system-created items.
+- Selected note Type dropdown is visible in Note Types and updates the selected note plus summary table immediately.
+- Add Type prevents duplicate note type names and adds new names to the dropdown.
+
+## Theme V2 Gap
+
+This PR added reusable Theme V2 classes in `assets/theme-v2/css/panels.css` because the existing system had 16px swatches and larger display badges, but no reusable 32px end-of-row action/indicator class or compact tool-tree rhythm.
+
+## Validation
+
+- PASS: Targeted Project Journey data/runtime/UI lane.
+- PASS: Project Workspace active-project handoff coverage in the Project Journey spec.
+- PASS: Toolbox registration/navigation coverage.
+- PASS: System guidance resolves from `project_journey_templates`.
+- PASS: Template guidance is not editable by normal users.
+- PASS: Item Details remains editable.
+- PASS: User edits set `updatedByType=user`.
+- PASS: Mock system updates set `updatedByType=system`.
+- PASS: Missing, inactive, and invalid template IDs show visible diagnostics.
+- PASS: User-created items work without `templateId`.
+- PASS: System-created delete remains blocked; user-created delete remains confirmed/deletable.
+- PASS: Selected note Type dropdown updates the note type and summary table.
+- PASS: Add Note Type creates a selectable non-duplicate type.
+- PASS: Forge-bot and trash controls are 32x32 and aligned at row end.
+- PASS: Compact tree spacing is verified.
+- PASS: Changed-file/static validation passed.
+- SKIP: Full samples smoke was not run per BUILD instruction.
diff --git a/docs_build/dev/reports/retry_suppression_report.md b/docs_build/dev/reports/retry_suppression_report.md
@@ -1,6 +1,6 @@
 # Retry Suppression Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Summary
diff --git a/docs_build/dev/reports/slow_path_pruning_report.md b/docs_build/dev/reports/slow_path_pruning_report.md
@@ -1,6 +1,6 @@
 # Slow Path Pruning Report
 
-Generated: 2026-06-06T19:12:11.138Z
+Generated: 2026-06-06T19:55:52.244Z
 Status: PASS
 Source timing evidence: docs_build/dev/reports/test_cleanup_performance_report.md (2026-05-26T21:18:42.199Z)
 
diff --git a/docs_build/dev/reports/static_validation_report.md b/docs_build/dev/reports/static_validation_report.md
@@ -1,6 +1,6 @@
 # Static Validation Report
 
-Generated: 2026-06-06T19:12:11.130Z
+Generated: 2026-06-06T19:55:52.236Z
 Status: PASS
 Static only: Yes
 Dry run: No
diff --git a/docs_build/dev/reports/targeted_file_manifest_report.md b/docs_build/dev/reports/targeted_file_manifest_report.md
@@ -1,6 +1,6 @@
 # Targeted File Manifest Report
 
-Generated: 2026-06-06T19:12:11.136Z
+Generated: 2026-06-06T19:55:52.242Z
 Status: PASS
 
 ## Manifest-Generated Lane Inputs
diff --git a/docs_build/dev/reports/test_cleanup_performance_report.md b/docs_build/dev/reports/test_cleanup_performance_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Performance Report
 
-Generated: 2026-06-06T19:12:11.138Z
+Generated: 2026-06-06T19:55:52.244Z
 Status: PASS
 
 ## Cost Summary
diff --git a/docs_build/dev/reports/test_cleanup_routing_report.md b/docs_build/dev/reports/test_cleanup_routing_report.md
@@ -1,6 +1,6 @@
 # Test Cleanup Routing Report
 
-Generated: 2026-06-06T19:12:11.138Z
+Generated: 2026-06-06T19:55:52.244Z
 Status: PASS
 
 ## Representative Routing Cases
diff --git a/docs_build/dev/reports/testing_lane_execution_report.md b/docs_build/dev/reports/testing_lane_execution_report.md
@@ -6,33 +6,41 @@ Generated: 2026-06-06
 
 Status: PASS
 
-This PR used the targeted Project Journey runtime/UI lane plus changed-file/static validation. Full samples smoke was intentionally not run.
+This PR used the targeted Project Journey data/runtime/UI lane plus changed-file/static validation. Full samples smoke was intentionally not run.
 
 ## Commands
 
 | Command | Result | Notes |
 | --- | --- | --- |
-| `npx playwright test tests/playwright/tools/ProjectJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=list` | PASS | 7 passed in 22.3s. |
+| `npx playwright test tests/playwright/tools/ProjectJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=list` | PASS | 10 passed in 23.4s. |
 | `npm run test:playwright:static` | PASS | Static-only lane runner completed and wrote static validation reports. |
 | `git diff --check` | PASS | No whitespace errors; Git reported line-ending normalization warnings only. |
 | `node --check toolbox/project-journey/project-journey.js` | PASS | Syntax check passed. |
-| `node --check toolbox/toolRegistry.js` | PASS | Syntax check passed. |
+| `node --check toolbox/project-journey/project-journey-mock-repository.js` | PASS | Syntax check passed. |
 | `node --check tests/playwright/tools/ProjectJourneyTool.spec.mjs` | PASS | Syntax check passed. |
 
 ## Runtime Coverage
 
-- Verified Statistics tiles render count first, label second, without status icons or status/pill label classes.
-- Verified Status Legend remains at the bottom of Statistics and contains the status icons.
-- Verified Admin Notes Current Folder/Open folder/Return to root index UI is absent from Project Journey.
-- Verified Delete Row is removed from the Selected Row Editor.
-- Verified user-created tree rows show a trash control and system-created rows do not.
-- Verified system-created tree rows show `forge-bot.svg` with `forge-bot created` alt/title text.
-- Verified delete confirmation cancel keeps the row and confirm deletes it.
-- Verified Project Journey is visible in normal-user Toolbox navigation after registry metadata update.
-- Verified Project Workspace handoff still opens Project Journey with the active project route.
+- Verified system-created item guidance resolves from `project_journey_templates`.
+- Verified template-owned guidance is not editable by normal users.
+- Verified Item Details remains editable and appears directly under the selected item.
+- Verified user edits set `updatedByType=user`.
+- Verified mock system updates set `updatedByType=system`.
+- Verified missing, inactive, and invalid template IDs show visible diagnostics.
+- Verified user-created items work without `templateId`.
+- Verified system-created delete remains blocked and user-created delete remains confirmed/deletable.
+- Verified selected note Type dropdown exists and updates note type plus summary table.
+- Verified Add Type creates a selectable non-duplicate note type.
+- Verified forge-bot and trash controls are 32x32 and aligned at row end.
+- Verified compact tree spacing is applied.
 
 ## Static Coverage
 
 - Changed-file/static validation passed.
 - Forbidden pattern scans found no page-local CSS, tool-local CSS, inline styles, `<style>` blocks, inline scripts, or inline event handlers.
 - Changed paths did not include archived V1/V2 files or `start_of_day` folders.
+- Full samples smoke was skipped because this PR affects Project Journey, Theme V2 reusable tool classes, and targeted tests only.
+
+## Coverage Note
+
+One browser note-type UI test disables V8 coverage collection because Chromium hung while stopping coverage after dynamic select option mutations in this environment. The remaining Project Journey browser tests collected coverage and the generated V8 report shows 93% coverage for `project-journey-mock-repository.js` and 97% coverage for `project-journey.js`.
diff --git a/docs_build/dev/reports/validation_cache_report.md b/docs_build/dev/reports/validation_cache_report.md
@@ -1,6 +1,6 @@
 # Validation Cache Report
 
-Generated: 2026-06-06T19:12:11.137Z
+Generated: 2026-06-06T19:55:52.244Z
 Status: PASS
 
 ## Cache Summary
diff --git a/docs_build/dev/reports/zero_browser_preflight_report.md b/docs_build/dev/reports/zero_browser_preflight_report.md
@@ -1,6 +1,6 @@
 # Zero-Browser Preflight Report
 
-Generated: 2026-06-06T19:12:11.137Z
+Generated: 2026-06-06T19:55:52.243Z
 Status: PASS
 
 ## Prevented Browser Launches
diff --git a/tests/playwright/tools/ProjectJourneyTool.spec.mjs b/tests/playwright/tools/ProjectJourneyTool.spec.mjs
diff --git a/toolbox/project-journey/index.html b/toolbox/project-journey/index.html
diff --git a/toolbox/project-journey/project-journey-mock-repository.js b/toolbox/project-journey/project-journey-mock-repository.js
diff --git a/toolbox/project-journey/project-journey.js b/toolbox/project-journey/project-journey.js
