Clean up build group color token leftovers - PR_26160_082-db-leftovers-cleanup

Author: ToolboxAid

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,8 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 43/56
+(100%) none changed - no changed runtime JS files
 
 Guardrail warnings:
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(100%) none changed - no changed runtime JS files

docs_build/dev/reports/db-leftovers-cleanup-report.md

@@ -0,0 +1,69 @@
+# PR_26160_082 DB Leftovers Cleanup
+
+Generated: 2026-06-09
+
+## Branch Validation
+
+| Check | Expected | Actual | Status |
+| --- | --- | --- | --- |
+| Current branch | `main` | `main` | PASS |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Replace hardcoded build-group color `#ff4d4d` | PASS | No active CSS/JS hardcoded usage existed; stale report references were replaced. |
+| Use Theme V2 token `--toolbox-group-build-color: var(--red)` | PASS | `assets/theme-v2/css/colors.css` line owns the token and `.toolbox-group-build` / `.tool-group-build` consume it. |
+| Audit additional hardcoded occurrences of `#ff4d4d` | PASS | Active source `rg` returned no matches after cleanup; intentional PR report text documents the removed literal. |
+| Replace all build-group usages with the Theme V2 token | PASS | Active build group CSS already routes through `--toolbox-group-build-color`; Playwright now validates this. |
+| Do not introduce new color constants or duplicate variables | PASS | No new color variable was added; existing Theme V2 token path is used. |
+| Use Theme V2 `colors.css` as color SSoT | PASS | `--red` and `--toolbox-group-build-color` remain in `assets/theme-v2/css/colors.css`. |
+
+## Replaced `#ff4d4d` Occurrences
+
+| File | Previous Occurrence | Replacement |
+| --- | --- | --- |
+| `docs_build/dev/reports/toolbox-group-color-restore-report.md` | Historical requirement evidence said Build/Create was restored to the literal hex value. | Reworded as superseded by PR_26160_082 and points to `--toolbox-group-build-color: var(--red)`. |
+| `docs_build/dev/reports/toolbox-group-color-restore-report.md` | Historical color source row named the old `--red` hex. | Replaced with `--toolbox-group-build-color: var(--red)` and current rendered color `rgb(255, 45, 45)`. |
+| `docs_build/dev/reports/toolbox-group-color-restore-report.md` | Historical note described a group-specific token set to the old literal. | Replaced with a note that PR_26160_082 keeps Build/Create on the Theme V2 SSoT path. |
+| `docs_build/dev/reports/toolbox-group-color-restore-report.md` | Historical validation command searched for the old literal. | Replaced with a token-only audit command. |
+
+No active runtime CSS, JavaScript, HTML, server, or test source used `#ff4d4d` before this PR. The remaining stale occurrences were report text from PR_26160_062; those were reworded to the Theme V2 token path.
+
+## Theme V2 Token Usage Report
+
+| Token / Selector | Source | Status |
+| --- | --- | --- |
+| `--red: #ff2d2d` | `assets/theme-v2/css/colors.css` | PASS: Theme V2 color SSoT owns the red value. |
+| `--toolbox-group-build-color: var(--red)` | `assets/theme-v2/css/colors.css` | PASS: Build group color delegates to `--red`. |
+| `.toolbox-group-build` | `assets/theme-v2/css/colors.css` | PASS: Uses `background: var(--toolbox-group-build-color)`. |
+| `.tool-group-build` | `assets/theme-v2/css/colors.css` | PASS: Uses `--tool-group-color` and `--tool-group-accent` from `--toolbox-group-build-color`. |
+| Toolbox group Playwright | `tests/playwright/tools/ToolboxRoutePages.spec.mjs` | PASS: Build/Create expected color now matches `--red`, and the test asserts `--toolbox-group-build-color` resolves to `--red`. |
+
+## Validation
+
+| Lane | Status | Command | Evidence |
+| --- | --- | --- | --- |
+| Branch guard | PASS | `git branch --show-current` | Returned `main`. |
+| Active-source hardcoded color audit | PASS | `rg -n "#ff4d4d" assets src toolbox admin tests --glob '!**/node_modules/**'` | No active source matches after cleanup. |
+| Theme V2 token audit | PASS | `rg -n -e "--toolbox-group-build-color" -e "--red" -e "toolbox-group-build" -e "tool-group-build" assets/theme-v2/css tests/playwright/tools/ToolboxRoutePages.spec.mjs` | Confirmed Theme V2 token usage and Playwright assertions. |
+| Changed-file syntax | PASS | `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs` | Exited 0. |
+| Targeted Toolbox Playwright | PASS | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox group labels match" --reporter=line` | 1 passed. |
+| Static diff validation | PASS | `git diff --check` | No whitespace errors; Git reported expected LF/CRLF warning for the changed Playwright file. |
+
+## Impacted Lanes
+
+- Toolbox group color rendering
+- Theme V2 color token validation
+
+## Skipped Lanes
+
+| Lane | Reason |
+| --- | --- |
+| Full samples validation | Samples and sample loaders were not changed. |
+| Broad Toolbox route suite | The scoped change only updates group color validation; the targeted group-color Playwright test was run. |
+| Admin runtime Playwright | Admin runtime behavior was unchanged; Admin relevance was covered by the existing group-color test reading Admin Tool Votes assignments. |
+
+## Manual Test Notes
+
+No separate manual walkthrough was required after the targeted Playwright test. Build/Create group labels now validate against the Theme V2 `--red` value through `--toolbox-group-build-color`.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,34 +12,26 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(70%) Toolbox Index - exercised 9 runtime JS files
+(74%) Toolbox Index - exercised 3 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 43/56
+(100%) none changed - no changed runtime JS files
 
 Files with executed line/function counts where available:
+(33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
 (38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
-(55%) toolbox/project-journey/project-journey.js - executed lines 1003/1003; executed functions 54/99
-(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
-(59%) toolbox/colors/colors.js - executed lines 2161/2161; executed functions 120/205
+(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
+(63%) admin/tool-votes.js - executed lines 378/378; executed functions 30/48
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(71%) toolbox/assets/assets.js - executed lines 519/519; executed functions 42/59
+(64%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 16/25
+(76%) toolbox/tools-page-accordions.js - executed lines 954/954; executed functions 78/103
 (77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 43/56
-(83%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 5/6
-(89%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 25/28
-(92%) admin/tool-votes.js - executed lines 378/378; executed functions 47/51
-(96%) toolbox/tools-page-accordions.js - executed lines 954/954; executed functions 109/113
-(100%) toolbox/assets/assets-api-client.js - executed lines 17/17; executed functions 3/3
-(100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
-(100%) toolbox/project-journey/project-journey-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(100%) none changed - no changed runtime JS files
 
 Changed JS files considered:
-(0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
-(77%) assets/theme-v2/js/gamefoundry-partials.js - changed JS file with browser V8 coverage
+(0%) tests/playwright/tools/ToolboxRoutePages.spec.mjs - changed JS file not collected as browser runtime coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,35 +1,34 @@
 # Testing Lane Execution Report
 
-PR: PR_26160_081-navigation-db-contract-audit
+PR: PR_26160_082-db-leftovers-cleanup
 Generated: 2026-06-09
 Full samples validation: SKIPPED
 
 ## Summary
 
 PASS: 6
 FAIL: 0
-SKIP: 4
+SKIP: 3
 
 ## Executed Lanes
 
 | Lane | Status | Command | Evidence |
 | --- | --- | --- | --- |
 | Branch guard | PASS | `git branch --show-current` | Returned `main`. |
-| Changed-file syntax | PASS | `node --check assets/theme-v2/js/gamefoundry-partials.js` | Exited 0. |
-| Changed-file syntax | PASS | `node --check src/dev-runtime/server/mock-api-router.mjs` | Exited 0. |
-| Navigation ownership static check | PASS | `rg -n "adminMainItems\|localAdminMyStuffItems\|routeMap" assets/theme-v2/js/gamefoundry-partials.js src/dev-runtime/server/mock-api-router.mjs` | Browser file no longer owns Admin menu item arrays; server route owns menu lists. |
-| Targeted Playwright | PASS | `npx playwright test tests/playwright/tools/LoginSessionMode.spec.mjs tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs tests/playwright/tools/ToolboxRoutePages.spec.mjs --reporter=line` | 20 passed. |
-| Static diff validation | PASS | `git diff --check` | No whitespace errors; Git reported expected LF/CRLF warning for `mock-api-router.mjs`. |
+| Active-source hardcoded color audit | PASS | `rg -n "#ff4d4d" assets src toolbox admin tests --glob '!**/node_modules/**'` | No active source matches after cleanup. |
+| Theme V2 token audit | PASS | `rg -n -e "--toolbox-group-build-color" -e "--red" -e "toolbox-group-build" -e "tool-group-build" assets/theme-v2/css tests/playwright/tools/ToolboxRoutePages.spec.mjs` | Confirmed Theme V2 token usage and Playwright assertions. |
+| Changed-file syntax | PASS | `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs` | Exited 0. |
+| Targeted Toolbox Playwright | PASS | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox group labels match" --reporter=line` | 1 passed. |
+| Static diff validation | PASS | `git diff --check` | No whitespace errors; Git reported expected LF/CRLF warning for the changed Playwright file. |
 
 ## Skipped Lanes
 
 | Lane | Status | Reason |
 | --- | --- | --- |
 | Full samples validation | SKIP | Samples and sample loaders were not changed. |
-| Colors runtime | SKIP | Explicitly out of scope for PR_081. |
-| Project Journey runtime | SKIP | Explicitly out of scope for PR_081. |
-| Workspace/Achievements user scoping | SKIP | Explicitly out of scope for PR_081. |
+| Broad Toolbox route suite | SKIP | The scoped change only updates group color validation; the targeted group-color Playwright test was run. |
+| Admin runtime Playwright | SKIP | Admin runtime behavior was unchanged; Admin relevance was covered by the existing group-color test reading Admin Tool Votes assignments. |
 
 ## Manual Test Notes
 
-No separate manual browser walkthrough was required after targeted Playwright. The tests opened API-backed local pages and verified Admin/My Stuff menu placement and route visibility through the rendered header.
+No separate manual walkthrough was required after the targeted Playwright test. Build/Create group labels now validate against the Theme V2 `--red` value through `--toolbox-group-build-color`.

docs_build/dev/reports/toolbox-group-color-restore-report.md

@@ -12,7 +12,7 @@
 | --- | --- | --- |
 | Restore `toolbox/index.html` group values to match Admin Tool Votes. | PASS | Playwright reads Admin Tool Votes rows from `admin/tool-votes.html`, then verifies every visible Toolbox card group label matches the Admin assignment. |
 | Use `admin/tool-votes.html` as source for current correct assignment. | PASS | Targeted Playwright extracts `Tool -> Group` from `[data-toolbox-votes-tool-id]` rows and compares it with `[data-toolbox-tool-card]` group labels. |
-| Restore Toolbox group colors to pre-voting/filter values. | PASS | `assets/theme-v2/css/colors.css` now owns `--toolbox-group-*` colors; Build/Create is restored to recovered `#ff4d4d`. |
+| Restore Toolbox group colors to pre-voting/filter values. | PASS | Superseded by PR_26160_082: `assets/theme-v2/css/colors.css` now routes Build/Create through `--toolbox-group-build-color: var(--red)`. |
 | Recover prior group color values from git history. | PASS | Source: `git show a3bc4016e:toolbox/tools-page-accordions.js` and `git show a3bc4016e:assets/theme-v2/css/colors.css`; `a3bc4016e` is the pre-PR_26160_055 recovery point. |
 | Keep group as metadata, not status. | PASS | Group mapping remains separate from `stateSwatchMap` and release channel/status code. |
 | Do not change tool status values or vote behavior. | PASS | No registry status/release/vote logic was changed. |
@@ -27,13 +27,13 @@ Recovered from git history at `a3bc4016e` (`PR_26159_054-toolbox-status-and-disp
 | --- | --- | --- |
 | AI | `swatch-purple` / `var(--purple)` | `rgb(184, 119, 255)` |
 | Audio | `swatch-orange` / `var(--orange)` | `rgb(255, 122, 0)` |
-| Build/Create | historical `swatch-red` when `--red` was `#ff4d4d` | `rgb(255, 77, 77)` |
+| Build/Create | `--toolbox-group-build-color: var(--red)` | `rgb(255, 45, 45)` |
 | Design | `swatch-pink` / `var(--pink)` | `rgb(255, 79, 139)` |
 | Marketplace | `swatch-gold` / `var(--gold)` | `rgb(255, 200, 87)` |
 | Platform | `swatch-blue` / `var(--electric-blue)` | `rgb(77, 163, 255)` |
 | Play | `swatch-green` / `var(--green)` | `rgb(125, 217, 87)` |
 
-Note: PR_26160_061 intentionally changed the global Theme V2 `--red` token to `#ff2d2d`. This PR restores Toolbox group color display without reverting that global token by adding group-specific Theme V2 tokens such as `--toolbox-group-build-color: #ff4d4d`.
+Note: PR_26160_082 supersedes the prior recovered literal and keeps Build/Create on the Theme V2 SSoT path: `--toolbox-group-build-color: var(--red)`.
 
 ## Validation
 
@@ -42,7 +42,7 @@ Note: PR_26160_061 intentionally changed the global Theme V2 `--red` token to `#
 | Branch guard | `git branch --show-current` | PASS |
 | Changed-file syntax | `node --check toolbox/tools-page-accordions.js`; `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs` | PASS |
 | Inline handler/style/script audit | `rg --pcre2 "onclick=|onchange=|oninput=|style=|<script(?![^>]+src=)|<style[\s>]" toolbox/index.html admin/tool-votes.html` | PASS |
-| Group color token audit | `Select-String -Path assets/theme-v2/css/colors.css -Pattern '--toolbox-group-build-color|#ff4d4d|--red:'` | PASS |
+| Group color token audit | `Select-String -Path assets/theme-v2/css/colors.css -Pattern '--toolbox-group-build-color|--red:'` | PASS |
 | Targeted Toolbox/Admin group Playwright | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox group labels match"` | PASS |
 | Static diff check | `git diff --check` | PASS with CRLF normalization warnings only |
 
@@ -58,7 +58,7 @@ Full samples validation was skipped because this PR only changes Toolbox group d
 
 - Admin Tool Votes remains the source for `Tool -> Group` assignment.
 - Toolbox cards show the same group names as Admin Tool Votes.
-- Build/Create group badges render the recovered pre-voting red `rgb(255, 77, 77)`.
+- Build/Create group badges render through `--toolbox-group-build-color: var(--red)`.
 - Marketplace and Play group badges keep the previous readable dark text behavior.
 
 ## Artifact

tests/playwright/tools/ToolboxRoutePages.spec.mjs

@@ -599,7 +599,7 @@ test("toolbox group labels match Admin Tool Votes assignments and restored group
     const expectedGroupColors = {
       "AI": "rgb(184, 119, 255)",
       "Audio": "rgb(255, 122, 0)",
-      "Build/Create": "rgb(255, 77, 77)",
+      "Build/Create": "rgb(255, 45, 45)",
       "Design": "rgb(255, 79, 139)",
       "Marketplace": "rgb(255, 200, 87)",
       "Platform": "rgb(77, 163, 255)",
@@ -608,6 +608,17 @@ test("toolbox group labels match Admin Tool Votes assignments and restored group
     for (const [groupName, expectedColor] of Object.entries(expectedGroupColors)) {
       await expect(page.locator(`[data-toolbox-group-label='${groupName}']`).first()).toHaveCSS("background-color", expectedColor);
     }
+    const buildColorTokens = await page.evaluate(() => {
+      const styles = getComputedStyle(document.documentElement);
+      return {
+        build: styles.getPropertyValue("--toolbox-group-build-color").trim(),
+        red: styles.getPropertyValue("--red").trim(),
+      };
+    });
+    expect(buildColorTokens).toEqual({
+      build: "#ff2d2d",
+      red: "#ff2d2d",
+    });
     await expect(page.locator("[data-toolbox-group-label='Marketplace']").first()).toHaveCSS("color", "rgb(9, 11, 15)");
     await expect(page.locator("[data-toolbox-group-label='Play']").first()).toHaveCSS("color", "rgb(9, 11, 15)");