Skip to content

Commit dac82e2

Browse files
committed
PR_26174_ALFA_013-remove-open-games-wrapper
1 parent 5101889 commit dac82e2

9 files changed

Lines changed: 108 additions & 20 deletions

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ Branch Validation: PASS
33
PASS - Current branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
44
PASS - Expected branch is pr/26174-ALFA-013-game-hub-game-row-child-rows.
55
PASS - Branch remains stacked on PR_26174_ALFA_012.
6-
PASS - Owner-updated docs_build/dev/ProjectInstructions/addendums/table_first_ui.md was reviewed as instruction content and left unstaged.
6+
PASS - Owner-updated docs_build/dev/ProjectInstructions/addendums/table_first_ui.md is committed on this branch and used as the parent/child table reference.
77
PASS - Work stayed scoped to Game Hub row rendering, targeted Playwright expectations, and required reports.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Manual Validation Notes: PASS
33
- Reviewed docs_build/dev/ProjectInstructions/addendums/table_first_ui.md as the owner-updated table-first reference.
44
- Compared Game Hub against the Idea Board parent row plus expanded child row pattern.
55
- Confirmed Game Hub no longer renders standalone Source Idea, Game Foundation, or Readiness Output panel/card sections.
6+
- Confirmed Game Hub no longer uses an Open Games wrapper/accordion or Open Games table wrapper.
67
- Confirmed expanding a game creates exactly two child rows: Source Idea, then Readiness Output.
78
- Confirmed Source Idea remains read-only and the readiness rows use existing service-contract output.
89
- Confirmed safe empty and unavailable state checks still pass.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ PASS - Game row is the parent row.
55
PASS - Source Idea is a child row/table under the game row.
66
PASS - Readiness Output is a child row/table under the game row.
77
PASS - Source Idea and Readiness Output are no longer separate card/panel sections.
8+
PASS - Open Games wrapper/accordion is not used.
89
PASS - Open Games wrapper/table identity is not used.
910
PASS - Game rows expand/collapse.
1011
PASS - Expanded game rows show Source Idea first and Readiness Output second.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,5 @@ Result: 5 passed.
77
2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
88
Result: 1 passed.
99

10-
3. git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
10+
3. git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs docs_build/dev/reports/codex_review.diff docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt
1111
Result: PASS.

docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Correct Game Hub so each game is the parent row and Source Idea plus Readiness O
77
## Summary
88

99
- Applied the updated table_first_ui.md guidance and matched the Idea Board parent-row/expanded-child-row pattern.
10+
- Removed the Open Games wrapper/accordion from the Game Hub page.
1011
- Removed the Open Games wrapper/table identity from the Game Hub list table.
1112
- Removed standalone Source Idea, Game Foundation, and Readiness Output panel/card sections.
1213
- Kept Source Idea and Readiness Output as the two expanded child rows under each game parent row.
@@ -16,4 +17,4 @@ Correct Game Hub so each game is the parent row and Source Idea plus Readiness O
1617

1718
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub shows a creator-safe empty state|Game Hub shows a creator-safe unavailable state|Game Hub readiness child rows update from mock game state"`
1819
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
19-
PASS - `git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
20+
PASS - `git diff --check -- toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs docs_build/dev/reports/codex_review.diff docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows.md docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-branch-validation.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-requirement-checklist.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-validation-lane.txt docs_build/dev/reports/PR_26174_ALFA_013-game-hub-game-row-child-rows-manual-validation-notes.txt`

docs_build/dev/reports/codex_changed_files.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
docs_build/dev/ProjectInstructions/addendums/table_first_ui.md
12
toolbox/game-hub/index.html
23
toolbox/game-hub/game-hub.js
34
tests/playwright/tools/GameHubMockRepository.spec.mjs

0 commit comments

Comments
 (0)