Skip to content

Commit df0093d

Browse files
committed
Close Toolbox image UI display gaps - PR_26156_114-117-tool-image-ui-closeout & Make Toolbox tool names link directly to tool pages - PR_26156_118-toolbox-name-link-navigation
1 parent e06d40a commit df0093d

41 files changed

Lines changed: 461 additions & 211 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

docs_build/dev/codex_commands.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,3 +561,32 @@ Required reports:
561561
- `docs_build/dev/reports/testing_lane_execution_report.md`
562562
- `docs_build/dev/reports/codex_changed_files.txt`
563563
- `docs_build/dev/reports/codex_review.diff`
564+
565+
566+
## PR_26156_114-117
567+
568+
Changes:
569+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
570+
- Fixed Toolbox card image UI behavior after the asset coverage closeout.
571+
- Kept Toolbox card preview images registry-backed through approved `/assets/theme-v2/images/tools/` paths.
572+
- Converted Toolbox card badges from `<object>` to registry-backed `<img>` elements through approved `/assets/theme-v2/images/badges/` paths.
573+
- Added registry diagnostics for missing/invalid badge and tool image mappings.
574+
- Added visible Toolbox card diagnostics when a preview or badge image falls back to `/assets/theme-v2/images/image-missing.svg`.
575+
- Added targeted Playwright/MSJ coverage for registry diagnostics and visible card-level missing-image diagnostics.
576+
- Did not add or modify CSS.
577+
- Did not modify `start_of_day`.
578+
579+
Validation:
580+
- `node --check toolbox/toolRegistry.js`
581+
- `node --check toolbox/tools-page-accordions.js`
582+
- `node --check tests/playwright/tools/ToolImageRegistry.spec.mjs`
583+
- `npm run test:lane:tool-images`
584+
- Scoped `git diff --check` for changed implementation/test/report files.
585+
- Targeted changed-file scan confirmed no local CSS, inline styles, script blocks, page-local image logic, `<object>` badge usage, `start_of_day` references, or size-suffix image registry paths were introduced.
586+
- Full samples smoke: skipped by request.
587+
588+
Required reports:
589+
- `docs_build/dev/reports/tool-image-ui-closeout-report.md`
590+
- `docs_build/dev/reports/testing_lane_execution_report.md`
591+
- `docs_build/dev/reports/codex_changed_files.txt`
592+
- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Close Toolbox image asset coverage gaps - PR_26156_110-113-tool-image-assets-closeout
1+
Close Toolbox image UI diagnostics - PR_26156_114-117-tool-image-ui-closeout

docs_build/dev/reports/coverage_changed_js_guardrail.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ Missing changed runtime JS files are WARN, not FAIL.
66
Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
77

88
Changed runtime JS files considered:
9-
(83%) toolbox/toolRegistry.js - executed lines 1574/1574; executed functions 24/29
9+
(66%) toolbox/tools-page-accordions.js - executed lines 1869/1869; executed functions 40/61
10+
(88%) toolbox/toolRegistry.js - executed lines 1598/1598; executed functions 28/32
1011

1112
Guardrail warnings:
1213
(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/dependency_gating_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Gating Report
22

3-
Generated: 2026-06-05T12:10:07.498Z
3+
Generated: 2026-06-05T12:32:34.997Z
44
Status: PASS
55

66
## Gate Order
@@ -20,9 +20,9 @@ Status: PASS
2020
| game-configuration | No | SKIP | none | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2121
| build-path | No | SKIP | none | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2222
| tools-progress | No | SKIP | none | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
23-
| tool-navigation | No | SKIP | none | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
23+
| tool-navigation | Yes | PASS | none | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | Lane has no lane dependencies and is eligible after preflight and compilation pass. |
2424
| tool-display-mode | No | SKIP | none | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
25-
| tool-images | Yes | PASS | none | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | Lane has no lane dependencies and is eligible after preflight and compilation pass. |
25+
| tool-images | No | SKIP | none | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2626
| tool-runtime | No | SKIP | none | Active public toolbox and Tool Template V2 contract | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2727
| game-runtime | No | SKIP | none | Deprecated archive/v1-v2/games reference coverage | Lane was not selected, so dependency-gated runtime scheduling skipped it. |
2828
| integration | No | SKIP | none | Integration handoff behavior | Lane was not selected, so dependency-gated runtime scheduling skipped it. |

docs_build/dev/reports/dependency_hydration_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Dependency Hydration Reuse Report
22

3-
Generated: 2026-06-05T12:10:07.499Z
3+
Generated: 2026-06-05T12:32:34.998Z
44
Status: PASS
55

66
## Summary
@@ -16,7 +16,7 @@ Prevented fixture ownership traversal: 0
1616

1717
| Lane | Status | Helpers | Fixtures | Imports | Dependency Hydration Hash | Reason |
1818
| --- | --- | --- | --- | --- | --- | --- |
19-
| tool-images | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs; toolbox/toolRegistry.js | b3b85748c9818b68 | Dependency hydration was refreshed after warm-start invalidation. |
19+
| tool-navigation | INVALIDATED | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs | none | tests/helpers/playwrightRepoServer.mjs; tests/helpers/playwrightStorageIsolation.mjs; tests/helpers/playwrightV8CoverageReporter.mjs; tests/helpers/workspaceV2CoverageReporter.mjs; toolbox/toolRegistry.js | 0074b6ff936b5572 | Dependency hydration was refreshed after warm-start invalidation. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/execution_graph_reuse_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Execution Graph Reuse Report
22

3-
Generated: 2026-06-05T12:10:07.499Z
3+
Generated: 2026-06-05T12:32:34.998Z
44
Status: PASS
55

66
## Summary
@@ -16,7 +16,7 @@ Prevented targeted scheduling work: 0
1616

1717
| Lane | Status | Snapshot Status | Execution Graph Hash | Reason |
1818
| --- | --- | --- | --- | --- |
19-
| tool-images | INVALIDATED | INVALIDATED | eb160af57e1ec65e | Lane snapshot is part of the selected targeted execution graph. |
19+
| tool-navigation | INVALIDATED | INVALIDATED | 7c80d9ed012db476 | Lane snapshot is part of the selected targeted execution graph. |
2020

2121
## Safeguards
2222

docs_build/dev/reports/failure_fingerprint_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Failure Fingerprint Report
22

3-
Generated: 2026-06-05T12:10:24.668Z
3+
Generated: 2026-06-05T12:32:34.998Z
44
Status: PASS
55

66
## Summary

docs_build/dev/reports/filesystem_scan_reduction_report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Filesystem Scan Reduction Report
22

3-
Generated: 2026-06-05T12:10:07.479Z
3+
Generated: 2026-06-05T12:32:34.965Z
44
Status: PASS
55

66
## Scan Enforcement

docs_build/dev/reports/incremental_validation_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Incremental Validation Report
22

3-
Generated: 2026-06-05T12:10:07.500Z
3+
Generated: 2026-06-05T12:32:34.998Z
44
Status: PASS
55

66
## Reuse Summary
@@ -18,7 +18,7 @@ Prevented fixture resolution passes: 0
1818

1919
| Lane | Decision | Invalidated By | Runtime Savings Observation |
2020
| --- | --- | --- | --- |
21-
| tool-images | INVALIDATED | Persistent manifest dependency graph hash changed for tool-images.; Persistent manifest input hash changed for tool-images.; Persistent manifest hash changed for tool-images. | Manifest was regenerated or skipped; no reuse savings for this lane. |
21+
| tool-navigation | INVALIDATED | Persistent manifest lane definition hash changed for tool-navigation. | Manifest was regenerated or skipped; no reuse savings for this lane. |
2222

2323
## Invalidation Rules
2424

docs_build/dev/reports/lane_compilation_report.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Lane Compilation Report
22

3-
Generated: 2026-06-05T12:10:07.498Z
3+
Generated: 2026-06-05T12:32:34.997Z
44
Status: PASS
55

66
## Lane Graph
@@ -13,9 +13,9 @@ Status: PASS
1313
| game-configuration | SKIP | Game Configuration mock repository, Game Design handoff, configuration validation, user-facing output, and Toolbox progress handoff | tests/playwright/tools/GameConfigurationMockRepository.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/GameConfigurationMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
1414
| build-path | SKIP | Toolbox Build Path simplification, workflow status table, and Admin Tools Progress navigation | tests/playwright/tools/BuildPathProgressSimplification.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/BuildPathProgressSimplification.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
1515
| tools-progress | SKIP | Admin Tools Progress hydration, Toolbox Group view color model, and Project Build Path separation | tests/playwright/tools/ToolsProgressHydration.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolsProgressHydration.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
16-
| tool-navigation | SKIP | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | tests/playwright/tools/ToolNavigationPrevNext.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
16+
| tool-navigation | PASS | Admin Tools Progress tool route links, Tool Display Mode build-order previous/next controls, and Toolbox group fallback routing | tests/playwright/tools/ToolNavigationPrevNext.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs --project=playwright --workers=1 --reporter=list | Lane graph, command shape, targets, fixtures, and ownership compile before runtime. |
1717
| tool-display-mode | SKIP | Tool Display Mode identity row, registry-owned previous/next links, disabled text fallback, and multi-path group routing | tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
18-
| tool-images | PASS | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | tests/playwright/tools/ToolImageRegistry.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolImageRegistry.spec.mjs --project=playwright --workers=1 --reporter=list | Lane graph, command shape, targets, fixtures, and ownership compile before runtime. |
18+
| tool-images | SKIP | Toolbox registry image contract, Toolbox card image rendering, and Tool Display Mode image fallback | tests/playwright/tools/ToolImageRegistry.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/ToolImageRegistry.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
1919
| tool-runtime | SKIP | Active public toolbox and Tool Template V2 contract | tests/playwright/tools/RootToolsFutureState.spec.mjs | C:\nvm4w\nodejs\node.exe C:\Users\davidq\Documents\GitHub\HTML-JavaScript-Gaming\node_modules\@playwright\test\cli.js test tests/playwright/tools/RootToolsFutureState.spec.mjs --project=playwright --workers=1 --reporter=list | Lane was not selected. |
2020
| game-runtime | SKIP | Deprecated archive/v1-v2/games reference coverage | none | none | Lane was not selected. |
2121
| integration | SKIP | Integration handoff behavior | none | none | Lane was not selected. |

0 commit comments

Comments
 (0)