Skip to content

Commit e83a299

Browse files
committed
Polish Input Mapping V2 combo token actions - PR_26140_109-polish-input-mapping-v2-combo-token-actions
1 parent 7d38366 commit e83a299

6 files changed

Lines changed: 260 additions & 46 deletions

File tree

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# Input Mapping V2 Combo Token Actions Report
2+
3+
Task: PR_26140_109-polish-input-mapping-v2-combo-token-actions
4+
5+
## Source Reading
6+
- Read `docs/dev/PROJECT_INSTRUCTIONS.md` before making changes.
7+
- Read `.codex/skills/repo-build/SKILL.md` and followed the repo BUILD workflow requirements.
8+
- Read `docs/pr/BUILD_PR.md`; it still describes an unrelated overlay runtime hardening build, so the explicit PR109 request was used as the active build scope.
9+
10+
## Implementation
11+
- Added per-token deletion for Captured Mappings tiles. Clicking or keyboard-activating a mapping token removes only that token and keeps the action tile selected.
12+
- Preserved combo capture as an exact two-input flow by default. The first input shows in-progress feedback and the second input commits one combo mapping.
13+
- Removed visible square brackets from token text while keeping comma-separated token content inside the span.
14+
- Set captured mapping token width to 250px and kept hover/title metadata intact.
15+
- Made mapping cards vertically scroll when mappings overflow and preserved the selected tile `scrollTop` across rerenders for selection, refresh, token deletion, and combo commits.
16+
- Preserved capture gating from PR108, selected tile indication, used-input highlighting, and existing combo/cross-device behavior.
17+
18+
## Constraints
19+
- No schema changes were made.
20+
- No sample JSON files were touched.
21+
- Workspace V2 launch behavior was preserved.
22+
23+
## Validation
24+
- `node --check tools/input-mapping-v2/js/ToolStarterApp.js`
25+
- `node --check tools/input-mapping-v2/js/controls/PreviewPanelControl.js`
26+
- `node --check tools/input-mapping-v2/js/services/InputMappingState.js`
27+
- `node --check tests/playwright/tools/WorkspaceManagerV2.spec.mjs`
28+
- `npx playwright test tests/playwright/tools/WorkspaceManagerV2.spec.mjs -g "Input Mapping V2"`: 7 passed.
29+
- `npm run test:workspace-v2`: 66 passed.
30+
- `git diff --check`: passed; PowerShell reported line-ending normalization warnings only.
31+
32+
Full samples smoke test was not run, per instruction.

0 commit comments

Comments
 (0)