Split Palette user-defined swatches from project color tags - PR_26156_176-palette-tag-and-editor-split

Author: ToolboxAid

docs_build/dev/reports/palette-tag-and-editor-split-report.md

@@ -0,0 +1,67 @@
+# PR_26156_176 Palette Tag and Editor Split Report
+
+## Result
+PASS
+
+## Summary
+- Split selected Palette Colors tag editing from user-defined swatch base-value editing.
+- Swatch Editor now mirrors the selected project palette swatch with disabled Symbol, Hex, and Name fields, and only enables custom Tags when a project palette swatch is selected.
+- User Defined Swatch now owns Symbol, Hex, and Name creation/update controls and does not expose Tags.
+- Removed Swatch Editor Add Swatch, Update Selected, Remove Selected, and Clear Form actions.
+- Project palette tags are persisted only on palette color records through explicit user tag entry or tag deletion.
+
+## Tag Behavior
+- Manual Add Swatch starts with empty tags even if any tag text exists elsewhere.
+- Update Selected preserves existing project palette tags and does not read tag input.
+- Source palette pins, Pin All, and harmony pins continue to add user palette colors with empty tags.
+- Rendered tags use existing compact Theme V2 button styling inside an action group.
+- Clicking a rendered tag removes only that tag from the selected project palette color.
+- Pressing Enter in the tag input adds only the normalized user-entered tag.
+
+## Swatch Editor
+- Symbol, Hex, and Name are disabled/read-only mirror fields.
+- Tags are enabled only when a project palette color is selected.
+- With no selected swatch, Symbol, Hex, Name, and Tags are blank and disabled.
+- No stale selected swatch data remains after removing the selected palette color through the pin/dot behavior.
+
+## User Defined Swatch
+- Added a new User Defined Swatch accordion copied from the previous editor structure.
+- Contains Symbol, Hex, and Name only.
+- Keeps Add Swatch, Update Selected, and Clear Form actions for base swatch values.
+- Does not contain Tags or Remove Selected.
+
+## Theme V2
+- No new CSS was added.
+- No Theme V2 gap was identified; existing form, action-group, and compact button classes were sufficient.
+
+## Validation
+- `node --check toolbox/colors/colors.js`
+  - PASS
+- `node --check toolbox/colors/palette-workspace-repository.js`
+  - PASS
+- `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS
+- `rg "style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `rg "readEditorForm|fillEditorForm|clearEditorForm|validateEditor|tagsFromText|elements\\.remove|data-palette-remove" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `rg "DEFAULT_SOURCE_PALETTES" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
+  - PASS, 3 tests
+- `npm run test:playwright:static`
+  - PASS
+
+## Verification Coverage
+- Copied/pinned source colors do not inherit source tags.
+- Harmony-pinned colors do not inherit harmony/source tags.
+- User tags render side by side and click-to-delete updates the project palette color record.
+- Enter adds a custom user tag only.
+- Swatch Editor has no Add, Update, Remove, or Clear actions.
+- Swatch Editor only allows tags when a Palette Colors swatch is selected.
+- Symbol, Hex, and Name are disabled in Swatch Editor.
+- Blank/disabled no-selection state is visible after selected color removal.
+- User Defined Swatch accordion exists with Symbol, Hex, and Name but no Tags.
+
+## Skipped
+- Full samples smoke was not run, per BUILD instruction.

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -17,23 +17,23 @@ Exercised tool entry points detected:
 (83%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1150/1150; executed functions 111/128
-(95%) toolbox/colors/colors.js - executed lines 734/734; executed functions 73/77
+(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1190/1190; executed functions 113/130
+(95%) toolbox/colors/colors.js - executed lines 776/776; executed functions 75/79
 
 Files with executed line/function counts where available:
 (65%) toolbox/project-workspace/project-workspace-mock-repository.js - executed lines 402/402; executed functions 20/31
 (75%) toolbox/toolRegistry.js - executed lines 1754/1754; executed functions 27/36
 (80%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 205/205; executed functions 16/20
 (87%) assets/theme-v2/js/tool-display-mode.js - executed lines 201/201; executed functions 13/15
-(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1150/1150; executed functions 111/128
-(95%) toolbox/colors/colors.js - executed lines 734/734; executed functions 73/77
+(87%) toolbox/colors/palette-workspace-repository.js - executed lines 1190/1190; executed functions 113/130
+(95%) toolbox/colors/colors.js - executed lines 776/776; executed functions 75/79
 (100%) toolbox/colors/palette-source-mock-db.js - executed lines 927/927; executed functions 6/6
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/PaletteToolMockRepository.spec.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs - changed JS file not collected as browser runtime coverage
 (87%) toolbox/colors/palette-workspace-repository.js - changed JS file with browser V8 coverage
 (95%) toolbox/colors/colors.js - changed JS file with browser V8 coverage

docs_build/dev/reports/testing_lane_execution_report.md

@@ -1,4 +1,4 @@
-# PR_26156_175 Testing Lane Execution Report
+# PR_26156_176 Testing Lane Execution Report
 
 ## Result
 PASS
@@ -10,12 +10,12 @@ PASS
   - PASS
 - `node --check tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
   - PASS
-- `node --check tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs`
-  - PASS
-- `rg "style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js assets/theme-v2/css/layout.css assets/theme-v2/css/accordion.css assets/theme-v2/css/panels.css tests/playwright/tools/PaletteToolMockRepository.spec.mjs tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs`
+- `rg "style=|<style|onclick|onchange|oninput|onsubmit" toolbox/colors/index.html toolbox/colors/colors.js toolbox/colors/palette-workspace-repository.js tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `rg "readEditorForm|fillEditorForm|clearEditorForm|validateEditor|tagsFromText|elements\\.remove|data-palette-remove" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
+  - PASS, no matches
+- `rg "DEFAULT_SOURCE_PALETTES" toolbox/colors tests/playwright/tools/PaletteToolMockRepository.spec.mjs`
   - PASS, no matches
-- `npx playwright test tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs --project=playwright --workers=1 --reporter=list`
-  - PASS, 1 test
 - `npx playwright test tests/playwright/tools/PaletteToolMockRepository.spec.mjs --project=playwright --workers=1 --reporter=list`
   - PASS, 3 tests
 - `npm run test:playwright:static`
@@ -24,37 +24,36 @@ PASS
   - PASS
 
 ## Required Lanes
-- Targeted shared Tool Center fullscreen UI lane: PASS.
 - Targeted Palette Tool runtime/UI lane: PASS.
 - Changed-file/static validation: PASS.
 
 ## Playwright Coverage
-- Palette fullscreen center panel overflow remains hidden so page-level center scrolling is disabled: PASS.
-- Palette Active Project Palette and Source Palette Browser split fullscreen vertical space evenly when both are expanded: PASS.
-- Palette swatch wrappers scroll while summaries and control rows stay fixed: PASS.
-- Publish Tool Center direct accordions split fullscreen vertical space evenly when both are expanded: PASS.
-- Publish Tool Center direct accordion body scrolls while summary remains fixed: PASS.
-- Collapsing one Publish Tool Center accordion expands the remaining open accordion: PASS.
-- Palette selected summary omits the swatch symbol: PASS.
 - Source-pinned user Palette Colors start with empty tags: PASS.
 - Harmony-pinned user Palette Colors start with empty tags: PASS.
-- Harmony swatches use red/green pin state and click-to-add/click-to-remove behavior: PASS.
-- Harmony Add All skips duplicates: PASS.
+- Manual Add Swatch starts user tags empty: PASS.
+- Rendered user tags appear side by side: PASS.
+- Clicking a rendered tag deletes it from the selected project palette color: PASS.
+- Pressing Enter adds only the user-entered tag: PASS.
+- Swatch Editor has disabled Symbol, Hex, and Name mirror fields: PASS.
+- Swatch Editor enables Tags only when a Palette Colors swatch is selected: PASS.
+- Swatch Editor has no Add, Update, Remove, or Clear actions: PASS.
+- User Defined Swatch has Symbol, Hex, and Name and no Tags: PASS.
+- Selected swatch removal clears selected editor fields and disables Tags: PASS.
 
 ## Impacted Lane
 - Palette Tool runtime/UI lane.
-- Shared Tool Center fullscreen UI lane.
-- Theme V2 static validation for reusable fullscreen accordion and Tool Center panel layout classes.
+- Changed-file/static validation lane.
 
 ## Skipped Lanes
 - Full samples smoke was skipped by BUILD instruction.
-- Broader tool lanes were skipped because changes are confined to Palette Tool swatch/harmony behavior, reusable Theme V2 Tool Center fullscreen layout, and targeted specs for those surfaces.
+- Shared Tool Center fullscreen UI lane was skipped because PR176 did not modify shared Tool Center or Theme V2 layout behavior.
+- Broader tool lanes were skipped because changes are confined to Palette Tool tag/editor behavior and the targeted Palette spec covers the changed runtime/UI paths.
 
 ## Not Run
 - Full samples smoke was not run, per BUILD instruction.
 
 ## Notes
-- A broader exploratory run of `tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs` failed existing identity-row copy expectations unrelated to this PR. The required shared Tool Center fullscreen lane was covered by `tests/playwright/tools/ToolCenterFullscreenAccordion.spec.mjs`, which passed.
+- Static validation generated companion reports during the run; non-required generated companion report updates were reverted so the PR remains scoped to the requested report artifacts.
 
 ## Coverage Artifact
 - Final V8 coverage artifact: `docs_build/dev/reports/playwright_v8_coverage_report.txt`.