Remove duplicate Objects Type Choices section - PR_26161_015-objects-remove-type-choices

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,18 +1,18 @@
 # git status --short
 M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
  M tests/playwright/tools/ObjectsTool.spec.mjs
  M toolbox/objects/index.html
-?? docs_build/dev/reports/objects-beta-promotion-and-catalog-relocation-report.md
+ M toolbox/objects/objects.js
+?? docs_build/dev/reports/objects-remove-type-choices-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/objects-beta-promotion-and-catalog-relocation-report.md
+docs_build/dev/reports/objects-remove-type-choices-report.md
 
 # git diff --stat
-.../dev/reports/coverage_changed_js_guardrail.txt  |  3 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |  4 +-
- .../guest-seeds/tool-metadata-inventory.js         | 21 +++++-----
- tests/playwright/tools/ObjectsTool.spec.mjs        | 45 ++++++++++++++++++----
- toolbox/objects/index.html                         | 22 +++++++----
- 5 files changed, 70 insertions(+), 25 deletions(-)
+docs_build/dev/reports/coverage_changed_js_guardrail.txt |  2 +-
+ docs_build/dev/reports/playwright_v8_coverage_report.txt |  8 ++++----
+ tests/playwright/tools/ObjectsTool.spec.mjs              | 14 +++++++++++---
+ toolbox/objects/index.html                               |  7 -------
+ toolbox/objects/objects.js                               |  2 +-
+ 5 files changed, 17 insertions(+), 16 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -7,7 +7,7 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
+(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
 
 Guardrail warnings:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,78 @@
+# PR_26161_015 Objects Remove Type Choices Report
+
+## Branch Validation
+
+PASS
+
+- Current branch: `main`
+- Expected branch: `main`
+- Worktree was clean before PR_26161_015 edits.
+
+## Scope
+
+- Impacted lane: Objects tool UI/runtime and targeted Objects Playwright coverage.
+- Playwright impacted: Yes.
+- Runtime engine behavior changed: No.
+- Samples validation: Skipped as requested. No sample JSON, auth behavior, production DB behavior, engine runtime behavior, or unrelated tool behavior changed.
+
+## Requirement Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Verified current git branch was `main` before edits.
+- PASS: Removed the duplicate visible `Type Choices` section from Objects.
+- PASS: Kept `Object Type Catalog` as the single visible reference list for object templates and capabilities.
+- PASS: Kept the catalog display limited to `Template` and `Capability`.
+- PASS: Preserved object template/type values in the underlying registry, validator, row type dropdown, and footer template selector.
+- PASS: Preserved Render, State, Asset, Sprite linking, DB persistence, and table editing behavior.
+- PASS: Kept Events integration framed as future behavior/event configuration by updating the user-facing Events action title to `Events configure when object behavior happens.`
+- PASS: Preserved Objects beta status.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only and preserved HTML restrictions.
+
+## Testing Performed
+
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: `git diff --check`
+  - Result: PASS. Git reported line-ending normalization warnings only.
+- PASS: `rg --pcre2 -n '<script(?![^>]*\bsrc=)|<style\b|\son[a-z]+\s*=' toolbox/objects/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `rg -n 'Type Choices|data-objects-type-basics' toolbox/objects/index.html`
+  - Expected no matches; command exited with no matches.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line`
+  - Result: 6 passed.
+
+## Playwright Behavior Covered
+
+- PASS: `Type Choices` no longer appears in the primary Objects UI.
+- PASS: `Object Type Catalog` remains visible.
+- PASS: Catalog headers remain `Template` and `Capability` only.
+- PASS: Events is not exposed as an object template/type in the catalog.
+- PASS: Footer template selector still offers object templates and can prefill active rows.
+- PASS: Row type dropdown still offers object type values.
+- PASS: Add, edit, delete, reset, and DB persistence after reload still work.
+- PASS: Sprite asset creation/resolution and linked sprite asset display still work.
+- PASS: Objects remains a clickable beta tool from Toolbox.
+
+## Playwright V8 Coverage
+
+- Report: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Changed runtime JavaScript coverage notes:
+  - `(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105`
+  - `(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only`
+- The advisory warning is safe for this PR because PR_26161_015 did not modify `src/dev-runtime/guest-seeds/tool-metadata-inventory.js`; this change only touched Objects UI/runtime, Objects Playwright coverage, and generated reports.
+
+## Manual Validation Steps
+
+1. Open `/toolbox/objects/index.html`.
+2. Confirm the left Objects panel shows `Object Setup` and `Object Type Catalog`, with no `Type Choices` section.
+3. Confirm the Object Type Catalog table shows only `Template` and `Capability`.
+4. Use the table footer template selector to choose `Hero`, then click `Add Object` and confirm the active row is prefilled.
+5. Save a Sprite object, reload the Objects page, and confirm the row plus linked sprite asset remain.
+6. Confirm `Open Events` is presented as event configuration for when object behavior happens, not as an object type.
+
+## Skipped Lanes
+
+- Full samples validation: SKIP, explicitly requested and no samples changed.
+- Broad workspace/project suite: SKIP, no shared Project Workspace contract, engine runtime behavior, public navigation behavior, auth behavior, production DB behavior, or sample behavior changed.
+- Full registry suite: SKIP, registry and validator values were intentionally preserved; targeted Objects Playwright validates row type/template dropdown behavior.

docs_build/dev/reports/objects-remove-type-choices-report.md

@@ -12,13 +12,13 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(86%) Toolbox Index - exercised 6 runtime JS files
+(85%) Toolbox Index - exercised 6 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
+(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
 
 Files with executed line/function counts where available:
 (33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
@@ -32,7 +32,7 @@ Files with executed line/function counts where available:
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
 (86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(94%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 99/105
+(93%) toolbox/objects/objects.js - executed lines 1107/1107; executed functions 98/105
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
@@ -43,4 +43,4 @@ Uncovered or low-coverage changed JS files:
 Changed JS files considered:
 (0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ObjectsTool.spec.mjs - changed JS file not collected as browser runtime coverage
-(94%) toolbox/objects/objects.js - changed JS file with browser V8 coverage
+(93%) toolbox/objects/objects.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -156,6 +156,7 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("[data-objects-template-catalog] td:first-child")).toHaveText(TYPE_OPTIONS);
     await expect(page.locator("[data-objects-template-catalog]")).toContainText("Spawn Point");
     await expect(page.locator("[data-objects-template-catalog]")).toContainText("Decoration");
+    await expect(page.locator("[data-objects-template-catalog]")).not.toContainText("Events");
     await expect(page.locator("[data-objects-template-catalog]")).not.toContainText("Sprite");
     await expect(page.locator("[data-objects-template-catalog]")).toContainText("Can Move");
     await expect(page.locator("[data-objects-template-catalog]")).toContainText("Scores Points");
@@ -174,7 +175,8 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     ]);
     await expect(page.locator("[data-objects-list-table] thead")).not.toContainText("Status");
     await expect(page.getByText("Object Types", { exact: true })).toHaveCount(0);
-    await expect(page.locator("[data-objects-type-basics] li")).toHaveText(TYPE_OPTIONS);
+    await expect(page.getByText("Type Choices", { exact: true })).toHaveCount(0);
+    await expect(page.locator("[data-objects-type-basics]")).toHaveCount(0);
     await expect(page.locator("[data-objects-readiness]")).toHaveText("Not Configured");
     await expect(page.locator("[data-objects-output-readiness]")).toHaveText("Not Configured");
     await expect(page.locator("[data-objects-asset-status]")).toHaveText("Not Configured");
@@ -227,7 +229,10 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("[data-objects-row-open-hitboxes]").first()).toHaveClass(/primary/);
     await expect(page.locator("[data-objects-row-open-events]").first()).toHaveClass(/primary/);
     await expect(page.locator("[data-objects-row-open-hitboxes]").first()).toHaveAttribute("title", "Missing Hitbox.");
-    await expect(page.locator("[data-objects-row-open-events]").first()).toHaveAttribute("title", "Missing Events.");
+    await expect(page.locator("[data-objects-row-open-events]").first()).toHaveAttribute(
+      "title",
+      "Missing Events. Events configure when object behavior happens."
+    );
     await expect(page.locator("[data-objects-output-render-asset]")).toHaveText("None");
     await expect(page.locator("[data-objects-edit-sprite]")).toBeHidden();
     await expect(page.locator("[data-objects-output-setup]")).toHaveText("Objects have saved setup details.");
@@ -471,7 +476,10 @@ test("Object Type Catalog selection prefills active table rows", async ({ page }
     await expect(page.locator("[data-objects-row-open-events]")).toHaveClass(/primary/);
     await expect(page.locator("[data-objects-row-edit-sprite]")).toHaveAttribute("title", "Sprite asset ready.");
     await expect(page.locator("[data-objects-row-open-hitboxes]")).toHaveAttribute("title", "Missing Hitbox.");
-    await expect(page.locator("[data-objects-row-open-events]")).toHaveAttribute("title", "Missing Events.");
+    await expect(page.locator("[data-objects-row-open-events]")).toHaveAttribute(
+      "title",
+      "Missing Events. Events configure when object behavior happens."
+    );
     await expect(page.locator("[data-objects-edit-sprite]")).toHaveAttribute(
       "href",
       "/toolbox/sprites/index.html?assetKey=sprite_catalog_hero&objectKey=catalog-hero&sourceTool=objects"

tests/playwright/tools/ObjectsTool.spec.mjs

@@ -55,13 +55,6 @@ <h2>Objects</h2>
                                     </div>
                                 </div>
                             </details>
-                            <details class="vertical-accordion" open>
-                                <summary>Type Choices</summary>
-                                <div class="accordion-body content-stack">
-                                    <p>Types describe each object's setup purpose. Use Custom when a project-specific type is not listed.</p>
-                                    <ul data-objects-type-basics></ul>
-                                </div>
-                            </details>
                         </div>
                     </aside>
                     <div data-tool-display-mode data-asset-root="assets/theme-v2/images" data-tool-slug="objects" data-tool-icon-src="assets/theme-v2/images/badges/objects.png" data-tool-character-src="assets/theme-v2/images/tools/objects.png"></div>

toolbox/objects/index.html

@@ -558,7 +558,7 @@ function rowConfigurationActions(object) {
   const openHitboxes = actionLink("Open Hitboxes", hitboxesHref(object), "objectsRowOpenHitboxes", id, "btn btn--compact primary");
   const openEvents = actionLink("Open Events", eventsHref(object), "objectsRowOpenEvents", id, "btn btn--compact primary");
   openHitboxes.title = "Missing Hitbox.";
-  openEvents.title = "Missing Events.";
+  openEvents.title = "Missing Events. Events configure when object behavior happens.";
   links.push(openHitboxes, openEvents);
   return links;
 }