Skip to content

Commit ed28e3a

Browse files
ToolboxAidToolboxAid
committed
Delete dead branches and deepen SSoT branch review - PR_26159_046-delete-dead-branches-review-ssot
1 parent c0755bb commit ed28e3a

3 files changed

Lines changed: 301 additions & 0 deletions

File tree

‎docs_build/dev/admin-notes/PS_commands.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
2+
- Remove-Item .\directory-name -Recurse -Force
3+
4+
- tree /f

‎docs_build/dev/reports/dead_branch_delete_report.md‎

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,73 @@
1+
# Dead Branch Delete Report
2+
3+
PR: PR_26159_046-delete-dead-branches-review-ssot
4+
Generated: 2026-06-08
5+
Runtime behavior changed: No
6+
Playwright impacted: No
7+
8+
## Branch Guard
9+
10+
| Check | Status | Evidence |
11+
| --- | --- | --- |
12+
| Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` first. | PASS | Project instructions were read before branch deletion. |
13+
| Current branch is `main`. | PASS | `git branch --show-current` returned `main`. |
14+
15+
## Deleted Remote Branches
16+
17+
| Branch | Status | Evidence |
18+
| --- | --- | --- |
19+
| `PR_26159_036-colors-picker-preview-layout` | PASS | Deleted from `origin`; no local or remote-tracking ref remains. |
20+
| `PR_26159_035-colors-picker-layout-tags` | PASS | Deleted from `origin`; no local or remote-tracking ref remains. |
21+
| `recover/70f1301b` | PASS | Deleted from `origin`; no local or remote-tracking ref remains. |
22+
23+
## Preserved Branch
24+
25+
| Branch | Status | Evidence |
26+
| --- | --- | --- |
27+
| `PR_26151_004-gamefoundry-site-structure-ssot` | PASS | Preserved; `git branch -r --list origin/PR_26151_004-gamefoundry-site-structure-ssot` returns `origin/PR_26151_004-gamefoundry-site-structure-ssot`. |
28+
29+
## Validation Evidence
30+
31+
### Local Branches
32+
33+
```text
34+
* main
35+
```
36+
37+
### Deleted Branch Remote-Tracking Query
38+
39+
```text
40+
(none)
41+
```
42+
43+
### Deleted Branch Remote Head Query
44+
45+
```text
46+
(none)
47+
```
48+
49+
### SSoT Remote Head Query
50+
51+
```text
52+
0aee052152b08c519e842e32bb2c1d0b9dca54d5 refs/heads/PR_26151_004-gamefoundry-site-structure-ssot
53+
```
54+
55+
## Commands Run
56+
57+
```text
58+
git push origin --delete PR_26159_036-colors-picker-preview-layout PR_26159_035-colors-picker-layout-tags recover/70f1301b
59+
git fetch --prune origin
60+
git branch -r --list ...
61+
git ls-remote --heads origin ...
62+
```
63+
64+
## Validation Checklist
65+
66+
| Requirement | Status | Evidence |
67+
| --- | --- | --- |
68+
| Validate current branch is main before branch deletion. | PASS | Branch guard returned `main`. |
69+
| Validate three dead branches no longer appear locally. | PASS | Local branch list is only `main`; remote-tracking query for the three dead branches returns none. |
70+
| Validate SSoT branch still exists. | PASS | `origin/PR_26151_004-gamefoundry-site-structure-ssot` remains. |
71+
| Do not merge or cherry-pick anything. | PASS | No merge or cherry-pick command was run. |
72+
| Playwright impacted: No. | PASS | Branch deletion/report-only PR. |
73+
| Do not run full samples validation. | PASS | Skipped because no runtime/sample behavior changed. |

‎docs_build/dev/reports/ssot_branch_deep_review.md‎

Lines changed: 224 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,224 @@
1+
# SSoT Branch Deep Review
2+
3+
PR: PR_26159_046-delete-dead-branches-review-ssot
4+
Branch reviewed: `origin/PR_26151_004-gamefoundry-site-structure-ssot`
5+
Generated: 2026-06-08
6+
Runtime behavior changed: No
7+
Playwright impacted: No
8+
9+
## Branch Position
10+
11+
- Behind main: 338
12+
- Ahead of main: 39
13+
- Changed files not in main: 38
14+
- Local branch was not created.
15+
- Remote branch was preserved.
16+
17+
## Commit Summary
18+
19+
The branch has 39 commits not in main. They break down into these themes:
20+
21+
- Site shell/pathing: shared nav routes, path-aware partial loader, shared shell on home page.
22+
- CSS split: `styles.css` was reduced while new `base.css`, `pages.css`, `tools.css`, and color meaning CSS files were added under `GameFoundryStudio/assets/css/`.
23+
- Page IA: account, arcade, marketplace, learn, community, docs, cloud, publish, tools index, tool builder/creator/publisher, and tool group pages.
24+
- PR artifacts: old `docs/dev` command, commit comment, validation, changed-files, and review diff artifacts.
25+
26+
```text
27+
0aee05215 (origin/PR_26151_004-gamefoundry-site-structure-ssot) Add commit comment for PR_26151_004
28+
25cedf280 Add codex command log for PR_26151_004
29+
ba448e9cf Add validation report for PR_26151_004
30+
c06619ff5 Add codex review diff report for PR_26151_004
31+
829f608ae Add changed files report for PR_26151_004
32+
ef47309bd Restore partial fallback for legacy pages
33+
5e21ad5cf Add organized Tool Publisher page
34+
e5a11aff4 Add organized Tool Creator page
35+
9d8bdfa57 Add organized Tool Builder page
36+
9dd7de321 Add organized Publish page
37+
07cffbcf6 Add organized Cloud page
38+
df9a69b4a Add organized Docs page
39+
3f41ebbed Add organized Community page
40+
17e6f4d05 Add organized Learn page
41+
5216f30db Add organized Marketplace page
42+
2d0f25a97 Add organized Arcade page
43+
9ce8bbb4e Add organized Configuration Admin group page
44+
e59d22ba3 Add organized Design Animation group page
45+
e284e99fc Add organized Media Community group page
46+
e1e0799f0 Add organized Assets Content group page
47+
3bfb96259 Add organized Technology System group page
48+
c532e0e80 Add organized Building Creation group page
49+
481edb60c Add organized Tools index page
50+
aeeba13b8 Add organized Controls page
51+
8157042bd Add organized Branding page
52+
152aa63de Add organized Account page
53+
e7f1524fd Use shared GameFoundryStudio shell on home page
54+
988d0505e Add GameFoundryStudio tool CSS
55+
04a254d07 Add GameFoundryStudio page-specific CSS
56+
4fd54fae4 Add steel gray meaning CSS
57+
2c86d7e13 Add purple meaning CSS
58+
dc4a269ef Add arcade cyan meaning CSS
59+
b649b6cc5 Add forge gold meaning CSS
60+
f2ddbb7e4 Add electric blue meaning CSS
61+
af52eda34 Add molten orange meaning CSS
62+
c06991e2d Add GameFoundryStudio shared base CSS
63+
da4cb2601 Split GameFoundryStudio CSS entry point
64+
dffa67dfc Make GameFoundryStudio partials path aware
65+
53cc15ec4 Update GameFoundryStudio shared nav routes
66+
```
67+
68+
## Diff Stat
69+
70+
```text
71+
GameFoundryStudio/account/branding.html | 14 +
72+
GameFoundryStudio/account/controls.html | 13 +
73+
GameFoundryStudio/account/index.html | 14 +
74+
GameFoundryStudio/arcade/index.html | 2 +
75+
GameFoundryStudio/assets/css/base.css | 18 +
76+
.../assets/css/colors/arcade-cyan.css | 5 +
77+
.../assets/css/colors/electric-blue.css | 5 +
78+
GameFoundryStudio/assets/css/colors/forge-gold.css | 5 +
79+
.../assets/css/colors/molten-orange.css | 5 +
80+
GameFoundryStudio/assets/css/colors/purple.css | 5 +
81+
GameFoundryStudio/assets/css/colors/steel-gray.css | 5 +
82+
GameFoundryStudio/assets/css/pages.css | 2 +
83+
GameFoundryStudio/assets/css/styles.css | 1087 +-------------------
84+
GameFoundryStudio/assets/css/tools.css | 5 +
85+
.../assets/js/gamefoundry-partials.js | 97 +-
86+
GameFoundryStudio/assets/partials/header-nav.html | 42 +-
87+
GameFoundryStudio/cloud/index.html | 2 +
88+
GameFoundryStudio/community/index.html | 2 +
89+
GameFoundryStudio/docs/index.html | 2 +
90+
GameFoundryStudio/index.html | 57 +-
91+
GameFoundryStudio/learn/index.html | 2 +
92+
GameFoundryStudio/marketplace/index.html | 2 +
93+
GameFoundryStudio/publish/index.html | 2 +
94+
GameFoundryStudio/tools/groups/assets-content.html | 2 +
95+
.../tools/groups/building-creation.html | 2 +
96+
.../tools/groups/configuration-admin.html | 2 +
97+
.../tools/groups/design-animation.html | 2 +
98+
.../tools/groups/media-community.html | 2 +
99+
.../tools/groups/technology-system.html | 2 +
100+
GameFoundryStudio/tools/index.html | 13 +
101+
GameFoundryStudio/tools/tool-builder.html | 2 +
102+
GameFoundryStudio/tools/tool-creator.html | 2 +
103+
GameFoundryStudio/tools/tool-publisher.html | 2 +
104+
docs/dev/codex_commands.md | 39 +
105+
docs/dev/commit_comment.txt | 15 +
106+
...4-gamefoundry-site-structure-ssot-validation.md | 65 ++
107+
docs/dev/reports/codex_changed_files.txt | 33 +
108+
docs/dev/reports/codex_review.diff | 15 +
109+
38 files changed, 434 insertions(+), 1157 deletions(-)
110+
```
111+
112+
## Changed Files Grouped by Area
113+
114+
### Pages
115+
116+
```text
117+
A GameFoundryStudio/account/branding.html
118+
A GameFoundryStudio/account/controls.html
119+
A GameFoundryStudio/account/index.html
120+
A GameFoundryStudio/arcade/index.html
121+
A GameFoundryStudio/cloud/index.html
122+
A GameFoundryStudio/community/index.html
123+
A GameFoundryStudio/docs/index.html
124+
M GameFoundryStudio/index.html
125+
A GameFoundryStudio/learn/index.html
126+
A GameFoundryStudio/marketplace/index.html
127+
A GameFoundryStudio/publish/index.html
128+
A GameFoundryStudio/tools/groups/assets-content.html
129+
A GameFoundryStudio/tools/groups/building-creation.html
130+
A GameFoundryStudio/tools/groups/configuration-admin.html
131+
A GameFoundryStudio/tools/groups/design-animation.html
132+
A GameFoundryStudio/tools/groups/media-community.html
133+
A GameFoundryStudio/tools/groups/technology-system.html
134+
A GameFoundryStudio/tools/index.html
135+
A GameFoundryStudio/tools/tool-builder.html
136+
A GameFoundryStudio/tools/tool-creator.html
137+
A GameFoundryStudio/tools/tool-publisher.html
138+
```
139+
140+
### CSS
141+
142+
```text
143+
A GameFoundryStudio/assets/css/base.css
144+
A GameFoundryStudio/assets/css/colors/arcade-cyan.css
145+
A GameFoundryStudio/assets/css/colors/electric-blue.css
146+
A GameFoundryStudio/assets/css/colors/forge-gold.css
147+
A GameFoundryStudio/assets/css/colors/molten-orange.css
148+
A GameFoundryStudio/assets/css/colors/purple.css
149+
A GameFoundryStudio/assets/css/colors/steel-gray.css
150+
A GameFoundryStudio/assets/css/pages.css
151+
M GameFoundryStudio/assets/css/styles.css
152+
A GameFoundryStudio/assets/css/tools.css
153+
```
154+
155+
### Navigation / Partials / JS
156+
157+
```text
158+
M GameFoundryStudio/assets/js/gamefoundry-partials.js
159+
M GameFoundryStudio/assets/partials/header-nav.html
160+
```
161+
162+
### Docs / Reports
163+
164+
```text
165+
A docs/dev/codex_commands.md
166+
A docs/dev/commit_comment.txt
167+
A docs/dev/reports/PR_26151_004-gamefoundry-site-structure-ssot-validation.md
168+
A docs/dev/reports/codex_changed_files.txt
169+
A docs/dev/reports/codex_review.diff
170+
```
171+
172+
### Other
173+
174+
```text
175+
(none)
176+
```
177+
178+
## Ideas Worth Preserving
179+
180+
- Public IA concepts: top-level destinations for Arcade, Marketplace, Learn, Community, Docs, Cloud, and Publish.
181+
- Tool IA concepts: dedicated Tool Builder, Tool Creator, and Tool Publisher pages.
182+
- Tool group concepts: Building / Creation, Technology / System, Assets / Content, Media / Community, Design / Animation, and Configuration / Admin.
183+
- Navigation path awareness idea: branch partial loader adjusted links based on nesting depth. The concept is useful, but current implementation should use the active Theme V2/header infrastructure instead.
184+
- Meaning color taxonomy idea: molten orange, electric blue, forge gold, arcade cyan, purple, and steel gray. Current main already has Theme V2 color surfaces; only taxonomy/content ideas should be reused.
185+
186+
## Obsolete Under Current Theme V2 / Toolbox Structure
187+
188+
- The branch uses a standalone `GameFoundryStudio/` tree. Current main no longer has that path and instead uses root-level pages plus `assets/theme-v2`.
189+
- CSS files under `GameFoundryStudio/assets/css/` are obsolete because current styling ownership is `assets/theme-v2/css/`. Do not copy or merge those CSS files.
190+
- `GameFoundryStudio/assets/partials/header-nav.html` is obsolete relative to current shared header/login/admin behavior. Rebuilding nav should use current partial/session patterns.
191+
- `GameFoundryStudio/assets/js/gamefoundry-partials.js` is obsolete relative to current API-backed local server and Theme V2 partial behavior.
192+
- Old `docs/dev/*` report paths are obsolete relative to current `docs_build/dev/reports/*` workflow.
193+
- The branch predates current dev-runtime, Local Mem/Local DB, Admin My Stuff, Colors, and toolbox registry work.
194+
195+
## Possibly Missing from main
196+
197+
- Some public product destinations may still be missing or not first-class in current main, especially Cloud, Publish, and Docs as public-facing pages.
198+
- Dedicated Tool Builder, Tool Creator, and Tool Publisher concepts may still be useful if they are not covered by current toolbox routes.
199+
- Tool group landing pages may still be useful as content/IA, but should be rebuilt from current toolbox registry/data rather than static legacy pages.
200+
- Account subpage concepts for Branding and Controls may still be useful if current account/admin surfaces do not cover them.
201+
202+
## Recommendation
203+
204+
Recommended action: **rebuild ideas in new Theme V2 PRs, then delete after notes are captured**.
205+
206+
Do not merge the branch wholesale. Do not cherry-pick CSS or old partial code. If work resumes, use this branch only as an archive/reference for IA and page inventory. Create small modern PRs for each surviving idea, using current root paths, Theme V2 CSS, current header/session patterns, and current toolbox registry/data contracts.
207+
208+
Specific safe future slices:
209+
210+
1. Public destination IA review: decide whether Cloud, Publish, and Docs should become current root pages.
211+
2. Toolbox IA review: rebuild Tool Builder / Tool Creator / Tool Publisher as current Theme V2 toolbox pages if still desired.
212+
3. Tool group review: map old group pages to current toolbox categories and registry metadata.
213+
4. Account/Admin review: determine whether Branding and Controls belong under Account, Admin, or Toolbox.
214+
215+
## Validation Checklist
216+
217+
| Requirement | Status | Evidence |
218+
| --- | --- | --- |
219+
| Summarize commits. | PASS | Commit summary and full commit list included. |
220+
| List changed files grouped by page/CSS/navigation/docs. | PASS | Changed files grouped by Pages, CSS, Navigation / Partials / JS, Docs / Reports, and Other. |
221+
| Identify ideas worth preserving. | PASS | See `Ideas Worth Preserving`. |
222+
| Identify obsolete code under Theme V2/current toolbox structure. | PASS | See `Obsolete Under Current Theme V2 / Toolbox Structure`. |
223+
| Identify anything that may still be missing from main. | PASS | See `Possibly Missing from main`. |
224+
| Recommend keep/cherry-pick/rebuild/delete path. | PASS | Recommendation is rebuild ideas in new Theme V2 PRs, preserve branch only until notes are captured, then delete. |

0 commit comments

Comments
 (0)