Skip to content

Commit ef771ff

Browse files
committed
PR_26174_ALFA_015-game-hub-actions-and-setup-cleanup
1 parent 177840f commit ef771ff

12 files changed

Lines changed: 394 additions & 369 deletions

assets/theme-v2/css/tables.css

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,15 @@ td {
115115
cursor: pointer
116116
}
117117

118+
.data-table [data-game-row][data-game-active="true"] {
119+
background: color-mix(in srgb, var(--gold) 14%, var(--panel))
120+
}
121+
122+
.data-table [data-game-row][data-game-active="true"] > th,
123+
.data-table [data-game-row][data-game-active="true"] > td {
124+
border-bottom-color: var(--gold-border-muted)
125+
}
126+
118127
.idea-board-idea-label {
119128
display: inline-flex;
120129
align-items: center;
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
Branch Validation: PASS
2+
3+
PASS - Current branch is pr/26174-ALFA-015-game-hub-actions-and-setup-cleanup.
4+
PASS - Branch was created from pr/26174-ALFA-014-game-hub-parent-columns-center at 177840f74.
5+
PASS - Worktree was clean before creating the PR branch.
6+
PASS - Scope is limited to Game Hub UI/controller, Theme V2 table styling, targeted Playwright coverage, and required reports.
7+
PASS - No protected Project Instructions files were modified.
8+
PASS - No merge to main was performed.
9+
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
Manual Validation Notes
2+
3+
PASS - Confirmed Game Hub no longer renders the Game Setup accordion.
4+
PASS - Confirmed Game Hub no longer renders the Open Game Journey action.
5+
PASS - Confirmed parent table columns remain Game, Purpose, Status, Owner, Actions.
6+
PASS - Confirmed visible parent row action text is Edit.
7+
PASS - Confirmed Edit keeps using the repository open-game method and does not introduce browser-owned project arrays.
8+
PASS - Confirmed the active game row exposes data-game-active="true", aria-current="true", and a non-transparent theme background.
9+
PASS - Confirmed Source Idea and Readiness Output remain separate child tables under the expanded game row.
10+
PASS - Confirmed Add submits through the existing create-game form/API path.
11+
PASS - Confirmed safe empty and API-unavailable states still pass targeted Playwright validation.
12+
NOTE - Full GameHubMockRepository.spec.mjs exploratory run had an unrelated toolbox-role completion-metrics 500 failure; scoped Game Hub validation passed.
13+
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
Requirement Checklist: PASS
2+
3+
PASS - Game Hub parent table Actions replaces Open {game} with Edit.
4+
PASS - A clear active-game visual state is applied to the active game row.
5+
PASS - Open Game Journey action was removed.
6+
PASS - An Add button is present for adding a game to the list.
7+
PASS - Game Setup accordion was removed.
8+
PASS - Parent columns remain Game, Purpose, Status, Owner, Actions.
9+
PASS - Source Idea remains a child row/table under the game parent row.
10+
PASS - Readiness Output remains a child row/table under the game parent row.
11+
PASS - Existing API/service contract was preserved.
12+
PASS - No browser-owned product data was introduced.
13+
PASS - No page-local arrays were introduced.
14+
PASS - No silent fallbacks were introduced.
15+
PASS - table_first_ui.md was followed by keeping game rows as parent rows with child tables beneath them.
16+
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
Validation Lane: PASS
2+
3+
Commands:
4+
1. npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"
5+
Result: PASS - 7 passed.
6+
7+
2. npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"
8+
Result: PASS - 1 passed.
9+
10+
3. git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
11+
Result: PASS.
12+
13+
Non-gating observation:
14+
- An exploratory full-file run of tests/playwright/tools/GameHubMockRepository.spec.mjs produced 13 passing tests and 1 failure in "Toolbox member-role filters focus tools without exposing admin-only controls" due repeated 500 responses from /api/game-journey/completion-metrics. The failing test is outside this PR's targeted Game Hub lane.
15+
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26174_ALFA_015-game-hub-actions-and-setup-cleanup
2+
3+
## Purpose
4+
5+
Clean up Game Hub parent-row actions and setup controls while preserving the parent/child table contract.
6+
7+
## Summary
8+
9+
- Replaced Game Hub parent-row `Open {game}` action text with `Edit`.
10+
- Added a theme-backed active-game visual state on the active parent row.
11+
- Removed the standalone Open Game Journey action from Game Hub.
12+
- Replaced the old Game Setup accordion with a direct Add game control surface.
13+
- Kept parent columns as Game, Purpose, Status, Owner, and Actions.
14+
- Kept Source Idea and Readiness Output as child row tables under each game parent row.
15+
- Preserved the existing API/service contract and did not add browser-owned project data.
16+
17+
## Validation
18+
19+
PASS - `npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs -g "Game Hub creates, opens, and deletes mock games|Game Hub validates game parent rows and child tables|Game Hub preserves guest browsing and blocks guest saves|Game Hub shows a creator-safe empty state when no projects exist|Game Hub shows a creator-safe unavailable state when project list API fails|Game Hub displays and edits game purpose and member role|Game Hub readiness child rows update from mock game state"`
20+
PASS - `npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs -g "Idea Board uses accordion table ideas and notes"`
21+
PASS - `git diff --check -- assets/theme-v2/css/tables.css toolbox/game-hub/index.html toolbox/game-hub/game-hub.js tests/playwright/tools/GameHubMockRepository.spec.mjs tests/playwright/tools/IdeaBoardTableNotes.spec.mjs`
22+
Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
toolbox/game-hub/index.html
2-
toolbox/game-hub/game-hub.js
1+
assets/theme-v2/css/tables.css
32
tests/playwright/tools/GameHubMockRepository.spec.mjs
43
tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
5-
docs_build/dev/reports/codex_review.diff
6-
docs_build/dev/reports/codex_changed_files.txt
7-
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center.md
8-
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-branch-validation.txt
9-
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-requirement-checklist.txt
10-
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-validation-lane.txt
11-
docs_build/dev/reports/PR_26174_ALFA_014-game-hub-parent-columns-center-manual-validation-notes.txt
4+
toolbox/game-hub/game-hub.js
5+
toolbox/game-hub/index.html

0 commit comments

Comments
 (0)