Skip to content

Commit f15fdaa

Browse files
committed
Refresh Sprites MVP validation
1 parent 8da9ed5 commit f15fdaa

9 files changed

Lines changed: 186 additions & 1697 deletions

docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Completed the Sprites MVP to a manually testable state without splitting additio
1111
Implemented:
1212
- Toolbox Sprites entry is active/clickable through the source-controlled registry.
1313
- `/toolbox/sprites/index.html` loads a Theme V2 Sprites workspace.
14+
- Removed placeholder-era visible wording including `Not implemented yet.`, `Setup`, `Plan sprite creation`, `future rebuild work`, and placeholder Workspace/Inspector/Output sections.
1415
- Sprites uses Web UI -> API/service contract -> asset repository.
1516
- Sprite list/create/edit/archive flows are API-backed through `/api/toolbox/sprites`.
1617
- Guest save attempts redirect to `account/sign-in.html`.
@@ -38,15 +39,7 @@ PASS `node ./scripts/run-node-test-files.mjs tests/dev-runtime/SpritesAssetRepos
3839

3940
PASS `npx playwright test tests/playwright/tools/SpritesToolMvp.spec.mjs --workers=1 --reporter=list`
4041

41-
PASS `npx playwright test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs -g "Toolbox card names link" --workers=1 --reporter=list`
42-
43-
PASS `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index shows wireframe and beta tools|toolbox status kickers" --workers=1 --reporter=list`
44-
45-
Note: one combined Toolbox status run hit a Playwright artifact timeout after the index test passed; the exact status test was rerun independently and passed.
46-
47-
PASS `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox status kickers, filters, card order, and voting controls work from registry metadata" --workers=1 --reporter=list --timeout=180000`
48-
49-
PASS `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox Build Path status filters" --workers=1 --reporter=list --timeout=180000`
42+
PASS `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --workers=1 --reporter=list`
5043

5144
PASS `git diff --check`
5245

docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_branch-validation.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ Status: PASS
2323

2424
PASS: changed files are Sprites UI/API contract, affected Toolbox metadata/tests, required reports, and generated validation coverage reports.
2525

26-
## Final Branch State Before Commit
26+
## Final Branch State
2727

28-
Pending commit/push at report generation time.
28+
- Branch tracks `origin/PR_26177_CHARLIE_018-sprites-testable-mvp-completion`.
29+
- Branch is updated from synced `main` and remains the active PR018 branch for this validation refresh.
30+
- Commit/push will be refreshed after report and ZIP regeneration.

docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_manual-validation-notes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Status: PASS
1010
2. Open `/toolbox/index.html`.
1111
3. Confirm the Sprites card is visible without enabling Planned tools.
1212
4. Click Sprites and confirm navigation to `/toolbox/sprites/index.html`.
13-
5. Confirm the Sprites table, summary cards, filters, preview, metadata, references, and validation panels render.
13+
5. Confirm the Sprites table, summary cards, filters, preview, metadata, references, validation panels, and `Sprite Details` side panel render.
1414
6. Click `Add Sprite`.
1515
7. Enter `Hero Sprite`.
1616
8. Select category `Character`.

docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_requirements-checklist.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Status: PASS
66

77
- PASS Ensure `/toolbox/index.html` Sprites is active/clickable.
88
- PASS Ensure `/toolbox/sprites/index.html` loads.
9+
- PASS `/toolbox/sprites/index.html` no longer shows `Not implemented yet.`, `Setup`, `Plan sprite creation`, `future rebuild work`, or placeholder Workspace/Inspector/Output sections.
910
- PASS Ensure Sprites tool has working table/list surface.
1011
- PASS Ensure API-backed list/create/edit/archive works.
1112
- PASS Ensure guest save redirects to `account/sign-in.html`.

docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_validation-lane.md

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,23 +18,8 @@ npx playwright test tests/playwright/tools/SpritesToolMvp.spec.mjs --workers=1 -
1818
```
1919

2020
```text
21-
npx playwright test tests/playwright/tools/ToolNavigationPrevNext.spec.mjs -g "Toolbox card names link" --workers=1 --reporter=list
22-
1 passed
23-
```
24-
25-
```text
26-
npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index shows wireframe and beta tools|toolbox status kickers" --workers=1 --reporter=list
27-
1 passed, 1 Playwright artifact timeout
28-
```
29-
30-
```text
31-
npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox status kickers, filters, card order, and voting controls work from registry metadata" --workers=1 --reporter=list --timeout=180000
32-
1 passed
33-
```
34-
35-
```text
36-
npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox Build Path status filters" --workers=1 --reporter=list --timeout=180000
37-
1 passed
21+
npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --workers=1 --reporter=list
22+
11 passed
3823
```
3924

4025
```text
@@ -46,5 +31,6 @@ PASS
4631

4732
- PASS Sprites HTML/JS has no inline style/script/event handler matches.
4833
- PASS Sprites HTML/JS has no browser storage product-data SSoT matches.
34+
- PASS `toolbox/sprites/index.html` no longer contains the blocked placeholder wording.
4935
- PASS No `start_of_day` changed files.
5036
- NOTE Broad scan over all changed files finds pre-existing hex literals in `tests/playwright/tools/ToolboxRoutePages.spec.mjs`; Sprites implementation does not introduce reusable color definitions.
Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,21 @@
11
# git status --short
2-
M docs_build/dev/reports/coverage_changed_js_guardrail.txt
2+
M docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion.md
3+
M docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_branch-validation.md
4+
M docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_manual-validation-notes.md
5+
M docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_requirements-checklist.md
6+
M docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_validation-lane.md
37
M docs_build/dev/reports/playwright_v8_coverage_report.txt
4-
M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
5-
M src/dev-runtime/server/local-api-router.mjs
6-
M src/shared/toolbox/tool-metadata-inventory.js
7-
M tests/playwright/tools/ToolboxRoutePages.spec.mjs
88
M toolbox/sprites/index.html
9-
?? assets/toolbox/sprites/
10-
?? docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion.md
11-
?? docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_branch-validation.md
12-
?? docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_manual-validation-notes.md
13-
?? docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_requirements-checklist.md
14-
?? docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_validation-lane.md
15-
?? tests/dev-runtime/SpritesAssetRepository.test.mjs
16-
?? tests/playwright/tools/SpritesToolMvp.spec.mjs
179

1810
# git ls-files --others --exclude-standard
19-
assets/toolbox/sprites/js/index.js
20-
docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion.md
21-
docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_branch-validation.md
22-
docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_manual-validation-notes.md
23-
docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_requirements-checklist.md
24-
docs_build/dev/reports/PR_26177_CHARLIE_018-sprites-testable-mvp-completion_validation-lane.md
25-
tests/dev-runtime/SpritesAssetRepository.test.mjs
26-
tests/playwright/tools/SpritesToolMvp.spec.mjs
11+
(no output)
2712

2813
# git diff --stat
29-
.../dev/reports/coverage_changed_js_guardrail.txt | 8 +-
30-
.../dev/reports/playwright_v8_coverage_report.txt | 38 ++-
31-
.../tool-repositories/assets-mock-repository.js | 332 +++++++++++++++++++++
32-
src/dev-runtime/server/local-api-router.mjs | 5 +-
33-
src/shared/toolbox/tool-metadata-inventory.js | 6 +-
34-
tests/playwright/tools/ToolboxRoutePages.spec.mjs | 20 +-
35-
toolbox/sprites/index.html | 87 +++++-
36-
7 files changed, 455 insertions(+), 41 deletions(-)
14+
..._CHARLIE_018-sprites-testable-mvp-completion.md | 11 ++--------
15+
...es-testable-mvp-completion_branch-validation.md | 6 ++++--
16+
...table-mvp-completion_manual-validation-notes.md | 2 +-
17+
...stable-mvp-completion_requirements-checklist.md | 1 +
18+
...ites-testable-mvp-completion_validation-lane.md | 20 +++--------------
19+
.../dev/reports/playwright_v8_coverage_report.txt | 25 ++++++++++++++++------
20+
toolbox/sprites/index.html | 2 +-
21+
7 files changed, 30 insertions(+), 37 deletions(-)

0 commit comments

Comments
 (0)