Convert Objects to wireframe table input and remove MVP wording - PR_26161_004-objects-table-input-wireframe

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -2,31 +2,39 @@
 M docs_build/dev/reports/codex_changed_files.txt
  M docs_build/dev/reports/codex_review.diff
  M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+ M docs_build/dev/reports/db-object-model-contract-report.md
+ M docs_build/dev/reports/object-render-asset-handoff-report.md
+ M docs_build/dev/reports/objects-beta-rebuild-report.md
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js
- M src/engine/object-model/objectDefinitionSchema.js
- M src/engine/object-model/objectDefinitionValidator.js
+ M src/dev-runtime/guest-seeds/tool-metadata-inventory.js
  M src/engine/object-model/objectModelRegistry.js
  M tests/engine/ObjectModelContract.test.mjs
  M tests/playwright/tools/ObjectsTool.spec.mjs
+ M tests/playwright/tools/RootToolsFutureState.spec.mjs
+ M tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs
+ M tests/playwright/tools/ToolboxRoutePages.spec.mjs
  M toolbox/objects/index.html
  M toolbox/objects/objects.js
-?? docs_build/dev/reports/object-render-asset-handoff-report.md
+?? docs_build/dev/reports/objects-table-input-wireframe-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/object-render-asset-handoff-report.md
+docs_build/dev/reports/objects-table-input-wireframe-report.md
 
 # git diff --stat
-docs_build/dev/reports/codex_changed_files.txt     |   32 +-
- docs_build/dev/reports/codex_review.diff           | 1990 +++++++++-----------
- .../dev/reports/coverage_changed_js_guardrail.txt  |   12 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |   33 +-
- .../tool-repositories/assets-mock-repository.js    |  179 ++
- src/engine/object-model/objectDefinitionSchema.js  |   14 +
- .../object-model/objectDefinitionValidator.js      |  103 +
- src/engine/object-model/objectModelRegistry.js     |    8 -
- tests/engine/ObjectModelContract.test.mjs          |   36 +-
- tests/playwright/tools/ObjectsTool.spec.mjs        |   66 +-
- toolbox/objects/index.html                         |   21 +-
- toolbox/objects/objects.js                         |  147 +-
- 12 files changed, 1473 insertions(+), 1168 deletions(-)
+docs_build/dev/reports/codex_changed_files.txt     |   46 +-
+ docs_build/dev/reports/codex_review.diff           | 4838 +++++++-------------
+ .../dev/reports/coverage_changed_js_guardrail.txt  |    7 +-
+ .../dev/reports/db-object-model-contract-report.md |   10 +-
+ .../reports/object-render-asset-handoff-report.md  |    6 +-
+ .../dev/reports/objects-beta-rebuild-report.md     |    8 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |   28 +-
+ .../guest-seeds/tool-metadata-inventory.js         |   16 +-
+ src/engine/object-model/objectModelRegistry.js     |    2 +-
+ tests/engine/ObjectModelContract.test.mjs          |   40 +-
+ tests/playwright/tools/ObjectsTool.spec.mjs        |  210 +-
+ .../playwright/tools/RootToolsFutureState.spec.mjs |    4 +-
+ .../tools/ToolboxAdminMetadataSsot.spec.mjs        |   36 +-
+ tests/playwright/tools/ToolboxRoutePages.spec.mjs  |   20 +-
+ toolbox/objects/index.html                         |  104 +-
+ toolbox/objects/objects.js                         |  617 ++-
+ 16 files changed, 2429 insertions(+), 3563 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -6,12 +6,13 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (67%) src/engine/object-model/objectModelRegistry.js - executed lines 139/139; executed functions 4/6
-(74%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 17/23
+(70%) src/engine/object-model/objectDefinitionValidator.js - executed lines 360/360; executed functions 16/23
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
-(96%) toolbox/objects/objects.js - executed lines 590/590; executed functions 68/71
-(100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
+(95%) toolbox/objects/objects.js - executed lines 741/741; executed functions 84/88
 
 Guardrail warnings:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,12 +12,12 @@
 - PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before BUILD execution.
 - PASS: Added shared object-model contract files under `src/engine/object-model/`.
 - PASS: Added object body/type registry for `Static`, `Dynamic`, `Collectible`, `Hazard`, and `Goal`.
-- PASS: Added trait registry for `movable`, `damageable`, `killable`, `playerControlled`, `bounces`, `collides`, `scores`, `collectible`, `hazard`, and `goal`.
+- PASS: Added trait registry for `movable`, `damageable`, `killable`, `playerControlled`, `collides`, `scores`, `collectible`, `hazard`, and `goal`.
 - PASS: Added object definition schema and validator for manifest/config-driven object definitions.
 - PASS: Validator returns visible, actionable issue objects with `code`, `path`, `message`, and `action`.
 - PASS: Validator rejects legacy names such as `objectStatic`, `objectDynamic`, and `objectKillable`; no legacy class hierarchy was restored.
 - PASS: Wired `toolbox/objects` to consume the shared object-model registry and validator instead of page-local type metadata.
-- PASS: Objects remains focused on static/dynamic paddle + ball MVP setup and visible diagnostics.
+- PASS: Objects remains focused on broad object setup and visible diagnostics.
 - PASS: Theme V2 restrictions preserved; no inline CSS, inline JS, script blocks, style blocks, or inline event handlers were added.
 - PASS: No persistence, auth, sample JSON alignment, DB write behavior, or new engine runtime behavior was added.
 - PASS: No Toolbox/Admin metadata was changed in this PR.
@@ -28,9 +28,9 @@
 - `src/engine/object-model/objectDefinitionSchema.js` owns the object definition schema metadata.
 - `src/engine/object-model/objectDefinitionValidator.js` validates definitions, rejects unknown fields/types/traits, rejects duplicate traits, and preserves incoming payloads without mutation.
 - `src/engine/object-model/index.js` exports the shared contract.
-- `toolbox/objects/objects.js` imports the shared registry/validator, renders object type and trait basics from the registry, derives MVP traits for draft rows, and validates draft/list definitions through the shared validator.
+- `toolbox/objects/objects.js` imports the shared registry/validator, renders object type and trait basics from the registry, derives role traits for draft rows, and validates draft/list definitions through the shared validator.
 - `tests/engine/ObjectModelContract.test.mjs` covers registry membership, schema enum alignment, valid payload cloning/no mutation, actionable invalid diagnostics, and legacy type rejection.
-- `tests/playwright/tools/ObjectsTool.spec.mjs` now verifies shared trait registry visibility and trait-backed MVP seeded output.
+- `tests/playwright/tools/ObjectsTool.spec.mjs` now verifies shared trait registry visibility and trait-backed seeded output.
 
 ## Validation
 
@@ -70,4 +70,4 @@ Note: an initial Playwright invocation used a Windows backslash path and returne
 
 - Objects still uses the First-Class Tool V2 surface and Theme V2 CSS.
 - Object type choices and visible type/trait registry lists are generated from `src/engine/object-model/`.
-- The MVP seeded path remains in-memory only and validates as ready with a Dynamic paddle, Dynamic ball, and Static boundary.
+- The seeded path remains in-memory only and validates as ready with Dynamic hero, Dynamic projectile, and Static wall rows.

docs_build/dev/reports/db-object-model-contract-report.md

@@ -14,12 +14,12 @@
 - PASS: Removed `bounces` from object identity traits. Bounce remains a future behavior/physics/event configuration concern.
 - PASS: Added object definition render config schema/validation for `None` and `Sprite`.
 - PASS: Wired Objects to the shared object-model registry and shared asset repository contract instead of owning duplicate sprite asset records.
-- PASS: Added Render Type = Sprite handoff that creates or resolves a real mock-adapter asset row named from the object key, for example `sprite_ball`.
+- PASS: Added Render Type = Sprite handoff that creates or resolves a real mock-adapter asset row named from the object key, for example `sprite_bolt`.
 - PASS: Linked the object render config to the returned sprite asset key and shared asset preview path.
 - PASS: Objects shows the linked sprite key/path and an Edit Sprite route with `assetKey`, `objectKey`, and `sourceTool=objects` query context.
 - PASS: Missing sprite assets create a minimal editable default sprite asset record with visible status diagnostics.
 - PASS: No fake `placeholder` asset key/concept and no `imageDataUrl` were introduced.
-- PASS: Object ownership stays in Objects; sprite content ownership stays with Assets/Sprite Editor.
+- PASS: Object definition ownership stays in Objects; sprite content ownership stays with Assets/Sprite Editor.
 - PASS: No sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites were added.
 - PASS: Toolbox/Admin tool metadata was not changed.
 
@@ -32,7 +32,7 @@
 - `toolbox/objects/index.html`: added Render Type input, Render Asset column, linked sprite preview, and Edit Sprite action using Theme V2 markup only.
 - `toolbox/objects/objects.js`: requests shared sprite assets, stores linked render config, logs warnings, and displays preview/action state.
 - `tests/engine/ObjectModelContract.test.mjs`: validates no `bounces` object trait and sprite render asset-key validation.
-- `tests/playwright/tools/ObjectsTool.spec.mjs`: validates sprite render selection creating/resolving `sprite_ball`, DB row evidence, no placeholder key, and no visible `bounces` trait.
+- `tests/playwright/tools/ObjectsTool.spec.mjs`: validates sprite render selection creating/resolving a real sprite asset, DB row evidence, no placeholder key, and no visible `bounces` trait.
 
 ## Validation
 

docs_build/dev/reports/object-render-asset-handoff-report.md

@@ -39,9 +39,9 @@ Files changed:
 - PASS: Rebuilt `toolbox/objects` as a Tool Template V2-style first-class surface with header, Tool Display Mode host, left setup panel, center workspace, right output/validation/status panels, and working accordions.
 - PASS: Used Theme V2 only. No inline CSS, no inline JS, no `<style>` blocks, no inline event handlers.
 - PASS: Added an external Objects module with in-memory-only object setup behavior.
-- PASS: Kept the tool focused on the paddle + ball MVP path with a seeded Dynamic paddle, Dynamic ball, and Static boundary.
+- PASS: Kept the tool focused on a targeted object setup path with seeded Dynamic hero, Dynamic projectile, and Static wall rows.
 - PASS: Added object type basics for Static, Dynamic, Collectible, Hazard, and Goal.
-- PASS: Added visible output, status logging, MVP requirement rows, and actionable validation diagnostics.
+- PASS: Added visible output, status logging, requirement rows, and actionable validation diagnostics.
 - PASS: Added no persistence, save/load, auth, sample JSON alignment, or engine runtime behavior.
 - PASS: Updated DB-backed tool metadata only after targeted Objects Playwright passed.
 - PASS: Marked Objects beta after execution evidence and targeted validation passed.
@@ -79,6 +79,6 @@ Coverage:
 ## Manual Notes
 
 - Objects page launches from `toolbox/objects/index.html`.
-- Seed Paddle + Ball creates three in-memory rows and validates the MVP path.
-- Add Object blocks missing fields and invalid Paddle/Ball/Boundary type combinations with actionable diagnostics.
+- Seed Starter Objects creates three in-memory rows and validates object setup.
+- Add Object blocks missing fields and invalid object type combinations with actionable diagnostics.
 - Reset/remove actions affect only the in-memory page draft.

docs_build/dev/reports/objects-beta-rebuild-report.md

@@ -0,0 +1,73 @@
+# PR_26161_004 Objects Table Input Wireframe Report
+
+## Branch Guard
+
+- Current branch: `main`
+- Expected branch: `main`
+- Branch validation before edits: PASS
+
+## Scope Checklist
+
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Kept the change targeted to the Objects tool table-input wireframe and DB/mock-adapter handoff behavior.
+- PASS: Moved Objects metadata status/release channel to `Wireframe` / `wireframe`, keeping it clickable from Toolbox.
+- PASS: Removed old sample-path wording from the Objects UI, targeted Objects tests, Objects metadata, shared object-model copy, and Objects-specific reports.
+- PASS: Renamed the visible role concept to `Role`.
+- PASS: Replaced narrow sample-path roles with broader role choices: `Collectible`, `Custom`, `Enemy`, `Goal`, `Hazard`, `Hero`, `Platform`, `Projectile`, `Spawner`, `UI`, and `Wall`.
+- PASS: Reworked Objects input from the sidebar form to an editable table with inline name/type/role/state/render controls.
+- PASS: Placed `Add Object` below the table and disabled it while a new or edited row is active.
+- PASS: Added saved-row `Edit` and `Trash` actions, plus active-row `Save` and `Cancel` actions on the right side.
+- PASS: Preserved shared object-model registry/validator usage and Sprite render asset create/resolve handoff.
+- PASS: Kept Theme V2 restrictions intact: no inline CSS, no inline JS, no script/style blocks, and no inline event handlers.
+- PASS: Added no sample JSON alignment, production DB behavior, auth behavior, persistence behavior, or engine runtime behavior.
+
+## Implementation Evidence
+
+- `toolbox/objects/index.html` now presents Object Setup, Role Choices, readiness checks, and an Objects Table instead of a sidebar draft form.
+- `toolbox/objects/objects.js` now owns row edit state, table rendering, inline row controls, add/save/cancel/edit/trash handlers, broader role traits, and the existing Sprite asset handoff path.
+- `src/dev-runtime/guest-seeds/tool-metadata-inventory.js` marks Objects as wireframe and updates Objects capability copy to `Object setup types`.
+- `src/engine/object-model/objectModelRegistry.js` no longer exposes sample-path wording in the Dynamic body type description.
+- `tests/playwright/tools/ObjectsTool.spec.mjs` validates table input, broad roles, add disabling, Cancel/Edit/Trash, Toolbox click-through, no `bounces` trait, and real sprite asset linking/resolution.
+
+## Validation
+
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check src/dev-runtime/guest-seeds/tool-metadata-inventory.js`
+- PASS: `node --check src/engine/object-model/objectModelRegistry.js`
+- PASS: `node --check tests/engine/ObjectModelContract.test.mjs`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: `node --check tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs`
+- PASS: `node --check tests/playwright/tools/ToolboxRoutePages.spec.mjs`
+- PASS: `node --check tests/playwright/tools/RootToolsFutureState.spec.mjs`
+- PASS: HTML restriction check for `toolbox/objects/index.html`
+- PASS: `node tests/engine/ObjectModelContract.test.mjs`
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line` (4 passed)
+- PASS: `npx playwright test tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs --reporter=line` (4 passed)
+- PASS: `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "toolbox index shows wireframe|toolbox status kickers|toolbox Build Path status filters" --reporter=line` (3 passed)
+- PASS: Combined affected browser lane: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs tests/playwright/tools/ToolboxRoutePages.spec.mjs -g "Objects|Toolbox and Admin Tool Votes|Admin metadata edits|Toolbox page does not|Toolbox and Admin pages do not|toolbox index shows wireframe|toolbox status kickers|toolbox Build Path status filters" --reporter=line` (11 passed)
+- PASS: targeted stale wording scan returned no matches across Objects UI, shared object-model files, targeted tests, Objects metadata, and Objects-specific reports.
+- PASS: `git diff --check`
+
+## Playwright V8 Coverage
+
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` regenerated from the final single-worker Objects Playwright run.
+- Covered changed browser/runtime modules:
+  - `toolbox/objects/objects.js` at 95% function coverage.
+  - `src/engine/object-model/objectDefinitionSchema.js` at 75%.
+  - `src/engine/object-model/objectDefinitionValidator.js` at 70%.
+  - `src/engine/object-model/objectModelRegistry.js` at 67%.
+- WARN: `src/dev-runtime/guest-seeds/tool-metadata-inventory.js` is server/dev-runtime metadata and was not collected by browser V8 coverage.
+- WARN: `src/dev-runtime/persistence/tool-repositories/assets-mock-repository.js` appears in the coverage helper's HEAD-change detection path and was not collected by browser V8 coverage; it is not modified in the PR_004 working diff.
+
+## Skipped Lanes
+
+- SKIP: Full samples validation. Safe to skip because no sample JSON, sample launch path, sample manifest, or engine runtime behavior changed.
+- SKIP: Sprite Editor launch/handoff Playwright. Safe to skip because no Sprite Editor files, routes, or context contract files changed; Objects still links to the existing Sprite Editor route with `assetKey`, `objectKey`, and `sourceTool=objects`.
+- SKIP: Full root future-state Playwright. Safe to skip because PR_004 validation targets Objects, Toolbox clickability, and Toolbox/Admin metadata. The touched root test change is limited to removing stale Objects wording and passed syntax check.
+- SKIP: Production DB/auth/persistence validation. Safe to skip because this PR only uses existing mock-adapter/shared asset contracts and adds no production DB, auth, or persistence behavior.
+
+## Remaining Follow-Up
+
+- Behavior and physics configuration still belong in future Events/behavior lanes, not object identity.
+- Sprite asset content editing remains owned by Sprite Editor; Objects only creates/resolves and links the shared sprite asset record.
+- The Objects table remains a wireframe authoring surface with in-session object definitions and no manifest persistence.