Refine Controls controller profile edit mode and input highlighting - PR_26161_029-controls-controller-profile-edit-mode

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,8 +1,7 @@
-docs_build/dev/reports/controls-compact-controller-profile-report.md
-docs_build/dev/reports/codex_review.diff
 docs_build/dev/reports/codex_changed_files.txt
-docs_build/dev/reports/playwright_v8_coverage_report.txt
+docs_build/dev/reports/codex_review.diff
+docs_build/dev/reports/controls-controller-profile-edit-mode-report.md
 docs_build/dev/reports/coverage_changed_js_guardrail.txt
+docs_build/dev/reports/playwright_v8_coverage_report.txt
 tests/playwright/tools/InputMappingV2Tool.spec.mjs
 toolbox/controls/controls.js
-toolbox/controls/index.html

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,46 @@
+# PR_26161_029 Controls Controller Profile Edit Mode Report
+
+## Scope
+- Updated Controls controller profile rows so saved profiles render as compact summaries outside edit mode.
+- Moved generated controller input Action dropdowns into profile edit mode only.
+- Added edit-mode gamepad input highlighting for matching generated controller inputs.
+- Kept Controls status as Wireframe and kept persistence through the shared DB/mock adapter.
+
+## Branch Validation
+- PASS: current branch verified as `main` before edits.
+
+## Impacted Lane
+- Controls / Input Mapping.
+
+## Playwright Impacted
+- Yes.
+
+## Validation Performed
+- PASS: `node --check toolbox/controls/controls.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: `git diff --check`
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+
+## Manual Validation Steps
+- Open Controls and refresh devices with a detected gamepad.
+- Add a controller profile and confirm the saved profile row shows only the compact summary.
+- Click Edit and confirm profile row values are text while generated input Action dropdowns appear underneath.
+- Press a controller button during edit and confirm the matching generated input row highlights with the selected Action.
+- Assign generated input Actions, Save, reload, and confirm assignments persist.
+- Edit a profile, change an Action, Cancel, reload, and confirm the unsaved change did not persist.
+
+## Skipped Lanes
+- Full samples validation skipped by request because this PR only changes Controls UI behavior and targeted Playwright coverage exercises the impacted lane.
+
+## Runtime Engine Behavior
+- Confirmed: no runtime engine behavior changed.
+
+## Completion Check
+- PASS: Controller Profile Edit shows profile row values as text, not dropdowns.
+- PASS: Generated input Action dropdowns appear only in edit mode.
+- PASS: Generated input Action dropdowns are hidden outside edit mode.
+- PASS: Controller input press during edit highlights the matching generated input.
+- PASS: Selected/assigned Action is visibly shown for the pressed input.
+- PASS: Editing one input does not alter other inputs.
+- PASS: Save persists generated input action assignments after reload.
+- PASS: Cancel does not persist unsaved generated input action changes.

docs_build/dev/reports/controls-controller-profile-edit-mode-report.md

@@ -6,10 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
+(94%) toolbox/controls/controls.js - executed lines 1686/1686; executed functions 186/197
 
 Guardrail warnings:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file missing from coverage; advisory only
+(100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,30 +12,25 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(89%) Toolbox Index - exercised 4 runtime JS files
+(92%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
+(94%) toolbox/controls/controls.js - executed lines 1686/1686; executed functions 186/197
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
+(94%) toolbox/controls/controls.js - executed lines 1686/1686; executed functions 186/197
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
-(0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: uncovered changed runtime JS file; advisory only
+(100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
-(0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
-(0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(91%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
+(94%) toolbox/controls/controls.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -600,11 +600,13 @@ test("Controls generates controller profiles, shows fallback status, and mapping
     expect(await controllerProfileRecords(page)).toHaveLength(0);
 
     await page.evaluate(() => {
+      window.__arcadeButtons = Array.from({ length: 16 }, () => ({ pressed: false, value: 0 }));
+      window.__arcadeAxes = [0, 0];
       Object.defineProperty(navigator, "getGamepads", {
         configurable: true,
         value: () => [{
-          axes: [0, 0],
-          buttons: Array.from({ length: 16 }, () => ({ pressed: false, value: 0 })),
+          axes: window.__arcadeAxes,
+          buttons: window.__arcadeButtons,
           id: "Arcade Test Pad",
           index: 0,
         }],
@@ -628,7 +630,7 @@ test("Controls generates controller profiles, shows fallback status, and mapping
     await page.locator("[data-controller-profile-add]").click();
     await expect(page.locator("[data-controller-profile-list]")).toContainText("Arcade Test Pad");
     await expect(page.locator("[data-controller-profile-list]")).toContainText("Arcade Test Pad Profile");
-    await expect(page.locator("[data-controller-profile-list]")).toContainText("Action Required");
+    await expect(page.locator("[data-controller-profile-list]")).toContainText("0/18 Actions assigned");
     await expect(page.locator("[data-controller-profile-table] th")).toHaveText([
       "Device Type",
       "Controller Name",
@@ -637,10 +639,8 @@ test("Controls generates controller profiles, shows fallback status, and mapping
       "Action",
     ]);
     await expect(page.locator("[data-controller-profile-row]").first()).not.toContainText("Button0");
-    await expect(page.locator("[data-controller-profile-actions-row]").first().locator(".content-grid--three")).toBeVisible();
-    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]")).toHaveCount(18);
-    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]").first().locator("strong")).toHaveText("Button0");
-    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]").first().locator("select")).toBeVisible();
+    await expect(page.locator("[data-controller-profile-actions-row]")).toHaveCount(0);
+    await expect(page.locator("[data-controller-profile-input-action]")).toHaveCount(0);
     await expect(page.locator("[data-controller-profile-fallback-status]")).toContainText("Exact saved profile");
 
     let profiles = await controllerProfileRecords(page);
@@ -673,22 +673,56 @@ test("Controls generates controller profiles, shows fallback status, and mapping
       "Axis1",
     ]);
 
-    await page.locator("[data-controller-profile-save-actions]").click();
+    await page.locator("[data-controller-profile-edit]").click();
+    const editRow = page.locator("[data-controller-profile-editing-row]");
+    await expect(editRow.locator("td").nth(0)).toHaveText("Gamepad");
+    await expect(editRow.locator("td").nth(1)).toHaveText("Arcade Test Pad");
+    await expect(editRow.locator("td").nth(2)).toHaveText("Arcade Test Pad");
+    await expect(editRow.locator("td").nth(3)).toHaveText("Arcade Test Pad Profile");
+    await expect(editRow.locator("select")).toHaveCount(0);
+    await expect(editRow.locator("input")).toHaveCount(0);
+    await expect(editRow.locator("button")).toHaveText(["Save", "Cancel"]);
+
+    const editingActionsRow = page.locator("[data-controller-profile-editing-actions-row]");
+    await expect(editingActionsRow.locator(".content-grid--three")).toBeVisible();
+    await expect(editingActionsRow.locator("[data-controller-profile-input-pair]")).toHaveCount(18);
+    await expect(editingActionsRow.locator("[data-controller-profile-input-pair]").first().locator("strong")).toHaveText("Button0");
+    await expect(editingActionsRow.locator("[data-controller-profile-input-action]")).toHaveCount(18);
+
+    await page.locator("[data-controller-profile-save]").click();
     await expect(page.locator("[data-controller-profile-status]")).toContainText("Action Required");
     profiles = await controllerProfileRecords(page);
     expect(profiles[0].actions).toEqual([]);
 
-    const inputActionSelects = page.locator("[data-controller-profile-input-action]");
+    const inputActionSelects = editingActionsRow.locator("[data-controller-profile-input-action]");
     const inputActionCount = await inputActionSelects.count();
     expect(inputActionCount).toBe(profiles[0].inputs.length);
     for (let index = 0; index < inputActionCount; index += 1) {
       await inputActionSelects.nth(index).selectOption(index === 0 ? "fire" : "moveRight");
     }
-    await page.locator("[data-controller-profile-save-actions]").click();
+    await expect(inputActionSelects.nth(1)).toHaveValue("moveRight");
+    await page.evaluate(() => {
+      window.__arcadeButtons[0] = { pressed: true, value: 1 };
+    });
+    const activeProfileInput = page.locator("[data-controller-profile-input-pair][data-controller-profile-input-active='true']");
+    await expect(activeProfileInput.locator("strong")).toHaveText("Button0");
+    await expect(activeProfileInput.locator("[data-controller-profile-input-assigned-action]")).toHaveText("Selected Action: Fire");
+    await expect(editingActionsRow.locator("[data-controller-profile-input-pair]").nth(1)).not.toHaveAttribute("data-controller-profile-input-active", "true");
+    await expect(editingActionsRow.locator("[data-controller-profile-input-pair]").nth(1).locator("[data-controller-profile-input-assigned-action]")).toHaveText("Assigned Action: Move Right");
+
+    await page.locator("[data-controller-profile-save]").click();
     profiles = await controllerProfileRecords(page);
     expect(profiles[0].actions).toHaveLength(profiles[0].inputs.length);
     expect(profiles[0].actions[0]).toBe("fire");
     expect(profiles[0].actions[1]).toBe("moveRight");
+    await expect(page.locator("[data-controller-profile-input-action]")).toHaveCount(0);
+
+    await page.locator("[data-controller-profile-edit]").click();
+    await page.locator("[data-controller-profile-input-action]").first().selectOption("jump");
+    await page.locator("[data-controller-profile-cancel]").click();
+    profiles = await controllerProfileRecords(page);
+    expect(profiles[0].actions[0]).toBe("fire");
+    await expect(page.locator("[data-controller-profile-input-action]")).toHaveCount(0);
 
     await page.locator("[data-controller-profile-trash]").click();
     await expect(page.locator("[data-controller-profile-list]")).toContainText("No controller profiles saved yet.");