Skip to content

Commit f4be737

Browse files
committed
Audit src destinations and remove demo artifact
1 parent f0be6d6 commit f4be737

13 files changed

Lines changed: 1507 additions & 145 deletions

dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ Rules:
117117

118118
## Current Version/Date
119119

120-
- Project Instructions Version: 2026.06.28.016
120+
- Project Instructions Version: 2026.06.28.017
121121
- Date: 2026-06-28
122122
- Owner: OWNER
123123

dev/build/ProjectInstructions/PROJECT_INSTRUCTIONS_VERSION.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Project Instructions Version
22

3-
Current Project Instructions Version: 2026.06.28.016
3+
Current Project Instructions Version: 2026.06.28.017
44

55
Last Updated: 2026-06-28
66

@@ -24,6 +24,7 @@ Last Updated: 2026-06-28
2424
- Moved the tracked browser-served favicon under `www/`, added remaining root/src audit governance, and documented root `.env` placement policy.
2525
- Added root leftover audit and `src/` transition plan for the final repository layout cleanup stage.
2626
- Removed safe empty local root directory shells and documented blocked local-only `assets/` cleanup.
27+
- Removed the local demo `.gfsp` artifact and recorded a file-by-file `src/` destination audit for future scoped migrations.
2728
- Codex must read this version file and the latest repository copy of `PROJECT_INSTRUCTIONS.md` before performing work.
2829
- Codex must discard previously remembered Project Instructions and treat the repository copy as authoritative.
2930
- Codex must validate canonical report and ZIP paths, branching model, and legacy path avoidance before work proceeds.

dev/build/ProjectInstructions/PROJECT_STATE.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Project State
22

33
```yaml
4-
project_state_version: "2026.06.28.016"
4+
project_state_version: "2026.06.28.017"
55
last_updated: "2026-06-28"
66
current_main_commit: "40de767476d70cadfd1292c916844c2f31b6f185"
77
repository_status:
@@ -10,18 +10,18 @@ repository_status:
1010
runtime_database: "Postgres"
1111
creator_metadata: "API to Postgres"
1212
creator_assets: "API to R2"
13-
project_instructions_version: "2026.06.28.016"
14-
repository_structure_version: "2026.06.28.016"
15-
canonical_layout_version: "2026.06.28.016"
13+
project_instructions_version: "2026.06.28.017"
14+
repository_structure_version: "2026.06.28.017"
15+
canonical_layout_version: "2026.06.28.017"
1616
active_teams:
1717
- "Owner"
1818
- "Alfa"
1919
- "Bravo"
2020
- "Charlie"
2121
- "Delta"
2222
- "Golf"
23-
latest_owner_pr: "PR_26180_OWNER_016-remove-empty-root-shells"
24-
latest_structure_pr: "PR_26180_OWNER_016-remove-empty-root-shells"
23+
latest_owner_pr: "PR_26180_OWNER_017-src-dissection-and-demo-cleanup"
24+
latest_structure_pr: "PR_26180_OWNER_017-src-dissection-and-demo-cleanup"
2525
valid_top_level_folders:
2626
- "api/"
2727
- "deploy/"

dev/build/ProjectInstructions/backlog/BACKLOG_MASTER.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ The backlog is the authoritative source for determining the next logical PRs.
3939
- Team: Owner
4040
- Product Area: Repository Architecture Simplification
4141
- Status: Active
42-
- Percent Complete: 98%
43-
- Active PR: PR_26180_OWNER_016-remove-empty-root-shells
42+
- Percent Complete: 99%
43+
- Active PR: PR_26180_OWNER_017-src-dissection-and-demo-cleanup
4444
- Next Milestone: Final layout validation and completion report
4545
- Source / Reference: `dev/build/ProjectInstructions/repository/repository_layout_architecture_plan.md`; `dev/build/ProjectInstructions/repository/www_migration_map.md`
4646

dev/build/ProjectInstructions/repository/repository_layout_architecture_plan.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ No browser, API, server, test, script, or runtime files move in the scaffold or
4242

4343
`PR_26180_OWNER_016-remove-empty-root-shells` removes safe empty local root directory shells left behind after the migration and documents the blocked local-only `assets/` shell that contains ignored user data.
4444

45+
`PR_26180_OWNER_017-src-dissection-and-demo-cleanup` removes the local ignored demo `.gfsp` artifact, removes the now-empty `assets/` shell, and records a file-by-file `src/` destination audit without moving source files.
46+
4547
## Proposed Future Layout
4648

4749
```text
@@ -189,7 +191,13 @@ Rules:
189191
- Do not delete ignored local-only data.
190192
- Document any folder that cannot be removed.
191193

192-
13. `PR_26180_OWNER_017-final-layout-validation`
194+
13. `PR_26180_OWNER_017-src-dissection-and-demo-cleanup`
195+
- Delete the local ignored demo `.gfsp` artifact and remove `assets/` if empty.
196+
- Audit every tracked `src/` file and assign a proposed destination.
197+
- Do not bulk-move `src/`.
198+
- Preserve runtime behavior.
199+
200+
14. `PR_26180_OWNER_018-final-layout-validation`
193201
- Validate final repository layout.
194202
- Confirm `www/` owns the browser-served app, `api/` owns the server app, and `dev/` owns the developer workspace.
195203
- Confirm runtime does not depend on `dev/`, browser code does not import `api/`, and legacy references are removed or documented.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# PR_26180_OWNER_017 Branch Validation
2+
3+
| Check | Result | Evidence |
4+
|---|---:|---|
5+
| Current branch | PASS | `PR_26180_OWNER_017-src-dissection-and-demo-cleanup` |
6+
| Expected stacked base | PASS | Created from `PR_26180_OWNER_016-remove-empty-root-shells` |
7+
| Base branch for PR | PASS | `PR_26180_OWNER_016-remove-empty-root-shells` |
8+
| Project Instructions loaded | PASS | Repository Project Instructions version `2026.06.28.017` |
9+
| Branching policy loaded | PASS | `PROJECT_BRANCHING_POLICY.md` version `2026.06.28.002` |
10+
| Scope | PASS | Local demo artifact cleanup, `src/` file audit, governance reports only |
11+
| Runtime/API/database implementation changes | PASS | None |
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# PR_26180_OWNER_017 Manual Validation Notes
2+
3+
- Deleted the ignored local demo artifact `assets/DemoGame-26168-001.gfsp`.
4+
- Removed `assets/` after it became empty.
5+
- Confirmed `games/`, `learn/`, `toolbox/`, `tmp/`, and `test-results/` remain absent.
6+
- Confirmed no tracked legacy root files remain in the target set.
7+
- Confirmed all 596 tracked `src/` files are audited.
8+
- No `src/` files moved in this PR.
9+
- Runtime behavior is preserved.
10+
- ZIP output remains under `dev/workspace/zips/`.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
# PR_26180_OWNER_017 src Dissection and Demo Cleanup Report
2+
3+
## Executive Summary
4+
5+
PR_26180_OWNER_017 removes the local ignored demo artifact `assets/DemoGame-26168-001.gfsp`, removes the now-empty `assets/` shell, and audits every tracked file under `src/`.
6+
7+
No tracked `src/` files are moved in this PR. The file-by-file audit assigns proposed destinations, but most files require scoped reference migrations to preserve runtime behavior.
8+
9+
## Demo Artifact Cleanup
10+
11+
- Deleted local ignored artifact: `assets/DemoGame-26168-001.gfsp`.
12+
- Removed `assets/` after the artifact deletion left the folder empty.
13+
- No tracked files were deleted.
14+
- No active `assets/DemoGame-26168-001.gfsp` path references remain outside reports/workspace.
15+
16+
Filename-only `DemoGame-26168-001.gfsp` references remain in Playwright tests as generated-download assertions. Those are not references to the deleted root file path.
17+
18+
## src Audit Summary
19+
20+
Tracked `src/` files audited: 596.
21+
22+
The detailed file-by-file audit lives at:
23+
24+
`dev/reports/PR_26180_OWNER_017-src-dissection-and-demo-cleanup_src-file-destination-audit.md`
25+
26+
## src Move Decision
27+
28+
No `src/` files moved.
29+
30+
Reason:
31+
32+
- `src/` content is actively referenced by `www/`, `api/`, `dev/tests/`, and `dev/tools/`.
33+
- Moving `src/` files requires scoped import/reference updates.
34+
- The PR request requires preserving runtime behavior.
35+
- Uncertain or mixed-ownership files must be documented before movement.
36+
37+
## Proposed Follow-Up PRs
38+
39+
1. Browser API client migration: move `src/api/` browser clients to a browser-owned location.
40+
2. Engine runtime migration: move `src/engine/` to the final browser/runtime source layer.
41+
3. Shared contract/schema migration: split `src/shared/contracts/` and `src/shared/schemas/` into the API contract surface.
42+
4. Shared utility migration: split `src/shared/` browser/runtime utilities by actual import ownership.
43+
5. Legacy Admin Notes retirement: migrate or retire `src/dev-runtime/admin/`.
44+
45+
## Runtime/Product Impact
46+
47+
No runtime behavior changed. No product code changed. No API/database behavior changed.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26180_OWNER_017 Requirement Checklist
2+
3+
| Requirement | Result | Notes |
4+
|---|---:|---|
5+
| Base on `PR_26180_OWNER_016-remove-empty-root-shells` | PASS | Branch created from PR016. |
6+
| Delete `assets/DemoGame-26168-001.gfsp` | PASS | Local ignored file deleted. |
7+
| Remove `assets/` if empty after deletion | PASS | `assets/` removed after the demo file deletion. |
8+
| Audit every tracked file under `src/` | PASS | 596 tracked `src/` files audited in the detailed audit report. |
9+
| Decide destination for each `src/` file | PASS | Each audited file has proposed destination: `www/`, `api/`, `dev/`, or `archive/delete`. |
10+
| Do not bulk-move `src/` blindly | PASS | No `src/` files moved. |
11+
| Move only files with clear ownership | PASS | No source movement attempted because scoped reference updates are required. |
12+
| If uncertain, document and hard stop before moving | PASS | Uncertain/mixed ownership documented; movement deferred. |
13+
| Preserve runtime behavior | PASS | No runtime/product code moved or changed. |
14+
| `git diff --check` | PASS | Whitespace validation passed. |
15+
| `npm run validate:canonical-structure` | PASS | Canonical guardrail passed. |
16+
| Targeted path/reference scan | PASS | No active `assets/DemoGame...` path references remain. |
17+
| Targeted bootstrap check if paths move | PASS | Bootstrap check passed; no tracked startup paths moved. |

0 commit comments

Comments
 (0)