Skip to content

Commit fececdc

Browse files
committed
PR_26171_BETA_083 message tts polish and dead code
1 parent a0da3ad commit fececdc

13 files changed

Lines changed: 1139 additions & 2355 deletions
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# PR_26171_BETA_083 Dead-Code Cleanup Checklist
2+
3+
## Message Studio
4+
- PASS: Removed duplicate preview TTS Profile control outside the table.
5+
- PASS: Removed duplicate TTS service selector outside the table.
6+
- PASS: Removed dead Test Speech button and selected-item helper text.
7+
- PASS: Removed unused Message Studio speech-test state and render paths.
8+
- PASS: Kept playback routed through selected message part, TTS Profile, and Emotion Setting.
9+
- PASS: Kept Play Part, Play Message, and Stop Playback controls available.
10+
11+
## TTS Studio
12+
- PASS: Kept Delivery in Emotion Settings.
13+
- PASS: Kept Presets in Emotion Settings as Delivery Preset.
14+
- PASS: Kept Voice Filters in profile controls.
15+
- PASS: No duplicate summary or output panel was added.
16+
- PASS: No separate Emotion Studio was added.
17+
18+
## Tests
19+
- PASS: Removed dead Message speech-test selector expectations.
20+
- PASS: Added absence checks for removed duplicate controls.
21+
- PASS: Added actionable error coverage for missing TTS Profile.
22+
- PASS: Added actionable error coverage for missing Emotion Setting on the selected profile.
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# PR_26171_BETA_083 Manual Validation Notes
2+
3+
## Manual Review
4+
- Reviewed changed Message Studio markup for removed duplicate controls.
5+
- Reviewed changed Message Studio JavaScript for removed speech-test state and render paths.
6+
- Reviewed changed TTS Studio labels for Profile, Age Filter, and Delivery Preset wording.
7+
- Reviewed Playwright coverage for missing TTS Profile and missing Emotion Setting error states.
8+
9+
## Browser Validation
10+
- Targeted Playwright validation covered Message Studio and TTS Studio flows.
11+
- No separate manual browser session was required beyond the automated browser validation.
12+
13+
## Packaging
14+
- Delta ZIP is required under tmp/ and must not be staged.
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# PR_26171_BETA_083 Message/TTS UX Checklist
2+
3+
## Message Studio
4+
- PASS: Messages parent table label is creator-friendly.
5+
- PASS: Message Parts child table uses Part Text, Emotion, TTS Profile, Status, and Actions.
6+
- PASS: Play Part label remains clear.
7+
- PASS: Play Message label remains clear.
8+
- PASS: Stop control is labeled Stop Playback.
9+
- PASS: Missing TTS Profile produces a visible actionable error.
10+
- PASS: Missing Emotion Setting on the selected TTS Profile produces a visible actionable error.
11+
- PASS: Duplicate TTS/Profile/Emotion controls were not left outside the tables.
12+
13+
## TTS Studio
14+
- PASS: TTS Profile parent table uses creator-friendly Profile labeling.
15+
- PASS: Age is clarified as Age Filter.
16+
- PASS: Emotion Settings child table uses Delivery Preset labeling.
17+
- PASS: Delivery settings live in Emotion Settings.
18+
- PASS: Presets live in Emotion Settings.
19+
- PASS: Voice Filters live only in profile controls.
20+
- PASS: Duplicate summary/output panels were not introduced.
21+
22+
## Ownership
23+
- PASS: Message Studio owns text, ordered message parts, Emotion selection, and TTS Profile selection.
24+
- PASS: TTS Studio owns Voice, Language, Emotion Settings, Delivery, and Presets.
25+
- PASS: src/engine/audio owns playback.
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26171_BETA_083 Validation Report
2+
3+
## Static Checks
4+
- PASS: node --check toolbox/messages/messages.js
5+
- PASS: node --check toolbox/text-to-speech/text2speech.js
6+
- PASS: node --check tests/playwright/tools/MessagesTool.spec.mjs
7+
- PASS: node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs
8+
9+
## Targeted Message Studio Validation
10+
- PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --reporter=list
11+
- Result: 3 passed in 38.3s
12+
13+
## Targeted TTS Studio Validation
14+
- PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --reporter=list
15+
- Result: 3 passed in 53.1s
16+
17+
## Project Workspace Validation
18+
- PASS: npm run test:workspace-v2
19+
- Result: 5 passed in 1.7m
20+
- Note: Command name is legacy; user-facing language is Project Workspace.
21+
22+
## Validation Notes
23+
- A first parallel Message Studio run timed out while TTS validation was also running. The Message Studio suite passed on the targeted rerun.
24+
- Generated workspace report churn was restored before PR report files were written.
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
# PR_26171_BETA_083-message-tts-polish-and-dead-code
2+
3+
## Summary
4+
- Team: BETA
5+
- Scope: Message Studio and TTS Studio polish after parent/child table and playback integration.
6+
- Branch: pr/26171-BETA-083-message-tts-polish-and-dead-code
7+
- Instruction compliance: PASS
8+
9+
## Ownership Confirmation
10+
- BETA owns Message Studio work.
11+
- BETA owns TTS Studio and TextToSpeechEngine integration work.
12+
- Message Studio owns message text, ordered message parts, Emotion selection, and TTS Profile selection.
13+
- TTS Studio owns profiles, voices, language, per-profile emotion settings, Delivery, and Presets.
14+
- src/engine/audio owns playback.
15+
16+
## Changes
17+
- Removed dead Message Studio speech-test controls and unused selection code.
18+
- Replaced Message Studio speech-test status with playback readiness/status.
19+
- Kept Message Studio playback controls visible and clarified Stop as Stop Playback.
20+
- Updated Message parent and part table labels to be more creator-friendly.
21+
- Added explicit missing TTS Profile and missing Emotion Setting validation coverage.
22+
- Clarified TTS Profile table and Emotion Settings table labels.
23+
- Clarified that TTS presets belong to Emotion Settings as Delivery Preset.
24+
25+
## Architecture Notes
26+
- Theme V2 only.
27+
- External JavaScript only.
28+
- No inline styles, style blocks, inline handlers, page-local CSS, or tool-local CSS were added.
29+
- No database changes.
30+
- No separate Emotion Studio was added.
31+
- Browser-owned product data was not introduced as a source of truth.
32+
- Silent fallback for an explicitly stale TTS Profile selection was removed.
33+
34+
## Validation Summary
35+
- PASS: node --check toolbox/messages/messages.js
36+
- PASS: node --check toolbox/text-to-speech/text2speech.js
37+
- PASS: node --check tests/playwright/tools/MessagesTool.spec.mjs
38+
- PASS: node --check tests/playwright/tools/TextToSpeechFunctional.spec.mjs
39+
- PASS: npx playwright test tests/playwright/tools/TextToSpeechFunctional.spec.mjs --reporter=list
40+
- PASS: npx playwright test tests/playwright/tools/MessagesTool.spec.mjs --reporter=list
41+
- PASS: npm run test:workspace-v2
42+
43+
## Notes
44+
- The first parallel Message Studio Playwright run timed out during report contention; the targeted Message Studio rerun passed by itself.
45+
- npm run test:workspace-v2 is a legacy command name; user-facing language remains Project Workspace.
Lines changed: 13 additions & 125 deletions
Original file line numberDiff line numberDiff line change
@@ -1,125 +1,13 @@
1-
PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff
2-
3-
Git workflow:
4-
- Current branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
5-
- Created branch: pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
6-
- Push result: PASS; pushed to origin/pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff
7-
- PR URL: https://github.com/ToolboxAid/HTML-JavaScript-Gaming/pull/32
8-
- Merge approval status: pending explicit Team Alpha owner approval
9-
- Merge result: not performed; merge is blocked until explicit Team Alpha owner approval
10-
- Rebase/conflict resolution: PASS; rebased onto origin/main at e8845dae6 after GitHub reported the branch was behind current main. Conflicts were limited to generated Codex report artifacts and reports were regenerated.
11-
- Latest rebase/conflict resolution: PASS; rebased onto origin/main at 195c90a64 after PR_26171_BETA_075 landed. Conflicts were resolved in generated Codex report artifacts and tests/playwright/tools/RootToolsFutureState.spec.mjs; the test expectations now preserve current-main Text To Speech coverage and ALPHA_047 canonical game-hub route/filter behavior.
12-
- Final approved rebase: PASS; Team Alpha approval granted for ALPHA_047, rebased onto origin/main at 1451a1173, with conflicts limited to generated Codex report artifacts.
13-
14-
Instruction compliance:
15-
- PASS: docs_build/dev/PROJECT_INSTRUCTIONS.md was read before file changes.
16-
- PASS: docs_build/dev/PROJECT_MULTI_PC.txt was read before file changes.
17-
- PASS: BUILD_PR.md was created and read before implementation.
18-
- PASS: Team Alpha owner scope applies to Game Hub, Game Journey handoff, and Idea Board continuity.
19-
- PASS: Full samples smoke was not run.
20-
21-
Validation:
22-
- PASS: node --check toolbox/game-hub/game-hub.js
23-
- PASS: node --check toolbox/game-hub/game-hub-api-client.js
24-
- PASS: node --check toolbox/idea-board/index.js
25-
- PASS: node --check toolbox/game-journey/game-journey.js
26-
- PASS: node --check src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
27-
- PASS: node --check src/dev-runtime/server/local-api-router.mjs
28-
- PASS: node --check tests/playwright/tools/GameHubMockRepository.spec.mjs
29-
- PASS: node --check tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
30-
- PASS: node --check tests/playwright/tools/GameJourneyTool.spec.mjs
31-
- PASS: npx playwright test tests/playwright/tools/GameHubMockRepository.spec.mjs --project=playwright --workers=1 --reporter=line (11 passed)
32-
- PASS: npx playwright test tests/playwright/tools/IdeaBoardTableNotes.spec.mjs --project=playwright --workers=1 --reporter=line (2 passed)
33-
- PASS: npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs --project=playwright --workers=1 --reporter=line --grep "Game Hub hands the active game route to Game Journey|Game Journey requires an active game" (2 passed)
34-
- PASS: npm run test:workspace-v2 (5 passed)
35-
- PASS: git diff --check (line-ending warnings only)
36-
- PASS: Completion revalidation for PR_26171_ALPHA_048 start-gate blocker; ALPHA_047 scoped validation was rerun while still on branch pr/26171-ALPHA-047-game-hub-canonical-path-journey-handoff, and ALPHA_048 implementation was not started.
37-
- PASS: Latest post-rebase validation after origin/main 195c90a64: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.
38-
- PASS: Final approved validation after origin/main 1451a1173: syntax checks, targeted Game Hub Playwright, targeted Idea Board Playwright, targeted Game Journey handoff Playwright, and npm run test:workspace-v2.
39-
40-
Requirement-by-requirement evidence:
41-
- PASS: Rename active path toolbox/game-workspace/ to toolbox/game-hub/.
42-
- PASS: Rename active game-workspace.js to game-hub.js.
43-
- PASS: Rename active game-workspace-api-client.js to game-hub-api-client.js.
44-
- PASS: Deep-audit and update imports, variables, data attributes, tests, toolbox navigation/registry, tool display mode slug, page titles, and creator-facing labels to Game Hub.
45-
- PASS: Do not leave active navigation pointing to toolbox/game-workspace; active route audit found no active legacy route.
46-
- PASS: Do not create duplicate active Game Hub paths; registry reads filter stale game-workspace rows and active metadata points to game-hub.
47-
- PASS: Idea Board Create Project creates/links a Game Hub project when a Ready idea becomes Project.
48-
- PASS: Project ideas lock original Idea, Pitch, and Notes.
49-
- PASS: Game Hub shows Source Idea/Pitch/Notes as read-only creator-facing content.
50-
- PASS: Game Journey receives executable Journey items from Idea notes when the linked project opens.
51-
- PASS: Original Idea notes are not mutated or moved.
52-
- PASS: Project/source-linked actions avoid Delete and use Open in Game Hub plus Archive.
53-
- PASS: No real database migration was added; existing shared mock/server contracts are reused.
54-
- PASS: Merge is not performed without explicit Team Alpha owner approval.
55-
56-
Changed files:
57-
- deleted: assets/theme-v2/images/badges/game-workspace-1024.png
58-
- deleted: assets/theme-v2/images/badges/game-workspace.png
59-
- added: assets/theme-v2/images/badges/game-hub-1024.png
60-
- added: assets/theme-v2/images/badges/game-hub.png
61-
- deleted: assets/theme-v2/images/tools/game-workspace-1024.png
62-
- deleted: assets/theme-v2/images/tools/game-workspace.png
63-
- added: assets/theme-v2/images/tools/game-hub-1024.png
64-
- added: assets/theme-v2/images/tools/game-hub.png
65-
- updated: assets/theme-v2/js/account-achievements.js
66-
- updated: assets/theme-v2/js/gamefoundry-partials.js
67-
- updated: assets/theme-v2/partials/header-nav.html
68-
- updated: docs_build/database/ddl/game-workspace.sql
69-
- updated: docs_build/database/dml/DML_INDEX.md
70-
- updated: docs_build/database/dml/game-workspace.sql
71-
- updated: docs_build/database/seed/game-workspace.json
72-
- updated: docs_build/database/seed/guest/game-workspace.json
73-
- updated: docs_build/dev/admin-notes/deployment-uat-prod/index.txt
74-
- added: docs_build/dev/reports/codex_changed_files.txt
75-
- added: docs_build/dev/reports/codex_review.diff
76-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/APPLY_PR.md
77-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/BUILD_PR.md
78-
- added: docs_build/pr/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff/PLAN_PR.md
79-
- deleted: learn/game-workspace/index.html
80-
- added: learn/game-hub/index.html
81-
- updated: learn/getting-started/index.html
82-
- updated: learn/index.html
83-
- updated: package.json
84-
- updated: scripts/run-targeted-test-lanes.mjs
85-
- updated: scripts/validate-browser-env-agnostic.mjs
86-
- updated: scripts/validate-local-postgres-runtime.mjs
87-
- updated: src/dev-runtime/admin/header-nav.local.html
88-
- updated: src/dev-runtime/persistence/mock-db-store.js
89-
- updated: src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
90-
- updated: src/dev-runtime/seed/server-seed-loader.mjs
91-
- updated: src/dev-runtime/server/local-api-router.mjs
92-
- updated: src/shared/toolbox/tool-metadata-inventory.js
93-
- updated: tests/dev-runtime/DevRuntimeBoundary.test.mjs
94-
- updated: tests/dev-runtime/ProductDataProviderContractHardening.test.mjs
95-
- updated: tests/dev-runtime/SupabaseProductDataCutover.test.mjs
96-
- updated: tests/playwright/account/AchievementsPage.spec.mjs
97-
- updated: tests/playwright/tools/AdminDbViewer.spec.mjs
98-
- added: tests/playwright/tools/GameHubMockRepository.spec.mjs
99-
- updated: tests/playwright/tools/GameJourneyTool.spec.mjs
100-
- deleted: tests/playwright/tools/GameWorkspaceMockRepository.spec.mjs
101-
- updated: tests/playwright/tools/IdeaBoardTableNotes.spec.mjs
102-
- updated: tests/playwright/tools/RootToolsFutureState.spec.mjs
103-
- updated: tests/playwright/tools/ToolDisplayModeNavigation.spec.mjs
104-
- updated: tests/playwright/tools/ToolImageRegistry.spec.mjs
105-
- updated: tests/playwright/tools/ToolNavigationPrevNext.spec.mjs
106-
- updated: tests/playwright/tools/ToolboxRoutePages.spec.mjs
107-
- updated: toolbox/colors/index.html
108-
- updated: toolbox/controls/controls.js
109-
- updated: toolbox/controls/index.html
110-
- updated: toolbox/game-design/index.html
111-
- added: toolbox/game-hub/game-hub-api-client.js
112-
- added: toolbox/game-hub/game-hub.js
113-
- added: toolbox/game-hub/index.html
114-
- updated: toolbox/game-journey/game-journey.js
115-
- deleted: toolbox/game-workspace/game-workspace-api-client.js
116-
- deleted: toolbox/game-workspace/game-workspace.js
117-
- deleted: toolbox/game-workspace/index.html
118-
- updated: toolbox/idea-board/index.js
119-
- updated: toolbox/project-workspace/index.html
120-
- updated: toolbox/tools-page-accordions.js
121-
122-
ZIP:
123-
- Path: tmp/PR_26171_ALPHA_047-game-hub-canonical-path-journey-handoff_delta.zip
124-
- Size: generated after branch push; final byte size is reported in the delivery response because the ZIP is not committed.
125-
- Contents: repo-structured scoped delta files. Deleted legacy paths are documented in the changed-files list and are not represented as physical files in the archive.
1+
docs_build/dev/reports/codex_changed_files.txt
2+
docs_build/dev/reports/codex_review.diff
3+
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-dead-code-cleanup-checklist.md
4+
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-manual-validation-notes.md
5+
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-message-tts-ux-checklist.md
6+
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code-validation-report.md
7+
docs_build/dev/reports/PR_26171_BETA_083-message-tts-polish-and-dead-code.md
8+
tests/playwright/tools/MessagesTool.spec.mjs
9+
tests/playwright/tools/TextToSpeechFunctional.spec.mjs
10+
toolbox/messages/index.html
11+
toolbox/messages/messages.js
12+
toolbox/text-to-speech/index.html
13+
toolbox/text-to-speech/text2speech.js

0 commit comments

Comments
 (0)