Skip to content

Commit ffc1870

Browse files
ToolboxAidToolboxAid
committed
Merge PR #215 PR_26177_CHARLIE_006-system-health-dashboard-complete
# Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
2 parents 7acacc2 + d6fd338 commit ffc1870

11 files changed

Lines changed: 1232 additions & 1178 deletions

‎admin/system-health.html‎

Lines changed: 20 additions & 20 deletions
Large diffs are not rendered by default.

‎docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
# PR_26177_CHARLIE_006-system-health-dashboard-complete
2+
3+
Team: Charlie
4+
Branch: PR_26177_CHARLIE_006-system-health-dashboard-complete
5+
Base: main
6+
Scope: System Health Dashboard completion polish
7+
8+
## Summary
9+
10+
- Removed stale foundation and placeholder wording from the Admin System Health dashboard source.
11+
- Kept unavailable provider metrics explicit with safe `PENDING` status and clear reasons.
12+
- Updated service health cards to display `PASS`, `WARN`, `FAIL`, or `NOT CONFIGURED` directly.
13+
- Preserved the Web UI to API/service contract flow; the browser still renders only server-owned System Health data.
14+
- Added targeted assertions for placeholder removal, service status display, secret masking, current-environment-only checks, and externalized Theme V2 script/style rules.
15+
16+
## Changed Files
17+
18+
- `admin/system-health.html`
19+
- `src/dev-runtime/server/local-api-router.mjs`
20+
- `tests/dev-runtime/AdminHealthOperations.test.mjs`
21+
- `tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
22+
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md`
23+
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md`
24+
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md`
25+
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md`
26+
- `docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md`
27+
- `docs_build/dev/reports/codex_changed_files.txt`
28+
- `docs_build/dev/reports/codex_review.diff`
29+
30+
## Validation
31+
32+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
33+
- PASS: `node --check tests/dev-runtime/AdminHealthOperations.test.mjs`
34+
- PASS: `node --check tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
35+
- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs`
36+
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1`
37+
38+
## Artifact
39+
40+
- `tmp/PR_26177_CHARLIE_006-system-health-dashboard-complete_delta.zip`

‎docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# PR_26177_CHARLIE_006 Branch Validation
2+
3+
Result: PASS
4+
5+
Checks:
6+
- PASS: Started from `main`.
7+
- PASS: Worktree was clean before branch creation.
8+
- PASS: Local/origin sync was `0/0` before branch creation.
9+
- PASS: Branch `PR_26177_CHARLIE_006-system-health-dashboard-complete` was created from current `main`.
10+
- PASS: Scope stayed within System Health Dashboard completion.
11+
- PASS: No `start_of_day` files changed.
12+
- PASS: No direct commits to `main`.
13+
- PASS: PR branch retained for review.

‎docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR_26177_CHARLIE_006 Manual Validation Notes
2+
3+
- Confirmed System Health dashboard copy no longer contains stale `foundation PR`, `foundation view`, `placeholder`, `Pending metric`, or `intentionally not wired` wording.
4+
- Confirmed provider metrics that are not available remain visibly marked `PENDING` with explanatory reasons.
5+
- Confirmed service cards retain existing Theme V2 card layout while displaying direct health status values.
6+
- Confirmed secret-like runtime variables remain masked as `********`.
7+
- Confirmed current-environment System Health behavior remains intact; peer environments are reference-only.
8+
- Confirmed no runtime/UI/API/database files outside the scoped System Health files were changed.
9+
- Confirmed no `start_of_day` files were changed.

‎docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26177_CHARLIE_006 Requirement Checklist
2+
3+
- PASS: Environment Summary remains current-deployment only.
4+
- PASS: Postgres Health remains API/service-owned and displays safe values only.
5+
- PASS: R2/Storage Health remains current-environment only.
6+
- PASS: Runtime Environment Variables render from server-owned diagnostics.
7+
- PASS: Runtime variables remain alphabetically sorted by key.
8+
- PASS: Secret-like runtime values remain masked.
9+
- PASS: Service Health cards now display direct `PASS`, `WARN`, `FAIL`, or `NOT CONFIGURED` text.
10+
- PASS: Stale foundation and placeholder wording removed from the dashboard source.
11+
- PASS: Empty/error states remain explicit `PENDING`, `WARN`, or `FAIL` with reasons.
12+
- PASS: Theme V2 layout and externalized scripts/styles preserved.
13+
- PASS: No inline styles, style blocks, script blocks, or inline event handlers introduced.
14+
- PASS: Browser does not own authoritative product data.
15+
- PASS: No MEM DB, local-mem, fake-login, browser storage SSoT, silent fallback, hidden default, or SQLite direction introduced.
16+
- PASS: Targeted tests updated and run.
17+
- PASS: Required reports and delta ZIP created.

‎docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR_26177_CHARLIE_006 Validation Lane
2+
3+
Impacted lanes:
4+
- Admin System Health page
5+
- Local API Admin System Health status contract
6+
- System Health Playwright page coverage
7+
8+
Commands:
9+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
10+
- PASS: `node --check tests/dev-runtime/AdminHealthOperations.test.mjs`
11+
- PASS: `node --check tests/playwright/tools/AdminHealthOperationsPage.spec.mjs`
12+
- PASS: `node --test tests/dev-runtime/AdminHealthOperations.test.mjs tests/api/admin-system-health/contract.test.mjs`
13+
- 6 tests passed.
14+
- PASS: `npx playwright test tests/playwright/tools/AdminHealthOperationsPage.spec.mjs --workers=1`
15+
- 3 tests passed.
16+
17+
Skipped lanes:
18+
- Full samples smoke was not run; this PR only touches targeted Admin System Health dashboard behavior and tests.
19+
20+
Result: PASS

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,28 @@
1-
docs_build/dev/BUILD_PR.md
2-
docs_build/dev/PLAN_PR.md
3-
docs_build/dev/reports/PR_26177_006-shared-time-foundation.md
4-
docs_build/dev/reports/PR_26177_006-shared-time-foundation_branch-validation.md
5-
docs_build/dev/reports/PR_26177_006-shared-time-foundation_closeout.md
6-
docs_build/dev/reports/PR_26177_006-shared-time-foundation_manual-validation-notes.md
7-
docs_build/dev/reports/PR_26177_006-shared-time-foundation_requirement-checklist.md
8-
docs_build/dev/reports/PR_26177_006-shared-time-foundation_validation-lane.md
9-
docs_build/dev/reports/codex_changed_files.txt
10-
docs_build/dev/reports/codex_review.diff
11-
src/shared/time/time.js
12-
tests/shared/TimeFoundation.test.mjs
1+
# git status --short
2+
M admin/system-health.html
3+
M docs_build/dev/reports/codex_changed_files.txt
4+
M docs_build/dev/reports/codex_review.diff
5+
M src/dev-runtime/server/local-api-router.mjs
6+
M tests/dev-runtime/AdminHealthOperations.test.mjs
7+
M tests/playwright/tools/AdminHealthOperationsPage.spec.mjs
8+
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md
9+
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md
10+
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md
11+
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md
12+
?? docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md
13+
14+
# git ls-files --others --exclude-standard
15+
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete.md
16+
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_branch-validation.md
17+
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_manual-validation-notes.md
18+
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_requirements-checklist.md
19+
docs_build/dev/reports/PR_26177_CHARLIE_006-system-health-dashboard-complete_validation-lane.md
20+
21+
# git diff --stat
22+
admin/system-health.html | 40 +-
23+
docs_build/dev/reports/codex_changed_files.txt | 42 +-
24+
docs_build/dev/reports/codex_review.diff | 765 +++++++++------------
25+
src/dev-runtime/server/local-api-router.mjs | 10 +-
26+
tests/dev-runtime/AdminHealthOperations.test.mjs | 3 +-
27+
.../tools/AdminHealthOperationsPage.spec.mjs | 4 +-
28+
6 files changed, 393 insertions(+), 471 deletions(-)

0 commit comments

Comments
 (0)