[FEATURE] server: update template to another template type

[DaanHoogland]

Is your feature request related to a problem? Please describe.
A new feature implemented in apache/cloudstack#3945 needs primate implementation

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[PaulAngus]

We were in a code freeze yesterday. please revert this commit

[davidjumani]

@PaulAngus The backend commit went in October, the UI component was merged a couple of days ago. Should the UI addition be reverted? That would make the feature unaccessible for a user / admin

[yadvr]

We merged the UI PR yesterday based on David and Gabriels' review, as the backend PR was already merged in Oct.
@PaulAngus to revert both frontend/backend PRs/commits see revert button at the bottom of any merged PR for ex #838 (comment), or it would be polite to request Wei to send a revert PR for the backend PR apache/cloudstack#3945 merged in Oct and Rakesh to send a revert PR for UI changes.

[PaulAngus]

The proposed UI change does not match the functionality described in the Backend PR which only allows changes between user and system. the UI screenshot shows changes to/from all types.

The UI change needs reverting -admins can use the API.

The [(https://github.com/apache/cloudstack/pull/3945)] logic also looks to be flawed, as the description does not suggest that the system VM template that was active is updated to inactive. - leaving the DB in an inconsistent state.

it really needs fixing or reverting.

@rhtyd @DaanHoogland @weizhouapache @ravening

[ravening]

@PaulAngus if I'm not mistaken, even in backend, you can change template type from any to any

[PaulAngus]

Thanks for clarifying @ravening, but that make might make it worse as:

• The description does not suggest that the system VM template that was active is updated to inactive. - leaving the DB in an inconsistent state.
• The testing description only says that only user -> system was tested.
• And I can't see anything that looks like the backend operations like downloading system VM templates to all secondary storage pools.
• User VM templates are only supposed to be in one pool, so what happens there? Cloudstack isn't going to be expecting user templates in all sec storage pools - hows deletion and GC going to work?
• Builtin templates should be in all secondary storage pools as well. do they get downloaded?

[DaanHoogland]

@PaulAngus , in your points above I only read items that come down to "the operator should know what they are doing". I hope I am not missing any. Is the UI bit only for admins, @ravening ?