Inline shadcn compatibility tokens

[kmcginnes]

The CSS has compatibility aliases for shadcn/Radix components that create a parallel vocabulary:

--color-destructive: var(--color-danger);
--color-popover: var(--color-background);
--color-popover-foreground: var(--color-foreground);

And the accent tokens serve double duty as both shadcn compat and highlight/selection semantics:

--color-accent-foreground: var(--color-primary-foreground);
--color-accent: var(--color-primary-subtle);
--color-accent-hover: var(--color-primary-subtle-hover);

Tasks:

1. Rewrite text-destructive → text-danger, bg-destructive → bg-danger etc. in shadcn-origin components (DropdownMenu, AlertDialog, Dialog)
2. Rewrite bg-popover/text-popover-foreground → bg-background/text-foreground
3. Evaluate accent usages — if they only appear in shadcn components for focus/selection highlights, rewrite to primary-subtle/primary-foreground directly. If they serve a distinct semantic role worth keeping, document it in design.md instead.
4. Delete the compat alias declarations from index.css

Acceptance Criteria

• No destructive, popover, or popover-foreground tokens remain in @theme or component code
• accent tokens either inlined or documented in design.md with clear distinction from primary-subtle
• pnpm checks passes
• pnpm test passes

Related Issues

• Part of Define design system and align codebase styling #1952
• Blocked by Strip orphaned dark mode fragments #1955

---

Important

Internal only — this issue is maintained by the core team and is not accepting external contributions.