From 4d719eb6d8069de0f11994eed8910290e124ad7e Mon Sep 17 00:00:00 2001 From: bluwy Date: Thu, 18 Jun 2026 23:20:16 +0800 Subject: [PATCH] Refactor const to functions --- src/core.ts | 35 +++++++++++++++++++---------------- src/git.ts | 6 +++--- 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/src/core.ts b/src/core.ts index 667e505..7594b0f 100644 --- a/src/core.ts +++ b/src/core.ts @@ -21,17 +21,20 @@ function getBaseRefSha( return baseRef.target.oid; } -const isAlreadyExistingRefError = (error: unknown) => - typeof error === "object" && - error !== null && - "status" in error && - "message" in error && - typeof error.status === "number" && - typeof error.message === "string" && - error.status === 422 && - error.message.includes("Reference already exists"); - -const createCommit = async ({ +function isAlreadyExistingRefError(error: unknown) { + return ( + typeof error === "object" && + error !== null && + "status" in error && + "message" in error && + typeof error.status === "number" && + typeof error.message === "string" && + error.status === 422 && + error.message.includes("Reference already exists") + ); +} + +async function createCommit({ octokit, refId, baseSha, @@ -40,7 +43,7 @@ const createCommit = async ({ }: Pick & { refId: string; baseSha: string; -}) => { +}) { // we have to stick to GraphQL here as with REST, each file change would become a separate API call return createCommitOnBranchQuery(octokit, { input: { @@ -52,9 +55,9 @@ const createCommit = async ({ fileChanges, }, }); -}; +} -export const commitFilesFromBase64 = async ({ +export async function commitFilesFromBase64({ octokit, owner, repo, @@ -63,7 +66,7 @@ export const commitFilesFromBase64 = async ({ force = false, message, fileChanges, -}: CommitFilesFromBase64Args): Promise => { +}: CommitFilesFromBase64Args): Promise { const baseRef = resolveGitRef(base); const targetRef = `refs/heads/${branch}`; @@ -225,4 +228,4 @@ export const commitFilesFromBase64 = async ({ return { refId: newCommit.createCommitOnBranch?.ref?.id ?? null, }; -}; +} diff --git a/src/git.ts b/src/git.ts index 8ea4cb8..b2a7826 100644 --- a/src/git.ts +++ b/src/git.ts @@ -9,12 +9,12 @@ import type { } from "./interface.ts"; import { resolveGitRef } from "./utils.ts"; -export const commitChangesFromRepo = async ({ +export async function commitChangesFromRepo({ cwd: workingDirectory, recursivelyFindRoot = true, filterFiles, ...otherArgs -}: CommitChangesFromRepoArgs): Promise => { +}: CommitChangesFromRepoArgs): Promise { const ref = resolveGitRef(otherArgs.base ?? { commit: "HEAD" }); const cwd = path.resolve(workingDirectory); const repoRoot = recursivelyFindRoot ? await findGitRoot(cwd) : cwd; @@ -36,7 +36,7 @@ export const commitChangesFromRepo = async ({ commit: refSha, }, }); -}; +} // Exported for testing only export async function getFileChanges(