From d9b0da8bc6d077693b61fba82a0f5cac36d3612d Mon Sep 17 00:00:00 2001 From: jonsykescherre Date: Tue, 30 Jun 2026 19:02:43 -0400 Subject: [PATCH] Chore: remove stale ML-pin comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The two comments in `concepts-ml` (`pyproject.toml`) were written when torch 2.2 was the resolved version and warned about numpy 2.x ABI breaks and a transformers 5.x NameError. Both were torch-2.2-specific. On main today, pip resolves torch 2.12, sentence-transformers 5.6, transformers 5.12, and numpy 2.4 — concepts-ml CI passes against that combination. The comments now mislead more than they help; the pins themselves are preserved as belt-and-braces. --- tools/extractors/pyproject.toml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/extractors/pyproject.toml b/tools/extractors/pyproject.toml index 71694b3..f1dfe42 100644 --- a/tools/extractors/pyproject.toml +++ b/tools/extractors/pyproject.toml @@ -38,11 +38,7 @@ docs = [ # extra rather than the base dependency set. The default string-similarity # pass (`cora concepts suggest`) needs none of this. concepts-ml = [ - # sentence-transformers 5.x pulls transformers 5.x which has a NameError - # in transformers/integrations/accelerate.py against torch 2.2; pin <5. "sentence-transformers>=3,<6", - # The transitive torch+sentence-transformers combo needs numpy 1.x — torch - # 2.2's pre-built wheels predate the numpy 2.x ABI break. "numpy>=1.26,<3", ]