You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Link the implementing PR to this issue by including Closes #<issue_number>
in the PR description or commit message.
What
Remove continue-on-error: true from the QA / Sanitizers CI job so that
unresolved sanitizer findings block PR merges.
The flag was added intentionally when the job was introduced because the codebase
had pre-existing sanitizer findings. Once all findings tracked in #76, #77, #78, #79
are fixed, this gate can be made blocking.
Important
Link the implementing PR to this issue by including
Closes #<issue_number>in the PR description or commit message.
What
Remove
continue-on-error: truefrom theQA / SanitizersCI job so thatunresolved sanitizer findings block PR merges.
The flag was added intentionally when the job was introduced because the codebase
had pre-existing sanitizer findings. Once all findings tracked in #76, #77, #78, #79
are fixed, this gate can be made blocking.
Acceptance Criteria
continue-on-error: trueremoved from thesanitizersjob in.github/workflows/sanitizers.ymlQA / SanitizersCI job passes without findings on a clean branchReferences