From 19237a405ee70b4620ed1d30aa5edbee8ef05243 Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Wed, 22 Jul 2026 08:55:04 +0200 Subject: [PATCH] docs: Fix stale pod-install script names in CONTRIBUTING The `yarn pod-install*` commands in the "Run the emulators" sections no longer exist in the RN sample; the scripts were renamed to the `pod-install-{debug,release}-{static,dynamic}[-legacy]` pattern. Update the docs to match and add a note about the #6413 xcframework default and the SENTRY_USE_XCFRAMEWORK=0 escape hatch. Co-Authored-By: Claude Opus 4.8 (1M context) --- CONTRIBUTING.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d3ca6dddde..a1380e6bf8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -82,13 +82,13 @@ Recommended is to open the native project in `samples/react-native/android` and For android switch `newArchEnabled` to `false` in [android/gradle.properties](https://github.com/getsentry/sentry-react-native/blob/c95aa21497ca93aaaaf0b44d170dc39dc7bcf660/sample-new-architecture/android/gradle.properties#L40). For iOS explicitly disable fabric in `samples/react-native/ios/Podfile` by setting `:fabric_enabled => false` before `pod install`. ```sh -yarn pod-install-legacy +yarn pod-install-debug-static-legacy yarn react-native run-ios yarn react-native run-android # Release builds -yarn pod-install-legacy-production +yarn pod-install-release-static-legacy yarn react-native run-ios --mode=Release yarn react-native run-android --mode=release @@ -96,18 +96,20 @@ yarn react-native run-android --mode=release ### Run the emulators (new-architecture): ```sh -yarn pod-install +yarn pod-install-debug-static yarn react-native run-ios yarn react-native run-android # Release builds -yarn pod-install-production +yarn pod-install-release-static yarn react-native run-ios --mode=Release yarn react-native run-android --mode=Release ``` +The `pod-install-*` scripts follow the pattern `pod-install-{debug,release}-{static,dynamic}[-legacy]` (dynamic variants build with frameworks as dynamic libraries). Since [#6413](https://github.com/getsentry/sentry-react-native/pull/6413), `pod install` downloads a prebuilt `Sentry.xcframework` from sentry-cocoa's GitHub release and vendors it, instead of building Sentry from source. Set `SENTRY_USE_XCFRAMEWORK=0` before `pod install` to restore the previous source-build behavior (e.g. for offline builds). + ## Running the macOS sample Head to the macOS sample root directory: