Build test with CMake failed

[chenqiuhao1997]

Build test with CMake failed with error below.

[cmake] CMake Error at third/tcmalloc/tcmalloc/tcmalloc_helpers.cmake:75 (target_link_libraries):
[cmake]   Target "tcmalloc_testing_tcmalloc_test_small_but_slow_with_assertions"
[cmake]   links to:
[cmake] 
[cmake]     tcmalloc::tcmalloc_small_but_slow_with_assertions
[cmake] 
[cmake]   but the target was not found.  Possible reasons include:
[cmake] 
[cmake]     * There is a typo in the target name.
[cmake]     * A find_package call is missing for an IMPORTED target.
[cmake]     * An ALIAS target is missing.

This bug may be caused by the commit 88d9d1e which forgot to remove tcmalloc_cc_test with NAME ${TCMALLOC_NAME}_small_but_slow_with_assertions around codes below.

tcmalloc/tcmalloc/tcmalloc_variants.cmake

Lines 126 to 133 in 6bdb786

	tcmalloc_cc_test(NAME ${TCMALLOC_NAME}_small_but_slow_with_assertions
	SRCS ${TCMALLOC_SRCS}
	HDRS ${TCMALLOC_HDRS}
	COPTS ${TCMALLOC_COPTS} -DTCMALLOC_INTERNAL_SMALL_BUT_SLOW
	LINKOPTS ${TCMALLOC_LINKOPTS}
	DEPS ${TCMALLOC_DEPS} $<LINK_LIBRARY:WHOLE_ARCHIVE,tcmalloc::tcmalloc_small_but_slow_with_assertions,tcmalloc::common_small_but_slow_with_assertions>
	)
	set_tests_properties(${TCMALLOC_NAME}_small_but_slow_with_assertions PROPERTIES ENVIRONMENT "TEST_TMPDIR=${CMAKE_CURRENT_BINARY_DIR};TEST_SRCDIR=${CMAKE_SOURCE_DIR}")

Are there any requirements for creating a PR if necessary?

[chenqiuhao1997]

By the way, build test with CMake version 3.26.5 would fail with error below.

CMake Error at third/tcmalloc/tcmalloc/tcmalloc_helpers.cmake:61 (add_executable):
  Impossible to link target 'tcmalloc_testing_tcmalloc_test_8k_pages' because
  the link item 'tcmalloc_common_8k_pages', specified without any feature or
  'DEFAULT' feature, has already occurred with the feature 'WHOLE_ARCHIVE',
  which is not allowed.
Call Stack (most recent call first):
  third/tcmalloc/tcmalloc/tcmalloc_variants.cmake:94 (tcmalloc_cc_test)
  third/tcmalloc/tcmalloc/testing/CMakeLists.txt:51 (tcmalloc_cc_test_variants)

This bug may be caused by WHOLE_ARCHIVE LIBRARY double declared in both TCMALLOC_DEPS and LINK_LIBRARY with different settings about WHOLE_ARCHIVE.

tcmalloc/tcmalloc/tcmalloc_variants.cmake

Lines 94 to 101 in 662170f

	tcmalloc_cc_test(NAME ${TCMALLOC_NAME}_8k_pages
	SRCS ${TCMALLOC_SRCS}
	HDRS ${TCMALLOC_HDRS}
	COPTS ${TCMALLOC_COPTS}
	LINKOPTS ${TCMALLOC_LINKOPTS}
	DEPS ${TCMALLOC_DEPS} $<LINK_LIBRARY:WHOLE_ARCHIVE,tcmalloc::tcmalloc,tcmalloc::common_8k_pages>
	)
	set_tests_properties(${TCMALLOC_NAME}_8k_pages PROPERTIES ENVIRONMENT "TEST_TMPDIR=${CMAKE_CURRENT_BINARY_DIR};TEST_SRCDIR=${CMAKE_SOURCE_DIR}")

But CMake version 3.31.8 seems no this WHOLE_ARCHIVE problem.