[release/3.30] Feedback on the current status of 3.30.0-alpha: Go version (& userauth); psiphon compatibility issues

[NewEraCracker]

Hello,

Please consider upgrading to Go 1.26 instead of Go 1.25.3.

The new release is set to use Go 1.25.3 (released 2025-10-13), but there are several reasons to upgrade to Go 1.26 instead:

• Current choice: Go 1.25.3 (2025-10-13);
• The previous CLI release/3.29: Go 1.24.12 (2026-01-15);
• Recommended: Go 1.26;

Alternative: At minimum, Go 1.25.12 (released 2026-07-07) includes security fixes to the crypto/tls and os packages, as well as bug fixes to the compiler, the go command, and the net and os packages.

My two cents. Thank you.

Related to: #1790

(More details below...)

[NewEraCracker]

While I admit my environment could be unsupported, this seems to be a clear programming mistake.
Edit: Nevermind.

User authentication build failure - Building fails with a missing header file error:
Edit: This is a local issue as I am not using the supported building toolchain or OS.

go build -v -ldflags "-s -w" ./cmd/ooniprobe

github.com/ooni/probe-cli/v3/internal/userauth
# github.com/ooni/probe-cli/v3/internal/userauth
internal\userauth\userauth_cgo.go:15:11: fatal error: ooniprobe_userauth.h: No such file or directory
   15 | // #include "ooniprobe_userauth.h"
      |           ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

The workaround being to skip the userauth:

go build -tags=nouserauth -v -ldflags "-s -w" ./cmd/ooniprobe

My two cents. Thank you.

---

Another bug: psiphon is disabled by default if using go1.25; a possible patch:

diff --git a/internal/feature/psiphonfeat/psiphon_enabled.go b/internal/feature/psiphonfeat/psiphon_enabled.go
index d1906831..b7462b0a 100644
--- a/internal/feature/psiphonfeat/psiphon_enabled.go
+++ b/internal/feature/psiphonfeat/psiphon_enabled.go
@@ -1,4 +1,4 @@
-//go:build !go1.25 && !ooni_feature_disable_psiphon
+//go:build !ooni_feature_disable_psiphon

 package psiphonfeat

diff --git a/internal/feature/psiphonfeat/psiphon_otherwise.go b/internal/feature/psiphonfeat/psiphon_otherwise.go
index c1fe01cf..2356e1da 100644
--- a/internal/feature/psiphonfeat/psiphon_otherwise.go
+++ b/internal/feature/psiphonfeat/psiphon_otherwise.go
@@ -1,4 +1,4 @@
-//go:build go1.25 || ooni_feature_disable_psiphon
+//go:build ooni_feature_disable_psiphon

 package psiphonfeat

Edit: This is not finished yet. LOL.

panic: tls: ConnectionState is not equal to tls.ConnectionState: struct field count mismatch: 17 vs 16

goroutine 1 [running]:
github.com/Psiphon-Labs/psiphon-tls.init.0()
        C:/Users/Developer/go/pkg/mod/github.com/!psiphon-!labs/psiphon-tls@v0.0.0-20250318183125-2a2fae2db378/unsafe.go:44 +0xd9

This could be a show stopper for 1.25 as they've rebased for 1.26: https://github.com/Psiphon-Labs/psiphon-tls/tree/release-branch.go1.26

[NewEraCracker]

I leave the userauth bug to those who may know how to solve it. The PR focus solely on fixing psiphon compatibility issues.

Edit: If desired, the developer team should have to look into upgrading the userauth static lib to Go 1.26. The issue is local as well.

My two cents. Thank you.

[DecFox]

Hello @NewEraCracker thanks for raising the issue, we do not intend to support go1.26 at the time. However, we have taken into consideration the security patches landed in go.1.25.12 and therefore will be upgrading to the version before we tag a new release.

Another bug: psiphon is disabled by default if using go1.25;

Unfortunately, psiphon support has been disabled for OONI Probe since v3.29.0 (changes here: #1762). More here: #1804 (comment)

User authentication build failure

Actually building from source requires developers to build/pull the staticlib for userauth. Can you share the os/arch you are trying to build on. I suggest using make while building from source:

USERAUTH_FROM_SOURCE=1 make CLI/ooniprobe

if you want to build the staticlib from source. If the flag is unset, it will pull in the configured release from ooni/ooniprobe-rs. LMK if you face any issues with the same.

[NewEraCracker]

I will likely return to explore the userauth after the new version becomes stable. My environment is embedded and miscellaneous. If the need arises, I will share feedback privately over e-mail to the OONI team.

I understand that you are on the tight schedule for this release and very strict operational requirements. I may even consider forking the project for private use with Go 1.26 and other compatibility patches.

Thank you.

[DecFox]

We are not really opposed to upgrading to go1.26. I left my thoughts on this here: #1804 (comment). Thanks for testing the alpha, and sharing feedback. You are welcome to share anything you find here or over email to the team.

Thank you.