From 2a66e3dad0f0ec3383f337f175a15211357bf605 Mon Sep 17 00:00:00 2001 From: Akindele Michael <49593618+DeleMike@users.noreply.github.com> Date: Tue, 21 Jul 2026 11:07:42 +0100 Subject: [PATCH 1/4] chore: update pr_maintainer_workflow to resolve breaking changes --- .../workflows/pr_maintainer_checklist.yaml | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr_maintainer_checklist.yaml b/.github/workflows/pr_maintainer_checklist.yaml index a597805c..7e5516dc 100644 --- a/.github/workflows/pr_maintainer_checklist.yaml +++ b/.github/workflows/pr_maintainer_checklist.yaml @@ -45,12 +45,21 @@ jobs: - name: First PR Contributor Email Check id: first_interaction - uses: actions/first-interaction@v1 + uses: actions/first-interaction@v3 with: - repo-token: ${{ secrets.GITHUB_TOKEN }} - pr-message: | + repo_token: ${{ secrets.GITHUB_TOKEN }} + issue_message: | + ## Thank you for opening your first issue! 💙 + + - If you're not already a member of our [public Matrix community](https://matrix.to/#/#scribe_community:matrix.org), please consider joining! + - We'd suggest that you use the [Element](https://element.io/) client as well as [Element X](https://element.io/app) for a mobile app + - Join the `General` and `iOS` rooms once you're in + - Also consider attending our bi-weekly Saturday developer syncs! + - Details are shared in the `General` room on Matrix each Wednesday before the sync + - It would be great to meet you 😊 + pr_message: | ## First PR Commit Check - [ ] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution - - The contributor's name and icon in remote commits should be the same as what appears in the PR - - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local Scribe-iOS repo (can be set with `git config --global user.email "GITHUB_EMAIL"`) + - The contributor's name and icon in remote commits should be the same as what appears in the PR + - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local Scribe-iOS repo (can be set with `git config --global user.email "GITHUB_EMAIL"`) From f81a97bfcf1092f661770ee91023feb842721970 Mon Sep 17 00:00:00 2001 From: Andrew Tavis McAllister Date: Tue, 21 Jul 2026 18:11:09 +0200 Subject: [PATCH 2/4] Update indentation --- .github/workflows/pr_maintainer_checklist.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_maintainer_checklist.yaml b/.github/workflows/pr_maintainer_checklist.yaml index 7e5516dc..4805141d 100644 --- a/.github/workflows/pr_maintainer_checklist.yaml +++ b/.github/workflows/pr_maintainer_checklist.yaml @@ -61,5 +61,5 @@ jobs: ## First PR Commit Check - [ ] The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution - - The contributor's name and icon in remote commits should be the same as what appears in the PR - - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local Scribe-iOS repo (can be set with `git config --global user.email "GITHUB_EMAIL"`) + - The contributor's name and icon in remote commits should be the same as what appears in the PR + - If there's a mismatch, the contributor needs to make sure that the [email they use for GitHub](https://github.com/settings/emails) matches what they have for `git config user.email` in their local Scribe-iOS repo (can be set with `git config --global user.email "GITHUB_EMAIL"`) From 2b2cbbcfb48b831b5dee6cd1083a2802215ad6a2 Mon Sep 17 00:00:00 2001 From: Andrew Tavis McAllister Date: Tue, 21 Jul 2026 18:11:47 +0200 Subject: [PATCH 3/4] Update workflows --- .github/workflows/pr_maintainer_checklist.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_maintainer_checklist.yaml b/.github/workflows/pr_maintainer_checklist.yaml index 4805141d..2355ec20 100644 --- a/.github/workflows/pr_maintainer_checklist.yaml +++ b/.github/workflows/pr_maintainer_checklist.yaml @@ -14,7 +14,7 @@ jobs: pull-requests: write steps: - name: Thank You Message - uses: thollander/actions-comment-pull-request@v2 + uses: thollander/actions-comment-pull-request@v3 with: message: | ## Thank you for the pull request! 💙 @@ -32,7 +32,7 @@ jobs: > Scribe uses [Conventional Comments](https://conventionalcomments.org/) in reviews to make sure that communication is as clear as possible. - name: Add Checklist - uses: thollander/actions-comment-pull-request@v2 + uses: thollander/actions-comment-pull-request@v3 with: message: | ## Maintainer Checklist From 5ae652bab8e445719803e943bca52f2cc1bd78ff Mon Sep 17 00:00:00 2001 From: Andrew Tavis McAllister Date: Tue, 21 Jul 2026 18:14:37 +0200 Subject: [PATCH 4/4] Restrict tests to just when Swift files are changed --- .github/workflows/ci_swiftlint.yaml | 2 ++ .github/workflows/ci_test.yaml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/ci_swiftlint.yaml b/.github/workflows/ci_swiftlint.yaml index 5ad4e310..82c2fce9 100644 --- a/.github/workflows/ci_swiftlint.yaml +++ b/.github/workflows/ci_swiftlint.yaml @@ -7,6 +7,8 @@ on: - opened - reopened - synchronize + paths: + - "**/*.swift" push: branches: - main diff --git a/.github/workflows/ci_test.yaml b/.github/workflows/ci_test.yaml index fa987771..2f9ffd2f 100644 --- a/.github/workflows/ci_test.yaml +++ b/.github/workflows/ci_test.yaml @@ -7,6 +7,8 @@ on: - opened - reopened - synchronize + paths: + - "**/*.swift" push: branches: - main