From 5ba6461e4b858114cc44f84992525fbfc20ba49a Mon Sep 17 00:00:00 2001 From: Meredith Date: Fri, 29 May 2026 15:43:14 -0400 Subject: [PATCH 1/2] Fix Trefethen(Strip)General --- src/grid/onedgrid.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/grid/onedgrid.py b/src/grid/onedgrid.py index cf214e1e..c228d307 100644 --- a/src/grid/onedgrid.py +++ b/src/grid/onedgrid.py @@ -897,7 +897,7 @@ class TrefethenGeneral(OneDGrid): name = "Trefethen-Polynomial" - def __init__(self, npoints: int, quadrature: OneDGrid, d=9): + def __init__(self, npoints: int, quadrature: OneDGrid, d=9, **quadrature_params): r"""Generate 1D grid on :math:`[-1,1]` interval based on Trefethen-General. Parameters @@ -909,6 +909,8 @@ def __init__(self, npoints: int, quadrature: OneDGrid, d=9): d : Odd degree of the Taylor series polynomial of :math:`\sin^{-1}`\. Only d=1,5,9 are supported. + quadrature_params : dict + Additional parameters to pass to the General one-dimensional grid. Returns ------- @@ -918,7 +920,7 @@ def __init__(self, npoints: int, quadrature: OneDGrid, d=9): if not issubclass(quadrature, OneDGrid): raise TypeError(f"Quadrature {type(OneDGrid)} should be of type OneDgrid.") - grid = quadrature(npoints) + grid = quadrature(npoints, **quadrature_params) if d == 1: points = grid.points @@ -1057,7 +1059,7 @@ class TrefethenStripGeneral(OneDGrid): name = "Trefethen-Strip-General" - def __init__(self, npoints: int, quadrature, rho: float = 1.1): + def __init__(self, npoints: int, quadrature, rho: float = 1.1, **quadrature_params): r"""Generate grid on :math:`[-1,1]` interval based on Trefethen-General. Parameters @@ -1071,7 +1073,7 @@ def __init__(self, npoints: int, quadrature, rho: float = 1.1): One-dimensional grid instance. """ - grid = quadrature(npoints) + grid = quadrature(npoints, **quadrature_params) points = _gstrip(rho, grid.points) weights = _dergstrip(rho, grid.points) * grid.weights From eab5311f41b10a3ff7f2c7a56282edb68e194d2e Mon Sep 17 00:00:00 2001 From: Meredith Date: Fri, 29 May 2026 16:20:22 -0400 Subject: [PATCH 2/2] Tested Trefethen Fix --- src/grid/tests/test_onedgrid.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/grid/tests/test_onedgrid.py b/src/grid/tests/test_onedgrid.py index 641fd619..93a40691 100644 --- a/src/grid/tests/test_onedgrid.py +++ b/src/grid/tests/test_onedgrid.py @@ -579,6 +579,14 @@ def test_TrefethenGeneral_d0(self): assert_allclose(grid.points, new.points) assert_allclose(grid.weights, new.weights) + def test_TrefethenGeneral_quadrature_params(self): + """Test for Trefethen - new quadrature params variable.""" + grid = TrefethenGeneral(11, TanhSinh, 1) + new = TrefethenGeneral(11, TanhSinh, 1, **{"delta":0.1}) + + assert_allclose(grid.points, new.points) + assert_allclose(grid.weights, new.weights) + def test_AuxiliarTrefethenStrip(self): """Test for Auxiliary functions using in Trefethen Strip.""" xref = np.array([-1.0, 0.0, 1.0])